checkoff 0.170.0 → 0.172.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e346e26787afb1656a88445f35f22cd18c88519080b6224d4dcb83074149696f
-  data.tar.gz: f33d96167e8036964aee3eaa9a69e8b3e81c31a4e9fcec314ece54defe375b83
+  metadata.gz: 460a9e7a6cd597a95b8a4d1510776d842433d53d77e12995eaafd14473edaa8d
+  data.tar.gz: cb639a1b164c6029577a13643a0688bd68ce09b507b5ad1c962ad9a060e41f55
 SHA512:
-  metadata.gz: abf2f44932128fdfdf7d89e162431d4e4cfa89029bd106adb3b49ad6cc801e5b41838249595cf1f7dab8d25d3d52dcc1a2114be1f8f4a821dead7b9dcaf2fb71
-  data.tar.gz: 3828a170cdaa9cdd0f82beb5830dc2392a87a69bb45bff4f54d06865a6acde7a9962379c94435f03d3774450e6f4939ef282bd8e8922b4360d8162d809630b13
+  metadata.gz: 2279da4267561c7b61865047ecb2646de2d288954e792496272cf5c1ddf3408b59c333498120bb29a86c43f534b029632f9ad5b38bc1e51c0fccdfb17da47fa9
+  data.tar.gz: 2dba9cc6ad70e3c8b682c760d7f8b9a20698362d06bca51487e4475ed39265db86589c28ff1596926495c5e7de7554871e9d85f124ff7a79d5bf2f220568df12

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.170.0)
+    checkoff (0.172.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/asana_event_filter.rb

@@ -17,11 +17,13 @@ module Checkoff
       include Logging
 
       # @param filters [Array<Hash>, nil] The filters to match against
-      # @param tasks [Checkoff::Tasks]
+      # @param clients [Checkoff::Clients]
+      # @param client [Asana::Client]
       def initialize(filters:,
-                     tasks: Checkoff::Tasks.new)
+                     clients: Checkoff::Clients.new,
+                     client: clients.client)
         @filters = filters
-        @tasks = tasks
+        @client = client
       end
 
       # @param asana_event [Hash] The event that Asana sent
@@ -29,10 +31,18 @@ module Checkoff
         logger.debug { "Filtering using #{@filters.inspect}" }
         return true if @filters.nil?
 
+        failures = []
+
         @filters.any? do |filter|
-          out = filter_matches_asana_event?(filter, asana_event)
-          logger.debug { "Filter #{filter.inspect} matched? #{out} against event #{asana_event.inspect}" }
-          out
+          filter_matches = filter_matches_asana_event?(filter, asana_event, failures)
+          logger.debug { "Filter #{filter.inspect} matched? #{filter_matches} against event #{asana_event.inspect}" }
+          unless filter_matches
+            logger.info do
+              "Filter #{filter.inspect} failed to match event #{asana_event.inspect} because of #{failures.inspect}"
+            end
+            failures << filter
+          end
+          filter_matches
         end
       end
 
@@ -40,14 +50,18 @@ module Checkoff
 
       # @param filter [Hash]
       # @param asana_event [Hash]
+      # @param failures [Array<String>]
       #
       # @sg-ignore
       # @return [Boolean]
-      def filter_matches_asana_event?(filter, asana_event)
+      def filter_matches_asana_event?(filter, asana_event, failures)
         # @param key [String]
         # @param value [String, Array<String>]
         filter.all? do |key, value|
-          asana_event_matches_filter_item?(key, value, asana_event)
+          matches = asana_event_matches_filter_item?(key, value, asana_event)
+          failures << "#{key.inspect} = #{value.inspect}" unless matches
+
+          matches
         end
       end
 
@@ -82,10 +96,10 @@ module Checkoff
           end
 
           task_gid = resource.fetch('gid')
-
-          task = @tasks.task_by_gid(task_gid,
-                                    extra_fields: ['completed_at'],
-                                    only_uncompleted: false)
+          options = {
+            fields: ['completed_at'],
+          }
+          task = @client.tasks.find_by_id(task_gid, options: options)
           task_completed = !task.completed_at.nil?
           task_completed == value
         else

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.170.0'
+  VERSION = '0.172.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.170.0
+  version: 0.172.0
 platform: ruby
 authors:
 - Vince Broz