checkoff 0.16.1 → 0.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 935a2426ba2f1d83fd784c8db089c4bf1d47d1a46e7ba67e8cd75e8bd797ee7e
-  data.tar.gz: 040062ba44ad30695289c383f2bf25f1cd7e9f0e0b0abf289de2c58118cc271e
+  metadata.gz: e25d521fa8afff414681761d8adde914f090fb3d09f3972301e1b7ce7a96c2ad
+  data.tar.gz: 63d68ed07099060b34ea6ab89cb584782912fd72726ff593491b7c9d9a9f1e94
 SHA512:
-  metadata.gz: b72f34b4a882d9299cddaa740a81399b8930009666dcac323dcd148954095a6f292a46ecc16829c8e129420f1335bd1e8c41453c7b4401991a15a6cae7a96b68
-  data.tar.gz: 2d2c3fcdecf30aeedcfd718e84d874ff8596f078c2f0ae276459f0224e802a968d7c08234fe2b7d55a15261c4dcadabd5240f0c4a08a119849728a176738f688
+  metadata.gz: 2c2b4ba30b21e9d43c79cf5df47a28f197755c3689209f6ce9fe880802f33da1b8dd899f089160135f3d0536060eee31a33a13a7ce5987cf9108d3acaedf02f8
+  data.tar.gz: f7a5dfaecb8dbb18e7faf5a7d79fe3e76b42836990a1f3ad153378d67abca691d9dfb2047ae3b0565ec5d7fb397ccf5b744f9ea0b0ce346174964d0d96549001

data/.envrc

@@ -1,3 +1,4 @@
 # shellcheck shell=bash
 PATH_add bin
-eval "$(with-op op-env sh -e ASANA__PERSONAL_ACCESS_TOKEN -e ASANA__DEFAULT_ASSIGNEE_GID)"
+export ASANA__PERSONAL_ACCESS_TOKEN="op://Private/Asana access token - VLD read-write/token" ASANA__DEFAULT_ASSIGNEE_GID="op://Private/Asana access token - VLD read-write/default_workspace_gid" ASANA__DEFAULT_WORKSPACE_GID="op://Private/Asana access token - VLD read-write/default_workspace_gid"
+direnv_load with-op op run --cache -- direnv dump

data/.gitignore

@@ -62,4 +62,3 @@ requirements_dev.txt.installed
 /coverage/assets/
 /coverage/index.html
 /coverage/lcov/
-/pkg

data/.markdownlint_style.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+rule 'MD029', style: 'ordered'

data/.mdlrc

@@ -0,0 +1 @@
+style ".markdownlint_style.rb"

data/CONTRIBUTING.rst

@@ -0,0 +1,75 @@
+============
+Contributing
+============
+
+Contributions are welcome, and they are greatly appreciated! Every little bit
+helps, and credit will always be given.
+
+You can contribute in many ways:
+
+Types of Contributions
+----------------------
+
+Report Bugs
+~~~~~~~~~~~
+
+Report bugs at https://github.com/apiology/checkoff/issues
+
+If you are reporting a bug, please include:
+
+* Your operating system name and version.
+* Any details about your local setup that might be helpful in troubleshooting.
+* Detailed steps to reproduce the bug.
+
+Fix Bugs
+~~~~~~~~
+
+Look through the GitHub issues for bugs. Anything tagged with "bug"
+and "help wanted" is open to whoever wants to implement a fix for it.
+
+Implement Features
+~~~~~~~~~~~~~~~~~~
+
+Look through the GitHub issues for features. Anything tagged with "enhancement"
+and "help wanted" is open to whoever wants to implement it.
+
+If you have a new feature in mind, please start it by filing an issue
+so we can discuss the need and approach before you invest time into
+coding it.
+
+Write Documentation
+~~~~~~~~~~~~~~~~~~~
+
+Checkoff could always use more documentation, whether as part of
+the official Checkoff docs, in docstrings, or even on the web in blog posts, articles,
+and such.
+
+Submit Feedback
+~~~~~~~~~~~~~~~
+
+The best way to send feedback is to file an issue at
+https://github.com/apiology/checkoff/issues.
+
+If you are proposing a new feature:
+
+* Explain in detail how it would work.
+* Keep the scope as narrow as possible, to make it easier to implement.
+* Remember that this is a volunteer-driven project, and that contributions
+  are welcome :)
+
+Get Started!
+------------
+
+Ready to contribute?  See DEVELOPMENT.md in this directory for details
+on how to set yourself up for local development.
+
+Pull Request Guidelines
+-----------------------
+
+Before you submit a pull request, check that it meets these guidelines:
+
+1. The pull request should include tests.
+
+2. If the pull request adds functionality, the docs should be updated. Put your
+   new functionality into a function with a docstring, and add the feature to
+   the list in README.md.

data/DEVELOPMENT.md

@@ -57,4 +57,13 @@ git log "v$(bump current)..."
 bump --tag --tag-prefix=v ${type_of_bump:?}
 rake release
 git push
+git push --tags
+```
+
+
+## Developing
+
+```sh
+bundle install
+bundle exec exe/checkoff --help
 ```

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.16.1)
+    checkoff (0.18.1)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -22,7 +22,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.5.1)
+    activesupport (6.1.6.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -33,10 +33,12 @@ GEM
     cache (0.4.1)
     cache_method (0.2.7)
       cache (>= 0.2.1)
+    chef-utils (17.10.0)
+      concurrent-ruby
     childprocess (4.0.0)
     coderay (1.1.3)
     concurrent-ruby (1.1.10)
-    dalli (3.2.1)
+    dalli (3.2.2)
     docile (1.4.0)
     faraday (1.5.1)
       faraday-em_http (~> 1.0)
@@ -61,15 +63,30 @@ GEM
       faraday_middleware
       multi_json
     gli (2.21.0)
-    i18n (1.10.0)
+    i18n (1.11.0)
       concurrent-ruby (~> 1.0)
     imagen (0.1.8)
       parser (>= 2.5, != 2.5.1.1)
     iniparse (1.5.0)
     jwt (2.2.3)
+    kramdown (2.4.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    mdl (0.11.0)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.1)
+      mixlib-cli (~> 2.1, >= 2.1.1)
+      mixlib-config (>= 2.2.1, < 4)
+      mixlib-shellout
     method_source (1.0.0)
-    minitest (5.15.0)
+    minitest (5.16.2)
     minitest-profile (0.0.2)
+    mixlib-cli (2.1.8)
+    mixlib-config (3.0.27)
+      tomlrb
+    mixlib-shellout (3.2.7)
+      chef-utils
     mocha (1.12.0)
     multi_json (1.15.0)
     multi_xml (0.6.0)
@@ -90,7 +107,7 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (2.2.3)
+    rack (2.2.4)
     rainbow (3.0.0)
     rake (13.0.3)
     regexp_parser (2.1.1)
@@ -120,6 +137,7 @@ GEM
     simplecov-html (0.12.3)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.3)
+    tomlrb (2.0.3)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     undercover (0.4.3)
@@ -127,7 +145,7 @@ GEM
       rainbow (>= 2.1, < 4.0)
       rugged (>= 0.27, < 1.2)
     unicode-display_width (2.0.0)
-    zeitwerk (2.5.4)
+    zeitwerk (2.6.0)
 
 PLATFORMS
   ruby
@@ -140,6 +158,7 @@ DEPENDENCIES
   bump
   bundler
   checkoff!
+  mdl
   minitest-profile
   mocha
   overcommit (>= 0.58.0)

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021, Vince Broz
+Copyright (c) 2016-2022, Vince Broz
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -19,4 +19,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
-

data/Makefile

@@ -39,6 +39,9 @@ clear_metrics: ## remove or reset result artifacts created by tests and quality
 
 clean: clear_metrics ## remove all built artifacts
 
+
+typecheck: ## validate types in code and configuration
+
 overcommit: ## run precommit quality checks
 	bundle exec overcommit --run
 

data/README.md

@@ -149,18 +149,14 @@ personal_access_token: 'some_big_long_string_from_asana.com_here'
 
 Alternately you can set environment variables to match - e.g., `ASANA__PERSONAL_ACCESS_TOKEN`
 
-## Developing
+## Contributions
 
-```sh
-bundle install
-bundle exec exe/checkoff --help
-```
+This project, as with all others, rests on the shoulders of a broad
+ecosystem supported by many volunteers doing thankless work, along
+with specific contributors.
 
-To publish new version as a maintainer:
+In particular I'd like to call out:
 
-```sh
-git log "v$(bump current)..."
-# Set type_of_bump to patch, minor, or major
-bump --tag --tag-prefix=v ${type_of_bump:?}
-rake release
-```
+* [Audrey Roy Greenfeld](https://github.com/audreyfeldroy) for the
+  cookiecutter tool and associated examples, which keep my many
+  projects building with shared boilerplate with a minimum of fuss.

data/checkoff.gemspec

@@ -32,6 +32,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bump'
   spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'mdl'
   spec.add_development_dependency 'minitest-profile'
   spec.add_development_dependency 'mocha'
   # 0.58.0 and 0.57.0 don't seem super compatible with signatures, and

data/coverage/.last_run.json

@@ -1,6 +1,6 @@
 {
   "result": {
-    "line": 99.78,
-    "branch": 94.31
+    "line": 98.68,
+    "branch": 93.26
   }
 }

data/fix.sh

@@ -284,12 +284,7 @@ ensure_python_versions() {
       }
 
       major_minor="$(cut -d. -f1-2 <<<"${ver}")"
-      if [ "${major_minor}" == 3.6 ]
-      then
-        pyenv_install --patch "${ver}" < <(curl -sSL https://github.com/python/cpython/commit/8ea6353.patch\?full_index=1)
-      else
-        pyenv_install "${ver}"
-      fi
+      pyenv_install "${ver}"
     else
       pyenv install -s "${ver}"
     fi
@@ -307,12 +302,12 @@ ensure_pyenv_virtualenvs() {
 }
 
 ensure_pip_and_wheel() {
-  # Make sure we have a pip with the 20.3 resolver, and after the
-  # initial bugfix release
+  # pip 22 seems to be better at finding pandas pre-compiled wheels
+  # for macOS, so let's make sure we're using at least that version
   major_pip_version=$(pip --version | cut -d' ' -f2 | cut -d '.' -f 1)
   if [[ major_pip_version -lt 21 ]]
   then
-    pip install 'pip>=20.3.1'
+    pip install 'pip>=22'
   fi
   # wheel is helpful for being able to cache long package builds
   pip show wheel >/dev/null 2>&1 || pip install wheel

data/lib/checkoff/cli.rb

@@ -61,7 +61,7 @@ module Checkoff
                    to_workspace_arg:,
                    to_project_arg:,
                    to_section_arg:,
-                   config: Checkoff::ConfigLoader.load(:asana),
+                   config: Checkoff::Internal::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config),
                    sections: Checkoff::Sections.new(config: config),
                    logger: $stderr)
@@ -122,7 +122,7 @@ module Checkoff
   class ViewSubcommand
     def initialize(workspace_name, project_name, section_name,
                    task_name,
-                   config: Checkoff::ConfigLoader.load(:asana),
+                   config: Checkoff::Internal::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config),
                    sections: Checkoff::Sections.new(config: config,
                                                     projects: projects),
@@ -201,7 +201,7 @@ module Checkoff
   # CLI subcommand that creates a task
   class QuickaddSubcommand
     def initialize(workspace_name, task_name,
-                   config: Checkoff::ConfigLoader.load(:asana),
+                   config: Checkoff::Internal::ConfigLoader.load(:asana),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    tasks: Checkoff::Tasks.new(config: config))
       @workspace_name = workspace_name

data/lib/checkoff/clients.rb

@@ -3,7 +3,7 @@
 # frozen_string_literal: true
 
 require 'forwardable'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require 'asana'
 
 # https://developers.asana.com/docs/clients
@@ -18,7 +18,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    asana_client_class: Asana::Client)
       @config = config
       @asana_client_class = asana_client_class

data/lib/checkoff/create-entity.sh

@@ -16,7 +16,7 @@ cat > "${underscored_plural_name}.rb" << EOF
 
 require 'forwardable'
 require 'cache_method'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'workspaces'
 require_relative 'clients'
 
@@ -31,7 +31,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client)

data/lib/checkoff/custom_fields.rb

@@ -4,7 +4,7 @@
 
 require 'forwardable'
 require 'cache_method'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'workspaces'
 require_relative 'clients'
 
@@ -20,7 +20,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client)

data/lib/checkoff/internal/config_loader.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'yaml'
+require 'active_support/core_ext/hash'
+
+module Checkoff
+  module Internal
+    # Use the provided config from a YAML file, and fall back to env
+    # variable if it's not populated for a key'
+    class EnvFallbackConfigLoader
+      def initialize(config, sym, yaml_filename)
+        @config = config
+        @envvar_prefix = sym.upcase
+        @yaml_filename = yaml_filename
+      end
+
+      def [](key)
+        config_value = @config[key]
+        return config_value unless config_value.nil?
+
+        ENV[envvar_name(key)]
+      end
+
+      def fetch(key)
+        out = self[key]
+        return out unless out.nil?
+
+        raise KeyError,
+              "Please configure either the #{key} key in #{@yaml_filename} or set #{envvar_name(key)}"
+      end
+
+      private
+
+      def envvar_name(key)
+        "#{@envvar_prefix}__#{key.upcase}"
+      end
+    end
+
+    # Load configuration file
+    class ConfigLoader
+      class << self
+        def load(sym)
+          yaml_result = load_yaml_file(sym)
+          EnvFallbackConfigLoader.new(yaml_result, sym, yaml_filename(sym))
+        end
+
+        private
+
+        def load_yaml_file(sym)
+          filename = yaml_filename(sym)
+          return {} unless File.exist?(filename)
+
+          YAML.load_file(filename).with_indifferent_access
+        end
+
+        def yaml_filename(sym)
+          file = "#{sym}.yml"
+          File.expand_path("~/.#{file}")
+        end
+      end
+    end
+  end
+end

data/lib/checkoff/internal/create-class.sh

@@ -0,0 +1,22 @@
+#!/bin/bash -eu
+
+set -o pipefail
+
+underscored_plural_name="${1:?underscored plural name of entities minus .rb}"
+class_name="${2:?class name without Checkoff:: prefix}"
+
+cat > "${underscored_plural_name}.rb" << EOF
+#!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
+module Checkoff
+  module Internal
+    class ${class_name}
+      def initialize(_deps = {}); end
+    end
+  end
+end
+EOF
+
+git add "${underscored_plural_name}.rb"

data/lib/checkoff/my_tasks.rb

@@ -14,7 +14,7 @@ module Checkoff
 
     attr_reader :projects
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config))
       @config = config
       @projects = projects
@@ -23,9 +23,9 @@ module Checkoff
     # Given a 'My Tasks' project object, pull all tasks, then provide
     # a Hash of tasks with section name -> task list of the
     # uncompleted tasks.
-    def tasks_by_section_for_my_tasks(project)
+    def tasks_by_section_for_my_tasks(project, extra_fields: [])
       raw_tasks = projects.tasks_from_project(project,
-                                              extra_fields: ['assignee_section.name'])
+                                              extra_fields: extra_fields + ['assignee_section.name'])
       active_tasks = projects.active_tasks(raw_tasks)
       by_my_tasks_section(active_tasks)
     end

data/lib/checkoff/projects.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'workspaces'
 require_relative 'clients'
 require 'cache_method'
@@ -23,7 +23,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE * 5
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client)

data/lib/checkoff/sections.rb

@@ -17,7 +17,7 @@ module Checkoff
 
     attr_reader :projects, :workspaces, :time, :my_tasks
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
@@ -38,12 +38,12 @@ module Checkoff
 
     # Given a workspace name and project name, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
-    def tasks_by_section(workspace_name, project_name)
+    def tasks_by_section(workspace_name, project_name, extra_fields: [])
       project = project_or_raise(workspace_name, project_name)
       if project_name == :my_tasks
-        my_tasks.tasks_by_section_for_my_tasks(project)
+        my_tasks.tasks_by_section_for_my_tasks(project, extra_fields: extra_fields)
       else
-        tasks_by_section_for_project(project)
+        tasks_by_section_for_project(project, extra_fields: extra_fields)
       end
     end
 
@@ -87,9 +87,9 @@ module Checkoff
 
     # Given a project object, pull all tasks, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
-    def tasks_by_section_for_project(project)
+    def tasks_by_section_for_project(project, extra_fields: [])
       # print("project: #{project}")
-      raw_tasks = projects.tasks_from_project(project)
+      raw_tasks = projects.tasks_from_project(project, extra_fields: extra_fields)
       # print("raw_tasks[0]: #{raw_tasks[0]}")
       active_tasks = projects.active_tasks(raw_tasks)
       by_section(active_tasks, project.gid)

data/lib/checkoff/subtasks.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'forwardable'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'projects'
 
 module Checkoff
@@ -13,7 +13,7 @@ module Checkoff
 
     extend Forwardable
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config))
       @projects = projects
     end

data/lib/checkoff/tags.rb

@@ -4,7 +4,7 @@
 
 require 'forwardable'
 require 'cache_method'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'workspaces'
 require_relative 'clients'
 
@@ -20,7 +20,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    workspaces: Checkoff::Workspaces.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client)

data/lib/checkoff/task_selectors.rb

@@ -0,0 +1,92 @@
+#!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
+require 'forwardable'
+require 'cache_method'
+require 'json'
+require_relative 'internal/config_loader'
+
+# https://developers.asana.com/docs/task-selectors
+
+module Checkoff
+  # Filter lists of tasks using declarative selectors.
+  class TaskSelectors
+    MINUTE = 60
+    HOUR = MINUTE * 60
+    DAY = 24 * HOUR
+    REALLY_LONG_CACHE_TIME = HOUR * 1
+    LONG_CACHE_TIME = MINUTE * 15
+    SHORT_CACHE_TIME = MINUTE
+
+    def initialize(_deps = {}); end
+
+    # @param [Hash<Symbol, Object>] task_selector Filter based on
+    #        description.  Examples: {tag: 'foo'} {:not {tag: 'foo'} (:tag 'foo')
+    def filter_via_task_selector(task, task_selector)
+      return true if task_selector == []
+
+      return !filter_via_task_selector(task, task_selector.fetch(1)) if fn?(task_selector, :not)
+
+      return filter_via_task_selector(task, task_selector.fetch(1)).nil? if fn?(task_selector, :nil?)
+
+      return contains_tag?(task, task_selector.fetch(1)) if fn?(task_selector, :tag)
+
+      return custom_field_value(task, task_selector.fetch(1)) if fn?(task_selector, :custom_field_value)
+
+      raise "Syntax issue trying to handle #{task_selector}"
+    end
+
+    private
+
+    def contains_tag?(task, tag_name)
+      task.tags.map(&:name).include? tag_name
+    end
+
+    def custom_field_value(task, custom_field_name)
+      custom_field = task.custom_fields.find { |field| field.fetch('name') == custom_field_name }
+      return nil if custom_field.nil?
+
+      custom_field['display_value']
+    end
+
+    def fn?(object, fn_name)
+      object.is_a?(Array) && !object.empty? && [fn_name, fn_name.to_s].include?(object[0])
+    end
+
+    # bundle exec ./task_selectors.rb
+    # :nocov:
+    class << self
+      def project_name
+        ARGV[1] || raise('Please pass project name to pull tasks from as first argument')
+      end
+
+      def workspace_name
+        ARGV[0] || raise('Please pass workspace name as first argument')
+      end
+
+      def task_selector
+        task_selector_json = ARGV[2] || raise('Please pass task_selector in JSON form as third argument')
+        JSON.parse(task_selector_json)
+      end
+
+      def run
+        require 'checkoff/projects'
+
+        task_selectors = Checkoff::TaskSelectors.new
+        extra_fields = []
+        projects = Checkoff::Projects.new
+        project = projects.project(workspace_name, project_name)
+        raw_tasks = projects.tasks_from_project(project, extra_fields: extra_fields)
+        tasks = raw_tasks.filter { |task| task_selectors.filter_via_task_selector(task, task_selector) }
+        puts "Results: #{tasks}"
+      end
+    end
+    # :nocov:
+  end
+end
+
+# :nocov:
+abs_program_name = File.expand_path($PROGRAM_NAME)
+Checkoff::TaskSelectors.run if abs_program_name == __FILE__
+# :nocov:

data/lib/checkoff/tasks.rb

@@ -14,7 +14,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE * 5
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    sections: Checkoff::Sections.new(config: config),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client,
@@ -85,6 +85,16 @@ module Checkoff
     end
 
     def incomplete_dependencies?(task)
+      # Avoid a reundant fetch.  Unfortunately, Ruby SDK allows
+      # dependencies to be fetched along with other attributes--but
+      # then doesn't use it and does another HTTP GET!  At least this
+      # way we can skip the extra HTTP GET in the common case when
+      # there are no dependencies.
+      #
+      # https://github.com/Asana/ruby-asana/issues/125
+      already_fetched_dependencies = task.instance_variable_get(:@dependencies)
+      return false unless already_fetched_dependencies.nil? || already_fetched_dependencies.size.positive?
+
       task.dependencies.any? do |parent_task_info|
         parent_task_gid = parent_task_info.gid
         parent_task = @asana_task.find_by_id(client, parent_task_gid,

data/lib/checkoff/version.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
+# Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.16.1'
+  VERSION = '0.18.1'
 end

data/lib/checkoff/workspaces.rb

@@ -2,7 +2,7 @@
 
 require 'forwardable'
 require 'cache_method'
-require_relative 'config_loader'
+require_relative 'internal/config_loader'
 require_relative 'clients'
 
 # https://developers.asana.com/docs/workspaces
@@ -17,7 +17,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    clients: Checkoff::Clients.new(config: config),
                    client: clients.client)
       @config = config

data/lib/checkoff.rb

@@ -8,3 +8,4 @@ require 'checkoff/subtasks'
 require 'checkoff/tasks'
 require 'checkoff/custom_fields'
 require 'checkoff/tags'
+require 'checkoff/task_selectors'

data/rakelib/console.rake

@@ -2,5 +2,14 @@
 
 desc 'Load up checkoff in pry'
 task :console do |_t|
+  puts 'Example:'
+  puts
+  puts '# https://www.rubydoc.info/github/Asana/ruby-asana/master'
+  puts '> client = Checkoff::Clients.new.client'
+  puts '# https://developers.asana.com/docs/input-output-options'
+  puts '> workspace_gid = ENV.fetch("ASANA__DEFAULT_WORKSPACE_GID")'
+  puts "> task = client.tasks.find_by_id('1199961990964812', options: { fields: ['dependencies'] })"
+  puts '# Asana.md#ruby-asana / API shows how to manually call endpoints with a client'
+  puts
   exec 'pry -I lib -r checkoff'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.16.1
+  version: 0.18.1
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-04-26 00:00:00.000000000 Z
+date: 2022-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mdl
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest-profile
   requirement: !ruby/object:Gem::Requirement
@@ -275,10 +289,13 @@ files:
 - ".git-hooks/pre_commit/circle_ci.rb"
 - ".gitattributes"
 - ".gitignore"
+- ".markdownlint_style.rb"
+- ".mdlrc"
 - ".overcommit.yml"
 - ".rubocop.yml"
 - ".yamllint.yml"
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.rst
 - DEVELOPMENT.md
 - Gemfile
 - Gemfile.lock
@@ -301,14 +318,16 @@ files:
 - lib/checkoff.rb
 - lib/checkoff/cli.rb
 - lib/checkoff/clients.rb
-- lib/checkoff/config_loader.rb
 - lib/checkoff/create-entity.sh
 - lib/checkoff/custom_fields.rb
+- lib/checkoff/internal/config_loader.rb
+- lib/checkoff/internal/create-class.sh
 - lib/checkoff/my_tasks.rb
 - lib/checkoff/projects.rb
 - lib/checkoff/sections.rb
 - lib/checkoff/subtasks.rb
 - lib/checkoff/tags.rb
+- lib/checkoff/task_selectors.rb
 - lib/checkoff/tasks.rb
 - lib/checkoff/version.rb
 - lib/checkoff/workspaces.rb

data/lib/checkoff/config_loader.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require 'yaml'
-require 'active_support/core_ext/hash'
-
-module Checkoff
-  # Use the provided config from a YAML file, and fall back to env
-  # variable if it's not populated for a key'
-  class EnvFallbackConfigLoader
-    def initialize(config, sym, yaml_filename)
-      @config = config
-      @envvar_prefix = sym.upcase
-      @yaml_filename = yaml_filename
-    end
-
-    def [](key)
-      config_value = @config[key]
-      return config_value unless config_value.nil?
-
-      ENV[envvar_name(key)]
-    end
-
-    def fetch(key)
-      out = self[key]
-      return out unless out.nil?
-
-      raise KeyError,
-            "Please configure either the #{key} key in #{@yaml_filename} or set #{envvar_name(key)}"
-    end
-
-    private
-
-    def envvar_name(key)
-      "#{@envvar_prefix}__#{key.upcase}"
-    end
-  end
-
-  # Load configuration file
-  class ConfigLoader
-    class << self
-      def load(sym)
-        yaml_result = load_yaml_file(sym)
-        EnvFallbackConfigLoader.new(yaml_result, sym, yaml_filename(sym))
-      end
-
-      private
-
-      def load_yaml_file(sym)
-        filename = yaml_filename(sym)
-        return {} unless File.exist?(filename)
-
-        YAML.load_file(filename).with_indifferent_access
-      end
-
-      def yaml_filename(sym)
-        file = "#{sym}.yml"
-        File.expand_path("~/.#{file}")
-      end
-    end
-  end
-end