checkoff 0.16.1 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 935a2426ba2f1d83fd784c8db089c4bf1d47d1a46e7ba67e8cd75e8bd797ee7e
-  data.tar.gz: 040062ba44ad30695289c383f2bf25f1cd7e9f0e0b0abf289de2c58118cc271e
+  metadata.gz: 934e52a0b06388d6c1dbadb1ff9890cdf74da88f95d9350af04beba49d4021cd
+  data.tar.gz: 1f8780b895c7be869384afc71e7e1187d7e6594dd9139cc951d5330c46028929
 SHA512:
-  metadata.gz: b72f34b4a882d9299cddaa740a81399b8930009666dcac323dcd148954095a6f292a46ecc16829c8e129420f1335bd1e8c41453c7b4401991a15a6cae7a96b68
-  data.tar.gz: 2d2c3fcdecf30aeedcfd718e84d874ff8596f078c2f0ae276459f0224e802a968d7c08234fe2b7d55a15261c4dcadabd5240f0c4a08a119849728a176738f688
+  metadata.gz: ac4dd6171e0867c4209bdd8b3b1e166164ab69b633e283d3985b3054c5a32aa81a076f573034584cfeece30312ea909ce0643850b49e7c5d1436ff75a0bc8cc8
+  data.tar.gz: 14e79f6ffc230d038cbb514dca84a34465c4f6aab7052b98f6de25dc63b1f3ca1507ab4a1b108da48e918da0f19ac10657d24f3e94d5610881379d0aafca6f4d

data/.envrc

@@ -1,3 +1,4 @@
 # shellcheck shell=bash
 PATH_add bin
-eval "$(with-op op-env sh -e ASANA__PERSONAL_ACCESS_TOKEN -e ASANA__DEFAULT_ASSIGNEE_GID)"
+export ASANA__PERSONAL_ACCESS_TOKEN="op://Private/Asana access token - VLD read-write/token" ASANA__DEFAULT_ASSIGNEE_GID="op://Private/Asana access token - VLD read-write/default_workspace_gid"
+direnv_load with-op op run --cache -- direnv dump

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.16.1)
+    checkoff (0.17.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/coverage/.last_run.json

@@ -1,6 +1,6 @@
 {
   "result": {
     "line": 99.78,
-    "branch": 94.31
+    "branch": 93.33
   }
 }

data/lib/checkoff/my_tasks.rb

@@ -23,9 +23,9 @@ module Checkoff
     # Given a 'My Tasks' project object, pull all tasks, then provide
     # a Hash of tasks with section name -> task list of the
     # uncompleted tasks.
-    def tasks_by_section_for_my_tasks(project)
+    def tasks_by_section_for_my_tasks(project, extra_fields: [])
       raw_tasks = projects.tasks_from_project(project,
-                                              extra_fields: ['assignee_section.name'])
+                                              extra_fields: extra_fields + ['assignee_section.name'])
       active_tasks = projects.active_tasks(raw_tasks)
       by_my_tasks_section(active_tasks)
     end

data/lib/checkoff/sections.rb

@@ -38,12 +38,12 @@ module Checkoff
 
     # Given a workspace name and project name, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
-    def tasks_by_section(workspace_name, project_name)
+    def tasks_by_section(workspace_name, project_name, extra_fields: [])
       project = project_or_raise(workspace_name, project_name)
       if project_name == :my_tasks
-        my_tasks.tasks_by_section_for_my_tasks(project)
+        my_tasks.tasks_by_section_for_my_tasks(project, extra_fields: extra_fields)
       else
-        tasks_by_section_for_project(project)
+        tasks_by_section_for_project(project, extra_fields: extra_fields)
       end
     end
 
@@ -87,9 +87,9 @@ module Checkoff
 
     # Given a project object, pull all tasks, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
-    def tasks_by_section_for_project(project)
+    def tasks_by_section_for_project(project, extra_fields: [])
       # print("project: #{project}")
-      raw_tasks = projects.tasks_from_project(project)
+      raw_tasks = projects.tasks_from_project(project, extra_fields: extra_fields)
       # print("raw_tasks[0]: #{raw_tasks[0]}")
       active_tasks = projects.active_tasks(raw_tasks)
       by_section(active_tasks, project.gid)

data/lib/checkoff/tasks.rb

@@ -85,6 +85,16 @@ module Checkoff
     end
 
     def incomplete_dependencies?(task)
+      # Avoid a reundant fetch.  Unfortunately, Ruby SDK allows
+      # dependencies to be fetched along with other attributes--but
+      # then doesn't use it and does another HTTP GET!  At least this
+      # way we can skip the extra HTTP GET in the common case when
+      # there are no dependencies.
+      #
+      # https://github.com/Asana/ruby-asana/issues/125
+      already_fetched_dependencies = task.instance_variable_get(:@dependencies)
+      return false unless already_fetched_dependencies.nil? || already_fetched_dependencies.size.positive?
+
       task.dependencies.any? do |parent_task_info|
         parent_task_gid = parent_task_info.gid
         parent_task = @asana_task.find_by_id(client, parent_task_gid,

data/lib/checkoff/version.rb

@@ -2,5 +2,5 @@
 
 module Checkoff
   # Version of library
-  VERSION = '0.16.1'
+  VERSION = '0.17.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.16.1
+  version: 0.17.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-04-26 00:00:00.000000000 Z
+date: 2022-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport