checkoff 0.134.0 → 0.136.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 774ff63fdebd9187b4aedf1cad2ee5ba52c4d7f5d582747b0414e698c6c31d9d
-  data.tar.gz: de61ee88dc1e575702bbe15df6fcd0e70738a3b0f5ffb10654633260831c9923
+  metadata.gz: 5e9b8a139f08b5a53da99f785ac0e57bed14e919e43cc56ecf929c3558e4b567
+  data.tar.gz: 524fd6f5a31e9737403610de5b5e6ae42671e8f157702feeeec79f1154b99c1a
 SHA512:
-  metadata.gz: 767386a4cb59daf9085a545e1e6bb8b76d01ac374785c2c574a285142b0531ebf1c3c7f930b3d104262452bdb1975b8158a2906d157cc88b46bce0852fd357e9
-  data.tar.gz: c3f95457b476ff66133dba010920db1feee0f27f98fa35ed92246b677dde95f17fd8347b91de6aa63f2777c2dcebef061a8d5aefaf85638e4c321009b68185d6
+  metadata.gz: df7a2327a7a1e63e15342dadcc6fded785de79c867bc4d9cf0de9b3d0c3c57d639c0908002162a188cd0fa261108b91a33788fd29f159f99f2f4139774f1a636
+  data.tar.gz: 55ffabad75909f3475ef78d702d6606be979dbce8ecbb3521133ec225651cdb53481ae4e5ddc571b587dbf88b63a1a7e78b3a7b271b43fa49169c15d80b26bad

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.134.0)
+    checkoff (0.136.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/tasks.rb

@@ -127,11 +127,16 @@ module Checkoff
     #
     # @param task_gid [String]
     # @param extra_fields [Array<String>]
+    # @param only_uncompleted [Boolean]
+    #
     # @return [Asana::Resources::Task, nil]
     def task_by_gid(task_gid,
-                    extra_fields: [])
+                    extra_fields: [],
+                    only_uncompleted: false)
+      # @type [Hash]
       options = projects.task_options.fetch(:options, {})
       options[:fields] += extra_fields
+      options[:completed_since] = '9999-12-01' if only_uncompleted
       client.tasks.find_by_id(task_gid, options: options)
     end
     cache_method :task_by_gid, SHORT_CACHE_TIME
@@ -182,9 +187,10 @@ module Checkoff
         # the completion status of dependencies, so we need to do this
         # regardless:
         parent_task_gid = parent_task_info.fetch('gid')
-        parent_task = @asana_task.find_by_id(client, parent_task_gid,
-                                             options: { fields: ['completed'] })
-        !parent_task.completed
+
+        parent_task = task_by_gid(parent_task_gid,
+                                  only_uncompleted: false)
+        parent_task.completed_at.nil?
       end
     end
 

data/lib/checkoff/timing.rb

@@ -9,6 +9,7 @@ require 'active_support'
 require 'forwardable'
 require 'cache_method'
 require_relative 'internal/config_loader'
+require_relative 'internal/logging'
 require_relative 'workspaces'
 require_relative 'clients'
 
@@ -22,6 +23,8 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
+    include Logging
+
     # @param today_getter [Class<Date>]
     # @param now_getter [Class<Time>]
     def initialize(today_getter: Date,
@@ -128,20 +131,35 @@ module Checkoff
       (@now_getter.now + (num_days * 24 * 60 * 60))
     end
 
+    # @param num_days [Integer]
+    #
+    # @return [Date]
+    def n_days_from_today(num_days)
+      (@today_getter.today + num_days)
+    end
+
     # @param date_or_time [Date,Time,nil]
     # @param beginning_num_days_from_now [Integer,nil]
     # @param end_num_days_from_now [Integer,nil]
     def between_relative_days?(date_or_time, beginning_num_days_from_now, end_num_days_from_now)
-      start_time = n_days_from_now(beginning_num_days_from_now || -99_999)
-      end_time = n_days_from_now(end_num_days_from_now || 99_999)
+      start_date = n_days_from_today(beginning_num_days_from_now || -99_999)
+      end_date = n_days_from_today(end_num_days_from_now || 99_999)
 
       return false if date_or_time.nil?
 
-      if date_or_time.is_a?(Time)
-        date_or_time > start_time && date_or_time <= end_time
-      else
-        date_or_time > start_time.to_date && date_or_time <= end_time.to_date
+      date = if date_or_time.is_a?(Time)
+               date_or_time.localtime.to_date
+             else
+               date_or_time
+             end
+      out = date > start_date && date <= end_date
+      logger.debug do
+        "Checkoff::Timing#between_relative_days?(#{date_or_time.inspect} " \
+          "(as date: #{date.inspect}) " \
+          "#{beginning_num_days_from_now.inspect}, #{end_num_days_from_now.inspect}) " \
+          "comparing with #{start_date} and #{end_date} = #{out.inspect}"
       end
+      out
     end
 
     # @param date_or_time [Date,Time,nil]

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.134.0'
+  VERSION = '0.136.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.134.0
+  version: 0.136.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-23 00:00:00.000000000 Z
+date: 2023-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport