checkoff 0.133.0 → 0.135.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7939d56faf627c0cf1df999033e52d4af51ba20415ead6d0ad7851e9068db682
-  data.tar.gz: 6b48464946d3ec56a5d5da6dfcafa8aef58ad971e2a75288ada658a102a95e47
+  metadata.gz: a1405ced59ee8be44fb64638fb70395489ac438812bb1307a58dc46f9bf2b0a3
+  data.tar.gz: 2a3eb1041ff8894f18ea135774542c0efc09ed0f3ec1771130059aacd93b7733
 SHA512:
-  metadata.gz: 48eec1f70323b78b165435b238ce25b0faaac5fcbc76fd0de68b0f8e30c34ce5fb1cb690093685be3ac0c39abb1df9c3c141a3a437c972e45dc11738b4e9e7a6
-  data.tar.gz: 6eba3315a48d7608a1cdd0a2626685eb9f29dc7bb1b02464e76224769deb876ff123dfb88203fef8c75f2dc216e481f0bc79559a35ebb35b3c2ae0523fd96567
+  metadata.gz: 376987e755790ea699766a7d419ff07353122a256d6d398c4cfbc015ef29418f396e3b3b5761de595e28f0c9bf29baf74afe87ede5c885e6bea5b1d742ebc3bc
+  data.tar.gz: 70c8298da537b7c9bdc9562eebdc03a5cffc04762917b9fcef577bef05c9dfc4bdc2a2bfba72c295b3dc7f343be08e1d4febbbcb3cc0817470118b0bca8adb0a

data/Gemfile

@@ -11,7 +11,7 @@ gem 'fakeweb'
 gem 'mdl'
 gem 'minitest-profile'
 gem 'minitest-reporters'
-gem 'mocha', ['~> 2.0.0.alpha.1']
+gem 'mocha', ['>= 2']
 # 0.58.0 and 0.57.0 don't seem super compatible with signatures, and
 # magit doesn't seem to want to use the bundled version at the moment,
 # so let's favor the more recent version...

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.133.0)
+    checkoff (0.135.0)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -22,7 +22,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.1)
+    activesupport (7.1.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -104,7 +104,7 @@ GEM
       mixlib-shellout
     method_source (1.0.0)
     mini_portile2 (2.8.2)
-    minitest (5.18.0)
+    minitest (5.20.0)
     minitest-profile (0.0.2)
     minitest-reporters (1.5.0)
       ansi
@@ -116,7 +116,8 @@ GEM
       tomlrb
     mixlib-shellout (3.2.7)
       chef-utils
-    mocha (2.0.0.alpha.1)
+    mocha (2.1.0)
+      ruby2_keywords (>= 0.0.5)
     multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
@@ -232,7 +233,7 @@ DEPENDENCIES
   mdl
   minitest-profile
   minitest-reporters
-  mocha (~> 2.0.0.alpha.1)
+  mocha (>= 2)
   overcommit (>= 0.60.0, < 0.61.0)
   pry
   punchlist

data/lib/checkoff/events.rb

@@ -0,0 +1,88 @@
+#!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
+require 'forwardable'
+require 'cache_method'
+require_relative 'internal/config_loader'
+require_relative 'internal/asana_event_filter'
+require_relative 'workspaces'
+require_relative 'clients'
+
+# https://developers.asana.com/reference/events
+
+module Checkoff
+  # Methods related to the Asana events / webhooks APIs
+  class Events
+    # @!parse
+    #   extend CacheMethod::ClassMethods
+
+    MINUTE = 60
+    private_constant :MINUTE
+    HOUR = MINUTE * 60
+    private_constant :HOUR
+    DAY = 24 * HOUR
+    private_constant :DAY
+    REALLY_LONG_CACHE_TIME = HOUR * 1
+    private_constant :REALLY_LONG_CACHE_TIME
+    LONG_CACHE_TIME = MINUTE * 15
+    private_constant :LONG_CACHE_TIME
+    SHORT_CACHE_TIME = MINUTE
+    private_constant :SHORT_CACHE_TIME
+
+    # @param config [Hash]
+    # @param workspaces [Checkoff::Workspaces]
+    # @param clients [Checkoff::Clients]
+    # @param client [Asana::Client]
+    # @param asana_event_filter_class [Class<Checkoff::Internal::AsanaEventFilter>]
+    def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
+                   workspaces: Checkoff::Workspaces.new(config: config),
+                   clients: Checkoff::Clients.new(config: config),
+                   client: clients.client,
+                   asana_event_filter_class: Checkoff::Internal::AsanaEventFilter)
+      @workspaces = workspaces
+      @client = client
+      @asana_event_filter_class = asana_event_filter_class
+    end
+
+    # @param filters [Array<Hash>, nil] The filters to match against
+    # @param asana_events [Array<Hash>] The events that Asana sent
+    #
+    # @return [Array<Hash>] The events that should be acted on
+    def filter_asana_events(filters, asana_events)
+      asana_event_filter = @asana_event_filter_class.new(filters: filters)
+      asana_events.select { |event| asana_event_filter.matches?(event) }
+    end
+
+    private
+
+    # @return [Checkoff::Workspaces]
+    attr_reader :workspaces
+
+    # @return [Asana::Client]
+    attr_reader :client
+
+    # bundle exec ./events.rb
+    # :nocov:
+    class << self
+      # @return [void]
+      def run
+        # @sg-ignore
+        # @type [String]
+        # workspace_name = ARGV[0] || raise('Please pass workspace name as first argument')
+        # @sg-ignore
+        # @type [String]
+        # event_name = ARGV[1] || raise('Please pass event name as second argument')
+        # events = Checkoff::Events.new
+        # event = events.event_or_raise(workspace_name, event_name)
+        # puts "Results: #{event}"
+      end
+    end
+    # :nocov:
+  end
+end
+
+# :nocov:
+abs_program_name = File.expand_path($PROGRAM_NAME)
+Checkoff::Events.run if abs_program_name == File.expand_path(__FILE__)
+# :nocov:

data/lib/checkoff/internal/asana_event_filter.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require_relative 'logging'
+
+module Checkoff
+  module Internal
+    # Uses an enhanced version of Asana event filter configuration
+    #
+    # See https://developers.asana.com/reference/createwebhook | body
+    # params | data | filters for a general description of the scheme.
+    #
+    # Additional supported filter keys:
+    #
+    # * 'checkoff:parent.gid' - requires that the 'gid' key in the 'parent' object
+    #   match the given value
+    class AsanaEventFilter
+      include Logging
+
+      # @param filters [Array<Hash>, nil] The filters to match against
+      def initialize(filters:)
+        @filters = filters
+      end
+
+      # @param asana_event [Hash] The event that Asana sent
+      def matches?(asana_event)
+        logger.debug { "Filtering using #{@filters.inspect}" }
+        return true if @filters.nil?
+
+        @filters.any? do |filter|
+          out = filter_matches_asana_event?(filter, asana_event)
+          logger.debug { "Filter #{filter.inspect} matched? #{out} against event #{asana_event.inspect}" }
+          out
+        end
+      end
+
+      private
+
+      # @param filter [Hash]
+      # @param asana_event [Hash]
+      #
+      # @sg-ignore
+      # @return [Boolean]
+      def filter_matches_asana_event?(filter, asana_event)
+        # @param key [String]
+        # @param value [String, Array<String>]
+        filter.all? do |key, value|
+          asana_event_matches_filter_item?(key, value, asana_event)
+        end
+      end
+
+      # @param key [String]
+      # @param value [String, Array<String>]
+      # @param asana_event [Hash]
+      #
+      # @sg-ignore
+      # @return [Boolean]
+      def asana_event_matches_filter_item?(key, value, asana_event)
+        case key
+        when 'resource_type'
+          asana_event.fetch('resource', {})['resource_type'] == value
+        when 'resource_subtype'
+          asana_event.fetch('resource', {})['resource_subtype'] == value
+        when 'action'
+          asana_event['action'] == value
+        when 'fields'
+          value.include? asana_event.fetch('change', {})['field']
+        when 'checkoff:parent.gid'
+          asana_event.fetch('parent', {})['gid'] == value
+        else
+          raise "Unknown filter key #{key}"
+        end
+      end
+    end
+  end
+end

data/lib/checkoff/internal/logging.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'logger'
+
+# include this to add ability to log at different levels
+module Logging
+  # @return [::Logger]
+  def logger
+    # @sg-ignore
+    @logger ||= if defined?(Rails) && Rails.respond_to?(:logger) && Rails.logger
+                  # @sg-ignore
+                  Rails.logger
+                else
+                  ::Logger.new($stdout, level: log_level)
+                end
+  end
+
+  # @param message [String,nil]
+  #
+  # @return [void]
+  def error(message = nil, &block)
+    logger.error(message, &block)
+  end
+
+  # @param message [String,nil]
+  #
+  # @return [void]
+  def warn(message = nil, &block)
+    logger.warn(message, &block)
+  end
+
+  # @param message [String,nil]
+  #
+  # @return [void]
+  def info(message = nil, &block)
+    logger.info(message, &block)
+  end
+
+  # @param message [String,nil]
+  #
+  # @return [void]
+  def debug(message = nil, &block)
+    logger.debug(message, &block)
+  end
+
+  # @param message [String,nil]
+  #
+  # @return [void]
+  def finer(message = nil, &block)
+    # No such level by default
+    #
+    # logger.finer(message, &block)
+  end
+
+  private
+
+  # @sg-ignore
+  # @return [Symbol]
+  def log_level
+    # @sg-ignore
+    ENV.fetch('LOG_LEVEL', 'INFO').downcase.to_sym
+  end
+end

data/lib/checkoff/tasks.rb

@@ -127,11 +127,16 @@ module Checkoff
     #
     # @param task_gid [String]
     # @param extra_fields [Array<String>]
+    # @param only_uncompleted [Boolean]
+    #
     # @return [Asana::Resources::Task, nil]
     def task_by_gid(task_gid,
-                    extra_fields: [])
+                    extra_fields: [],
+                    only_uncompleted: false)
+      # @type [Hash]
       options = projects.task_options.fetch(:options, {})
       options[:fields] += extra_fields
+      options[:completed_since] = '9999-12-01' if only_uncompleted
       client.tasks.find_by_id(task_gid, options: options)
     end
     cache_method :task_by_gid, SHORT_CACHE_TIME
@@ -182,9 +187,10 @@ module Checkoff
         # the completion status of dependencies, so we need to do this
         # regardless:
         parent_task_gid = parent_task_info.fetch('gid')
-        parent_task = @asana_task.find_by_id(client, parent_task_gid,
-                                             options: { fields: ['completed'] })
-        !parent_task.completed
+
+        parent_task = task_by_gid(parent_task_gid,
+                                  only_uncompleted: false)
+        parent_task.completed_at.nil?
       end
     end
 

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.133.0'
+  VERSION = '0.135.0'
 end

data/lib/checkoff.rb

@@ -2,6 +2,7 @@
 
 require 'checkoff/version'
 require 'checkoff/clients'
+require 'checkoff/events'
 require 'checkoff/workspaces'
 require 'checkoff/portfolios'
 require 'checkoff/projects'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.133.0
+  version: 0.135.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-09 00:00:00.000000000 Z
+date: 2023-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -131,8 +131,11 @@ files:
 - lib/checkoff/clients.rb
 - lib/checkoff/create-entity.sh
 - lib/checkoff/custom_fields.rb
+- lib/checkoff/events.rb
+- lib/checkoff/internal/asana_event_filter.rb
 - lib/checkoff/internal/config_loader.rb
 - lib/checkoff/internal/create-class.sh
+- lib/checkoff/internal/logging.rb
 - lib/checkoff/internal/project_hashes.rb
 - lib/checkoff/internal/project_selector_evaluator.rb
 - lib/checkoff/internal/project_timing.rb