checkoff 0.13.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d54f389a54d7a47d43ec3fb15e1281482d54b3d1fbfd7fe5622a75e2710ab8d9
-  data.tar.gz: c4696373fb23d4dd798803bafeb09c64eb04f7f68cf9c94edcf35ac37d60f02b
+  metadata.gz: aa6999ea3bcde70f2cba0d6ecbf45102c85041d109e4d0d6ab55b92a941a1f3a
+  data.tar.gz: 52fe760413e0a8f559c42b9c0ac736e80f467d4d77578e77315fc0eea98b82ba
 SHA512:
-  metadata.gz: 87aefeff6e2b41c1aea50835e2552a6c44cbbdb3017f478a6f004de2052cc639d7bb887fb3613fecdf4429e1e87c541cbfa875d5ae4c008cf5ecd4d4fa90eb4f
-  data.tar.gz: 20de66650b388bc3f243a584efa2607637d46e8dfb51eb6ddd44b8bb15bafd9d71343e334c1a7af3f5417679d5da2d0a53f14cbf6221ead4b16cc3b89109f9c5
+  metadata.gz: 8ed9570ef12c90f3abb8ff8a19a8cf3678729c47785ab3bbfb1b000daab79a257f5df123ae4aa5b93fb9bb22bffb125c83552ee5168a59d4e5ae7ec36b57b31d
+  data.tar.gz: fad8749d150cddccdc7bab8baab9084bb63502d02874969113879f4607f02fa791f41444c70419218c45224053a4321a19e4f1c0bf53ac00f759e01d9789fe4d

data/.rubocop.yml

@@ -45,6 +45,15 @@ Naming/MethodParameterName:
     - x # cartesian coordinates
     - y # cartesian coordinates
 
+# by default (EnforcedStyle=NormalCase) this rule doesn't like
+# things like check_1, check_2, etc and wants check1, check2, etc. I
+# like the former.
+#
+# https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablenumber
+Naming/VariableNumber:
+  Enabled: true
+  EnforcedStyle: snake_case
+
 #
 # Add 'XX X' to the standard list
 #

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.13.0)
+    checkoff (0.14.1)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -85,7 +85,7 @@ GEM
       iniparse (~> 1.4)
       rexml (~> 3.2)
     parallel (1.20.1)
-    parser (3.0.1.1)
+    parser (3.0.2.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
@@ -95,16 +95,16 @@ GEM
     rake (13.0.3)
     regexp_parser (2.1.1)
     rexml (3.2.5)
-    rubocop (1.15.0)
+    rubocop (1.18.4)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.5.0, < 2.0)
+      rubocop-ast (>= 1.8.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.5.0)
+    rubocop-ast (1.8.0)
       parser (>= 3.0.1.1)
     rubocop-minitest (0.12.1)
       rubocop (>= 0.90, < 2.0)

data/coverage/.last_run.json

@@ -1,6 +1,6 @@
 {
   "result": {
-    "line": 98.57,
-    "branch": 91.66
+    "line": 99.75,
+    "branch": 95.0
   }
 }

data/lib/checkoff/subtasks.rb

@@ -11,6 +11,19 @@ module Checkoff
 
     extend Forwardable
 
+    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+                   projects: Checkoff::Projects.new(config: config))
+      @projects = projects
+    end
+
+    # True if all subtasks of the task are completed
+    def all_subtasks_completed?(task)
+      raw_subtasks = raw_subtasks(task)
+      active_subtasks = @projects.active_tasks(raw_subtasks)
+      # anything left should be a section
+      active_subtasks.all? { |subtask| subtask_section?(subtask) }
+    end
+
     # pulls a Hash of subtasks broken out by section
     def by_section(tasks)
       current_section = nil
@@ -24,14 +37,27 @@ module Checkoff
 
     # Returns all subtasks, including section headers
     def raw_subtasks(task)
-      task.subtasks(projects.task_options)
+      task_options = projects.task_options
+      task_options[:options][:fields] << 'is_rendered_as_separator'
+      task.subtasks(task_options)
+    end
+    cache_method :raw_subtasks, SHORT_CACHE_TIME
+
+    # True if the subtask passed in represents a section in the subtasks
+    #
+    # Note: expect this to be removed in a future version, as Asana is
+    # expected to move to the new-style way of representing sections
+    # as memberships with a separate API within a task.
+    def subtask_section?(subtask)
+      subtask.is_rendered_as_separator
     end
-    cache_method :raw_subtasks, LONG_CACHE_TIME
 
     private
 
+    attr_reader :projects
+
     def file_task_by_section(current_section, by_section, task)
-      if task.name =~ /:$/
+      if subtask_section?(task)
         current_section = task.name
         by_section[current_section] = []
       else

data/lib/checkoff/tasks.rb

@@ -16,12 +16,24 @@ module Checkoff
 
     def initialize(config: Checkoff::ConfigLoader.load(:asana),
                    sections: Checkoff::Sections.new(config: config),
+                   time_class: Time,
                    asana_task: Asana::Resources::Task)
       @config = config
       @sections = sections
+      @time_class = time_class
       @asana_task = asana_task
     end
 
+    def task_ready?(task)
+      return false if incomplete_dependencies?(task)
+
+      due = due_time(task)
+
+      return true if due.nil?
+
+      due < @time_class.now
+    end
+
     # Pull a specific task by name
     def task(workspace_name, project_name, task_name,
              section_name: :unspecified,
@@ -45,6 +57,11 @@ module Checkoff
                          workspace: workspace_gid, name: name)
     end
 
+    # Return an end-user URL to the task in question
+    def url_of_task(task)
+      "https://app.asana.com/0/0/#{task.gid}/f"
+    end
+
     private
 
     def client
@@ -58,5 +75,21 @@ module Checkoff
     def default_assignee_gid
       @config.fetch(:default_assignee_gid)
     end
+
+    def due_time(task)
+      return @time_class.parse(task.due_at) if task.due_at
+      return @time_class.parse(task.due_on) if task.due_on
+
+      nil
+    end
+
+    def incomplete_dependencies?(task)
+      task.dependencies.any? do |parent_task_info|
+        parent_task_gid = parent_task_info.gid
+        parent_task = @asana_task.find_by_id(client, parent_task_gid,
+                                             options: { fields: ['completed'] })
+        !parent_task.completed
+      end
+    end
   end
 end

data/lib/checkoff/version.rb

@@ -2,5 +2,5 @@
 
 module Checkoff
   # Version of library
-  VERSION = '0.13.0'
+  VERSION = '0.14.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-30 00:00:00.000000000 Z
+date: 2021-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport