checkoff 0.127.0 → 0.129.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 012d3342af651a679b9a7d56add94a0e3a908defaacf596d1f9a1573630327e4
-  data.tar.gz: 00c71d7578c1347b76d9364ca18dc73247bef830767aa14d8d2ec458b8d7a93d
+  metadata.gz: 1c9d07ad7181d5b4c1dcf0df6542f92e5468a4ffef70231dc2c4a35f03f9fd45
+  data.tar.gz: fff0a9a8e7663a71e4c5a257b709fcebe57e712d4536d12b1890834c1dd75be5
 SHA512:
-  metadata.gz: 4feed1a46d323588135bf5de72b162cdd0f3f05216fff8c7f9609627ca6514b4cb4a2214675b81ac02adfb51919ca84dbcaa088dddc826c714d4afbe1ad4bb4d
-  data.tar.gz: 60c6604bd7228984938f0c439500c2f62572c24fa6dec68c0bb68a823696e06a734cd09717e9faf7421ae530b60b534819c98c75b8fe3ada4f0923e46147a6e0
+  metadata.gz: ddebe33692c02e9798a4ffa65b9ba105c1a3a62c7f6482fccbf9fd2ca4ba9cce443680a26f4b488f40d3a8316baf70b9acfaa811e79cf552bc1fc900d62da48f
+  data.tar.gz: 1b49aeddc864873a270b08076d2d6ba9b107b25a8113714fd9e7a2e14b19e38ea59d143d33f6d75f6e1be23444230d25fdfcaf10bd0f8d82552f7b333a907a0e

data/GLOSSARY.md

@@ -2,10 +2,15 @@
 
 * ready: See tasks.rb#task_ready?.  Indicates a task is ready for
   a person to work on it.  This is subtly different than what is used
-  by Asana to mark a date as red/green!  A task is ready if it is not
-  dependent on an incomplete task and one of these is true:
+  by Asana to mark a date as red/green!
+
+  A task is ready if it is not dependent on an incomplete task and one
+  of these is true:
 
   * start is null and due on is today
   * start is null and due at is before now
   * start on is today
   * start at is before now
+
+  A project is ready if there is no start date, or if the start date
+  is today or in the past.

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.127.0)
+    checkoff (0.129.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/config/definitions.rb

@@ -209,6 +209,13 @@
 #
 #         # @return [Asana::Resources::Portfolio,nil]
 #         def find_by_id(client, id, options: {}); end
+#         # Get portfolio items
+#         #
+#         # @param portfolio_gid [String]  (required) Globally unique identifier for the portfolio.
+#         # @param options [Hash] the request I/O options
+#         #
+#         # @return [Enumerable<Asana::Resources::Project>]
+#         def get_items_for_portfolio(portfolio_gid: required("portfolio_gid"), options: {}); end
 #       end
 #       class User
 #         # Returns the full user record for the currently authenticated user.

data/lib/checkoff/internal/project_timing.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+module Checkoff
+  module Internal
+    # Utility methods for working with project dates and times
+    class ProjectTiming
+      # @param time_class [Class<Time>]
+      # @param date_class [Class<Date>]
+      # @param client [Asana::Client]
+      # @param custom_fields [Checkoff::CustomFields]
+      def initialize(time_class: Time, date_class: Date,
+                     client: Checkoff::Clients.new.client,
+                     custom_fields: Checkoff::CustomFields.new(client: client))
+        @time_class = time_class
+        @date_class = date_class
+        @custom_fields = custom_fields
+      end
+
+      # @param project [Asana::Resources::Project]
+      # @param field_name [Symbol]
+      #
+      # @sg-ignore
+      # @return [Date, nil]
+      def start_date(project)
+        return @date_class.parse(project.start_on) unless project.start_on.nil?
+
+        nil
+      end
+
+      # @param project [Asana::Resources::Project]
+      # @param field_name [Symbol]
+      #
+      # @sg-ignore
+      # @return [Date, nil]
+      def due_date(project)
+        return @date_class.parse(project.due_on) unless project.due_on.nil?
+
+        nil
+      end
+
+      # @param project [Asana::Resources::Project]
+      # @param custom_field_name [String]
+      #
+      # @return [Time, Date, nil]
+      def custom_field(project, custom_field_name)
+        custom_field = @custom_fields.resource_custom_field_by_name_or_raise(project, custom_field_name)
+        # @sg-ignore
+        # @type [String, nil]
+        time_str = custom_field.fetch('display_value')
+        return nil if time_str.nil?
+
+        Time.parse(time_str)
+      end
+
+      # @param project [Asana::Resources::Project]
+      # @param field_name [Symbol,Array]
+      #
+      # @sg-ignore
+      # @return [Date, Time, nil]
+      def date_or_time_field_by_name(project, field_name)
+        return due_date(project) if field_name == :due
+
+        return start_date(project) if field_name == :start
+
+        return start_date(project) if field_name == :ready
+
+        if field_name.is_a?(Array)
+          # @sg-ignore
+          # @type [Symbol]
+          actual_field_name = field_name.first
+          args = field_name[1..]
+
+          return custom_field(project, *args) if actual_field_name == :custom_field
+        end
+
+        raise "Teach me how to handle field #{field_name}"
+      end
+    end
+  end
+end

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -136,7 +136,7 @@ module Checkoff
             selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
             [{ "custom_fields.#{gid}.is_set" => 'true' },
-             ['custom_field_gid_value_contains_all_gids',
+             ['custom_field_gid_value_contains_all_gids?',
               gid,
               selected_options]]
           end

data/lib/checkoff/internal/selector_classes/project.rb

@@ -20,6 +20,22 @@ module Checkoff
           resource.due_date
         end
       end
+
+      # :ready? function
+      class ReadyPFunctionEvaluator < FunctionEvaluator
+        FUNCTION_NAME = :ready?
+
+        def matches?
+          fn?(selector, FUNCTION_NAME)
+        end
+
+        # @param project [Asana::Resources::Project]
+        # @param period [Symbol<:now_or_before,:this_week>]
+        # @return [Boolean]
+        def evaluate(project, period = :now_or_before)
+          @projects.project_ready?(project, period: period)
+        end
+      end
     end
   end
 end

data/lib/checkoff/portfolios.rb

@@ -99,7 +99,7 @@ module Checkoff
         fields: ['name'],
       }
       options[:fields] += extra_project_fields
-      portfolio.get_items(options: options)
+      client.portfolios.get_items_for_portfolio(portfolio_gid: portfolio.gid, options: options)
     end
 
     private

data/lib/checkoff/projects.rb

@@ -2,6 +2,7 @@
 
 require_relative 'internal/config_loader'
 require_relative 'internal/project_hashes'
+require_relative 'internal/project_timing'
 require_relative 'workspaces'
 require_relative 'clients'
 require 'cache_method'
@@ -32,15 +33,21 @@ module Checkoff
     # @param client [Asana::Client]
     # @param workspaces [Checkoff::Workspaces]
     # @param project_hashes [Checkoff::Internal::ProjectHashes]
+    # @param project_timing [Checkoff::Internal::ProjectTiming]
+    # @param timing [Checkoff::Timing]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    client: Checkoff::Clients.new(config: config).client,
                    workspaces: Checkoff::Workspaces.new(config: config,
                                                         client: client),
-                   project_hashes: Checkoff::Internal::ProjectHashes.new)
+                   project_hashes: Checkoff::Internal::ProjectHashes.new,
+                   project_timing: Checkoff::Internal::ProjectTiming.new(client: client),
+                   timing: Checkoff::Timing.new)
       @config = config
       @workspaces = workspaces
       @client = client
       @project_hashes = project_hashes
+      @project_timing = project_timing
+      @timing = timing
     end
 
     # Default options used in Asana API to pull tasks
@@ -139,8 +146,37 @@ module Checkoff
       project_hashes.project_to_h(project_obj, project: project)
     end
 
+    # Indicates a project is ready for a person to work on it.  This
+    # is subtly different than what is used by Asana to mark a date as
+    # red/green!
+    #
+    # A project is ready if there is no start date, or if the start
+    # date is today or in the past.
+    #
+    # @param project [Asana::Resources::Project]
+    # @param period [Symbol<:now_or_before,:this_week>]
+    def project_ready?(project, period: :now_or_before)
+      in_period?(project, :ready, period)
+    end
+
+    # @param project [Asana::Resources::Project]
+    # @param field_name [Symbol,Array]
+    # @param period [Symbol<:now_or_before,:this_week>,Array] See Checkoff::Timing#in_period?
+    def in_period?(project, field_name, period)
+      # @type [Date,Time,nil]
+      project_date = project_timing.date_or_time_field_by_name(project, field_name)
+
+      timing.in_period?(project_date, period)
+    end
+
     private
 
+    # @return [Checkoff::Timing]
+    attr_reader :timing
+
+    # @return [Checkoff::Internal::ProjectTiming]
+    attr_reader :project_timing
+
     # @return [Checkoff::Internal::ProjectHashes]
     attr_reader :project_hashes
 

data/lib/checkoff/tasks.rb

@@ -54,7 +54,7 @@ module Checkoff
       @portfolios = portfolios
       @custom_fields = custom_fields
       @workspaces = workspaces
-      @timing = Timing.new(today_getter: date_class, now_getter: time_class)
+      @timing = Checkoff::Timing.new(today_getter: date_class, now_getter: time_class)
     end
 
     # Indicates a task is ready for a person to work on it.  This is

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.127.0'
+  VERSION = '0.129.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.127.0
+  version: 0.129.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-04 00:00:00.000000000 Z
+date: 2023-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -135,6 +135,7 @@ files:
 - lib/checkoff/internal/create-class.sh
 - lib/checkoff/internal/project_hashes.rb
 - lib/checkoff/internal/project_selector_evaluator.rb
+- lib/checkoff/internal/project_timing.rb
 - lib/checkoff/internal/search_url.rb
 - lib/checkoff/internal/search_url/custom_field_param_converter.rb
 - lib/checkoff/internal/search_url/custom_field_variant.rb