checkoff 0.101.0 → 0.103.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6242a956ad83d3a1818be59711f4ba42040d7051dac2dd0ba2c8a2e5ed29f244
-  data.tar.gz: 515a08a90d20a58956256f76248f01d7a5fd52c6ac14e1fbd8215a6eb33dcc6d
+  metadata.gz: 18ab918128cd0d805829245306102209f7715f9dfa580a8861b4e97be7aa3b31
+  data.tar.gz: 0c40f9f30d1a0441de43140dcd442d783c7b6ae5e584e9b0ed23e13acbe5e35e
 SHA512:
-  metadata.gz: 8575f32ba5e2130117784cdf0b6e3f9bd40a11c918ffd99208457cd8dde84f7333da5ffc09096f520bccb28f6451da0605f3a3073002de89e8b9d75800371dfa
-  data.tar.gz: 037b01300963f231ba1401eb55beb47aff94deb9baab62c3d952876de3d3afc6d5a2c427bb717f5bdc0b8faa8cf3029bdd844de8d955ae3d600ebf9b2ee20835
+  metadata.gz: 4b0ce332d7ee01af5680511dd1c7da6b7654f94b153b3240d344c64663ebc71ceaff79bc4ae2fb01846430904e167a36b81d55ac581f992524eef3dae50c6783
+  data.tar.gz: 738deef8848a424fe874711c874f83b70b14320b9df49a85da6b187da8e817887a3d3de9b63cc65411cf866e5813eb759d5c051eaf9b3c1d50726a98fa3dde33

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.101.0)
+    checkoff (0.103.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/ready_between_relative.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module Checkoff
+  module Internal
+    # Determine whether a task is due within a relative date range
+    class ReadyBetweenRelative
+      # @param config [Hash<Symbol, Object>]
+      # @param clients [Checkoff::Clients]
+      # @param task_timing [Checkoff::Internal::TaskTiming]
+      # @param tasks [Checkoff::Tasks]
+      def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
+                     clients: Checkoff::Clients.new(config: config),
+                     task_timing: ::Checkoff::Internal::TaskTiming.new,
+                     tasks: ::Checkoff::Tasks.new(config: config,
+                                                  client: clients.client))
+        @task_timing = task_timing
+        @tasks = tasks
+      end
+
+      # @param task [Asana::Resources::Task]
+      # @param beginning_num_days_from_now [Integer]
+      # @param end_num_days_from_now [Integer]
+      # @param ignore_dependencies [Boolean]
+      #
+      # @return [Boolean]
+      def ready_between_relative?(task,
+                                  beginning_num_days_from_now,
+                                  end_num_days_from_now,
+                                  ignore_dependencies: false)
+        beginning_n_days_from_now_time = (Time.now + (beginning_num_days_from_now * 24 * 60 * 60))
+        end_n_days_from_now_time = (Time.now + (end_num_days_from_now * 24 * 60 * 60))
+
+        # @type [Date, Time, nil]
+        ready_date_or_time = @task_timing.date_or_time_field_by_name(task, :ready)
+
+        return false if ready_date_or_time.nil?
+
+        in_range = ready_in_range?(ready_date_or_time,
+                                   beginning_n_days_from_now_time,
+                                   end_n_days_from_now_time)
+
+        return false unless in_range
+
+        return false if !ignore_dependencies && @tasks.incomplete_dependencies?(task)
+
+        true
+      end
+
+      private
+
+      # @param ready_date_or_time [Date, Time]
+      # @param start_time [Time]
+      # @param end_time [Time]
+      def ready_in_range?(ready_date_or_time, start_time, end_time)
+        if ready_date_or_time.is_a?(Time)
+          ready_date_or_time > start_time && ready_date_or_time <= end_time
+        else
+          ready_date_or_time > start_time.to_date && ready_date_or_time <= end_time.to_date
+        end
+      end
+    end
+  end
+end

data/lib/checkoff/internal/selector_classes/task/function_evaluator.rb

@@ -17,7 +17,6 @@ module Checkoff
           @selector = selector
           @tasks = tasks
           @timelines = timelines
-          @task_timing = ::Checkoff::Internal::TaskTiming.new
           super()
         end
 

data/lib/checkoff/internal/selector_classes/task.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative 'task/function_evaluator'
+require 'checkoff/internal/ready_between_relative'
 
 module Checkoff
   module SelectorClasses
@@ -134,51 +135,10 @@ module Checkoff
         #
         # @return [Boolean]
         def evaluate(task, beginning_num_days_from_now, end_num_days_from_now, ignore_dependencies: false)
-          ready_between_relative?(task,
-                                  beginning_num_days_from_now, end_num_days_from_now,
-                                  ignore_dependencies: ignore_dependencies)
-        end
-
-        private
-
-        # @param task [Asana::Resources::Task]
-        # @param beginning_num_days_from_now [Integer]
-        # @param end_num_days_from_now [Integer]
-        # @param ignore_dependencies [Boolean]
-        #
-        # @return [Boolean]
-        def ready_between_relative?(task,
-                                    beginning_num_days_from_now,
-                                    end_num_days_from_now,
-                                    ignore_dependencies: false)
-          beginning_n_days_from_now_time = (Time.now + (beginning_num_days_from_now * 24 * 60 * 60))
-          end_n_days_from_now_time = (Time.now + (end_num_days_from_now * 24 * 60 * 60))
-
-          # @type [Date, Time, nil]
-          ready_date_or_time = @task_timing.date_or_time_field_by_name(task, :ready)
-
-          return false if ready_date_or_time.nil?
-
-          in_range = ready_in_range?(ready_date_or_time,
-                                     beginning_n_days_from_now_time,
-                                     end_n_days_from_now_time)
-
-          return false unless in_range
-
-          return false if !ignore_dependencies && @tasks.incomplete_dependencies?(task)
-
-          true
-        end
-
-        # @param ready_date_or_time [Date, Time]
-        # @param start_time [Time]
-        # @param end_time [Time]
-        def ready_in_range?(ready_date_or_time, start_time, end_time)
-          if ready_date_or_time.is_a?(Time)
-            ready_date_or_time > start_time && ready_date_or_time <= end_time
-          else
-            ready_date_or_time > start_time.to_date && ready_date_or_time <= end_time.to_date
-          end
+          ready_between_relative = Checkoff::Internal::ReadyBetweenRelative.new(tasks: @tasks)
+          ready_between_relative.ready_between_relative?(task,
+                                                         beginning_num_days_from_now, end_num_days_from_now,
+                                                         ignore_dependencies: ignore_dependencies)
         end
       end
 

data/lib/checkoff/tasks.rb

@@ -76,6 +76,7 @@ module Checkoff
     end
 
     # Pull a specific task by name
+    #
     # @param workspace_name [String]
     # @param project_name [String, Symbol]
     # @param section_name [String, nil, Symbol]
@@ -98,7 +99,8 @@ module Checkoff
     end
     cache_method :task, SHORT_CACHE_TIME
 
-    # Pull a specific task by name
+    # Pull a specific task by GID
+    #
     # @param task_gid [String]
     # @param extra_fields [Array<String>]
     # @return [Asana::Resources::Task, nil]
@@ -110,9 +112,12 @@ module Checkoff
     end
     cache_method :task_by_gid, SHORT_CACHE_TIME
 
+    # Add a task
+    #
     # @param name [String]
     # @param workspace_gid [String]
     # @param assignee_gid [String]
+    #
     # @return [Asana::Resources::Task]
     def add_task(name,
                  workspace_gid: @workspaces.default_workspace_gid,
@@ -122,12 +127,17 @@ module Checkoff
                          workspace: workspace_gid, name: name)
     end
 
+    # Return user-accessible URL for a task
+    #
     # @param task [Asana::Resources::Task]
+    #
     # @return [String] end-user URL to the task in question
     def url_of_task(task)
       "https://app.asana.com/0/0/#{task.gid}/f"
     end
 
+    # True if any of the task's dependencies are marked incomplete
+    #
     # @param task [Asana::Resources::Task]
     def incomplete_dependencies?(task)
       # Avoid a redundant fetch.  Unfortunately, Ruby SDK allows
@@ -166,11 +176,14 @@ module Checkoff
     # task: String (name)
     #
     # @param task [Asana::Resources::Task]
+    #
     # @return [Hash]
     def task_to_h(task)
       task_hashes.task_to_h(task)
     end
 
+    # True if the task is in a project which is in the given portfolio
+    #
     # @param task [Asana::Resources::Task]
     # @param portfolio_name [String]
     # @param workspace_name [String]

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.101.0'
+  VERSION = '0.103.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.101.0
+  version: 0.103.0
 platform: ruby
 authors:
 - Vince Broz
@@ -134,6 +134,7 @@ files:
 - lib/checkoff/internal/config_loader.rb
 - lib/checkoff/internal/create-class.sh
 - lib/checkoff/internal/project_selector_evaluator.rb
+- lib/checkoff/internal/ready_between_relative.rb
 - lib/checkoff/internal/search_url.rb
 - lib/checkoff/internal/search_url/custom_field_param_converter.rb
 - lib/checkoff/internal/search_url/custom_field_variant.rb