checkoff 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fa7ac9629b6bf129771e5c5d7f9cdf0a19fcdfa
-  data.tar.gz: 7508f757fd87b77d57759bd94a9dd088dbd11668
+  metadata.gz: fb140b2c3cd6899f6244d46a8b8c979ff84156c4
+  data.tar.gz: 27fe46e1995216eb5e7a663e64baffc4528732a3
 SHA512:
-  metadata.gz: 743208cf0f350833f60134480c9ae88ffc59cedb646a43e1edb961594023577354a7691590563c9b5b5b69f39ecc7a2ac7d33f152b4552be1513c5a6ace573b3
-  data.tar.gz: 577fe3cfb99e59890367501d946cf66d7bf3d8c12694af9d0d860a6a0a0ada80dd93d3c44666ee1b23abb0c7f51746d20b88a389b481d69c8de8641295ab96cc
+  metadata.gz: 7296099b7f92d602263ffbff3f29365ece01b4915b5dcdbf8526dce9e2381c478e96b695443f57ef543a578f6c74550eb1470e855893abb2cc964171836fc704
+  data.tar.gz: ecabaf1af01734d7b5cfe4407fa35c80e2b0e1fddd15eecb31a87ab35a4c894e310166546cdadf06ec33505b0c356971b1c49a714c20aaca48f8750796d949a1

data/.rubocop.yml

@@ -17,6 +17,9 @@ ParameterLists:
 TrivialAccessors:
    ExactNameMatch: true
 
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
 #
 # Add 'XXX' to the standard list
 #

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in checkoff.gemspec

data/Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 
 Dir['lib/tasks/**/*.rake'].each { |t| load t }

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "checkoff"
+require 'bundler/setup'
+require 'checkoff'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "checkoff"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/checkoff.gemspec

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 # coding: ascii
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'checkoff/version'

data/coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "covered_percent": 98.66
+    "covered_percent": 98.78
   }
 }

data/exe/checkoff

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'checkoff/cli'
 

data/lib/checkoff/cli.rb

@@ -1,9 +1,11 @@
 #!/usr/bin/env ruby
 
 # frozen_string_literal: true
+
 require 'ostruct'
 require 'dalli'
 require 'cache_method'
+require_relative 'workspaces'
 require_relative 'projects'
 require_relative 'tasks'
 require_relative 'sections'
@@ -13,12 +15,16 @@ module Checkoff
   class CLI
     attr_reader :sections, :stderr
 
-    def initialize(projects: Checkoff::Projects.new,
+    def initialize(workspaces: Checkoff::Workspaces.new,
+                   projects: Checkoff::Projects.new,
                    sections: Checkoff::Sections.new(projects: projects),
+                   tasks: Checkoff::Tasks.new,
                    stderr: STDERR,
                    kernel: Kernel)
+      @workspaces = workspaces
       @projects = projects
       @sections = sections
+      @tasks = tasks
       @kernel = kernel
       @stderr = stderr
     end
@@ -54,26 +60,37 @@ module Checkoff
       tasks_to_hash(tasks).to_json
     end
 
-    def quickadd(task_name)
-      @projects.add_task(task_name)
+    def quickadd(workspace_name, task_name)
+      workspace = @workspaces.workspace_by_name(workspace_name)
+      @tasks.add_task(task_name,
+                      workspace_id: workspace.id)
     end
 
     def validate_args!(args)
-      return unless args.length < 2 || !%w(view quickadd).include?(args[0])
+      return unless args.length < 2 || !%w[view quickadd].include?(args[0])
 
       output_help
       exit(1)
     end
 
+    def parse_view_args(subargs, args)
+      subargs.workspace = args[1]
+      subargs.project = args[2]
+      subargs.section = args[3]
+    end
+
+    def parse_quickadd_args(subargs, args)
+      subargs.workspace = args[1]
+      subargs.task_name = args[2]
+    end
+
     def parse_args(args)
-      validate_args!(args)
       mode = args[0]
       subargs = OpenStruct.new
       if mode == 'view'
-        subargs.workspace = args[1]
-        subargs.project = args[2]
+        parse_view_args(subargs, args)
       elsif mode == 'quickadd'
-        subargs.task_name = args[1]
+        parse_quickadd_args(subargs, args)
       else
         raise
       end
@@ -83,24 +100,28 @@ module Checkoff
     def output_help
       stderr.puts 'View tasks:'
       stderr.puts "  #{$PROGRAM_NAME} view workspace project [section]"
-      stderr.puts "  #{$PROGRAM_NAME} quickadd task_name"
+      stderr.puts "  #{$PROGRAM_NAME} quickadd workspace task_name"
       stderr.puts
       stderr.puts "'project' can be set to a project name, or :my_tasks, " \
                   ':my_tasks_upcoming, :my_tasks_new, or :my_tasks_today'
     end
 
+    def view(workspace_name, project_name, section_name)
+      project_name = project_name[1..-1].to_sym if project_name.start_with? ':'
+      if section_name.nil?
+        run_on_project(workspace_name, project_name)
+      else
+        run_on_section(workspace_name, project_name, section_name)
+      end
+    end
+
     def run(args)
+      validate_args!(args)
       command, subargs = parse_args(args)
       if command == 'view'
-        project = subargs.project
-        project = project[1..-1].to_sym if project.start_with? ':'
-        if section.nil?
-          run_on_project(subargs.workspace, project)
-        else
-          run_on_section(subargs.workspace, project, subargs.section)
-        end
+        view(subargs.workspace, subargs.project, subargs.section)
       elsif command == 'quickadd'
-        quickadd(subargs.task_name)
+        quickadd(subargs.workspace, subargs.task_name)
       else
         raise
       end

data/lib/checkoff/config_loader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'yaml'
 require 'active_support/core_ext/hash'
 
@@ -9,7 +10,7 @@ module Checkoff
     def self.load(sym)
       file = "#{sym}.yml"
       YAML.load_file(File.expand_path("~/.#{file}"))
-          .with_indifferent_access
+        .with_indifferent_access
     end
   end
 end

data/lib/checkoff/projects.rb

@@ -24,15 +24,15 @@ module Checkoff
     # XXX: Move low-level functions private
 
     def initialize(config: Checkoff::ConfigLoader.load(:asana),
-                   asana_client: Asana::Client)
+                   asana_client: Asana::Client,
+                   workspaces: Checkoff::Workspaces.new)
       @config = config
       @asana_client = asana_client
+      @workspaces = workspaces
     end
 
     def client
-      @client ||= @asana_client.new do |c|
-        c.authentication :access_token, @config[:personal_access_token]
-      end
+      @workspaces.client
     end
 
     def projects
@@ -40,37 +40,8 @@ module Checkoff
     end
     cache_method :projects, LONG_CACHE_TIME
 
-    def add_task(name,
-                 workspace_id: default_workspace_id,
-                 assignee_id: default_assignee_id)
-      Asana::Resources::Task.create(client,
-                                    assignee: assignee_id,
-                                    workspace: workspace_id, name: name)
-    end
-
-    def default_workspace_id
-      @config[:default_workspace_id]
-    end
-
-    def default_assignee_id
-      @config[:default_assignee_id]
-    end
-
-    def user_by_name(name, workspace_id: raise)
-      client.users.find_all(workspace: workspace_id).find do |user|
-        print(user)
-        user.name == name
-      end || raise("Could not find user #{email}")
-    end
-
-    def workspace_by_name(workspace_name)
-      client.workspaces.find_all.find do |workspace|
-        workspace.name == workspace_name
-      end || raise("Could not find workspace #{workspace_name}")
-    end
-
     def projects_by_workspace_name(workspace_name)
-      workspace = workspace_by_name(workspace_name)
+      workspace = @workspaces.workspace_by_name(workspace_name)
       raise "Could not find workspace named #{workspace_name}" unless workspace
       projects.find_by_workspace(workspace: workspace.id)
     end
@@ -102,14 +73,19 @@ module Checkoff
 
     def task_options
       {
+        per_page: 100,
         options: {
-          fields: %w(name assignee_status completed_at due_at due_on),
+          fields: %w[name completed_at due_at due_on],
         },
       }
     end
 
-    def tasks_from_project(project)
-      project.tasks(task_options).to_a
+    def tasks_from_project(project, only_uncompleted: true, extra_fields: [])
+      options = task_options
+      options[:completed_since] = '9999-12-01' if only_uncompleted
+      options[:project] = project.id
+      options[:options][:fields] += extra_fields
+      client.tasks.find_all(options).to_a
     end
     cache_method :tasks_from_project, LONG_CACHE_TIME
   end

data/lib/checkoff/sections.rb

@@ -1,4 +1,7 @@
 # frozen_string_literal: true
+
+require 'forwardable'
+
 module Checkoff
   # Query different sections of Asana projects
   class Sections
@@ -6,6 +9,8 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE * 5
 
+    extend Forwardable
+
     attr_reader :projects, :time
 
     def initialize(projects: Checkoff::Projects.new,
@@ -14,6 +19,8 @@ module Checkoff
       @time = time
     end
 
+    def_delegators :@projects, :client
+
     def file_task_by_section(current_section, by_section, task)
       if task.name =~ /:$/
         current_section = task.name
@@ -47,7 +54,7 @@ module Checkoff
       raw_tasks = projects.tasks_from_project(project)
       by_assignee_status =
         projects.active_tasks(raw_tasks)
-                .group_by(&:assignee_status)
+          .group_by(&:assignee_status)
       active_tasks = by_assignee_status[assignee_status]
       by_section(active_tasks)
     end

data/lib/checkoff/tasks.rb

@@ -14,12 +14,32 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE * 5
 
-    def initialize(sections: Checkoff::Sections.new)
+    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+                   sections: Checkoff::Sections.new,
+                   asana_task: Asana::Resources::Task)
+      @config = config
       @sections = sections
+      @asana_task = asana_task
+    end
+
+    def client
+      @sections.client
     end
 
     def tasks_minus_sections(tasks)
       @sections.by_section(tasks).values.flatten
     end
+
+    def add_task(name,
+                 workspace_id: default_workspace_id,
+                 assignee_id: default_assignee_id)
+      @asana_task.create(client,
+                         assignee: assignee_id,
+                         workspace: workspace_id, name: name)
+    end
+
+    def default_assignee_id
+      @config[:default_assignee_id]
+    end
   end
 end

data/lib/checkoff/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Checkoff
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/lib/checkoff/workspaces.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Checkoff
+  # Query different workspaces of Asana projects
+  class Workspaces
+    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+                   asana_client: Asana::Client)
+      @config = config
+      @asana_client = asana_client
+    end
+
+    def client
+      @client ||= @asana_client.new do |c|
+        c.authentication :access_token, @config[:personal_access_token]
+      end
+    end
+
+    def default_workspace_id
+      @config[:default_workspace_id]
+    end
+
+    def workspace_by_name(workspace_name)
+      client.workspaces.find_all.find do |workspace|
+        workspace.name == workspace_name
+      end || raise("Could not find workspace #{workspace_name}")
+    end
+  end
+end

data/lib/checkoff.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
+
 require 'checkoff/version'
+require 'checkoff/workspaces'
 require 'checkoff/projects'
 require 'checkoff/sections'
 require 'checkoff/tasks'

data/lib/tasks/ci.rake

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
+
 task ci: :localtest

data/lib/tasks/clear_metrics.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 task :clear_metrics do |_t|
   ret =
     system('git checkout coverage/.last_run.json metrics/*_high_water_mark')

data/lib/tasks/default.rake

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
+
 task default: :localtest

data/lib/tasks/feature.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rspec/core/rake_task'
 
 desc 'Run features'

data/lib/tasks/localtest.rake

@@ -1,2 +1,3 @@
 # frozen_string_literal: true
-task localtest: [:clear_metrics, :test, :quality]
+
+task localtest: %i[clear_metrics test quality]

data/lib/tasks/quality.rake

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
+
 require 'quality/rake/task'
 
 Quality::Rake::Task.new do |task|
   task.skip_tools = ['reek']
   task.output_dir = 'metrics'
+  task.exclude_files = ['docs/example_project.png']
 end

data/lib/tasks/spec.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rspec/core/rake_task'
 
 desc 'Run specs'

data/lib/tasks/test.rake

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rake/testtask'
 
 Rake::TestTask.new do |t|

data/metrics/bigfiles_high_water_mark

@@ -1 +1 @@
-487
+459

data/metrics/flake8_high_water_mark

@@ -0,0 +1 @@
+0

data/metrics/mdl_high_water_mark

@@ -0,0 +1 @@
+8

data/metrics/scalastyle_high_water_mark

@@ -0,0 +1 @@
+0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-16 00:00:00.000000000 Z
+date: 2017-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dalli
@@ -181,7 +181,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/checkoff
 - bin/console
 - bin/setup
 - checkoff.gemspec
@@ -196,6 +195,7 @@ files:
 - lib/checkoff/sections.rb
 - lib/checkoff/tasks.rb
 - lib/checkoff/version.rb
+- lib/checkoff/workspaces.rb
 - lib/tasks/ci.rake
 - lib/tasks/clear_metrics.rake
 - lib/tasks/default.rake
@@ -209,13 +209,16 @@ files:
 - metrics/bundle-audit_high_water_mark
 - metrics/cane_high_water_mark
 - metrics/eslint_high_water_mark
+- metrics/flake8_high_water_mark
 - metrics/flay_high_water_mark
 - metrics/flog_high_water_mark
 - metrics/jscs_high_water_mark
+- metrics/mdl_high_water_mark
 - metrics/pep8_high_water_mark
 - metrics/punchlist_high_water_mark
 - metrics/rails_best_practices_high_water_mark
 - metrics/rubocop_high_water_mark
+- metrics/scalastyle_high_water_mark
 homepage: http://github.com/apiology/checkoff
 licenses:
 - MIT

data/bin/checkoff

@@ -1 +0,0 @@
-#!/usr/bin/env ruby