checker_jobs 1.1.1 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 407540f61ad36263f771cc0493b8675c23037ed6887227ebc73d2ef2d49fb25a
-  data.tar.gz: e2151498b71791a6065bf1e951b18e6d000c0c05bd287c1e1cbe6862c09bf3d7
+  metadata.gz: e2702b00cc3f7fa8a5b68ff40faf5edffe09c7ddc15bfd4c08ab627ade6bc6d4
+  data.tar.gz: 2ecf0e6f78a41ae17532e0ed57c4bbca00af5222fb999fb4b71dda19085e88d0
 SHA512:
-  metadata.gz: 8da268fd3e0e20148297bafeb4f6ffe2aca570d957520ba4d90f25b9b6cb3c228ef3dd2a0ac47307c5ff2f1e837ce7194ab12d6369b1d3b079374081c3e3ccec
-  data.tar.gz: 4715cf8a236d1c19a6234a9b0234c53104a5a8ee9c238aadeed993fa709a8f4c4a5a1f7391a81d7562ac98925daa6a36fcb4b47653363f1d9abf59cbe9d574be
+  metadata.gz: d1968fd1504a6b4b4bc056a0a67ae4e501658a95defc4b874bd16e24acf7567edc7f57058d412afee865ab5af2e00590422c05c6a66852009757f86da41cdf58
+  data.tar.gz: 7b61bfb6e7ecdfd9095058fb6bc9d4bf26edd6bf8c1798bfad79d9df6ba82c798db45f4178e2c5020b6c79508c12a5b50e5fc61b7706d14df8526500197db321

data/.circleci/config.yml

@@ -1,48 +1,62 @@
 version: 2
 jobs:
-  build:
+  test-ruby:
     docker:
-      - image: drivy/rails-ci:0.1.2
+      - image: cimg/ruby:2.6.6
     steps:
       - checkout
-
-      - run: git fetch origin --depth=1000
-
-      # Install CodeClimate test reporter binary, rebuild without cache to update the binary
-      - restore_cache:
-          key: cc_test_reporter
       - run:
-          name: Install Code Climate test reporter
+          name: Install CMake, pkg-config and system dependencies
+          command: sudo apt update && sudo apt install cmake pkg-config libsqlite3-dev
+      - run:
+          name: Install Bundler
           command: |
-            [ -f bin/cc-test-reporter ] || curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./bin/cc-test-reporter
-            chmod +x bin/cc-test-reporter
-      - restore_cache:
-          key: cc_test_reporter
-          paths:
-            - bin/cc-test-reporter
-
+            sudo gem update --system
+            gem install bundler --no-document
       - run:
-          name: "Creating a Gemfile.lock without bundler's version"
-          command: "head -n -3 Gemfile.lock > Gemfile.lock.no-version"
-
-      # Bundle install with cache, Ignore bundler version
-      - restore_cache:
-          key: checker_jobs-{{ checksum "Gemfile.lock.no-version"}}
-      - run:
-          name: Install Ruby dependencies
-          command: bundle install --path vendor/bundle --jobs=`nproc`
-      - save_cache:
-          key: checker_jobs-{{ checksum "Gemfile.lock.no-version"}}
-          paths:
-            - vendor/bundle
-
+          name: Install dependencies (bundler)
+          command: |
+            bundle config set frozen 'true'
+            bundle config set path 'vendor/bundle'
+            bundle install --jobs=4
       - run:
-          name: RSpec
+          name: Install linting dependencies (Bundler)
           command: |
-            ./bin/cc-test-reporter before-build
-            bundle exec rspec --format documentation
-            ./bin/cc-test-reporter after-build --exit-code $?
+            bundle config set frozen 'true'
+            bundle config set path 'vendor/bundle'
+            bundle install --jobs=4
+      - run:
+          name: Lint Ruby sources (RSpec)
+          command: bundle exec rspec
 
+  lint-ruby:
+    docker:
+      - image: cimg/ruby:2.6.6
+    steps:
+      - checkout
+      - run:
+          name: Install CMake, pkg-config and system dependencies
+          command: sudo apt update && sudo apt install cmake pkg-config libsqlite3-dev
+      - run:
+          name: Install Bundler
+          command: |
+            sudo gem update --system
+            gem install bundler --no-document
+      - run:
+          name: Install dependencies (bundler)
+          command: |
+            bundle config set frozen 'true'
+            bundle config set path 'vendor/bundle'
+            bundle install --jobs=4
       - run:
-          name: Pronto
-          command: bin/pronto-ci
+          name: Lint Ruby sources (Rubocop)
+          command: bundle exec rubocop
+
+workflows:
+  version: 2
+  test-and-deploy:
+    jobs:
+      - test-ruby:
+          context: default
+      - lint-ruby:
+          context: default

data/.gitignore

@@ -7,3 +7,4 @@
 /tmp/
 .*.swp
 *.gem
+vendor/bundle

data/.rubocop.yml

@@ -1,9 +1,9 @@
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.3
   Exclude:
     - "examples/*.rb"
+    - vendor/**/*
 
 #
 # Opinionated cops
@@ -12,7 +12,7 @@ AllCops:
 Layout/DotPosition:
   EnforcedStyle: trailing
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
 Metrics/AbcSize:
@@ -33,6 +33,9 @@ Style/TrailingCommaInArrayLiteral:
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: comma
 
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
 #
 # Disabled cops
 #
@@ -40,9 +43,6 @@ Style/TrailingCommaInHashLiteral:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 Style/FormatString:
   Enabled: false
 
@@ -59,3 +59,6 @@ Metrics/BlockLength:
 
 Style/Proc:
   Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+2.6.6

data/Gemfile.lock

@@ -1,72 +1,83 @@
 PATH
   remote: .
   specs:
-    checker_jobs (1.1.1)
+    checker_jobs (1.2.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (5.1.4)
-      actionpack (= 5.1.4)
-      actionview (= 5.1.4)
-      activejob (= 5.1.4)
+    actionmailer (6.1.3.1)
+      actionpack (= 6.1.3.1)
+      actionview (= 6.1.3.1)
+      activejob (= 6.1.3.1)
+      activesupport (= 6.1.3.1)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (5.1.4)
-      actionview (= 5.1.4)
-      activesupport (= 5.1.4)
-      rack (~> 2.0)
+    actionpack (6.1.3.1)
+      actionview (= 6.1.3.1)
+      activesupport (= 6.1.3.1)
+      rack (~> 2.0, >= 2.0.9)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.1.4)
-      activesupport (= 5.1.4)
+      rails-html-sanitizer (~> 1.0, >= 1.2.0)
+    actionview (6.1.3.1)
+      activesupport (= 6.1.3.1)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (5.1.4)
-      activesupport (= 5.1.4)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activejob (6.1.3.1)
+      activesupport (= 6.1.3.1)
       globalid (>= 0.3.6)
-    activesupport (5.1.4)
+    activesupport (6.1.3.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    ast (2.4.0)
-    bugsnag (5.4.1)
-    builder (3.2.3)
-    byebug (9.1.0)
-    coderay (1.1.2)
-    concurrent-ruby (1.0.5)
-    connection_pool (2.2.1)
-    crass (1.0.4)
-    daemons (1.2.6)
-    diff-lcs (1.3)
-    docile (1.1.5)
-    erubi (1.7.0)
-    eventmachine (1.2.5)
-    faraday (0.14.0)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.2)
+    bugsnag (6.20.0)
+      concurrent-ruby (~> 1.0)
+    builder (3.2.4)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.8)
+    connection_pool (2.2.5)
+    crass (1.0.6)
+    daemons (1.3.1)
+    diff-lcs (1.4.4)
+    docile (1.3.5)
+    erubi (1.10.0)
+    eventmachine (1.2.7)
+    faraday (1.4.1)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
       multipart-post (>= 1.2, < 3)
-    gitlab (4.3.0)
-      httparty
-      terminal-table
-    globalid (0.4.1)
+      ruby2_keywords (>= 0.0.4)
+    faraday-excon (1.1.0)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
+    gitlab (4.17.0)
+      httparty (~> 0.18)
+      terminal-table (~> 1.5, >= 1.5.1)
+    globalid (0.4.2)
       activesupport (>= 4.2.0)
-    haml (5.0.4)
+    haml (5.2.1)
       temple (>= 0.8.0)
       tilt
-    httparty (0.15.6)
+    httparty (0.18.1)
+      mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    i18n (0.9.3)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
-    json (2.1.0)
-    loofah (2.2.2)
+    json (2.5.1)
+    loofah (2.9.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    mail (2.7.0)
+    mail (2.7.1)
       mini_mime (>= 0.1.1)
     mailcatcher (0.2.4)
       eventmachine
@@ -78,132 +89,146 @@ GEM
       skinny (>= 0.1.2)
       sqlite3-ruby
       thin
-    method_source (0.9.0)
-    mini_mime (1.0.0)
-    mini_portile2 (2.3.0)
-    minitest (5.11.3)
+    method_source (1.0.0)
+    mime-types (3.3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2021.0225)
+    mini_mime (1.1.0)
+    mini_portile2 (2.5.1)
+    minitest (5.14.4)
     multi_xml (0.6.0)
-    multipart-post (2.0.0)
-    mustermann (1.0.2)
-    nokogiri (1.8.2)
-      mini_portile2 (~> 2.3.0)
-    octokit (4.8.0)
+    multipart-post (2.1.1)
+    mustermann (1.1.1)
+      ruby2_keywords (~> 0.0.1)
+    nokogiri (1.11.3)
+      mini_portile2 (~> 2.5.0)
+      racc (~> 1.4)
+    octokit (4.21.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
-    parallel (1.12.1)
-    parser (2.5.0.5)
-      ast (~> 2.4.0)
-    powerpack (0.1.1)
-    pronto (0.9.5)
-      gitlab (~> 4.0, >= 4.0.0)
+    parallel (1.20.1)
+    parser (3.0.1.0)
+      ast (~> 2.4.1)
+    pronto (0.11.0)
+      gitlab (~> 4.4, >= 4.4.0)
       httparty (>= 0.13.7)
       octokit (~> 4.7, >= 4.7.0)
-      rainbow (~> 2.1)
-      rugged (~> 0.24, >= 0.23.0)
-      thor (~> 0.19.0)
-    pronto-rubocop (0.9.0)
-      pronto (~> 0.9.0)
-      rubocop (~> 0.38, >= 0.35.0)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.5.1)
-      byebug (~> 9.1)
-      pry (~> 0.10)
-    public_suffix (3.0.1)
-    rack (2.0.5)
-    rack-protection (2.0.3)
+      rainbow (>= 2.2, < 4.0)
+      rexml (~> 3.2)
+      rugged (>= 0.23.0, < 1.1.0)
+      thor (>= 0.20.3, < 2.0)
+    pronto-rubocop (0.11.1)
+      pronto (~> 0.11.0)
+      rubocop (>= 0.63.1, < 2.0)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.6)
+    racc (1.5.2)
+    rack (2.2.3)
+    rack-protection (2.1.0)
       rack
-    rack-test (0.8.2)
+    rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.4)
-      loofah (~> 2.2, >= 2.2.2)
-    rainbow (2.2.2)
-      rake
-    rake (10.5.0)
-    redis (4.0.1)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
+    rainbow (3.0.0)
+    rake (13.0.3)
+    redis (4.2.5)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.53.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (1.13.0)
       parallel (~> 1.10)
-      parser (>= 2.5)
-      powerpack (~> 0.1)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    rubocop-rspec (1.22.1)
-      rubocop (>= 0.52.1)
-    ruby-progressbar (1.9.0)
-    rugged (0.26.0)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
-    sidekiq (5.0.5)
-      concurrent-ruby (~> 1.0)
-      connection_pool (~> 2.2, >= 2.2.0)
-      rack-protection (>= 1.5.0)
-      redis (>= 3.3.4, < 5)
-    simplecov (0.15.1)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
-    sinatra (2.0.3)
-      mustermann (~> 1.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-rspec (2.3.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.4)
+    rugged (1.0.1)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
+    sidekiq (6.2.1)
+      connection_pool (>= 2.2.2)
       rack (~> 2.0)
-      rack-protection (= 2.0.3)
+      redis (>= 4.2.0)
+    simplecov (0.21.2)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.2)
+    sinatra (2.1.0)
+      mustermann (~> 1.0)
+      rack (~> 2.2)
+      rack-protection (= 2.1.0)
       tilt (~> 2.0)
     skinny (0.2.2)
       eventmachine (~> 1.0)
       thin
-    sqlite3 (1.3.13)
+    sqlite3 (1.4.2)
     sqlite3-ruby (1.3.3)
       sqlite3 (>= 1.3.3)
-    temple (0.8.0)
+    temple (0.8.2)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
-    thin (1.7.2)
+    thin (1.8.0)
       daemons (~> 1.0, >= 1.0.9)
       eventmachine (~> 1.0, >= 1.0.4)
       rack (>= 1, < 3)
-    thor (0.19.4)
-    thread_safe (0.3.6)
-    tilt (2.0.8)
-    tzinfo (1.2.4)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.3.0)
+    thor (1.1.0)
+    tilt (2.0.10)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  actionmailer (~> 5.0)
+  actionmailer (>= 5.0, < 7.0)
   bugsnag
-  bundler (~> 1.13)
+  bundler
   checker_jobs!
   mailcatcher
   pronto
   pronto-rubocop
   pry-byebug
-  rake (~> 10.0)
-  rspec (~> 3.7)
+  rake (~> 13.0)
+  rspec (~> 3.10)
   rubocop
   rubocop-rspec
-  sidekiq (~> 5.0)
+  sidekiq (>= 6.0, < 7.0)
   simplecov
 
 BUNDLED WITH
-   1.16.1
+   2.1.4

data/README.md

@@ -23,7 +23,7 @@ you like and then those checks are run by your application, in background jobs.
 
 A small DSL is provided to helps you express your predicates:
 
-- `ensure_no` will check that the result of a given block is `zero?` or `empty?`
+- `ensure_no` will check that the result of a given block is `zero?`, `empty?` or `false`
 - `ensure_more` will check that the result of a given block is `>=` than a given number
 - `ensure_fewer` will check that the result of a given block is `<=` than a given number
 
@@ -84,6 +84,10 @@ require "checker_jobs"
 CheckerJobs.configure do |c|
   c.jobs_processor = :sidekiq
 
+  c.notifier :bugsnag do |options|
+    options[:formatter_class] = CheckerJobs::Notifiers::BugsnagDefaultFormatter
+  end
+
   c.notifier :email do |options|
     options[:formatter_class] = CheckerJobs::Notifiers::EmailDefaultFormatter
     options[:email_options] = {
@@ -119,7 +123,7 @@ PRs are appreciated 🙏
 
 We support different kind of notifiers, as of today we have the following:
 
-- `:bugsnag`: uses `Bugsnag` to send notifications. It takes the global configuration.
+- `:bugsnag`: uses `Bugsnag` to send notifications. It takes the global Bugsnag configuration.
 - `:email`: uses `ActionMailer` to send emails. You can pass it any `ActionMailer` options.
 - `:logger`: Uses `Logger` to output inconsitencies in the log. Takes the following params:
   - `logdev`: The log device. This is a filename (String) or IO object (typically STDOUT, STDERR, or an open file).
@@ -155,7 +159,7 @@ fired through ActionMailer to `oss@drivy.com`.
 Once you have checker jobs, you'll need to run them. There are many task
 schedulers out there and it isn't really relevant what you'll be using.
 
-You have to enqueue you job as often as you like and that's it.
+You have to enqueue your job as often as you like and that's it.
 
 ``` ruby
 UserChecker.perform_async
@@ -170,3 +174,7 @@ You'll find out that the CI is setup to run test coverage and linting.
 ## License
 
 The gem is available as open source under the terms of the [MIT License][licence].
+
+[licence]: https://github.com/drivy/checker_jobs/blob/master/LICENSE.txt
+[d-jobs]: https://drivy.engineering/jobs/
+[gh-sidekiq]: https://github.com/mperham/sidekiq

data/checker_jobs.gemspec

@@ -1,8 +1,8 @@
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "checker_jobs/version"
 
-Gem::Specification.new do |spec|
+Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.name          = "checker_jobs"
   spec.version       = CheckerJobs::VERSION
   spec.authors       = ["Drivy", "Nicolas Zermati"]
@@ -19,18 +19,19 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
+  spec.required_ruby_version = ">= 2.6.0"
 
-  spec.add_development_dependency "actionmailer", "~> 5.0"
+  spec.add_development_dependency "actionmailer", ">= 5.0", "< 7.0"
   spec.add_development_dependency "bugsnag"
-  spec.add_development_dependency "bundler", "~> 1.13"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "mailcatcher"
   spec.add_development_dependency "pronto"
   spec.add_development_dependency "pronto-rubocop"
   spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.7"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.10"
   spec.add_development_dependency "rubocop"
   spec.add_development_dependency "rubocop-rspec"
-  spec.add_development_dependency "sidekiq", "~> 5.0"
+  spec.add_development_dependency "sidekiq", ">= 6.0", "< 7.0"
   spec.add_development_dependency "simplecov"
 end

data/examples/user_checker.rb

@@ -21,6 +21,10 @@ CheckerJobs.configure do |config|
 
   config.jobs_processor = :sidekiq
 
+  config.notifier :bugsnag do |options|
+    options[:formatter_class] = CheckerJobs::Notifiers::EmailDefaultFormatter
+  end
+
   config.notifier :email do |options|
     options[:formatter_class] = CheckerJobs::Notifiers::EmailDefaultFormatter
     options[:email_options] = {

data/lib/checker_jobs/checks/ensure_no.rb

@@ -7,6 +7,8 @@ class CheckerJobs::Checks::EnsureNo < CheckerJobs::Checks::Base
       notify(count: result) unless result.zero?
     when Enumerable
       notify(count: result.size, entries: result) unless result.empty?
+    when TrueClass, FalseClass
+      notify(count: 1) if result
     else
       raise ArgumentError, "Unsupported result: '#{result.class.name}' for 'ensure_no'"
     end

data/lib/checker_jobs/configuration.rb

@@ -25,8 +25,8 @@ class CheckerJobs::Configuration
   end
 
   def notifier(notifier_symbol)
-    options = {}
-    yield(options)
+    options = default_options_for(notifier_symbol)
+    yield options
     @notifiers_options[notifier_symbol] = options
   end
 
@@ -45,4 +45,11 @@ class CheckerJobs::Configuration
     end
     Object.const_get(notifier_class_name)
   end
+
+  private
+
+  def default_options_for(notifier_symbol)
+    klass = notifier_class(notifier_symbol)
+    klass.respond_to?(:default_options) ? klass.default_options : {}
+  end
 end

data/lib/checker_jobs/dsl.rb

@@ -43,11 +43,13 @@ module CheckerJobs::DSL
 
   def notifier
     raise CheckerJobs::MissingNotifier, self.class unless defined?(@notifier)
+
     @notifier
   end
 
   def notifier_options
     raise CheckerJobs::MissingNotifier, self.class unless defined?(@notifier)
+
     @notifier_options
   end
 
@@ -60,7 +62,7 @@ module CheckerJobs::DSL
   end
 
   def checks
-    @check ||= {}
+    @checks ||= {}
   end
 
   def add_check(klass, name, options, block)

data/lib/checker_jobs/notifiers/base.rb

@@ -0,0 +1,22 @@
+class CheckerJobs::Notifiers::Base
+  def initialize(check, _count, _entries)
+    @check = check
+  end
+
+  def notify
+    raise NotImplementedError
+  end
+
+  def self.default_options
+    raise NotImplementedError
+  end
+
+  private
+
+  def notifier_options
+    CheckerJobs.configuration.notifiers_options.fetch(
+      @check.klass.notifier,
+      self.class.default_options,
+    )
+  end
+end

data/lib/checker_jobs/notifiers/bugsnag.rb

@@ -1,29 +1,30 @@
-require "action_mailer"
-
-class CheckerJobs::Notifiers::Bugsnag
-  include CheckerJobs::Notifiers::FormatterHelpers
-
+class CheckerJobs::Notifiers::Bugsnag < CheckerJobs::Notifiers::Base
   class Error < StandardError; end
 
   def initialize(check, count, entries)
-    @check = check
-    @metadata = {
-      klass: @check.klass,
-      name: @check.name,
-      count: count,
-      entries: entries&.map { |entry| format_entry(entry) },
-      source_code_url: repository_url,
-    }
+    super
+
+    @formatter = formatter_class.new(check, count, entries)
   end
 
   def notify
-    raise Error, "(#{@check.klass}) #{human_check_name} was triggered!"
-  rescue Error => error
-    ::Bugsnag.notify(error, {
-      severity: "warning",
-      context: "checker_jobs",
-      grouping_hash: error.message,
-      triggered_check: @metadata,
-    })
+    raise @formatter.base_error
+  rescue Error => e
+    ::Bugsnag.notify(e) do |notification|
+      notification.severity = @formatter.severity
+      notification.context = @formatter.context
+      notification.grouping_hash = @formatter.grouping_hash
+      notification.add_tab(*@formatter.tab_infos)
+    end
+  end
+
+  def self.default_options
+    { formatter_class: CheckerJobs::Notifiers::BugsnagDefaultFormatter }
+  end
+
+  private
+
+  def formatter_class
+    notifier_options.fetch(:formatter_class)
   end
 end

data/lib/checker_jobs/notifiers/bugsnag_default_formatter.rb

@@ -0,0 +1,45 @@
+class CheckerJobs::Notifiers::BugsnagDefaultFormatter
+  include CheckerJobs::Notifiers::FormatterHelpers
+
+  def initialize(check, count, entries)
+    @check = check
+    @count = count
+    @entries = entries
+  end
+
+  def base_error
+    CheckerJobs::Notifiers::Bugsnag::Error.new(error_message)
+  end
+
+  def severity
+    "warning"
+  end
+
+  def context
+    "checker_jobs"
+  end
+
+  def grouping_hash
+    error_message
+  end
+
+  def tab_infos
+    ["triggered_check", triggered_check]
+  end
+
+  private
+
+  def triggered_check
+    {
+      klass: @check.klass,
+      name: @check.name,
+      count: @count,
+      entries: @entries&.map { |entry| format_entry(entry) },
+      source_code_url: repository_url,
+    }
+  end
+
+  def error_message
+    "(#{@check.klass}) #{human_check_name} was triggered!"
+  end
+end

data/lib/checker_jobs/notifiers/email.rb

@@ -1,8 +1,9 @@
 require "action_mailer"
 
-class CheckerJobs::Notifiers::Email
+class CheckerJobs::Notifiers::Email < CheckerJobs::Notifiers::Base
   def initialize(check, count, entries)
-    @check = check
+    super
+
     @formatter = formatter_class.new(check, count, entries)
     @defaults = { subject: @formatter.subject }
 
@@ -10,27 +11,34 @@ class CheckerJobs::Notifiers::Email
   end
 
   def notify
-    Mailer.notify(@formatter.body, options).deliver!
+    Mailer.notify(@formatter.body, mailer_options).deliver!
+  end
+
+  def self.default_options
+    {
+      formatter_class: CheckerJobs::Notifiers::EmailDefaultFormatter,
+      email_options: {},
+    }
   end
 
   private
 
   def valid?
-    options[:to].is_a?(String)
+    mailer_options[:to].is_a?(String)
   end
 
-  def options
-    @options ||=  @defaults.
-                  merge(notifier_options[:email_options]).
-                  merge(@check.klass.notifier_options)
+  def mailer_options
+    @mailer_options ||= @defaults.
+                        merge(email_options).
+                        merge(@check.klass.notifier_options)
   end
 
-  def formatter_class
-    notifier_options[:formatter_class] || CheckerJobs::Notifiers::EmailDefaultFormatter
+  def email_options
+    notifier_options[:email_options]
   end
 
-  def notifier_options
-    CheckerJobs.configuration.notifiers_options[@check.klass.notifier]
+  def formatter_class
+    notifier_options[:formatter_class]
   end
 
   # Simple mailer class based on ActionMailer to send HTML emails while reusing

data/lib/checker_jobs/notifiers/email_default_formatter.rb

@@ -24,7 +24,7 @@ class CheckerJobs::Notifiers::EmailDefaultFormatter
 
   private
 
-  def format_entry(entry)
+  def format_entry(entry) # rubocop:disable Lint/UselessMethodDefinition
     # NOTE: inherit and override to support your custom objects
     super
   end

data/lib/checker_jobs/notifiers/formatter_helpers.rb

@@ -25,7 +25,7 @@ module CheckerJobs::Notifiers::FormatterHelpers
 
   def github_url
     filepath, line_number = @check.block.source_location
-    filepath = filepath.sub(Dir.pwd + "/", "")
+    filepath = filepath.sub("#{Dir.pwd}/", "")
     GITHUB_URL_FORMAT % {
       repository: repository_configuration[:github],
       path: filepath,

data/lib/checker_jobs/notifiers/logger.rb

@@ -1,13 +1,11 @@
 require "logger"
 
-class CheckerJobs::Notifiers::Logger
+class CheckerJobs::Notifiers::Logger < CheckerJobs::Notifiers::Base
   include CheckerJobs::Notifiers::FormatterHelpers
 
-  DEFAULT_LEVEL = Logger::INFO
-  DEFAULT_LOGDEV = STDOUT
-
   def initialize(check, count, _entries)
-    @check = check
+    super
+
     @count = count
     raise CheckerJobs::InvalidNotifierOptions unless valid?
 
@@ -19,13 +17,20 @@ class CheckerJobs::Notifiers::Logger
     @logger.add(level, format, human_check_name)
   end
 
+  def self.default_options
+    {
+      logdev: $stdout,
+      level: Logger::INFO,
+    }
+  end
+
+  private
+
   # override this
   def format
     "found #{@count} entries"
   end
 
-  private
-
   def valid?
     (logdev.is_a?(String) || logdev.is_a?(IO)) &&
       [
@@ -35,18 +40,10 @@ class CheckerJobs::Notifiers::Logger
   end
 
   def level
-    @level ||=  @check.klass.notifier_options[:level] ||
-                notifier_options[:level] ||
-                DEFAULT_LEVEL
+    @level ||= @check.klass.notifier_options[:level] || notifier_options[:level]
   end
 
   def logdev
-    @logdev ||= @check.klass.notifier_options[:logdev] ||
-                notifier_options[:logdev] ||
-                DEFAULT_LOGDEV
-  end
-
-  def notifier_options
-    CheckerJobs.configuration.notifiers_options[@check.klass.notifier]
+    @logdev ||= @check.klass.notifier_options[:logdev] || notifier_options[:logdev]
   end
 end

data/lib/checker_jobs/notifiers.rb

@@ -1,7 +1,9 @@
 module CheckerJobs::Notifiers
-  autoload :Bugsnag,                "checker_jobs/notifiers/bugsnag"
-  autoload :Email,                  "checker_jobs/notifiers/email"
-  autoload :EmailDefaultFormatter,  "checker_jobs/notifiers/email_default_formatter"
-  autoload :FormatterHelpers,       "checker_jobs/notifiers/formatter_helpers"
-  autoload :Logger,                 "checker_jobs/notifiers/logger"
+  autoload :Base,                    "checker_jobs/notifiers/base"
+  autoload :Bugsnag,                 "checker_jobs/notifiers/bugsnag"
+  autoload :BugsnagDefaultFormatter, "checker_jobs/notifiers/bugsnag_default_formatter"
+  autoload :Email,                   "checker_jobs/notifiers/email"
+  autoload :EmailDefaultFormatter,   "checker_jobs/notifiers/email_default_formatter"
+  autoload :FormatterHelpers,        "checker_jobs/notifiers/formatter_helpers"
+  autoload :Logger,                  "checker_jobs/notifiers/logger"
 end

data/lib/checker_jobs/version.rb

@@ -1,3 +1,3 @@
 module CheckerJobs
-  VERSION = "1.1.1".freeze
+  VERSION = "1.2.1".freeze
 end

metadata

@@ -1,30 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: checker_jobs
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.1
 platform: ruby
 authors:
 - Drivy
 - Nicolas Zermati
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-08-03 00:00:00.000000000 Z
+date: 2024-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: bugsnag
   requirement: !ruby/object:Gem::Requirement
@@ -43,16 +49,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mailcatcher
   requirement: !ruby/object:Gem::Requirement
@@ -115,28 +121,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -169,16 +175,22 @@ dependencies:
   name: sidekiq
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -204,6 +216,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -227,7 +240,9 @@ files:
 - lib/checker_jobs/jobs_processors.rb
 - lib/checker_jobs/jobs_processors/sidekiq.rb
 - lib/checker_jobs/notifiers.rb
+- lib/checker_jobs/notifiers/base.rb
 - lib/checker_jobs/notifiers/bugsnag.rb
+- lib/checker_jobs/notifiers/bugsnag_default_formatter.rb
 - lib/checker_jobs/notifiers/email.rb
 - lib/checker_jobs/notifiers/email_default_formatter.rb
 - lib/checker_jobs/notifiers/formatter_helpers.rb
@@ -237,7 +252,7 @@ homepage: https://github.com/drivy/checker_jobs
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -245,16 +260,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.2.33
+signing_key:
 specification_version: 4
 summary: Regression tests for data
 test_files: []