checker 0.0.1 → 0.7.0

data/lib/checker/rvm.rb

@@ -0,0 +1,16 @@
+module Checker
+  class RVM
+    class << self
+      def rvm_command(command)
+        rvm_gem  = ENV['GEM_HOME'].to_s
+        rvm_version = rvm_gem.gsub(/.+rvm\/gems\//, "")
+
+        "#{rvm_shell} '#{rvm_version}' -c '#{command}'"
+      end
+
+      def rvm_shell
+        File.join(ENV['rvm_path'].to_s, 'bin/rvm-shell')
+      end
+    end
+  end
+end

data/lib/checker/version.rb

@@ -0,0 +1,3 @@
+module Checker
+  VERSION = '0.7.0'
+end

data/spec/checker/cli_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+module Checker
+  module Modules
+    class Bogus < Base
+      extensions '.test'
+      private
+      def check_one(file)
+        true
+      end
+
+      def check_for_executable
+        true
+      end
+    end
+  end
+end
+
+describe Checker::CLI do
+  context "running without arguments" do
+    it "should run checks on modules from git config" do
+      ARGV.stub(:size).and_return 0
+      Checker::CLI.should_receive(:get_modules_to_check).and_return(["bogus"])
+      Checker::CLI.should_receive(:exit).with(0).and_return true
+      Checker::CLI.execute
+    end
+  end
+
+  context "running with argument" do
+    it "should run check on modules from argument" do
+      stub_const("ARGV", ["pry"])
+      Checker::CLI.should_not_receive(:get_modules_to_check)
+      Checker::CLI.should_receive(:exit).with(0).and_return true
+      Checker::CLI.execute
+    end
+  end
+end

data/spec/checker/fixtures/conflict/with_conflict.rb

@@ -0,0 +1,5 @@
+def test
+<<<<<<< Updated upstream
+=======
+end
+>>>>>>> Stashed changes

data/spec/checker/fixtures/conflict/without_conflict.rb

@@ -0,0 +1,2 @@
+def test
+end

data/spec/checker/fixtures/console_log/with_console_log.js

@@ -0,0 +1,3 @@
+(function() {
+  console.log("test");
+});

data/spec/checker/fixtures/console_log/without_console_log.js

@@ -0,0 +1,2 @@
+(function() {
+});

data/spec/checker/fixtures/pry/with_both.rb

@@ -0,0 +1,4 @@
+binding.pry
+def test
+end
+binding.remote_pry

data/spec/checker/fixtures/pry/with_pry.rb

@@ -0,0 +1,3 @@
+def test
+  binding.pry
+end

data/spec/checker/fixtures/pry/with_pry_remote.rb

@@ -0,0 +1,3 @@
+def test
+  binding.remote_pry
+end

data/spec/checker/fixtures/pry/without_pry.rb

@@ -0,0 +1,2 @@
+def test
+end

data/spec/checker/fixtures/ruby/bad.rb

@@ -0,0 +1,2 @@
+def test
+  {:some => 'random', :hash => 'qwe'}

data/spec/checker/fixtures/ruby/good.rb

@@ -0,0 +1,3 @@
+def test
+  {some: 'random', hash: 'qwe'}
+end

data/spec/checker/fixtures/yaml/bad.yaml

@@ -0,0 +1,18 @@
+defaults: &defaults
+  mobile_ipad: "iPad"
+  mobile_agents:
+    - "AppleWebKit.+Mobile"
+    - "webOS"
+   - "SymbianOS"
+    - "AppleWebKit.+midori"
+  new_search_config:
+    options:
+      suffix: "/search"
+    params:
+      a: "a"
+      b: "b"
+
+test:
+  <<: *defaults
+  discount: 0.12
+  host: test.test

data/spec/checker/fixtures/yaml/good.yaml

@@ -0,0 +1,18 @@
+defaults: &defaults
+  mobile_ipad: "iPad"
+  mobile_agents:
+    - "AppleWebKit.+Mobile"
+    - "webOS"
+    - "SymbianOS"
+    - "AppleWebKit.+midori"
+  new_search_config:
+    options:
+      suffix: "/search"
+    params:
+      a: "a"
+      b: "b"
+
+test:
+  <<: *defaults
+  discount: 0.12
+  host: test.test

data/spec/checker/modules/base_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Checker::Modules::Base do
+  describe "rvm_command method" do
+    context "properly fetches the ruby version from the environment variables" do
+      before do
+        ENV.stub!(:[]).with("rvm_path").and_return "/Users/test/.rvm"
+      end
+
+      it "uses no gemsets" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
+      end
+
+      it "uses global gemset" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
+      end
+
+      it "uses some other gemset" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/Users/test/.rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
+      end
+    end
+
+    context "using different rvm_path (system-wide rvm)" do
+      before do
+        ENV.stub!(:[]).with("rvm_path").and_return "/usr/lib/rvm"
+      end
+
+      it "uses no gemsets" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version' -c 'test'"
+      end
+
+      it "uses global gemset" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@global"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@global' -c 'test'"
+      end
+
+      it "uses some other gemset" do
+        ENV.stub!(:[]).with("GEM_HOME").and_return "/Users/test/.rvm/gems/some_ruby_version@v2"
+
+        Checker::Modules::Base.new.send(:rvm_command, "test").should == "/usr/lib/rvm/bin/rvm-shell 'some_ruby_version@v2' -c 'test'"
+      end
+    end
+  end
+end

data/spec/checker/modules/coffeescript_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Checker::Modules::Coffeescript do
+  it 'should only check .coffee files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee']
+    mod = Checker::Modules::Coffeescript.new(files)
+    mod.stub(:check_for_executable).and_return(true)
+    mod.should_receive(:check_one_file).with('f.coffee').and_return(stub(:success? => true, :status => :ok))
+    mod.should_not_receive(:check_one_file).with('e.yaml')
+    mod.should_not_receive(:check_one_file).with('d.yml')
+    mod.should_not_receive(:check_one_file).with('a.rb')
+    mod.should_not_receive(:check_one_file).with('b.js.erb')
+    mod.should_not_receive(:check_one_file).with('c.r')
+    mod.check 
+  end
+end

data/spec/checker/modules/conflict_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Checker::Modules::Conflict do
+  it 'checks all files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee']
+    mod = Checker::Modules::Conflict.new(files)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one).exactly(6).times
+    mod.check 
+  end
+
+  it "does find git conflict" do
+    files = [fixture("conflict", "with_conflict.rb")]
+    mod = Checker::Modules::Conflict.new(files)
+    mod.check.should be_false
+  end
+
+  it "does not find git conflict" do
+    files = [fixture("conflict", "without_conflict.rb")]
+    mod = Checker::Modules::Conflict.new(files)
+    mod.check.should be_true
+  end
+end

data/spec/checker/modules/console_log_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe Checker::Modules::ConsoleLog do
+  it 'checks coffee and js files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee', 'g.js']
+    mod = Checker::Modules::ConsoleLog.new(files)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one).exactly(2).times
+    mod.check 
+  end
+
+  describe "does find console.log" do
+    before do
+      files = [fixture("console_log", "with_console_log.js")]
+      @mod = Checker::Modules::ConsoleLog.new(files)
+    end
+
+    it "results to be true if prevent_commit_on_warning is set to false" do
+      Checker::Options.stub(:prevent_commit_on_warning).and_return(false)
+      @mod.check.should be_true
+    end
+
+    it "results to be false if prevent_commit_on_warning is set to true" do
+      Checker::Options.stub(:prevent_commit_on_warning).and_return(true)
+      @mod.check.should be_false
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_warning_message)
+      @mod.check
+    end
+  end
+
+  describe "does not find console.log" do
+    before do
+      files = [fixture("console_log", "without_console_log.js")]
+      @mod = Checker::Modules::ConsoleLog.new(files)
+    end
+
+    it "results to be true" do
+      @mod.check.should be_true
+    end
+
+    it "prints proper message" do
+      @mod.should_receive(:print_success_message)
+      @mod.check
+    end
+  end
+end

data/spec/checker/modules/haml_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Checker::Modules::Haml do
+  it 'should only check .haml files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml']
+    mod = Checker::Modules::Haml.new(files)
+    mod.stub(:check_for_executable).and_return(true)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one_file).with('g.haml')
+    mod.should_not_receive(:check_one_file).with('f.coffee')
+    mod.should_not_receive(:check_one_file).with('e.yaml')
+    mod.should_not_receive(:check_one_file).with('d.yml')
+    mod.should_not_receive(:check_one_file).with('a.rb')
+    mod.should_not_receive(:check_one_file).with('b.js.erb')
+    mod.should_not_receive(:check_one_file).with('c.r')
+    mod.check 
+  end
+end

data/spec/checker/modules/javascript_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe Checker::Modules::Javascript do
+  it 'should only check .js files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yml', 'e.yaml', 'f.coffee', 'g.haml', 'h.js']
+    mod = Checker::Modules::Javascript.new(files)
+    mod.stub(:check_for_executable).and_return(true)
+    mod.should_receive(:check_one_file).with('h.js').and_return(stub(:success? => true, :status => :ok))
+    mod.should_not_receive(:check_one_file).with('g.haml')
+    mod.should_not_receive(:check_one_file).with('f.coffee')
+    mod.should_not_receive(:check_one_file).with('e.yaml')
+    mod.should_not_receive(:check_one_file).with('d.yml')
+    mod.should_not_receive(:check_one_file).with('a.rb')
+    mod.should_not_receive(:check_one_file).with('b.js.erb')
+    mod.should_not_receive(:check_one_file).with('c.r')
+    mod.check 
+  end
+
+  describe "good js file" do
+    before do
+      files = ['good.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('good.js').and_return(stub(:success? => true, :status => :ok))
+    end
+
+    xit "results to be true" do
+      @mod.check.should be_true
+    end
+
+    xit "prints proper message" do
+      @mod.should_receive(:print_success_message)
+      @mod.check
+    end
+  end
+
+  describe "js with warnings" do
+    before do
+      files = ['warning.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('warning.js').and_return(stub(:success? => true, :status => :warning))
+    end
+
+    xit "results to be true" do
+      @mod.check.should be_true
+    end
+
+    xit "prints proper message" do
+      @mod.should_receive(:print_warning_message)
+      @mod.check
+    end
+  end
+
+  describe "bad js with errors" do
+    before do
+      files = ['bad.js']
+      @mod = Checker::Modules::Javascript.new(files)
+      @mod.should_receive(:check_one_file).with('bad.js').and_return(stub(:success? => false, :status => :fail))
+    end
+
+    xit "results to be true" do
+      @mod.check.should be_false
+    end
+
+    xit "prints proper message" do
+      @mod.should_receive(:print_fail_message)
+      @mod.check
+    end
+  end
+end

data/spec/checker/modules/pry_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe Checker::Modules::Pry do
+  it 'should check all files' do
+    files = ['a.rb', 'b.js.erb', 'c.r', 'd.yaml', 'e.yml', 'f.coffee']
+    mod = Checker::Modules::Pry.new(files)
+    mod.stub(:check_one).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one).exactly(6).times
+    mod.check 
+  end
+
+  it "should not find the pry or remote_pry" do
+    files = [fixture("pry", "without_pry.rb")]
+    mod = Checker::Modules::Pry.new(files)
+    mod.check.should be_true
+  end
+
+  it "should find the pry or remote_pry" do
+    files = [fixture("pry", "with_pry.rb")]
+    mod = Checker::Modules::Pry.new(files)
+    mod.check.should be_false
+  end
+
+  it "should find the pry or remote_pry" do
+    files = [fixture("pry", "with_pry_remote.rb")]
+    mod = Checker::Modules::Pry.new(files)
+    mod.check.should be_false
+  end
+
+  it "should find the pry or remote_pry" do
+    files = [fixture("pry", "with_both.rb")]
+    mod = Checker::Modules::Pry.new(files)
+    mod.check.should be_false
+  end
+end

data/spec/checker/modules/ruby_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe Checker::Modules::Ruby do
+  it 'should only check .rb files' do
+    files = ['a.rb', 'b.js.erb', 'c.r']
+    mod = Checker::Modules::Ruby.new(files)
+    mod.stub(:check_one_file).and_return(stub(:success? => true, :status => :ok))
+    mod.should_receive(:check_one_file).with('a.rb')
+    mod.should_not_receive(:check_one_file).with('b.js.erb')
+    mod.should_not_receive(:check_one_file).with('c.r')
+    mod.check
+  end
+
+
+  it "should pass the syntax check" do
+    files = [fixture("ruby", "good.rb")]
+    mod = Checker::Modules::Ruby.new(files)
+    mod.check.should be_true
+  end
+
+  it "should not pass the syntax check" do
+    files = [fixture("ruby", "bad.rb")]
+    mod = Checker::Modules::Ruby.new(files)
+    mod.check.should be_false
+  end
+end