checkability 2.0.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa1ae6fc8c72cd3073a9301eb633a23bed7a3912a3e338e54c83aba5fc8f4b08
-  data.tar.gz: 8d1935bd53420a47316e76ce952b18c0b8ca4d96e8ee0193fcce5aea16a159e4
+  metadata.gz: 025ba09f183579762584e89daf10b06fe93c8d2da5ce899120ae2c9b8bf15726
+  data.tar.gz: 3b5f2c538aa618dfc077c35c2d176bf78a36336a97395caeab236f1101795aa1
 SHA512:
-  metadata.gz: 971c297f7e4d8da9eb73a02bdad49329c0e84024553d3f864e0a91e02aee71fc5f71e0ab3d4ef9b66b6696047237c3c36f7c22d72004bc70fc6dfceb4d4ec125
-  data.tar.gz: 1a22cb5f5f8b25612116f5b302e82b5d914a05aaedfc624c6c635db56fd23d3998b29dc8582f633d78f64f7ef8120d5a87d66052b0c5adba0ec41558174166a6
+  metadata.gz: 464e94ce7a7c4538f27c1e740b92f61392f0a08683debb21d39e7189782fc214ad4dc8e9add85278352c36d40249799cef53f00005361cf20439d9d6f534e12b
+  data.tar.gz: 16c0f544f7b2164fb31c9be12bfcedcae5a28a54b31028ed048ae4bafe1e49d22dea0ba606ce750eeebdac64cb8fd0a25b9ff5dc4fdab559d982260287a2105e

data/README.md

@@ -76,4 +76,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Future works
 
-- [ ] Use ChainOfResponsibility pattern to simplify call of checkers
+- [X] Use ChainOfResponsibility pattern to simplify call of checkers
+- [ ] Improve test with adding doubles

data/lib/checkability/acts_as_checkable.rb

@@ -23,7 +23,7 @@ module Checkability
       end
     end
 
-    attr_accessor :ch_allowed, :ch_messages
+    attr_accessor :ch_allowed, :ch_messages, :ch_conf
 
     def initialize(params)
       @ch_messages = []
@@ -32,7 +32,8 @@ module Checkability
     end
 
     def perform_check
-      Checkability::Checkable.new(self).check(ch_conf)
+      @ch_conf = ch_conf
+      Checkability::Checkable.new(self).check
       ch_messages << "#{ch_allowed}:::'#{_value}' is #{_allowness}. "
     end
 

data/lib/checkability/base_checker.rb

@@ -10,10 +10,10 @@ module Checkability
                 :success_message, :failure_message
 
     def initialize(opts = {})
-      @stop_process_on_failure = opts[:stop_process_on_failure] || false
-      @stop_process_on_success = opts[:stop_process_on_success] || false
-      @success_message = opts[:success_message] || 'Success.'
-      @failure_message = opts[:failure_message] || 'Failed.'
+      @stop_process_on_failure = opts.fetch(:stop_process_on_failure) { false }
+      @stop_process_on_success = opts.fetch(:stop_process_on_success) { false }
+      @success_message = opts.fetch(:success_message) { 'Success.' }
+      @failure_message = opts.fetch(:failure_message) { 'Failed.' }
 
       @next_handler = nil
       post_initialize(opts) # implemented in subclass

data/lib/checkability/checkable.rb

@@ -7,10 +7,10 @@ module Checkability
   # Possible to implemet as Iterator in future
   #
   class Checkable
-    attr_accessor :check_obj
+    attr_accessor :check_obj, :handler_confs
 
     extend Forwardable
-    def_delegators :@check_obj, :ch_messages, :ch_allowed
+    def_delegators :@check_obj, :ch_messages, :ch_allowed, :ch_conf
 
     def initialize(check_obj)
       @check_obj = check_obj
@@ -26,11 +26,8 @@ module Checkability
     #
     # ChainOfResponsibilty
     #
-    def check(handler_confs)
-      first_handler_name = handler_confs.keys.first
-      first_handler = _handlers(handler_confs)[first_handler_name]
-
-      first_handler.handle(check_obj)
+    def check
+      _first_handler.handle(check_obj)
     rescue StandardError => e
       check_obj.ch_messages << "false:::#{e}: #{handler_confs}."
       false
@@ -38,17 +35,21 @@ module Checkability
 
     private
 
-    def _handlers(handler_confs)
-      handlers = _make_handlers(handler_confs)
+    def _first_handler
+      _handlers[ch_conf.keys.first]
+    end
+
+    def _handlers
+      handlers = _make_handlers
       handlers.each_value.with_index do |handler, i|
-        next_handler_name = handlers.keys[i + 1]
-        handler.next_handler(handlers[next_handler_name]) if handlers[next_handler_name]
+        next_handler = handlers[handlers.keys[i + 1]]
+        handler.next_handler(next_handler) if next_handler
       end
       handlers
     end
 
-    def _make_handlers(confs)
-      confs.transform_values { |conf| _make_handler(conf) }
+    def _make_handlers
+      ch_conf.transform_values { |conf| _make_handler(conf) }
     end
 
     def _make_handler(conf)

data/lib/checkability/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkability
-  VERSION = '2.0.1'
+  VERSION = '2.1.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkability
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Andrey Eremeev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-06 00:00:00.000000000 Z
+date: 2021-04-23 00:00:00.000000000 Z
 dependencies: []
 description: Provide Checkers functionality.
 email: