checkability 1.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f427c18e28549b00de27a9b29d5c3278be27a07f76b5efeb3c88bd07c9fa8004
-  data.tar.gz: 68c2e5ca988d593452a15b07c2b0a9f6155cf4a170434c40509c2e8f570a1cff
+  metadata.gz: ae01f58d2012ce52ed74568c007178ad6e43b40046c41d6f088b42bcbac0d766
+  data.tar.gz: 769768802d26c6a47f90517fb5875f3b18f6b347ffd86455d7d0b79ab0d6c930
 SHA512:
-  metadata.gz: 6f86d27e1c09d25597de9a6f82701aba4ebfe77c29c469857c1cb2b07d492e87485a9f234c957083220df84f03d66d991b1e700a7aa4121782e567a8be9a3cb2
-  data.tar.gz: d52836824181062c8e294b56e27d3b6d486b5860d6f13be64d2fe6cefd6c9e98f22d3980a1d35d5ebde74374f3df3c89a4be8bf1b2feb7be4f69ff750c23713c
+  metadata.gz: 393836e6c626564325df8a5c13583804c071b720ad100003f876d4cdddda55aecd6e815b03d2389a204c4746d0ed9d9700a76d7a1d5a9ee8db79cfd86323d38b
+  data.tar.gz: 0a45353c00ca35c7ee4acf69097f937667f1dcb850ff1285d2e92e31a6bc4995edad468c10bb970bad2db6bc4c5ace876cf85181b85bf6d85cd182995b55e320

data/README.md

@@ -76,4 +76,5 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Future works
 
-- [ ] Use ChainOfResponsibility pattern to simplify call of checkers
+- [X] Use ChainOfResponsibility pattern to simplify call of checkers
+- [ ] Improve test with adding doubles

data/lib/checkability/acts_as_checkable.rb

@@ -23,7 +23,7 @@ module Checkability
       end
     end
 
-    attr_accessor :ch_allowed, :ch_messages
+    attr_accessor :ch_allowed, :ch_messages, :ch_conf
 
     def initialize(params)
       @ch_messages = []
@@ -32,8 +32,9 @@ module Checkability
     end
 
     def perform_check
-      Checkability::Checkable.new(self).check(ch_conf)
-      ch_messages << "#{ch_allowed}::'#{_value}' is #{_allowness}. "
+      @ch_conf = ch_conf
+      Checkability::Checkable.new(self).check
+      ch_messages << "#{ch_allowed}:::'#{_value}' is #{_allowness}. "
     end
 
     private

data/lib/checkability/base_checker.rb

@@ -53,8 +53,8 @@ module Checkability
 
       str = res ? success_message : failure_message
       [res, message(res, str)]
-      #    rescue StandardError => e
-      #      [false, message(false, e)]
+    rescue StandardError => e
+      [false, message(false, e)]
     end
 
     # subclass should implement
@@ -64,7 +64,7 @@ module Checkability
 
     # subclass may override
     def message(res, str)
-      "#{res}::#{str}"
+      "#{res}:::#{str}"
     end
 
     private

data/lib/checkability/checkable.rb

@@ -7,10 +7,10 @@ module Checkability
   # Possible to implemet as Iterator in future
   #
   class Checkable
-    attr_accessor :check_obj
+    attr_accessor :check_obj, :handler_confs
 
     extend Forwardable
-    def_delegators :@check_obj, :ch_messages, :ch_allowed
+    def_delegators :@check_obj, :ch_messages, :ch_allowed, :ch_conf
 
     def initialize(check_obj)
       @check_obj = check_obj
@@ -24,29 +24,32 @@ module Checkability
     #
     # validator.handle(request)
     #
-    def check(handler_confs)
-      first_handler_name = handler_confs.keys.first
-      first_handler = _handlers(handler_confs)[first_handler_name]
-
-      first_handler.handle(check_obj)
-    rescue StandardError => e
-      check_obj.ch_messages << "false::#{e}: #{handler_confs}."
-      false
+    # ChainOfResponsibilty
+    #
+    def check
+      _first_handler.handle(check_obj)
+      #    rescue StandardError => e
+      #      check_obj.ch_messages << "false:::#{e}: #{handler_confs}."
+      #      false
     end
 
     private
 
-    def _handlers(handler_confs)
-      handlers = _make_handlers(handler_confs)
+    def _first_handler
+      _handlers[ch_conf.keys.first]
+    end
 
-      handlers.each do |handler_name, handler|
-        next_handler_name = handler_confs[handler_name][:next_handler]
-        handler.next_handler(handlers[next_handler_name]) if handlers[next_handler_name]
+    def _handlers
+      handlers = _make_handlers
+      handlers.each_value.with_index do |handler, i|
+        next_handler = handlers[handlers.keys[i + 1]]
+        handler.next_handler(next_handler) if next_handler
       end
+      handlers
     end
 
-    def _make_handlers(confs)
-      confs.transform_values { |conf| _make_handler(conf) }
+    def _make_handlers
+      ch_conf.transform_values { |conf| _make_handler(conf) }
     end
 
     def _make_handler(conf)

data/lib/checkability/external_api_checker.rb

@@ -35,7 +35,7 @@ module Checkability
     end
 
     def message(res, str = nil)
-      "#{res}::#{path}: #{str}"
+      "#{res}:::#{path}: #{str}"
     end
 
     private

data/lib/checkability/storage_checker.rb

@@ -18,7 +18,7 @@ module Checkability
     end
 
     def message(res, str = nil)
-      "#{res}::Allowed #{storage_class}s list: #{str}"
+      "#{res}:::Allowed #{storage_class}s list: #{str}"
     end
 
     private

data/lib/checkability/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkability
-  VERSION = '1.0.0'
+  VERSION = '2.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkability
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Andrey Eremeev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-05 00:00:00.000000000 Z
+date: 2021-04-07 00:00:00.000000000 Z
 dependencies: []
 description: Provide Checkers functionality.
 email: