checkability 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae53afa68f33c527bee835d3c84e304c7596f46665cc41ff1df67b2e4189f595
-  data.tar.gz: 8de80e50a31b5e3c7b2f498b8c81de8793b4d80f9a4665653dd12be745331721
+  metadata.gz: 0f584d475c0bf9395f3cbdb0d47a436b7f1a56ab93fb4d76095b58de9a0a4485
+  data.tar.gz: d9ff4ef5b3a877fd0a8efe830958df8e14d3ae0e221903fbb436623457c14e74
 SHA512:
-  metadata.gz: 32ed1b0305e36d037d38bde6acf78f4c7d4ae04e49764d4129fb5d9f455cf349607131ea17b5a500a0f47ab38f31698d06eeaec07dc9a014b030518be42e66fa
-  data.tar.gz: cec99b497500443955ef650e56948037e8e7855456f14aa66a491e71ecd884c9d1553c64bbb10fd7a1ce23ae535fa1d42bb730a0979bfead71db07a625bc2407
+  metadata.gz: e7f9740350a632cea6131709f9e765f0c8e47981b564a8fb426103fe1c55688f7d27ce7190b11278e540807bd0e2dfeabe65d5d47d4e494b4865074db384447d
+  data.tar.gz: 4baa39ca9c3aaec3845e2d84a72f38caf74f662bab1b3f6ff453439763393db4865c7a3912b8c09f606d37a2b15860f779750f9d8cc0e8b19f102362310355d5

data/lib/checkability.rb

@@ -9,5 +9,7 @@ require_relative 'checkability/external_api_checker'
 require_relative 'checkability/external_api_connector'
 require_relative 'checkability/validator'
 require_relative 'checkability/acts_as_checkable'
+require_relative 'checkability/chain_of_resp/handler'
+require_relative 'checkability/chain_of_resp/abstract_handler'
 
 ActiveRecord::Base.include Checkability::ActsAsCheckable

data/lib/checkability/acts_as_checkable.rb

@@ -24,12 +24,20 @@ module Checkability
 
     def perform_check
       _setup
-      self.allowed = _check
-      messages << "#{allowed}::'#{value}' is #{_allowness}. "
+      self.allowed = Checkability::Checkable.new(self).check(checkable_conf)
+      messages << "#{allowed}::'#{_value}' is #{_allowness}. "
     end
 
     private
 
+    def _value
+      send(_attr_name)
+    end
+
+    def _attr_name
+      checkable_conf[:attr_name] || :value
+    end
+
     def _setup
       self.allowed = nil
       self.messages = []
@@ -38,9 +46,5 @@ module Checkability
     def _allowness
       allowed ? 'ALLOWED' : 'NOT allowed'
     end
-
-    def _check
-      Checkability::Checkable.new(self).check(checkable_conf)
-    end
   end
 end

data/lib/checkability/chain_of_resp/abstract_handler.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require_relative 'handler'
+
+module ChainOfResp
+  # @abstract
+  class AbstractHandler < ChainOfResp::Handler
+    # @return [Handler]
+    attr_reader :stop_process_on_failure, :stop_process_on_success
+    attr_accessor :handler, :result
+
+    def initialize(opts = {})
+      @stop_process_on_failure = opts[:stop_process_on_failure] || false
+      @stop_process_on_success = opts[:stop_process_on_success] || false
+      @next_handler = nil
+      post_initialize(opts) # implemented in subclass
+    end
+
+    # @param [Handler] handler
+    #
+    # @return [Handler]
+    def next_handler(handler)
+      @handler = handler if handler
+
+      handler
+    end
+
+    # @abstract
+    #
+    # @param [String] request
+    #
+    # @return [Boolean, nil]
+    def handle(request)
+      check = check_value(request) # imlemented in subclass
+      return true  if check && stop_process_on_success
+
+      return false if !check && stop_process_on_failure
+
+      handler&.handle(request)
+    end
+  end
+end

data/lib/checkability/chain_of_resp/handler.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module ChainOfResp
+  # @abstract
+  class Handler
+    # @abstract
+    #
+    # @param [Handler] handler
+    def next_handler=(_handler)
+      raise NotImplementedError, "#{self.class} has not implemented method '#{__method__}'"
+    end
+
+    # @abstract
+    #
+    # @param [String] request
+    #
+    # @return [String, nil]
+    def handle(_request)
+      raise NotImplementedError, "#{self.class} has not implemented method '#{__method__}'"
+    end
+
+    # @abstract
+    #
+    # @param [String] request
+    #
+    # @return [Boolean, true|false]
+    def check_value(_request)
+      raise NotImplementedError, "#{self.class} has not implemented method '#{__method__}'"
+    end
+  end
+end

data/lib/checkability/checkable.rb

@@ -9,32 +9,43 @@ module Checkability
 
     def initialize(checkable)
       @checkable = checkable
+      @checkable.messages = []
     end
 
-    # strategy is a proc
-    #   like { |a,b,c| a && ( b || c ) }
-    #   where a,b,c are checkers
-    #   and each should return true|false
-    # checker_confs is an array of checker_conf hashes
-    #   e.g. [storage_checker, external_api_checker]
+    # As in result handlers should behave like this:
+    # validator    .set_next(storage)
+    # storage      .set_next(api_validator)
+    # api_validator.set_next(api_finder)
+    # api_validator.set_next(nil)
+    #
+    # validator.handle(request)
+    #
     def check(opts = {})
-      results = []
-      opts[:checker_confs].each do |checker_conf|
-        results << (res = _checker_to_check_value(checker_conf))
-        break if res && checker_conf[:stop_process_if_success]
-        break if res == false && checker_conf[:stop_process_if_failure]
-      end
-      opts[:strategy].call(results)
+      require 'pry'; binding.pry
+      first_handler_name = opts[:first_handler]
+      _handlers(opts)[first_handler_name].handle(checkable)
+    rescue StandardError => e
+      checkable.messages << "false::#{e}: #{opts}."
+      false
     end
 
     private
 
-    def _checker_to_check_value(checker_conf)
-      k = "Checkability::#{checker_conf[:name].to_s.camelize}".constantize
-      k.new(checker_conf).check_value(checkable)
-    rescue NameError => e
-      checkable.messages << "false::#{e}: #{checker_conf[:name]}."
-      false
+    def _handlers(opts)
+      handler_confs = opts[:handler_confs]
+      handlers = {}
+      handler_confs.each do |handler_name, handler_conf|
+        handlers[handler_name] = _make_handler(handler_name, handler_conf)
+      end
+      handlers.each do |handler_name, handler|
+        next_handler_name = handler_confs[handler_name][:next_handler]
+        handler.next_handler(handlers[next_handler_name])
+      end
+    end
+
+    def _make_handler(_name, conf)
+      k = Checkability.const_get conf[:name].to_s.camelize
+      k.new(conf)
     end
   end
 end

data/lib/checkability/external_api_checker.rb

@@ -5,14 +5,17 @@ require 'net/http'
 require 'net/https'
 require 'json'
 
+# frozen_string_literal: true
+
+require_relative 'chain_of_resp/abstract_handler'
 module Checkability
   # Checks if postcode exists in external API
   #
-  class ExternalApiChecker
+  class ExternalApiChecker < ChainOfResp::AbstractHandler
     attr_reader :path, :path_suffix, :check_method, :connection, :http_verb,
                 :failure_message, :success_message
 
-    def initialize(conf = {})
+    def post_initialize(conf = {})
       @path = conf[:path]
       @http_verb = conf[:http_verb] || :get
       @path_suffix = conf[:path_suffix] || ''

data/lib/checkability/storage_checker.rb

@@ -1,12 +1,13 @@
 # frozen_string_literal: true
 
+require_relative 'chain_of_resp/abstract_handler'
 module Checkability
   # Checks if postcode exists in Storage
   #
-  class StorageChecker
+  class StorageChecker < ChainOfResp::AbstractHandler
     attr_reader :storage_class
 
-    def initialize(conf = {})
+    def post_initialize(conf = {})
       @storage_class = conf[:storage_class]
     end
 

data/lib/checkability/validator.rb

@@ -3,10 +3,10 @@
 module Checkability
   # Checks if postcode comply with regex
   #
-  class Validator
+  class Validator < ChainOfResp::AbstractHandler
     attr_reader :format
 
-    def initialize(conf = {})
+    def post_initialize(conf = {})
       @format = conf[:format]
     end
 

data/lib/checkability/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkability
-  VERSION = '0.5.0'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkability
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Andrey Eremeev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-01 00:00:00.000000000 Z
+date: 2021-04-03 00:00:00.000000000 Z
 dependencies: []
 description: Provide Checkers functionality.
 email:
@@ -24,6 +24,8 @@ files:
 - bin/checkability
 - lib/checkability.rb
 - lib/checkability/acts_as_checkable.rb
+- lib/checkability/chain_of_resp/abstract_handler.rb
+- lib/checkability/chain_of_resp/handler.rb
 - lib/checkability/checkable.rb
 - lib/checkability/external_api_checker.rb
 - lib/checkability/external_api_connector.rb