checkability 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ae846f196e0b6d2648429f824e02205b9a3fe04d
-  data.tar.gz: 10156c70279d72817146d19fceaef9cbba3f116d
+SHA256:
+  metadata.gz: ae53afa68f33c527bee835d3c84e304c7596f46665cc41ff1df67b2e4189f595
+  data.tar.gz: 8de80e50a31b5e3c7b2f498b8c81de8793b4d80f9a4665653dd12be745331721
 SHA512:
-  metadata.gz: 990b1575b7ebfb0e667aa1ab2e6a0601e3388ea1b2ecd7f4808d843d1341085f454477804fa8f0edeb743fd2508fdb16d2b7a9eb2d8451a20a212791f67f411d
-  data.tar.gz: 445c267c33c75d63188d6ec04767409afed7734292a369e880d8e1d1cc03b5b8a9af80339b076968d60816ec9834901ab9ed6a7299606b9d3fe496276e869af3
+  metadata.gz: 32ed1b0305e36d037d38bde6acf78f4c7d4ae04e49764d4129fb5d9f455cf349607131ea17b5a500a0f47ab38f31698d06eeaec07dc9a014b030518be42e66fa
+  data.tar.gz: cec99b497500443955ef650e56948037e8e7855456f14aa66a491e71ecd884c9d1553c64bbb10fd7a1ce23ae535fa1d42bb730a0979bfead71db07a625bc2407

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 
 require 'bundler/gem_tasks'

data/bin/checkability

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../lib/checkability'
 

data/lib/checkability.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record'
 require 'active_support'
 require_relative 'checkability/version'

data/lib/checkability/acts_as_checkable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   # Adding class and instance methods
   #
@@ -10,9 +12,7 @@ module Checkability
 
     class_methods do
       def acts_as_checkable(options = {})
-        if !options.is_a?(Hash) && !options.empty?
-          raise ArgumentError, "Hash expected, got #{options.class.name}"
-        end
+        raise ArgumentError, "Hash expected, got #{options.class.name}" if !options.is_a?(Hash) && !options.empty?
 
         class_attribute :checkable_conf
 
@@ -25,7 +25,7 @@ module Checkability
     def perform_check
       _setup
       self.allowed = _check
-      messages << "'#{value}' is #{_allowness}. "
+      messages << "#{allowed}::'#{value}' is #{_allowness}. "
     end
 
     private

data/lib/checkability/checkable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   # Implements check method to Iterate on chechers
   # Possible to implemet as Iterator in future
@@ -9,11 +11,11 @@ module Checkability
       @checkable = checkable
     end
 
-    # sentence is a proc
+    # strategy is a proc
     #   like { |a,b,c| a && ( b || c ) }
     #   where a,b,c are checkers
     #   and each should return true|false
-    # checkers is an array of checker objects
+    # checker_confs is an array of checker_conf hashes
     #   e.g. [storage_checker, external_api_checker]
     def check(opts = {})
       results = []
@@ -31,7 +33,7 @@ module Checkability
       k = "Checkability::#{checker_conf[:name].to_s.camelize}".constantize
       k.new(checker_conf).check_value(checkable)
     rescue NameError => e
-      checkable.messages << "#{e}: #{checker_conf[:name]}."
+      checkable.messages << "false::#{e}: #{checker_conf[:name]}."
       false
     end
   end

data/lib/checkability/external_api_checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday'
 require 'net/http'
 require 'net/https'
@@ -21,8 +23,9 @@ module Checkability
     end
 
     def check_value(checkable)
-      @resp = connection.connect.send(http_verb,
-                                      checkable.value.delete(' ') + path_suffix)
+      @resp = connection
+              .connect
+              .send(http_verb, "#{checkable.value.delete(' ')}#{path_suffix}")
       result, message = _result_and_message
       checkable.messages << message
       result
@@ -30,8 +33,8 @@ module Checkability
 
     private
 
-    def _message(str)
-      "#{path}: #{str}"
+    def _message(str, res)
+      "#{res}::#{path}: #{str}"
     end
 
     def _parsed(resp)
@@ -39,14 +42,14 @@ module Checkability
     end
 
     def _result_and_message
-      return [false, _message(@resp.status)] unless @resp.status == 200
+      return [false, _message(@resp.status, false)] unless @resp.status == 200
 
-      return [true, _message(success_message)] if check_method
-                                                  .call(_parsed(@resp))
+      return [true, _message(success_message, true)] if check_method
+                                                        .call(_parsed(@resp))
 
-      [false, _message(failure_message)]
+      [false, _message(failure_message, false)]
     rescue StandardError => e
-      [false, _message(e)]
+      [false, _message(e, false)]
     end
   end
 end

data/lib/checkability/external_api_connector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   # Create connection
   #

data/lib/checkability/railtie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   class Railtie < ::Rails::Railtie
   end

data/lib/checkability/storage_checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   # Checks if postcode exists in Storage
   #
@@ -11,7 +13,8 @@ module Checkability
     def check_value(checkable)
       value = checkable.value.upcase
       result = _present_in_storage(value)
-      checkable.messages << (result ? _message('Found') : _message('Not found'))
+      checkable.messages << (
+        result ? _message('Found', result) : _message('Not found', result))
       result
     end
 
@@ -22,8 +25,8 @@ module Checkability
                    .present?
     end
 
-    def _message(str)
-      "Allowed #{storage_class}s list: #{str}."
+    def _message(str, res)
+      "#{res}::Allowed #{storage_class}s list: #{str}."
     end
   end
 end

data/lib/checkability/validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
   # Checks if postcode comply with regex
   #
@@ -18,9 +20,9 @@ module Checkability
 
     def _result_and_message(checkable)
       if (checkable.value.delete(' ') =~ format[:regex]).nil?
-        [false, "Value is NOT COMPLY with format of #{format[:name]}."]
+        [false, "false::Value is NOT COMPLY with format of #{format[:name]}."]
       else
-        [true, "Value is COMPLY with format of #{format[:name]}."]
+        [true, "true::Value is COMPLY with format of #{format[:name]}."]
       end
     end
   end

data/lib/checkability/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Checkability
-  VERSION = '0.4.1'.freeze
+  VERSION = '0.5.0'
 end

data/lib/tasks/checkability_tasks.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # desc "Explaining what the task does"
 # task :checkability do
 #   # Task goes here

metadata

@@ -1,11 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: checkability
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Andrey Eremeev
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2021-04-01 00:00:00.000000000 Z
@@ -40,7 +40,7 @@ metadata:
   homepage_uri: https://github.com/azazelo/checkability
   source_code_uri: https://rubygems.org
   changelog_uri: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -48,16 +48,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.6
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Provide Checkers functionality.
 test_files: []