check_graphite 0.0.1 → 0.0.2

data/README.md

@@ -13,6 +13,8 @@ check_graphite accepts the following options:
 * `-M' or `--metric`: the metric expression which will be queried, it can be an expression
 * `-F` or `--from`: time frame for which to query metrics, defaults to "30seconds"
 * `-N` or `--name`: name to give to the metric, defaults to "value"
+* `-U` or `--username`: username used for basic authentication
+* `-P` or `--password`: password used for basic authentication
 * `-w`: warning threshold for the metric
 * `-c`: critical threshold for the metric
 * `-t`: timeout after which the metric should be considered unknown

data/check_graphite.gemspec

@@ -21,5 +21,7 @@ Gem::Specification.new do |s|
   # specify any dependencies here; for example:
   # s.add_development_dependency "rspec"
   s.add_runtime_dependency "nagios_check"
-  s.add_runtime_dependency "http"
+
+  s.add_development_dependency "rspec"
+  s.add_development_dependency "fakeweb"
 end

data/lib/check_graphite/version.rb

@@ -1,3 +1,3 @@
 module CheckGraphite
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/check_graphite.rb

@@ -1,6 +1,6 @@
 require "nagios_check"
 require "json"
-require "http"
+require "net/http"
 require "check_graphite/version"
 
 module CheckGraphite
@@ -12,15 +12,29 @@ module CheckGraphite
     on "--metric METRIC", "-M METRIC", :mandatory
     on "--from TIMEFRAME", "-F TIMEFRAME", :default => "30seconds"
     on "--name NAME", "-N NAME", :default => :value
+    on "--username USERNAME", "-U USERNAME"
+    on "--password PASSWORD", "-P PASSWORD"
 
     enable_warning
     enable_critical
     enable_timeout
 
     def check
-      data = Http.get "#{options.endpoint}?target=#{options.metric}&from=-#{options.from}&format=json"
-      raise "no such metric registered" unless data.length > 0
-      res = data.first["datapoints"].reduce({:sum => 0.0, :count => 0}) {|acc, e|
+      uri = URI(URI.encode("#{options.endpoint}?target=#{options.metric}&from=-#{options.from}&format=json"))
+      req = Net::HTTP::Get.new(uri.request_uri)
+
+      # use basic auth if username is set
+      if options.username
+        req.basic_auth options.username, options.password
+      end
+
+      res = Net::HTTP.start(uri.hostname, uri.port) { |http|
+        http.request(req)
+      }
+
+      res.code == "200" || raise("HTTP error code #{res.code}")
+
+      res = JSON(res.body).first["datapoints"].reduce({:sum => 0.0, :count => 0}) {|acc, e|
         if e[0]
           {:sum => acc[:sum] + e[0], :count => acc[:count] + 1}
         else

data/spec/check_graphite_spec.rb

@@ -0,0 +1,57 @@
+require "rspec"
+require "fake_web"
+
+require "check_graphite"
+
+describe CheckGraphite::Command do
+  before do
+    FakeWeb.allow_net_connect = false
+  end
+
+  describe "it should make http requests and return data" do
+    before do
+      FakeWeb.register_uri(:get, "http://your.graphite.host/render?target=collectd.somebox.load.load.midterm&from=-30seconds&format=json",
+                           :body => '[{"target": "default.test.boottime", "datapoints": [[1.0, 1339512060], [3.0, 1339512120]]}]',
+                           :content_type => "application/json")
+    end
+
+    it "should just work" do
+      ARGV = %w{ -H http://your.graphite.host/render -M collectd.somebox.load.load.midterm }
+      c = CheckGraphite::Command.new
+      STDOUT.should_receive(:puts).with("OK|value=2.0;;;;")
+      lambda { c.run }.should raise_error SystemExit
+    end
+
+    it "should be critical" do
+      ARGV = %w{ -H http://your.graphite.host/render -M collectd.somebox.load.load.midterm -c 0 }
+      c = CheckGraphite::Command.new
+      STDOUT.should_receive(:puts).with("CRITICAL|value=2.0;;;;")
+      lambda { c.run }.should raise_error SystemExit
+    end
+  end
+
+  describe "it should make http requests with basic auth and return data" do
+    before do
+      FakeWeb.register_uri(:get, "http://baduser:badpass@your.graphite.host/render?target=collectd.somebox.load.load.midterm&from=-30seconds&format=json",
+                           :body => "Unauthorized", :status => ["401", "Unauthorized"])
+
+      FakeWeb.register_uri(:get, "http://testuser:testpass@your.graphite.host/render?target=collectd.somebox.load.load.midterm&from=-30seconds&format=json",
+                           :body => '[{"target": "default.test.boottime", "datapoints": [[1.0, 1339512060], [3.0, 1339512120]]}]',
+                           :content_type => "application/json")
+    end
+
+    it "should work with valid username and password" do
+      ARGV = %w{ -H http://your.graphite.host/render -M collectd.somebox.load.load.midterm -U testuser -P testpass}
+      c = CheckGraphite::Command.new
+      STDOUT.should_receive(:puts).with("OK|value=2.0;;;;")
+      lambda { c.run }.should raise_error SystemExit
+    end
+
+    it "should fail with bad username and password" do
+      ARGV = %w{ -H http://your.graphite.host/render -M collectd.somebox.load.load.midterm -U baduser -P badpass }
+      c = CheckGraphite::Command.new
+      STDOUT.should_receive(:puts).with(/UNKNOWN: INTERNAL ERROR: HTTP error code 401/)
+      lambda { c.run }.should raise_error SystemExit
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: check_graphite
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-10 00:00:00.000000000Z
+date: 2012-06-22 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nagios_check
-  requirement: &70361640493220 !ruby/object:Gem::Requirement
+  requirement: &21306100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,18 +21,29 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70361640493220
+  version_requirements: *21306100
 - !ruby/object:Gem::Dependency
-  name: http
-  requirement: &70361640492800 !ruby/object:Gem::Requirement
+  name: rspec
+  requirement: &21305220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
+  prerelease: false
+  version_requirements: *21305220
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: &21304580 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  version_requirements: *70361640492800
+  version_requirements: *21304580
 description: check values from a graphite server
 email:
 - pyr@spootnik.org
@@ -49,6 +60,7 @@ files:
 - check_graphite.gemspec
 - lib/check_graphite.rb
 - lib/check_graphite/version.rb
+- spec/check_graphite_spec.rb
 homepage: https://github.com/pyr/check-graphite
 licenses: []
 post_install_message: 
@@ -69,8 +81,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: check_graphite
-rubygems_version: 1.8.15
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: check_graphite
-test_files: []
+test_files:
+- spec/check_graphite_spec.rb