cheap_ams 0.10.5 → 0.10.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5643a60ddfc5ccd9d47234e8fe013a28cdbd084
-  data.tar.gz: 45d1854982df42bd7cf35be0853bf41e0c37a30d
+  metadata.gz: bacc6451ac77d1740a76023d37025b72e83dc758
+  data.tar.gz: 4c34c52e8871b663c994862f13eb1d6dfd459f51
 SHA512:
-  metadata.gz: 4d8160cb879e7b600352563761855e507edc435b3343948ce4e47645c5ed1d7ef7b68d622596e35178bddbe572bdd206bb77d3b6dd0edcbf9e4833e2caa9bc46
-  data.tar.gz: 99aeb8386164dd14723662669e2d52c157e67c0b20020df43a85bd31eedbb526a7f323f65237a502e2d9c1a59783a00124706529be3aa49093b4436855b0b7ef
+  metadata.gz: 21b1ac7c84fc65eb0122bcd001797e78bd6bf1ca7e6a5f851ff464a9b2472024ddff2ac6fb9ec623d2f064f719e07bb5a8cfab8d2d5e91b3a235b4a5991d1539
+  data.tar.gz: 5a9abdae7b843688e75db24c2b1428b9a927a83758237b8f8499e7640faf8ed86982bfb07630a911dd2fae06d3f6d83ab7de0bdff8cf4f4886e7395f9076ec02

data/.rubocop.yml

@@ -0,0 +1,49 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - config/initializers/forbidden_yaml.rb
+    - !ruby/regexp /(vendor|bundle|bin|db|tmp)\/.*/
+  RunRailsCops: true
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+
+Lint/NestedMethodDefinition:
+  Enabled: false
+  Exclude:
+    - test/action_controller/serialization_test.rb
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+
+Metrics/AbcSize:
+  Max: 35 # TODO: Lower to 15
+
+Metrics/ClassLength:
+  Max: 261 # TODO: Lower to 100
+  Exclude:
+    - test/**/*.rb
+
+Metrics/CyclomaticComplexity:
+  Max: 7 # TODO: Lower to 6
+
+Metrics/LineLength:
+  Max: 251 # TODO: Lower to 80
+
+Metrics/MethodLength:
+  Max: 106 # TODO: Lower to 10
+
+Metrics/PerceivedComplexity:
+  Max: 9 # TODO: Lower to 7
+
+Style/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Style/ClassAndModuleChildren:
+  EnforcedStyle: compact
+
+Style/Documentation:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented

data/.rubocop_todo.yml

@@ -0,0 +1,315 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2015-08-31 04:23:33 -0500 using RuboCop version 0.33.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: AllowSafeAssignment.
+Lint/AssignmentInCondition:
+  Exclude:
+    - 'lib/active_model/serializer/adapter/json_api.rb'
+
+# Offense count: 1
+Lint/EmptyEnsure:
+  Exclude:
+    - 'test/serializers/adapter_for_test.rb'
+
+# Offense count: 1
+Lint/HandleExceptions:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/active_model/serializer/adapter/json_api/fragment_cache.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/active_model/serializer/adapter.rb'
+    - 'lib/active_model/serializer/adapter/null.rb'
+    - 'lib/active_model/serializer/pass_through_serializer.rb'
+    - 'test/fixtures/poro.rb'
+    - 'test/lint_test.rb'
+
+# Offense count: 1
+Lint/UselessAccessModifier:
+  Exclude:
+    - 'lib/active_model/serializable_resource.rb'
+
+# Offense count: 3
+Lint/UselessAssignment:
+  Exclude:
+    - 'bench/perf.rb'
+    - 'lib/active_model/serializer/adapter/json_api/fragment_cache.rb'
+    - 'test/test_helper.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Rails/Date:
+  Exclude:
+    - 'test/fixtures/poro.rb'
+
+# Offense count: 8
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Rails/TimeZone:
+  Exclude:
+    - 'test/action_controller/serialization_test.rb'
+    - 'test/fixtures/poro.rb'
+    - 'test/serializers/cache_test.rb'
+
+# Offense count: 16
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+Style/AlignHash:
+  Exclude:
+    - 'test/action_controller/json_api/pagination_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AndOr:
+  Exclude:
+    - 'lib/active_model/serializer/lint.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+Style/BlockDelimiters:
+  Enabled: false
+
+# Offense count: 46
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'test/action_controller/adapter_selector_test.rb'
+    - 'test/action_controller/json_api/pagination_test.rb'
+    - 'test/action_controller/serialization_test.rb'
+    - 'test/adapter/json_api/linked_test.rb'
+    - 'test/adapter/json_api/pagination_links_test.rb'
+    - 'test/adapter/null_test.rb'
+    - 'test/adapter_test.rb'
+    - 'test/array_serializer_test.rb'
+    - 'test/serializable_resource_test.rb'
+    - 'test/serializers/associations_test.rb'
+    - 'test/serializers/attribute_test.rb'
+    - 'test/serializers/attributes_test.rb'
+    - 'test/serializers/fieldset_test.rb'
+    - 'test/serializers/root_test.rb'
+    - 'test/serializers/urls_test.rb'
+
+# Offense count: 167
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/CommentIndentation:
+  Exclude:
+    - 'active_model_serializers.gemspec'
+
+# Offense count: 1
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/active_model/serializable_resource.rb'
+
+# Offense count: 1
+Style/EachWithObject:
+  Exclude:
+    - 'lib/active_model/serializer/fieldset.rb'
+
+# Offense count: 3
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/active_model/serializer.rb'
+    - 'lib/active_model/serializer/adapter/json_api.rb'
+    - 'test/capture_warnings.rb'
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
+Style/HashSyntax:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/IndentArray:
+  Exclude:
+    - 'test/adapter/json/has_many_test.rb'
+    - 'test/adapter/json_api/json_api_test.rb'
+    - 'test/adapter/json_api/pagination_links_test.rb'
+    - 'test/adapter/json_test.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/IndentHash:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/IndentationConsistency:
+  Exclude:
+    - 'test/action_controller/serialization_scope_name_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: Width.
+Style/IndentationWidth:
+  Exclude:
+    - 'lib/active_model/serializable_resource.rb'
+    - 'lib/active_model/serializer/fieldset.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Lambda:
+  Exclude:
+    - 'lib/active_model/serializer.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/MethodCallParentheses:
+  Exclude:
+    - 'lib/active_model/serializer/adapter/json.rb'
+    - 'lib/active_model/serializer/adapter/json_api.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodDefParentheses:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/NegatedIf:
+  Exclude:
+    - 'lib/action_controller/serialization.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+Style/Next:
+  Exclude:
+    - 'lib/active_model/serializer/adapter/json_api.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  MinDigits: 7
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'active_model_serializers.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+    - 'test/fixtures/poro.rb'
+    - 'test/serializers/associations_test.rb'
+
+# Offense count: 6
+# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+Style/PredicateName:
+  Exclude:
+    - 'lib/active_model/serializer/adapter.rb'
+    - 'lib/active_model/serializer/adapter/json_api.rb'
+    - 'lib/active_model/serializer/associations.rb'
+    - 'test/action_controller/json_api/linked_test.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'lib/active_model/serializer.rb'
+    - 'lib/active_model/serializer/associations.rb'
+    - 'test/fixtures/poro.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Exclude:
+    - 'lib/active_model/serializer/fieldset.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SignalException:
+  Exclude:
+    - 'lib/active_model/serializer.rb'
+    - 'lib/active_model/serializer/adapter.rb'
+    - 'lib/active_model/serializer/fieldset.rb'
+    - 'lib/active_model/serializer/pass_through_serializer.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowIfMethodIsEmpty.
+Style/SingleLineMethods:
+  Exclude:
+    - 'test/serializers/serializer_for_test.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+# Offense count: 1
+Style/StructInheritance:
+  Exclude:
+    - 'bench/perf.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+Style/SymbolProc:
+  Exclude:
+    - 'lib/generators/serializer/serializer_generator.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/TrailingBlankLines:
+  Exclude:
+    - 'lib/active_model/serializer/pass_through_serializer.rb'
+    - 'lib/generators/serializer/serializer_generator.rb'
+    - 'test/adapter/fragment_cache_test.rb'
+    - 'test/adapter/json_api/json_api_test.rb'
+    - 'test/adapter/null_test.rb'
+    - 'test/serializers/cache_test.rb'
+    - 'test/serializers/fieldset_test.rb'
+    - 'test/support/stream_capture.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+Style/TrailingComma:
+  Exclude:
+    - 'test/action_controller/adapter_selector_test.rb'
+    - 'test/action_controller/serialization_test.rb'
+    - 'test/adapter/json_api/belongs_to_test.rb'
+    - 'test/adapter/json_api/linked_test.rb'
+
+# Offense count: 1
+Style/UnlessElse:
+  Exclude:
+    - 'lib/active_model/serializer.rb'

data/.simplecov

@@ -0,0 +1,99 @@
+# https://github.com/colszowka/simplecov#using-simplecov-for-centralized-config
+# see https://github.com/colszowka/simplecov/blob/master/lib/simplecov/defaults.rb
+# vim: set ft=ruby
+
+## DEFINE VARIABLES
+@minimum_coverage = ENV.fetch('COVERAGE_MINIMUM') {
+  case (defined?(RUBY_ENGINE) && RUBY_ENGINE) || "ruby"
+  when 'jruby', 'rbx'
+    96.0
+  else
+    98.3
+  end
+}.to_f.round(2)
+# rubocop:disable Style/DoubleNegation
+ENV['FULL_BUILD'] ||= ENV['CI']
+@running_ci       = !!(ENV['FULL_BUILD'] =~ /\Atrue\z/i)
+@generate_report  = @running_ci || !!(ENV['COVERAGE'] =~ /\Atrue\z/i)
+@output = STDOUT
+# rubocop:enable Style/DoubleNegation
+
+## CONFIGURE SIMPLECOV
+SimpleCov.pid = $$ # In case there's any forking
+
+SimpleCov.profiles.define 'app' do
+  coverage_dir 'coverage'
+  load_profile 'test_frameworks'
+
+  add_group 'Libraries', 'lib'
+
+  add_group 'Long files' do |src_file|
+    src_file.lines.count > 100
+  end
+  class MaxLinesFilter < SimpleCov::Filter
+    def matches?(source_file)
+      source_file.lines.count < filter_argument
+    end
+  end
+  add_group 'Short files', MaxLinesFilter.new(5)
+
+  # Exclude these paths from analysis
+  add_filter '/config/'
+  add_filter '/db/'
+  add_filter 'tasks'
+end
+
+## START TRACKING COVERAGE (before activating SimpleCov)
+require 'coverage'
+Coverage.start
+
+## ADD SOME CUSTOM REPORTING AT EXIT
+SimpleCov.at_exit do
+  header = "#{'*' * 20} SimpleCov Results #{'*' * 20}"
+  @output.puts
+  @output.puts header
+  @output.puts SimpleCov.result.format!
+  percent = Float(SimpleCov.result.covered_percent)
+  if percent < @minimum_coverage
+    @output.puts "Spec coverage was not high enough: "\
+    "#{percent.round(2)} is < #{@minimum_coverage}%\n"
+    exit 1 if @generate_report
+  else
+    @output.puts "Nice job! Spec coverage (#{percent.round(2)}) "\
+    "is still at or above #{@minimum_coverage}%\n"
+  end
+  @output.puts
+  @output.puts '*' * header.size
+end
+
+## CAPTURE CONFIG IN CLOSURE 'AppCoverage.start'
+## to defer running until test/test_helper.rb is loaded.
+# rubocop:disable Style/MultilineBlockChain
+AppCoverage = Class.new do
+  def initialize(&block)
+    @block = block
+  end
+
+  def start
+    @block.call
+  end
+end.new do
+  SimpleCov.start 'app'
+  if @generate_report
+    if @running_ci
+      require 'codeclimate-test-reporter'
+      @output.puts '[COVERAGE] Running with SimpleCov Simple Formatter and CodeClimate Test Reporter'
+      formatters = [
+        SimpleCov::Formatter::SimpleFormatter,
+        CodeClimate::TestReporter::Formatter
+      ]
+    else
+      @output.puts '[COVERAGE] Running with SimpleCov HTML Formatter'
+      formatters = [SimpleCov::Formatter::HTMLFormatter]
+    end
+  else
+    formatters = []
+  end
+  SimpleCov.formatters = formatters
+end
+# rubocop:enable Style/MultilineBlockChain

data/.travis.yml

@@ -2,6 +2,9 @@ language: ruby
 
 sudo: false
 
+cache:
+  bundler: true
+
 rvm:
   - 1.9.3
   - 2.0.0
@@ -14,6 +17,10 @@ rvm:
 install:
   - bundle install --retry=3
 
+script:
+  - bundle exec rake
+  - bundle exec rake rubocop
+
 env:
   - "RAILS_VERSION=4.0"
   - "RAILS_VERSION=4.1"
@@ -24,3 +31,4 @@ matrix:
   allow_failures:
     - rvm: ruby-head
     - env: "RAILS_VERSION=master"
+  fast_finish: true

data/Gemfile

@@ -27,9 +27,18 @@ end
 
 group :test do
   gem 'activerecord'
-  gem 'sqlite3', platform: :ruby
+  gem 'sqlite3', platform: [:ruby, :mingw, :x64_mingw, :mswin]
   gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
+  gem 'codeclimate-test-reporter', require: false
+end
+
+group :test, :development do
+  gem 'simplecov', '~> 0.10', require: false
 end
 
 # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
 gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+
+group :development, :test do
+  gem 'rubocop', '~> 0.34.0', require: false
+end

data/README.md

@@ -1,8 +1,10 @@
 # ActiveModel::Serializer
 
-[![Build Status](https://travis-ci.org/rails-api/active_model_serializers.svg)](https://travis-ci.org/rails-api/active_model_serializers)
+[![Build Status](https://travis-ci.org/rails-api/active_model_serializers.svg)](https://travis-ci.org/rails-api/active_model_serializers) 
+<a href="https://codeclimate.com/github/rails-api/active_model_serializers"><img src="https://codeclimate.com/github/rails-api/active_model_serializers/badges/gpa.svg" /></a>
+<a href="https://codeclimate.com/github/rails-api/active_model_serializers/coverage"><img src="https://codeclimate.com/github/rails-api/active_model_serializers/badges/coverage.svg" /></a>
 
-_Windows Build Status -_ ![Build Status](https://ci.appveyor.com/api/projects/status/1dly7uj4l69bchmu)
+_Windows Build Status -_ [![Build status](https://ci.appveyor.com/api/projects/status/x6xdjydutm54gvyt/branch/master?svg=true)](https://ci.appveyor.com/project/joaomdmoura/active-model-serializers/branch/master)
 
 ActiveModel::Serializer brings convention over configuration to your JSON generation.
 
@@ -34,8 +36,6 @@ class PostSerializer < ActiveModel::Serializer
   attributes :title, :body
 
   has_many :comments
-
-  url :post
 end
 ```
 
@@ -46,8 +46,6 @@ class CommentSerializer < ActiveModel::Serializer
   attributes :name, :body
 
   belongs_to :post
-
-  url [:post, :comment]
 end
 ```
 
@@ -237,8 +235,6 @@ class PostSerializer < ActiveModel::Serializer
 
   has_many :comments
   has_one :author
-
-  url :post
 end
 ```
 
@@ -249,8 +245,6 @@ class CommentSerializer < ActiveModel::Serializer
   attributes :name, :body
 
   belongs_to :post_id
-
-  url [:post, :comment]
 end
 ```
 
@@ -272,8 +266,6 @@ And you can change the JSON key that the serializer should use for a particular
   has_many :comments, key: :reviews
 ```
 
-The `url` declaration describes which named routes to use while generating URLs
-for your JSON. Not every adapter will require URLs.
 ## Pagination
 
 Pagination links will be included in your response automatically as long as the resource is paginated using [Kaminari](https://github.com/amatsuda/kaminari) or [WillPaginate](https://github.com/mislav/will_paginate) and if you are using a ```JSON-API``` adapter.
@@ -305,8 +297,6 @@ class PostSerializer < ActiveModel::Serializer
   attributes :title, :body
 
   has_many :comments
-
-  url :post
 end
 ```
 
@@ -330,8 +320,6 @@ class PostSerializer < ActiveModel::Serializer
   attributes :title, :body
 
   has_many :comments
-
-  url :post
 end
 ```
 

data/Rakefile

@@ -1,9 +1,36 @@
-require "bundler/gem_tasks"
+begin
+  require 'simplecov'
+rescue LoadError
+end
+
+require 'bundler/gem_tasks'
+
+begin
+  require 'rubocop'
+  require 'rubocop/rake_task'
+rescue LoadError
+else
+  Rake::Task[:rubocop].clear if Rake::Task.task_defined?(:rubocop)
+  if !defined?(::Rubinius)
+    Rake::Task[:rubocop].clear if Rake::Task.task_defined?(:rubocop)
+    desc 'Execute rubocop'
+    RuboCop::RakeTask.new(:rubocop) do |task|
+      task.options = ['--rails', '--display-cop-names', '--display-style-guide']
+      task.fail_on_error = true
+    end
+  else
+    desc 'No-op rubocop to avoid rbx segfault'
+    task :rubocop do
+      puts 'Skipping rubocop on rbx due to segfault'
+      puts 'https://github.com/rubinius/rubinius/issues/3499'
+    end
+  end
+end
 
 require 'rake/testtask'
 
 Rake::TestTask.new do |t|
-  t.libs << "test"
+  t.libs << 'test'
   t.test_files = FileList['test/**/*_test.rb']
   t.ruby_opts = ['-r./test/test_helper.rb']
   t.verbose = true

data/cheap_ams.gemspec

@@ -9,8 +9,9 @@ Gem::Specification.new do |spec|
   spec.platform      = Gem::Platform::RUBY
   spec.authors       = ['Steve Klabnik']
   spec.email         = ['steve@steveklabnik.com']
-  spec.summary       = %q{Conventions-based JSON generation for Rails.}
-  spec.description   = %q{ActiveModel::Serializers allows you to generate your JSON in an object-oriented and convention-driven manner.}
+  spec.summary       = 'Conventions-based JSON generation for Rails.'
+  spec.description   = 'ActiveModel::Serializers allows you to generate your JSON in an object-oriented and convention-driven manner.'
+  spec.homepage      = 'https://github.com/rails-api/active_model_serializers'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/docs/README.md

@@ -8,6 +8,7 @@ This is the documentation of AMS, it's focused on the **0.10.x version.**
 
 - [Getting Started](general/getting_started.md)
 - [Adapters](general/adapters.md)
+- [Configuration Options](general/configuration_options.md)
 
 ## How to
 

data/docs/general/configuration_options.md

@@ -0,0 +1,11 @@
+# Configuration Options
+
+The following configuration options can be set on `ActiveModel::Serializer.config` inside an initializer.
+
+## General
+
+- `adapter`: The [adapter](adapters.md) to use. Possible values: `:flatten_json, :json, :json_api`. Default: `:flatten_json`.
+
+## JSON API
+
+- `jsonapi_resource_type`: Whether the `type` attributes of resources should be singular or plural. Possible values: `:singular, :plural`. Default: `:plural`.

data/lib/action_controller/serialization.rb

@@ -17,8 +17,8 @@ module ActionController
     end
 
     def get_serializer(resource, options = {})
-      if ! use_adapter?
-        warn "ActionController::Serialization#use_adapter? has been removed. "\
+      if !use_adapter?
+        warn 'ActionController::Serialization#use_adapter? has been removed. '\
           "Please pass 'adapter: false' or see ActiveSupport::SerializableResource#serialize"
         options[:adapter] = false
       end