chats 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '001542179fe490a6f8743099b6b31a2d9cff7cf43a28b982c0cac932b8c06bd1'
-  data.tar.gz: 29720d94ecd7302ae2adcb17f9a81b6fbc6f0365d900e5773655250e14ea9bb9
+  metadata.gz: f2f76b973f012e2c86514932efaca3db25eaf8c70ed4709276d1f5f33d520de2
+  data.tar.gz: 2b88c68ad0d239a9ba87b5e907193924926a3926715ed39b62f844e2d899bf19
 SHA512:
-  metadata.gz: 3d9f25316a4832204fb285ea6547fe34a5c7f938c148307bef311a3311ed770401329b60e020031d7468b200ecf1170294cb7edce6dfbebb5d8c386052aa1adf
-  data.tar.gz: d7f28cf57770b2ad517299f56d431ea11fcc6f33b1886c36a815cce6de81dec983082cd16eb74dfd3528bb966af8feb277cb6ff286d7c89d395f934a12737d3c
+  metadata.gz: be31c3ce5aad04e1c9d5d0ba141403514da0f547de42a4516ede78117025a12c7f3936060787a3935e477e4f2c03aa2fcfb7b7550c0fdca77a5c6d65a0c86db3
+  data.tar.gz: f22af91cf0ccb50bd933659d0fdc549306ecb2bfad09ee87cfb0193499a0839c2f468cd8e109ad7266ddba35200126b28d5f8958b065420fd828a065b9f40b80

data/CHANGELOG.md

@@ -4,6 +4,35 @@ All notable changes to this project are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.2] - 2026-10-17
+
+### Changed
+**Upgrade note: your `can_message` policy now runs on every direct send,
+not only when a thread is opened.** Read yours before upgrading. If it
+means "who may OPEN a conversation" (a listing must be live, a ride must be
+accepted), existing threads will stop taking messages the moment it turns
+false for the pair — which is usually what you want (a block already
+behaves this way), but is a change. If it is expensive, it now costs that
+on every direct message; make it cheap or cache what it reads. It must not
+raise: an exception escapes the send like any other host error. Group
+conversations and system messages are unchanged.
+
+- **`can_message` holds on every direct send.** A block placed
+  mid-conversation already stopped the next message; the host's policy
+  turning false did not, so a pair allowed when the thread was opened kept
+  talking after an account was banned or a membership ended. Every text
+  message into a direct conversation now re-runs `Chats.can_message?`
+  exactly like the block check: `:blocked` when either side blocked the
+  other, `:not_allowed` (new, in `en` and `es`) when the policy says no.
+  The policy is asked last, only of a send that is otherwise valid (a
+  stranger, a locked thread or an empty body is refused before it runs).
+  The composer answers with its errors stream as before.
+- **A direct thread with nobody on the other side takes no messages.** When
+  the counterpart's account was destroyed, its seat went with it (the
+  gem's `dependent: :destroy` on participations); a text message into that
+  thread is refused with `:not_allowed` instead of slipping past both the
+  block and the policy checks. The thread stays readable.
+
 ## [0.4.1] - 2026-10-17
 
 ### Fixed

data/README.md

@@ -171,7 +171,7 @@ That single hook makes moderate's bidirectional block table the law everywhere c
 - **can't send** into an existing one (a block placed mid-conversation stops the very next message),
 - and **stop seeing** each other's direct threads in the inbox and unread counts — *hidden, never deleted*: lift the block and the history reappears.
 
-Two semantics worth knowing: blocking is enforced **beneath** your `can_message` policy (a permissive or buggy policy can never let a blocked pair talk), and **group conversations are exempt from pair blocks** — the industry standard: blocking someone removes your private line, not your seat in shared spaces. If your domain should eject blocked members from groups, do it in moderate's `on_block` hook by tearing down whatever domain relationship feeds the group membership.
+Two semantics worth knowing: blocking is enforced **beneath** your `can_message` policy (a permissive or buggy policy can never let a blocked pair talk), both are checked on **every direct send**, not only when the thread is opened (a block placed, or a policy turning false, mid-conversation stops the very next message with `:blocked` / `:not_allowed`), and **group conversations are exempt from pair blocks** — the industry standard: blocking someone removes your private line, not your seat in shared spaces. If your domain should eject blocked members from groups, do it in moderate's `on_block` hook by tearing down whatever domain relationship feeds the group membership.
 
 ### 2. Reportable + filtered messages
 

data/config/locales/en.yml

@@ -82,6 +82,7 @@ en:
             base:
               locked: "This conversation is closed."
               blocked: "You can't message this person."
+              not_allowed: "You can't message this person right now."
             action:
               invalid: "needs a label of up to %{count} characters and a link to an http(s) address or to a path on this site that starts with /"
             author:

data/config/locales/es.yml

@@ -82,6 +82,7 @@ es:
             base:
               locked: "Esta conversación está cerrada."
               blocked: "No puedes enviar mensajes a esta persona."
+              not_allowed: "Ahora mismo no puedes enviar mensajes a esta persona."
             action:
               invalid: "necesita un texto de hasta %{count} caracteres y un enlace a una dirección http(s) o a una ruta de este sitio que empiece por /"
             author:

data/lib/chats/models/message.rb

@@ -115,13 +115,15 @@ module Chats
     validate :body_or_files_required
     validate :body_must_fit_length_limit
     validate :sender_must_be_active_participant, on: :create
-    validate :sender_must_not_be_blocked, on: :create
     validate :conversation_must_not_be_locked, on: :create
     validate :author_must_be_persisted
     # Checked at the write that SETS it, not on every save: an edit must
     # never fail over an action nobody touched.
     validate :action_must_be_well_formed, if: :will_save_change_to_action?
     validate :files_must_be_allowed
+    # Last on purpose: the host's policy is asked only of a send that is
+    # otherwise valid (see the method).
+    validate :sender_must_still_be_allowed, on: :create
 
     after_create :register_on_conversation
     after_create_commit :broadcast_created
@@ -337,15 +339,37 @@ module Chats
       errors.add(:sender, :not_a_participant) unless conversation.participant?(sender)
     end
 
-    # Block enforcement at the WRITE, not just at conversation creation: a
-    # block placed mid-conversation must stop the very next send. Direct
-    # threads only — see Conversation.excluding_blocked_for for the group
-    # rationale.
-    def sender_must_not_be_blocked
-      return if system? || sender.nil? || conversation.nil? || !conversation.direct?
+    # Who may talk to whom is decided at the WRITE, not just when the
+    # conversation was opened: a block placed mid-conversation stops the very
+    # next send, and so does the host's `can_message` policy turning false —
+    # an account banned, a listing closed, a membership ended. The pair was
+    # allowed when the thread began; what matters is whether it still is.
+    # Direct threads only — see Conversation.excluding_blocked_for for the
+    # group rationale. Two errors, because they read differently to the
+    # sender: `:blocked` (either side blocked the other) and `:not_allowed`
+    # (the policy said no).
+    #
+    # Asked last, and only of a send that is otherwise valid: a stranger to
+    # the conversation, a locked thread or an empty body is refused before
+    # the host's policy runs, so the policy is never consulted about a
+    # message that could not be sent anyway (it may be expensive, and it
+    # runs on every direct send now). A policy must not raise: an
+    # exception escapes the send like any other host error.
+    #
+    # A direct thread with nobody on the other side — the counterpart's
+    # account was destroyed and its seat went with it — takes no messages:
+    # there is no one the policy could allow.
+    def sender_must_still_be_allowed
+      return if system? || sender.nil? || conversation.nil? || !conversation.direct? || errors.any?
 
       other = conversation.other_participants(sender).first&.messager
-      errors.add(:base, :blocked) if other && Chats.blocked_between?(sender, other)
+      if other.nil?
+        errors.add(:base, :not_allowed)
+      elsif Chats.blocked_between?(sender, other)
+        errors.add(:base, :blocked)
+      elsif !Chats.config.can_message.call(sender, other)
+        errors.add(:base, :not_allowed)
+      end
     end
 
     # Authorship is a signature, not a conversation seat. A host may keep

data/lib/chats/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Chats
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chats
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - rameerez