chats 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0e116038dc60b864f51b65edb4f5b879305da0cabef4c8aa2db73e23464c674
-  data.tar.gz: '0179846f4e07b60cb1d07a9d50909a836456794636da584a6178843f0d39f8ff'
+  metadata.gz: 80fff570dabbff3e99a5a5f37c43b43acd334a94aae30c23b8c76bfbab5441e8
+  data.tar.gz: 72efe83f785fe99876d6b5922a5d834897f1771f3880bead3b43ae6f342ba96d
 SHA512:
-  metadata.gz: 1c3dc69a2bdba881bc7fc6543bc768885797e121f8d23b619e72a578cb3e7c6555c9b19c6dde52bec3085efe52d98e40dc277af932015bb08f65a7aaf67ca5c1
-  data.tar.gz: 4ab1a0ae08133bbe02240e12b1efa8efccb6dfe5bfbf53a1662acce5542a74ec4bb3adfc1eeaf10e6db94a961b17dc81523e8b2ac5044fa02ff22bba6904e303
+  metadata.gz: 362eda363af938a99823b38d7fd4e0a5594d62d305f6a47f88a1dc9978c6556ab37561259007f1649567472a98deecff6cc96050afbbedc3d36637ee99207a84
+  data.tar.gz: aa7b170ba97de94d58b08516dbd4674905f1ab78e2bcd4a2e9af997e0aab6d71a3fc35b1aea2f6f0ab97fd02d1d6fa46494a1826f784b35184105c0c1c3c89b6

data/CHANGELOG.md

@@ -4,6 +4,18 @@ All notable changes to this project are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.2] - 2026-09-17
+
+### Fixed
+
+- Grouped inbox limits preserve other counterparts even when one desk has many recent conversations.
+- Conversation creation and participant departure events run after commit and remain silent on rollback. Direct conversation creation includes its roster in the transaction.
+- A message author may be any persisted model; staff need not become messagers to sign a desk's reply.
+
+### Added
+
+- `Chats::SendRateLimited`, a controller concern sharing the configured sender budget across chat and product-specific composers, using the host's cache store on all supported Rails versions.
+
 ## [0.3.1] - 2026-09-16
 
 ### Fixed

data/README.md

@@ -368,6 +368,10 @@ message.authored_by?(lucia)
 
 The bundled bubble renders a signature line ("— Lucía G.") via `Chats.display_name_for`; `config.message_signature = ->(message) { … }` rewrites it. Ordinary messages have no author and render exactly as before.
 
+An author must be persisted, but needs neither `acts_as_messager` nor a conversation
+seat. The host authorizes who may send on behalf of a shared identity; the HTTP
+message controller never accepts an author from request parameters.
+
 Existing installs get the columns with one command:
 
 ```bash
@@ -457,7 +461,7 @@ Chats.configure do |config|
   config.max_group_size = 32
   config.max_attachment_size = 10.megabytes
   config.max_attachments_per_message = 4
-  config.send_rate_limit = { to: 60, within: 1.minute }  # Rails 8 rate_limit; nil disables
+  config.send_rate_limit = { to: 60, within: 1.minute }  # shared sender budget; nil disables
   config.encrypt_messages = false           # ActiveRecord Encryption on bodies
 
   # Policies (on top of — never instead of — block enforcement)

data/app/controllers/chats/messages_controller.rb

@@ -12,19 +12,7 @@ module Chats
     # opened the composer" race in one place.
     before_action :refuse_when_locked!, only: %i[update destroy]
 
-    # Per-sender send throttle via Rails 8's built-in controller rate
-    # limiting (https://api.rubyonrails.org/classes/ActionController/RateLimiting.html).
-    # Feature-detected so the gem still loads on Rails 7.1 (where this is
-    # simply not enforced). Keyed by messager, not IP — one abusive account
-    # behind a corporate NAT must not silence the rest.
-    if respond_to?(:rate_limit) && Chats.config.send_rate_limit
-      rate_limit(
-        **Chats.config.send_rate_limit,
-        only: :create,
-        by: -> { send(Chats.config.current_messager_method)&.to_gid&.to_s || request.remote_ip },
-        with: -> { head :too_many_requests }
-      )
-    end
+    include Chats::SendRateLimited
 
     # A single bubble, re-rendered. Exists for one delightful reason: it's
     # the "cancel edit" target — replacing the inline edit form back with the

data/lib/chats/engine.rb

@@ -30,7 +30,7 @@ module Chats
     CHATS_LIB = File.expand_path("chats", LIB_ROOT)
 
     ZEITWERK_IGNORED = %w[
-      version.rb errors.rb configuration.rb engine.rb macros.rb subscribers.rb
+      version.rb errors.rb configuration.rb engine.rb macros.rb subscribers.rb send_rate_limited.rb
     ].freeze
 
     initializer "chats.autoload", before: :set_autoload_paths do

data/lib/chats/inbox.rb

@@ -151,10 +151,13 @@ module Chats
       else
         stacked = Chats::Conversation.direct.where(id: stacked_seats)
         @ungrouped_relation = base_relation.where.not(id: stacked).limit(limit)
-        # Ordered by recency and limited like the other leg, which also makes
-        # the FIRST conversation of each counterpart that counterpart's
-        # freshest — that's the one the stacked row previews.
-        @stacked = apply_search(base_relation.direct.where(id: stacked_seats).limit(limit))
+        recent = base_relation.direct.where(id: stacked_seats).except(:includes).select(:id).limit(limit)
+        # Preserve the recent search window, plus the freshest conversation
+        # of each counterpart. A busy stack cannot consume another stack's
+        # row; at most twice the row limit is materialized.
+        candidates = base_relation.where(id: limited_ids(recent))
+                                  .or(base_relation.where(id: limited_ids(stack_representatives)))
+        @stacked = apply_search(candidates)
       end
 
       @ungrouped = apply_search(@ungrouped_relation)
@@ -163,6 +166,29 @@ module Chats
       @flat = @stacked.empty? && query.nil? ? @ungrouped_relation : @ungrouped + @stacked
     end
 
+    # MySQL rejects LIMIT directly in an IN subquery. A derived table keeps
+    # the bounded selection in SQL and works on all three supported adapters.
+    def limited_ids(relation)
+      Chats::Conversation.from(relation, :limited_conversations).select(:id)
+    end
+
+    # ROW_NUMBER works on every supported adapter (PostgreSQL, SQLite and
+    # MySQL 8). Ranking in SQL avoids loading an entire busy desk's history.
+    def stack_representatives
+      activity = "COALESCE(chats_conversations.last_message_at, chats_conversations.created_at)"
+      ranking = "ROW_NUMBER() OVER (PARTITION BY stack_seats.messager_type, stack_seats.messager_id " \
+                "ORDER BY #{activity} DESC, chats_conversations.id DESC) AS stack_rank"
+      ranked = base_relation.direct.except(:includes, :order)
+                            .joins("INNER JOIN chats_participants stack_seats " \
+                                   "ON stack_seats.conversation_id = chats_conversations.id")
+                            .where(stack_seats: { messager_type: grouped_types })
+                            .where.not(stack_seats: { messager_type: viewer.class.polymorphic_name,
+                                                      messager_id: viewer.id })
+                            .select("chats_conversations.id, #{activity} AS activity_at", ranking)
+      Chats::Conversation.from(ranked, :ranked_stacks).where("stack_rank = 1")
+                         .order(Arel.sql("activity_at DESC, id DESC")).limit(limit).select(:id)
+    end
+
     # Only the direct threads shared with one counterpart. Direct only, by
     # design: a group that happens to include the desk is not part of the
     # desk's stack.

data/lib/chats/models/concerns/messager.rb

@@ -156,11 +156,6 @@ module Chats
     #
     #   desk.message!(alice, "On it!", author: lucia)
     def message!(target, body = nil, about: nil, files: [], reply_to: nil, author: nil)
-      if author && !Chats.messager_class?(author.class)
-        raise Chats::NotAllowedError,
-              "author must be a messager (acts_as_messager), got #{author.class.name}"
-      end
-
       conversation =
         case target
         when Chats::Conversation then target

data/lib/chats/models/conversation.rb

@@ -114,6 +114,8 @@ module Chats
     # mechanism. https://api.rubyonrails.org/classes/ActiveRecord/Relation.html#method-i-create_or_find_by
     validate :groups_must_be_enabled, if: :group?
 
+    after_create_commit -> { Chats.notify(:conversation_created, conversation: self) }
+
     # --- Finding & creating ---------------------------------------------------
 
     class << self
@@ -133,21 +135,17 @@ module Chats
         raise Chats::BlockedError, "messagers are blocked" if Chats.blocked_between?(a, b)
         raise Chats::NotAllowedError, "policy forbids messaging" unless Chats.can_message?(a, b)
 
-        conversation = create_or_find_by!(direct_key: direct_key_for([a, b], subject: about)) do |c|
-          c.kind = "direct"
-          c.subject = about
+        transaction do
+          conversation = create_or_find_by!(direct_key: direct_key_for([a, b], subject: about)) do |c|
+            c.kind = "direct"
+            c.subject = about
+          end
+          # Keep the roster in the creation transaction: the after-commit
+          # event must describe a complete conversation, including under an
+          # outer host transaction or a failed participant insertion.
+          [a, b].each { |messager| conversation.add_participant!(messager) }
+          conversation
         end
-
-        # `create_or_find_by!` may have FOUND a conversation created a moment
-        # ago by the other side — participants are ensured idempotently
-        # either way (their own unique index makes this race-safe too).
-        # `previously_new_record?` is how we tell the two apart, so the
-        # :conversation_created event fires ONCE per conversation, not on
-        # every resume.
-        created = conversation.previously_new_record?
-        [a, b].each { |messager| conversation.add_participant!(messager) }
-        Chats.notify(:conversation_created, conversation: conversation) if created
-        conversation
       end
 
       # Create a group conversation. +others+ excludes the creator (who joins
@@ -163,17 +161,12 @@ module Chats
         others = Array(others) - [creator]
         raise ArgumentError, "a group needs at least 2 other participants" if others.size < 2
 
-        conversation = transaction do
+        transaction do
           created = create!(kind: "group", title: title, subject: about)
           created.add_participant!(creator, role: "owner")
           others.each { |messager| created.add_participant!(messager) }
           created
         end
-
-        # Emitted AFTER the transaction: subscribers see a complete roster
-        # and never run inside the write that created it.
-        Chats.notify(:conversation_created, conversation: conversation)
-        conversation
       end
 
       # Deterministic identity for a direct pair (+ optional subject).

data/lib/chats/models/message.rb

@@ -96,7 +96,7 @@ module Chats
     validate :sender_must_be_active_participant, on: :create
     validate :sender_must_not_be_blocked, on: :create
     validate :conversation_must_not_be_locked, on: :create
-    validate :author_must_be_a_messager
+    validate :author_must_be_persisted
     validate :files_must_be_allowed
 
     after_create :register_on_conversation
@@ -312,13 +312,13 @@ module Chats
       errors.add(:base, :blocked) if other && Chats.blocked_between?(sender, other)
     end
 
-    # An author signs the bubble with `Chats.display_name_for`, so it has to
-    # be something that HAS a name in this system — a messager, not a ride or
-    # a listing that would render as "Listing 1".
-    def author_must_be_a_messager
-      return if author.nil? || Chats.messager_class?(author.class)
+    # Authorship is a signature, not a conversation seat. A host may keep
+    # staff in a separate model without giving them messaging capabilities.
+    # Never implicitly create that identity while sending a message.
+    def author_must_be_persisted
+      return if author.nil? || author.persisted?
 
-      errors.add(:author, :not_a_messager)
+      errors.add(:author, :invalid)
     end
 
     # The subject owns the conversation's openness (Chats::ChatSubject#

data/lib/chats/models/participant.rb

@@ -43,6 +43,8 @@ module Chats
     # concurrent joins race-safe. Same rationale as Conversation#direct_key.
     validate :group_must_have_room, on: :create
 
+    after_update_commit :notify_departure, if: -> { saved_change_to_left_at? && left? }
+
     def owner? = role == "owner"
     def left? = left_at.present?
     def active? = left_at.nil?
@@ -104,11 +106,17 @@ module Chats
     def unmute! = update!(muted_at: nil)
 
     def leave!
+      return self if left?
+
       update!(left_at: Time.current)
-      Chats.notify(:participant_left, participant: self)
       self
     end
 
+    def notify_departure
+      Chats.notify(:participant_left, participant: self)
+    end
+    private :notify_departure
+
     # Hand this seat to a different messager, keeping the read horizon, the
     # role and the history: the guest who signs up, the agent who takes over
     # a shared mailbox. The MESSAGES keep their original sender — what was

data/lib/chats/send_rate_limited.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Chats
+  # Share one sender budget across chat and product-specific HTTP composers.
+  # The host owns the cache store. Using its atomic increment also works on
+  # Rails 7 and avoids depending on Rails' private controller limiter API.
+  module SendRateLimited
+    extend ActiveSupport::Concern
+
+    included do
+      before_action :enforce_chat_send_rate_limit, only: :create
+    end
+
+    private
+
+    def chat_rate_limit_messager
+      send(Chats.config.current_messager_method)
+    end
+
+    def enforce_chat_send_rate_limit
+      limit = Chats.config.send_rate_limit
+      return unless limit
+
+      sender = chat_rate_limit_messager&.to_gid&.to_s || request.remote_ip
+      count = self.class.cache_store.increment("rate-limit:chats/messages:#{sender}", 1,
+                                               expires_in: limit.fetch(:within))
+      head :too_many_requests if count && count > limit.fetch(:to)
+    end
+  end
+end

data/lib/chats/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Chats
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/lib/chats.rb

@@ -7,6 +7,7 @@ require_relative "chats/version"
 require_relative "chats/errors"
 require_relative "chats/configuration"
 require_relative "chats/subscribers"
+require_relative "chats/send_rate_limited"
 require_relative "chats/macros"
 
 require_relative "chats/engine" if defined?(::Rails::Engine)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: chats
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - rameerez
 bindir: exe
 cert_chain: []
-date: 2026-09-16 00:00:00.000000000 Z
+date: 2026-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -152,6 +152,7 @@ files:
 - app/views/chats/messages/locked.turbo_stream.erb
 - app/views/chats/shared/_unread_badge.html.erb
 - app/views/chats/shared/_verified_badge.html.erb
+- chats-0.3.1.gem
 - config/importmap.rb
 - config/locales/en.yml
 - config/locales/es.yml
@@ -177,6 +178,7 @@ files:
 - lib/chats/models/message.rb
 - lib/chats/models/participant.rb
 - lib/chats/models/reaction.rb
+- lib/chats/send_rate_limited.rb
 - lib/chats/subscribers.rb
 - lib/chats/version.rb
 - lib/generators/chats/install_generator.rb