chat_sdk-linear 1.1.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d0491ce8378e3f97fd5df84ee8d9c33ed93d8eafd9ef349336bb954eb6e40af
-  data.tar.gz: 5dfcf8ba68473c04a906f47c1262045f8cfc2fbfe1c443ea7a06e6e3500de205
+  metadata.gz: 9be95d3a597df82103644afc1355e9709b60ff415eea342a9f9d13d74acb3271
+  data.tar.gz: 8974b645ccf302b9cf03319bc60a2ad42d3e5b94fec36664ff61072c79972bd4
 SHA512:
-  metadata.gz: 3c1f81ee0e1ecbc4f79f05cb04fd6989667048a73b74652f0392d44b75696272dc6464a5e97a0f4cc7f25eb2dff2e14b0ba5149c06a43b0983f641df854d28a1
-  data.tar.gz: b985a4d87dc592e18081bcd9f62d4f9618f030978fcf4608b52a998e02bf7b71616c535f2fbc748b7dadd56ce6b800edab4b232e8c3c5186c106dbb6cd568c30
+  metadata.gz: 8a88044be09c56867ba3ca1965a6631fc7f55256f8f6cf05e2458060317dbfa58c4f190a77b0e5b26ae88ff838d6a9e603f8ac56fd7d418b5d3c784ad98696d5
+  data.tar.gz: 5686a9c75793d24afa7f45ef5efd9199b16ff0d952ce57f85f52091194f0978587b801abd8e9ad440f926307a28a484724fe867a8dfc6675bb1d0ff7c4d32037

data/lib/chat_sdk/linear/adapter.rb

@@ -89,21 +89,25 @@ module ChatSDK
         )
       end
 
-      def edit_message(channel_id:, message_id:, message:)
+      def edit_message(channel_id:, message_id:, message:, thread_id: nil)
+        validate_comment_ownership!(channel_id, message_id, thread_id)
         msg = ChatSDK::PostableMessage.from(message)
         text = msg.text || msg.card&.fallback_text || ""
         @client.update_comment(comment_id: message_id, body: text)
       end
 
-      def delete_message(channel_id:, message_id:)
+      def delete_message(channel_id:, message_id:, thread_id: nil)
+        validate_comment_ownership!(channel_id, message_id, thread_id)
         @client.delete_comment(comment_id: message_id)
       end
 
-      def add_reaction(channel_id:, message_id:, emoji:) # rubocop:disable Lint/UnusedMethodArgument
+      def add_reaction(channel_id:, message_id:, emoji:, thread_id: nil)
+        validate_comment_ownership!(channel_id, message_id, thread_id)
         @client.create_reaction(comment_id: message_id, emoji: emoji)
       end
 
-      def remove_reaction(channel_id:, message_id:, emoji:) # rubocop:disable Lint/UnusedMethodArgument
+      def remove_reaction(channel_id:, message_id:, emoji:, thread_id: nil)
+        validate_comment_ownership!(channel_id, message_id, thread_id)
         @client.delete_reaction(comment_id: message_id, emoji: emoji)
       end
 
@@ -112,12 +116,16 @@ module ChatSDK
         parent_id = nil
 
         if thread_id&.include?(":c:")
-          parts = thread_id.split(":c:")
-          parent_id = parts.last
+          parent_id = thread_id.split(":c:", 2).last
+          validate_comment_ownership!(issue_id, parent_id, nil)
         end
 
         result = @client.fetch_comments(issue_id: issue_id, parent_id: parent_id)
-        comments = result.dig("data", "comments", "nodes") || []
+        comments = if parent_id
+          result.dig("data", "comment", "children", "nodes") || []
+        else
+          result.dig("data", "comments", "nodes") || []
+        end
 
         messages = comments.map do |comment|
           user = comment["user"] || {}
@@ -142,6 +150,37 @@ module ChatSDK
       def render(postable_message)
         postable_message.text
       end
+
+      private
+
+      def validate_comment_ownership!(channel_id, message_id, thread_id)
+        comment = @client.fetch_comment(comment_id: message_id)
+        issue_id = comment&.dig("issue", "id")
+        unless comment && same_identifier?(issue_id, channel_id)
+          raise ChatSDK::Error, "Linear comment does not belong to issue #{channel_id}"
+        end
+
+        root_id = thread_root_id(thread_id)
+        return unless root_id
+        return if same_identifier?(comment["id"], root_id)
+
+        root = @client.fetch_comment(comment_id: root_id)
+        root_issue_id = root&.dig("issue", "id")
+        unless root && same_identifier?(root_issue_id, channel_id) &&
+            same_identifier?(comment.dig("parent", "id"), root_id)
+          raise ChatSDK::Error, "Linear comment does not belong to thread #{thread_id}"
+        end
+      end
+
+      def thread_root_id(thread_id)
+        return unless thread_id.is_a?(String) && thread_id.include?(":c:")
+
+        thread_id.split(":c:", 2).last
+      end
+
+      def same_identifier?(left, right)
+        left.is_a?(String) && right.is_a?(String) && left.casecmp?(right)
+      end
     end
   end
 end

data/lib/chat_sdk/linear/api_client.rb

@@ -90,6 +90,19 @@ module ChatSDK
         end
       end
 
+      def fetch_comment(comment_id:)
+        query = <<~GQL
+          query CommentOwnership($id: String!) {
+            comment(id: $id) {
+              id
+              issue { id }
+              parent { id }
+            }
+          }
+        GQL
+        graphql(query, {id: comment_id}).dig("data", "comment")
+      end
+
       private
 
       def base_url

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chat_sdk-linear
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Quentin Rousseau
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement