chartmogul-ruby 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50f98ff0c8672795e594ce60423c90321c157373
-  data.tar.gz: 8d96dd0cb5eb27611827e0db47e712344465c8fe
+  metadata.gz: e7ad064432c9e4fecaf637584b5d34052e76055d
+  data.tar.gz: c54868e20a9715858c983033c6919f585883de3d
 SHA512:
-  metadata.gz: 9b9936e6898bc049c6d0a3d87d315a3c9a3edee35b28a9af7bfdd88b40aac34c6c2ea70d3bd20238a3ae79255a8265ef3412cbf434a022fa196caf451a2f2656
-  data.tar.gz: f1db11b939b4946bdd9e3386acdd6576be5c2f98edc3680517b8d69e0d4ceea466990156b70f59e849a458a7e12447ec4e9fe80921b8a03d2786c2d286f7f9b9
+  metadata.gz: 09dd03962421da8a7f03e1d11f9317541f5e616e4d45c5f63b52c549d0c6f715c10696281104ad936ee0c1c3418aa0052ae8343f7923694eaebaef1dd1b3cd7e
+  data.tar.gz: 9246cc2c80a01bbec3fa24f205351bdb1293d44ccd8c9fb6c2cd270c432d2a2ba109bd951f0284aa509e3be0df6c83dcf57cf8cf3a73f82b2c6d4a8cdb004586

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "chartmogul"
+require 'bundler/setup'
+require 'chartmogul'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "chartmogul"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/chartmogul-ruby.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'chartmogul/version'

data/lib/chartmogul.rb

@@ -2,70 +2,71 @@ require 'time'
 require 'json'
 require 'faraday'
 
-require "chartmogul/version"
-
-require "chartmogul/utils/hash_snake_caser"
-require "chartmogul/utils/json_parser"
-
-require "chartmogul/errors/chartmogul_error"
-require "chartmogul/errors/configuration_error"
-require "chartmogul/errors/not_found_error"
-require "chartmogul/errors/resource_invalid_error"
-require "chartmogul/errors/schema_invalid_error"
-require "chartmogul/errors/unauthorized_error"
-
-require "chartmogul/config_attributes"
-require "chartmogul/configuration"
-
-require "chartmogul/object"
-require "chartmogul/resource_path"
-require "chartmogul/api_resource"
-require "chartmogul/summary"
-
-require "chartmogul/api/actions/all"
-require "chartmogul/api/actions/create"
-require "chartmogul/api/actions/custom"
-require "chartmogul/api/actions/destroy"
-require "chartmogul/api/actions/retrieve"
-require "chartmogul/api/actions/update"
-
-require "chartmogul/line_items/one_time"
-require "chartmogul/line_items/subscription"
-
-require "chartmogul/transactions/payment"
-require "chartmogul/transactions/refund"
-
-require "chartmogul/concerns/entries"
-require "chartmogul/concerns/summary"
-require "chartmogul/concerns/pageable"
-require "chartmogul/concerns/pageable2"
-
-require "chartmogul/subscription"
-require "chartmogul/invoice"
-require "chartmogul/customer_invoices"
-require "chartmogul/customer"
-require "chartmogul/data_source"
-require "chartmogul/ping"
-require "chartmogul/plan"
-
-require "chartmogul/metrics/arpa"
-require "chartmogul/metrics/arr"
-require "chartmogul/metrics/asp"
-require "chartmogul/metrics/customer_churn_rate"
-require "chartmogul/metrics/customer_count"
-require "chartmogul/metrics/ltv"
-require "chartmogul/metrics/mrr"
-require "chartmogul/metrics/mrr_churn_rate"
-require "chartmogul/metrics/all_key_metrics"
-require "chartmogul/metrics/base"
-
-require "chartmogul/metrics/activity"
-require "chartmogul/metrics/subscription"
-
-require "chartmogul/enrichment/customer"
+require 'chartmogul/version'
+
+require 'chartmogul/utils/hash_snake_caser'
+require 'chartmogul/utils/json_parser'
+
+require 'chartmogul/errors/chartmogul_error'
+require 'chartmogul/errors/configuration_error'
+require 'chartmogul/errors/forbidden_error'
+require 'chartmogul/errors/not_found_error'
+require 'chartmogul/errors/resource_invalid_error'
+require 'chartmogul/errors/schema_invalid_error'
+require 'chartmogul/errors/unauthorized_error'
+
+require 'chartmogul/config_attributes'
+require 'chartmogul/configuration'
+
+require 'chartmogul/object'
+require 'chartmogul/resource_path'
+require 'chartmogul/api_resource'
+require 'chartmogul/summary'
+
+require 'chartmogul/api/actions/all'
+require 'chartmogul/api/actions/create'
+require 'chartmogul/api/actions/custom'
+require 'chartmogul/api/actions/destroy'
+require 'chartmogul/api/actions/retrieve'
+require 'chartmogul/api/actions/update'
+
+require 'chartmogul/line_items/one_time'
+require 'chartmogul/line_items/subscription'
+
+require 'chartmogul/transactions/payment'
+require 'chartmogul/transactions/refund'
+
+require 'chartmogul/concerns/entries'
+require 'chartmogul/concerns/summary'
+require 'chartmogul/concerns/pageable'
+require 'chartmogul/concerns/pageable2'
+
+require 'chartmogul/subscription'
+require 'chartmogul/invoice'
+require 'chartmogul/customer_invoices'
+require 'chartmogul/customer'
+require 'chartmogul/data_source'
+require 'chartmogul/ping'
+require 'chartmogul/plan'
+
+require 'chartmogul/metrics/arpa'
+require 'chartmogul/metrics/arr'
+require 'chartmogul/metrics/asp'
+require 'chartmogul/metrics/customer_churn_rate'
+require 'chartmogul/metrics/customer_count'
+require 'chartmogul/metrics/ltv'
+require 'chartmogul/metrics/mrr'
+require 'chartmogul/metrics/mrr_churn_rate'
+require 'chartmogul/metrics/all_key_metrics'
+require 'chartmogul/metrics/base'
+
+require 'chartmogul/metrics/activity'
+require 'chartmogul/metrics/subscription'
+
+require 'chartmogul/enrichment/customer'
 
 module ChartMogul
-  API_BASE = 'https://api.chartmogul.com'
+  API_BASE = 'https://api.chartmogul.com'.freeze
 
   class << self
     extend ConfigAttributes

data/lib/chartmogul/api/actions/create.rb

@@ -8,9 +8,9 @@ module ChartMogul
 
         def create!
           resp = handling_errors do
-            connection.post(resource_path.apply(self.instance_attributes)) do |req|
+            connection.post(resource_path.apply(instance_attributes)) do |req|
               req.headers['Content-Type'] = 'application/json'
-              req.body = JSON.dump(self.serialize_for_write)
+              req.body = JSON.dump(serialize_for_write)
             end
           end
           json = ChartMogul::Utils::JSONParser.parse(resp.body)

data/lib/chartmogul/api/actions/destroy.rb

@@ -8,7 +8,7 @@ module ChartMogul
 
         def destroy!
           handling_errors do
-            connection.delete("#{resource_path.apply(self.instance_attributes)}/#{uuid}")
+            connection.delete("#{resource_path.apply(instance_attributes)}/#{uuid}")
           end
           true
         end

data/lib/chartmogul/api/actions/update.rb

@@ -4,9 +4,9 @@ module ChartMogul
       module Update
         def update!
           resp = handling_errors do
-            connection.patch("#{resource_path.apply(self.instance_attributes)}/#{uuid}") do |req|
+            connection.patch("#{resource_path.apply(instance_attributes)}/#{uuid}") do |req|
               req.headers['Content-Type'] = 'application/json'
-              req.body = JSON.dump(self.serialize_for_write)
+              req.body = JSON.dump(serialize_for_write)
             end
           end
           json = ChartMogul::Utils::JSONParser.parse(resp.body)

data/lib/chartmogul/api_resource.rb

@@ -17,7 +17,7 @@ module ChartMogul
     def self.set_resource_root_key(root_key)
       @resource_root_key = root_key
     end
-    
+
     def self.connection
       @connection ||= Faraday.new(url: ChartMogul::API_BASE) do |faraday|
         faraday.use Faraday::Request::BasicAuthentication, ChartMogul.account_token, ChartMogul.secret_key
@@ -45,7 +45,7 @@ module ChartMogul
         message = 'No valid API key provided'
         raise ChartMogul::UnauthorizedError.new(message, http_status: 401, response: response)
       when 403
-        message = "The requested action is forbidden."
+        message = 'The requested action is forbidden.'
         raise ChartMogul::ForbiddenError.new(message, http_status: 403, response: response)
       when 404
         message = "The requested #{resource_name} could not be found."
@@ -60,7 +60,7 @@ module ChartMogul
     end
 
     def self.handle_other_error(exception)
-      raise ChartMogul::ChartMogulError.new(exception.message)
+      raise ChartMogul::ChartMogulError, exception.message
     end
 
     def_delegators 'self.class', :resource_path, :resource_name, :resource_root_key, :connection, :handling_errors

data/lib/chartmogul/concerns/entries.rb

@@ -5,9 +5,7 @@ module ChartMogul
         base.extend ClassMethods
 
         base.instance_eval do
-          if @resource_root_key.nil?
-            @resource_root_key = :entries
-          end
+          @resource_root_key = :entries if @resource_root_key.nil?
           readonly_attr @resource_root_key, default: []
 
           include API::Actions::All
@@ -16,22 +14,22 @@ module ChartMogul
           def_delegators @resource_root_key, :each, :[], :<<, :size, :length, :empty?, :first
 
           resource_root_key = @resource_root_key.to_s
-          base.send :define_method, "set_" + resource_root_key do |entries|
+          base.send :define_method, 'set_' + resource_root_key do |entries|
             objects = entries.map do |entity|
               self.class.get_entry_class.new_from_json(entity)
             end
-            self.instance_variable_set "@#{resource_root_key}", objects
+            instance_variable_set "@#{resource_root_key}", objects
           end
         end
       end
 
       module ClassMethods
         def set_entry_class(klass)
-          instance_variable_set("@entry_class", klass)
+          instance_variable_set('@entry_class', klass)
         end
 
         def get_entry_class
-          instance_variable_get("@entry_class")
+          instance_variable_get('@entry_class')
         end
       end
     end

data/lib/chartmogul/concerns/summary.rb

@@ -17,4 +17,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/config_attributes.rb

@@ -3,7 +3,7 @@ module ChartMogul
     def config_accessor(attribute)
       define_method(attribute) do
         attr = config.send(attribute)
-        raise ConfigurationError.new("Configuration for #{attribute} not set") if attr.nil?
+        raise ConfigurationError, "Configuration for #{attribute} not set" if attr.nil?
         attr
       end
 

data/lib/chartmogul/customer.rb

@@ -42,7 +42,6 @@ module ChartMogul
       Customers.all(options)
     end
 
-
     def self.search(email, options = {})
       Customers.search(email, options)
     end
@@ -129,7 +128,11 @@ module ChartMogul
     def typecast_custom_attributes(custom_attributes)
       return {} unless custom_attributes
       custom_attributes.each_with_object({}) do |(key, value), hash|
-        hash[key] = value.instance_of?(String) ? (Time.parse(value) rescue value) : value
+        hash[key] = value.instance_of?(String) ? (begin
+                                                    Time.parse(value)
+                                                  rescue
+                                                    value
+                                                  end) : value
       end
     end
   end

data/lib/chartmogul/data_source.rb

@@ -21,7 +21,6 @@ module ChartMogul
     end
   end
 
-
   class DataSources < APIResource
     set_resource_name 'Data Sources'
     set_resource_path '/v1/data_sources'

data/lib/chartmogul/enrichment/customer.rb

@@ -1,9 +1,7 @@
 module ChartMogul
   module Enrichment
-
     # <b>DEPRECATED:</b> Please use <tt>ChartMogul/Customer</tt> instead.
     class DeprecatedCustomer < APIResource
-
       set_resource_name 'Customer'
       set_resource_path '/v1/customers'
 
@@ -108,14 +106,18 @@ module ChartMogul
       def typecast_custom_attributes(custom_attributes)
         return {} unless custom_attributes
         custom_attributes.each_with_object({}) do |(key, value), hash|
-          hash[key] = value.instance_of?(String) ? (Time.parse(value) rescue value) : value
+          hash[key] = value.instance_of?(String) ? (begin
+                                                      Time.parse(value)
+                                                    rescue
+                                                      value
+                                                    end) : value
         end
       end
     end
 
     def self.const_missing(const_name)
       super unless const_name == :Customer
-      warn "DEPRECATION WARNING: the class ChartMogul::Enrichment::Customer is deprecated. Use ChartMogul::Customer instead."
+      warn 'DEPRECATION WARNING: the class ChartMogul::Enrichment::Customer is deprecated. Use ChartMogul::Customer instead.'
       DeprecatedCustomer
     end
 

data/lib/chartmogul/errors/chartmogul_error.rb

@@ -4,15 +4,15 @@ module ChartMogul
     attr_accessor :response
     attr_accessor :http_status
 
-    def initialize(message, http_status:nil, response:nil)
+    def initialize(message, http_status: nil, response: nil)
       @message = message
       @http_status = http_status
       @response = response
     end
 
     def to_s
-      status = @http_status ? " (HTTP Status: #{@http_status.to_s})" : ''
-      response = @response ? "\nResponse: #{@response.to_s}" : ''
+      status = @http_status ? " (HTTP Status: #{@http_status})" : ''
+      response = @response ? "\nResponse: #{@response}" : ''
       "#{message}#{status}#{response}"
     end
   end

data/lib/chartmogul/metrics/activity.rb

@@ -31,4 +31,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/all_key_metrics.rb

@@ -22,4 +22,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/arpa.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/arr.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/asp.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/base.rb

@@ -1,6 +1,5 @@
 module ChartMogul
   module Metrics
-
     def self.all(options = {})
       ChartMogul::Metrics::AllKeyMetrics.all(preprocess_params(options))
     end
@@ -40,12 +39,12 @@ module ChartMogul
     private
 
     def self.preprocess_params(options)
-      [:start_date, :end_date].each do |param_name|
-        options[param_name.to_s.gsub('_', '-')] = options.delete(param_name) if options[param_name]
+      %i[start_date end_date].each do |param_name|
+        options[param_name.to_s.tr('_', '-')] = options.delete(param_name) if options[param_name]
       end
 
-      [:geo, :plans].each do |param_name|
-        if options[param_name] && options[param_name].kind_of?(Array)
+      %i[geo plans].each do |param_name|
+        if options[param_name] && options[param_name].is_a?(Array)
           options[param_name] = options[param_name].join(',')
         end
       end
@@ -53,4 +52,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/customer_churn_rate.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/customer_count.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/ltv.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/metrics/mrr_churn_rate.rb

@@ -16,4 +16,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/object.rb

@@ -64,8 +64,8 @@ module ChartMogul
       assign_writeable_attributes(attributes)
     end
 
-    def self.new_from_json(attributes={})
-      self.new.tap do |resource|
+    def self.new_from_json(attributes = {})
+      new.tap do |resource|
         resource.assign_all_attributes(attributes)
       end
     end
@@ -77,8 +77,8 @@ module ChartMogul
     end
 
     def assign_writeable_attributes(new_values)
-      self.class.writeable_attributes.each do |attr, value|
-        self.send("#{attr}=", new_values[attr]) if new_values.key?(attr)
+      self.class.writeable_attributes.each do |attr, _value|
+        send("#{attr}=", new_values[attr]) if new_values.key?(attr)
       end
 
       self
@@ -86,7 +86,7 @@ module ChartMogul
 
     def assign_all_attributes(new_values)
       self.class.attributes.each do |attr|
-        self.send("set_#{attr}", new_values[attr]) if new_values.key?(attr)
+        send("set_#{attr}", new_values[attr]) if new_values.key?(attr)
       end
 
       self

data/lib/chartmogul/ping.rb

@@ -7,7 +7,7 @@ module ChartMogul
 
     include API::Actions::Custom
 
-    def self.ping()
+    def self.ping
       custom!(:get, '/v1/ping')
     end
   end

data/lib/chartmogul/plan.rb

@@ -23,7 +23,6 @@ module ChartMogul
     end
   end
 
-
   class Plans < APIResource
     set_resource_name 'Plans'
     set_resource_path '/v1/plans'

data/lib/chartmogul/resource_path.rb

@@ -10,7 +10,7 @@ module ChartMogul
     def initialize(path)
       @path = path
       @named_params = path.scan(/:\w+/).each_with_object({}) do |named_param, hash|
-        hash[named_param] = named_param.gsub(':', '').to_sym
+        hash[named_param] = named_param.delete(':').to_sym
       end
     end
 

data/lib/chartmogul/subscription.rb

@@ -43,6 +43,5 @@ module ChartMogul
     def self.all(customer_uuid, options = {})
       super(options.merge(customer_uuid: customer_uuid))
     end
-
   end
 end

data/lib/chartmogul/utils/hash_snake_caser.rb

@@ -39,12 +39,11 @@ module ChartMogul
 
       def underscore(string)
         string.gsub(/::/, '/')
-          .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-          .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-          .tr('-', '_')
-          .downcase
+            .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+              .gsub(/([a-z\d])([A-Z])/, '\1_\2')
+              .tr('-', '_')
+              .downcase
       end
     end
   end
 end
-

data/lib/chartmogul/utils/json_parser.rb

@@ -8,4 +8,3 @@ module ChartMogul
     end
   end
 end
-

data/lib/chartmogul/version.rb

@@ -1,3 +1,3 @@
 module ChartMogul
-  VERSION = "1.1.4"
+  VERSION = '1.1.5'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chartmogul-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Jason Langenauer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-09 00:00:00.000000000 Z
+date: 2017-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday