chanko_ab 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a967e68060d36eb785d8fd8759e8222e82c9e484e731e837064568ed12e62371
-  data.tar.gz: 23454bd8fe55e33eb8cf75ae6c9ca755f36eae4aef583c8970363b934251b477
+  metadata.gz: 669ae5ace4fc737c1712ff414847634c912c82148ef545286ea989e6be4984a0
+  data.tar.gz: 6b64b0e029598252785701d324c006e29793e430261a1df250a901ae5f49d9d1
 SHA512:
-  metadata.gz: e7c9cbdb8222de95783a790f7168918a7dbad6c43d683a7c9a4e483b838fec080a42bcf96023ad04fd113a1a878879aeba9668a941e397a2ba32567e63141a67
-  data.tar.gz: 77e2ddf77e4298023e7de46f892db281c094f32c2b776401f20bb4d584d6b41de2fd57f00e71c06a4dbe0df45f82d40dbd6942ad74b321d129f974d4a48a7c8c
+  metadata.gz: ca89fbde6694dc77c8df037196496a58a81a915b0db22976d20fb8d09ce2ed82affd391d488cfe7538908b0839a6c9a0f89ab2c5b14f7639fedd13c4c9e8a448
+  data.tar.gz: 37fa07a8175de2913f99de64968fa51cfa0491712c585a8bcd0384bdf2c1592f2790a48118bfe6a9b3545a2149cada1a0c14af4d8c574660633d342e7deb2b15

data/CHANGELOG.md

@@ -1,4 +1,17 @@
 # Change Log
+## [0.3.3] (2022-09-07)
+### Added
+- Support for selectable identifier for each experiment.
+### Changed
+- ChankoAb.set_identifier has been renamed renamed to ChankoAb.set_default_identifier
+
+## [0.2.2] (2022-09-07)
+### Fixed
+- Fix codes for tests
+
+## [0.2.1] (2022-09-07)
+### Fixed
+- Always load constants for testing to prevent unforeseen accident
 
 ## [0.2.0] (2022-09-07)
 ### Added

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    chanko_ab (0.1.1)
+    chanko_ab (0.2.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -24,7 +24,7 @@ ChankoAb.set_logging do |name|
   Rails.logger.debug(name)
 end
 
-ChankoAb.set_identifier do
+ChankoAb.set_default_identifier do
   cookies[:identifier]
 end
 ```
@@ -53,6 +53,15 @@ module MySplitTest
 end
 ```
 
+### Switch using identifier
+```ruby
+module MySplitTest
+  ...
+  split_test.identifier { cookies[:unique_id] }
+  ...
+end
+```
+
 ### Use HexIdentifier if identifier is composed by hex.
 ```ruby
 module HexMySplitTest

data/lib/chanko_ab/logic/base.rb

@@ -20,7 +20,7 @@ module ChankoAb
 
       def validate!
         unless Rails.env.production?
-          raise "Argument should be a divisor of #{just_patterns_size.max}, but #{split_size} is given." if !just_patterns_size.member?(split_size)
+          raise "Argument should be a divisor of #{just_patterns_size.max}, but #{split_size} is given." unless just_patterns_size.member?(split_size)
           raise "Identifier is blank" if @identifier.blank?
           raise "Identifier is too short" if @identifier.size < (@using_index + 1)
           raise 'Too large pattern size' if patterns.size >= just_pattern_sizes.max
@@ -32,7 +32,7 @@ module ChankoAb
       end
 
       def should_run_default?
-        return true if !item
+        return true unless item
         @identifier.blank?
       end
 
@@ -61,7 +61,7 @@ module ChankoAb
       end
 
       def item
-        if Rails.env.test? && ChankoAb::Test.overwritten?(@split_test.unit)
+        if (Rails.env.test? || ChankoAb.env == :test) && ChankoAb::Test.overwritten?(@split_test.unit)
           return pattern_by_overwritten
         else
           index = decide_pattern_index

data/lib/chanko_ab/split_test.rb

@@ -23,6 +23,18 @@ module ChankoAb
       @unit
     end
 
+    def identifier(&block)
+      @identifier_proc = block
+    end
+
+    def identifier_proc
+      @identifier_proc
+    end
+
+    def reset_identifier
+      @identifier_proc = nil
+    end
+
     def logic(logic)
       @logic = logic
     end
@@ -85,7 +97,11 @@ module ChankoAb
         end
 
         shared(:identifier) do
-          self.instance_eval(&ChankoAb.identifier_proc)
+          self.instance_eval(&identifier_proc)
+        end
+
+        shared(:identifier_proc) do
+          __split_test__.identifier_proc || ChankoAb.default_identifier_proc
         end
       end
     end

data/lib/chanko_ab/test.rb

@@ -1,16 +1,20 @@
 module ChankoAb
   module Test
+    def self.overwritten_names
+      @overwritten_names ||= {}
+      @overwritten_names
+    end
+
     def self.overwritten_name(klass)
-      @overwritten_names[klass]
+      self.overwritten_names[klass]
     end
 
     def self.overwrite(klass, name)
-      @overwritten_names ||= {}
-      @overwritten_names[klass] = name
+      self.overwritten_names[klass] = name
     end
 
     def self.overwritten?(klass)
-      !!@overwritten_names[klass]
+      !!self.overwritten_names[klass]
     end
 
     def self.reset!

data/lib/chanko_ab/version.rb

@@ -1,3 +1,3 @@
 module ChankoAb
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/chanko_ab.rb

@@ -1,10 +1,19 @@
 require "chanko_ab/version"
+require "chanko_ab/test"
 require "chanko_ab/split_test"
 require "chanko_ab/logic/base"
 require "chanko_ab/logic/number_identifier"
 require "chanko_ab/logic/hex_identifier"
 
 module ChankoAb
+  def self.env=(env)
+    @env = env
+  end
+
+  def self.env
+    @env
+  end
+
   module ClassMethods
     def split_test
       @split_test ||= SplitTest.new(self)
@@ -19,12 +28,12 @@ module ChankoAb
     @logging_proc = block
   end
 
-  def self.set_identifier(&block)
-    @identifier_proc = block
+  def self.set_default_identifier(&block)
+    @default_identifier_proc = block
   end
 
-  def self.identifier_proc
-    @identifier_proc
+  def self.default_identifier_proc
+    @default_identifier_proc
   end
 
   def self.default_logic

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chanko_ab
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - morita shingo
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-06 00:00:00.000000000 Z
+date: 2022-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chanko