chanko 2.0.0 → 2.3.0

data/spec/chanko/unit_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 module Chanko
   describe Unit do
     before do
-      unit.stub(:name => "ExampleUnit")
+      allow(unit).to receive_messages(:name => "ExampleUnit")
     end
 
     let(:unit) do
@@ -14,7 +14,7 @@ module Chanko
       Class.new { include Chanko::Helper }.new
     end
 
-    describe ".active_if" do
+    describe "about active_if" do
       before do
         ActiveIf.define(:true) { true }
         ActiveIf.define(:false) { false }
@@ -26,38 +26,112 @@ module Chanko
 
       subject { unit.active?(view) }
 
-      context "in default configuration" do
-        it "is configured to return always true" do
-          should be_true
+      describe ".active_if" do
+        context "in default configuration" do
+          it "is configured to return always true" do
+            is_expected.to eq(true)
+          end
+        end
+
+        context "when labels are specified" do
+          before do
+            unit.active_if(:true, :false)
+          end
+          specify "all of defined conditions must pass" do
+            is_expected.to eq(false)
+          end
+        end
+
+        context "when block is passed" do
+          before do
+            unit.active_if(:true) { false }
+          end
+          specify "all of defined conditions and block must pass" do
+            is_expected.to eq(false)
+          end
+        end
+
+        context "when an undefined condition is specified" do
+          before do
+            unit.active_if(:this_is_not_a_condition)
+          end
+
+          specify "an undefined condition must raise NoConditionFound" do
+            expect { subject }.to raise_error Chanko::ActiveIf::NoConditionFound, /this_is_not_a_condition/
+          end
         end
       end
 
-      context "when labels are specified" do
-        before do
-          unit.active_if(:true, :false)
+      describe ".any" do
+        context "when conditions returned true and false" do
+          before do
+            unit.instance_eval do
+              active_if any(:true, :false)
+            end
+          end
+          it { is_expected.to eq(true) }
         end
-        specify "all of defined conditions must pass" do
-          should be_false
+
+        context "when all conditions returned false" do
+          before do
+            unit.instance_eval do
+              active_if any(:false, :false)
+            end
+          end
+          it { is_expected.to eq(false) }
         end
       end
 
-      context "when block is passed" do
-        before do
-          unit.active_if(:true) { false }
+      describe ".none" do
+        context "when all conditions returned false" do
+          before do
+            unit.instance_eval do
+              active_if none(:false, :false)
+            end
+          end
+          it { is_expected.to eq(true) }
         end
-        specify "all of defined conditions and block must pass" do
-          should be_false
+
+        context "when conditions returned true and false" do
+          before do
+            unit.instance_eval do
+              active_if none(:true, :false)
+            end
+          end
+          it { is_expected.to eq(false) }
         end
       end
 
-      context "when any is specified" do
-        before do
-          unit.instance_eval do
-            active_if any(:true, :false)
+      context "when using 'any' and 'none'" do
+        context "'any' in 'none'" do
+          before do
+            unit.instance_eval do
+              active_if none(any(:true, :false))
+            end
+          end
+          it "returns negatived result of inner-expression" do
+            is_expected.to eq(false)
           end
         end
-        specify "any of conditions must pass" do
-          should be_true
+
+        context "'none' in 'any'" do
+          before do
+            unit.instance_eval do
+              active_if any(none(:true), :false)
+            end
+          end
+          it "uses none(:true) as false" do
+            is_expected.to eq(false)
+          end
+        end
+
+        context "more nested" do
+          before do
+            unit.instance_eval do
+              active_if any(any(none(:false), :false), :false)
+            end
+          end
+          it { is_expected.to eq(true) }
         end
       end
     end
@@ -65,13 +139,13 @@ module Chanko
     describe ".scope" do
       specify "given scope is recorded to used scope list" do
         unit.scope(:view) { }
-        unit.scopes.keys.should == [ActionView::Base]
+        expect(unit.scopes.keys).to eq([ActionView::Base])
       end
 
       context "in the scoped block" do
         specify "current_scope returns given scope" do
           unit.scope(:view) do
-            unit.current_scope.should == ActionView::Base
+            expect(unit.current_scope).to eq(ActionView::Base)
           end
         end
       end
@@ -79,7 +153,7 @@ module Chanko
       context "out of the scoped block" do
         specify "current_scope returns nil" do
           unit.scope(:view) { }
-          unit.current_scope.should == nil
+          expect(unit.current_scope).to eq(nil)
         end
       end
     end
@@ -91,16 +165,16 @@ module Chanko
             "test"
           end
         end
-        unit.scopes[ActionView::Base][:test].block.call.should == "test"
+        expect(unit.scopes[ActionView::Base][:test].block.call).to eq("test")
       end
     end
 
     describe ".shared" do
-      it "stroes given block with given label" do
+      it "stores given block with given label" do
         unit.shared(:test) do
           "test"
         end
-        unit.shared_methods[:test].call.should == "test"
+        expect(unit.shared_methods[:test].call).to eq("test")
       end
     end
 
@@ -111,7 +185,7 @@ module Chanko
             "test"
           end
         end
-        view.__example_unit_test.should == "test"
+        expect(view.__example_unit_test).to eq("test")
       end
     end
 
@@ -156,25 +230,25 @@ module Chanko
       end
 
       it "defines instance methods with prefix" do
-        ExampleModel.new.__example_unit_test.should == "test"
+        expect(ExampleModel.new.__example_unit_test).to eq("test")
       end
 
       it "defines class methods with prefix" do
-        ExampleModel.__example_unit_test.should == "test"
+        expect(ExampleModel.__example_unit_test).to eq("test")
       end
 
       it "defines scope method with prefix" do
-        ExampleModel.__example_unit_active.should == "scoped"
+        expect(ExampleModel.__example_unit_active).to eq("scoped")
       end
 
       it "defines has_one association method with prefix" do
-        ExampleModel.__example_unit_user.should == [:class_name => "User"]
+        expect(ExampleModel.__example_unit_user).to eq([:class_name => "User"])
       end
     end
 
     describe ".view_path" do
       it "returns path for its view directory" do
-        unit.view_path.should == "#{Config.units_directory_path}/example_unit/views"
+        expect(unit.view_path).to eq("#{Config.units_directory_path}/example_unit/views")
       end
     end
   end

data/spec/controllers/application_controller_spec.rb

@@ -7,8 +7,8 @@ describe ApplicationController do
     end
   end
 
-  it "clears cache before each request" do
-    Chanko::Loader.cache.should_receive(:clear).exactly(2)
+  it "clears cache before each request", classic: true do
+    expect(Chanko::Loader.cache).to receive(:clear).exactly(2)
     get :index
     get :index
   end

data/spec/dummy/README.md

@@ -0,0 +1,12 @@
+# Chanko example
+This is an example rails application using Chanko.
+This application has a unit called EntryDeletion,
+which extends MVC logics to provide a feature to delete entries.
+
+## Start
+```
+$ bundle install
+$ bundle exec rake db:create db:migrate
+$ rails s
+$ open http://localhost:3000
+```

data/spec/dummy/app/assets/config/manifest.js

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link_directory ../javascripts .js
+//= link_directory ../stylesheets .css

data/spec/dummy/app/controllers/entries_controller.rb

@@ -17,7 +17,7 @@ class EntriesController < ApplicationController
   end
 
   def create
-    @entry = Entry.create(params[:entry])
+    @entry = Entry.create(params[:entry].permit(:title, :body))
     redirect_to @entry
   end
 
@@ -27,7 +27,7 @@ class EntriesController < ApplicationController
 
   def update
     @entry = Entry.find(params[:id])
-    @entry.update_attributes(params[:entry])
+    @entry.update_attributes(params[:entry].permit(:title, :body))
     redirect_to @entry
   end
 end

data/spec/dummy/app/models/entry.rb

@@ -1,3 +1,2 @@
 class Entry < ActiveRecord::Base
-  attr_accessible :body, :deleted_at, :title
 end

data/spec/dummy/app/units/entry_deletion/entry_deletion.rb

@@ -26,6 +26,12 @@ module EntryDeletion
       def soft_delete
         update_attributes(:deleted_at => Time.now)
       end
+
+      class_methods do
+        def gc_all_soft_deleted_users
+          where.not(deleted_at: nil).delete_all
+        end
+      end
     end
   end
 

data/spec/dummy/config/application.rb

@@ -1,15 +1,9 @@
 require File.expand_path('../boot', __FILE__)
 
-# Pick the frameworks you want:
-require "active_record/railtie"
-require "action_controller/railtie"
-require "action_mailer/railtie"
-require "active_resource/railtie"
-require "sprockets/railtie"
-# require "rails/test_unit/railtie"
+require "rails/all"
 
 if defined?(Bundler)
-  Bundler.require(*Rails.groups(:assets => %w(development test)))
+  Bundler.require(:default, Rails.env)
 end
 
 require "chanko"
@@ -52,17 +46,21 @@ module Dummy
     # like if you have constraints or database-specific column types
     # config.active_record.schema_format = :sql
 
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    config.active_record.whitelist_attributes = true
-
-    # Enable the asset pipeline
-    config.assets.enabled = true
-
     # Version of your assets, change this if you want to expire all your assets
     config.assets.version = '1.0'
+    config.assets.quiet = true if ::Rails::VERSION::MAJOR >= 5
+    if Rails::VERSION::MAJOR >= 6
+      if ENV['AUTOLOADER'] == 'zeitwerk'
+        Chanko::Test.logger.info("Autoloader: zeitwerk")
+        config.autoloader = :zeitwerk
+      else
+        Chanko::Test.logger.info("Autoloader: classic")
+        config.autoloader = :classic
+      end
+    end
   end
 end
 
+if Rails::VERSION::MAJOR >= 6 && Rails.autoloaders.zeitwerk_enabled?
+  Rails.autoloaders.main.collapse(Rails.root.join('app', 'units', '*'))
+end

data/spec/dummy/config/boot.rb

@@ -1,10 +1,9 @@
 require 'rubygems'
-gemfile = File.expand_path('../../../../Gemfile', __FILE__)
 
-if File.exist?(gemfile)
-  ENV['BUNDLE_GEMFILE'] = gemfile
-  require 'bundler'
-  Bundler.setup
+unless ENV['BUNDLE_GEMFILE']
+  raise "Select Gemfile_x.rb from gemfiles dir then set BUNDLE_GEMFILE"
 end
 
+require 'bundler/setup'
+
 $:.unshift File.expand_path('../../../../lib', __FILE__)

data/spec/dummy/config/environment.rb

@@ -2,4 +2,4 @@
 require File.expand_path('../application', __FILE__)
 
 # Initialize the rails application
-Dummy::Application.initialize!
+Rails.application.initialize!

data/spec/dummy/config/environments/development.rb

@@ -6,9 +6,6 @@ Dummy::Application.configure do
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
@@ -19,19 +16,8 @@ Dummy::Application.configure do
   # Print deprecation notices to the Rails logger
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
-
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  config.active_record.auto_explain_threshold_in_seconds = 0.5
-
-  # Do not compress assets
-  config.assets.compress = false
-
   # Expands the lines which load the assets
   config.assets.debug = true
+
+  config.eager_load = false
 end

data/spec/dummy/config/environments/production.rb

@@ -9,7 +9,7 @@ Dummy::Application.configure do
   config.action_controller.perform_caching = true
 
   # Disable Rails's static asset server (Apache or nginx will already do this)
-  config.serve_static_assets = false
+  config.serve_static_files = false
 
   # Compress JavaScripts and CSS
   config.assets.compress = true
@@ -64,4 +64,8 @@ Dummy::Application.configure do
   # Log the query plan for queries taking more than this (works
   # with SQLite, MySQL, and PostgreSQL)
   # config.active_record.auto_explain_threshold_in_seconds = 0.5
+
+  config.eager_load = true
+
+  config.assets.js_compressor = :uglifier
 end

data/spec/dummy/config/environments/test.rb

@@ -8,12 +8,9 @@ Dummy::Application.configure do
   config.cache_classes = true
 
   # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
+  config.serve_static_files = true
   config.static_cache_control = "public, max-age=3600"
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
@@ -29,9 +26,15 @@ Dummy::Application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
+
+  if ENV['EAGER_LOAD'] == 'true'
+    Chanko::Test.logger.info("EagerLoad: on")
+    config.eager_load = true
+  else
+    Chanko::Test.logger.info("EagerLoad: off")
+    config.eager_load = false
+  end
+
 end

data/spec/dummy/config/initializers/secret_token.rb

@@ -5,3 +5,4 @@
 # Make sure the secret is at least 30 characters and all random,
 # no regular words or you'll be exposed to dictionary attacks.
 Dummy::Application.config.secret_token = '51ca37a6709156b59d667c092cd18abe392f137efb5e8be61287a5d38823e31d61470bb417098476092e5c53c52467e4a949163c6e78ce70e921ed928b39f9d8'
+Dummy::Application.config.secret_key_base = '24b191b073b60770ff32d8c0096a6786c8aa0c5f7c0968838f5321a0fbda49da3a567984ca3862f353b4cc408e1e23fedd1f3d808ae91965758239f19642a2e6'

data/spec/dummy/config/storage.yml

@@ -0,0 +1 @@
+

data/spec/fixtures/units/example_unit/example_unit.rb

@@ -29,6 +29,19 @@ module ExampleUnit
     function(:render) do
       render_to_string :partial => "/test", :locals => { :local => "test" }
     end
+
+    function(:nesting_locals_outer) do
+      result = "#{outer_one}."
+      result += invoke(:example_unit, :nesting_locals_inner, :locals => { :inner_one => "inner_one", :inner_two => "inner_two" }) do
+        "#{outer_two}.#{run_default}"
+      end
+      result += ".#{outer_three}"
+      result
+    end
+
+    function(:nesting_locals_inner) do
+      "#{inner_one}.#{run_default}.#{inner_two}"
+    end
   end
 
   scope(:view) do
@@ -60,6 +73,10 @@ module ExampleUnit
       unit.helper
     end
 
+    function(:respond_to_helper?) do
+      unit.respond_to?(:helper)
+    end
+
     function(:render) do
       render "/test", :local => "test"
     end

data/spec/fixtures/units/sensitive_inactive_unit/sensitive_inactive_unit.rb

@@ -0,0 +1,9 @@
+module SensitiveInactiveUnit
+  include Chanko::Unit
+  active_if { false }
+
+  scope(:controller) do
+    function(:outer) {}
+    function(:innner) {}
+  end
+end

data/spec/fixtures/units/sensitive_unit/sensitive_unit.rb

@@ -1,4 +1,20 @@
 module SensitiveUnit
   include Chanko::Unit
   raise_error
+
+  def self.ping
+  end
+
+  scope(:controller) do
+    function(:outer_default) do
+      invoke(:sensitive_unit, :inner_default) do
+        SensitiveUnit.ping
+        run_default
+      end
+    end
+
+    function(:inner_default) do
+      run_default
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,27 +1,57 @@
-require "simplecov"
-SimpleCov.start do
+require 'simplecov'
+
+SimpleCov.start 'rails' do
+  if ENV['CI']
+    require 'simplecov-lcov'
+    SimpleCov::Formatter::LcovFormatter.config do |c|
+      c.report_with_single_file = true
+      c.single_report_path = 'coverage/lcov.info'
+    end
+    formatter SimpleCov::Formatter::LcovFormatter
+  end
+
   add_filter "/spec\/fixtures/"
   add_filter "/spec\/dummy/"
 end
 
 ENV["RAILS_ENV"] ||= "test"
 require "chanko"
+require "chanko/test"
+Chanko::Config.units_directory_path = File.expand_path("../fixtures/units", __FILE__)
 
 require File.expand_path("../dummy/config/environment", __FILE__)
 require "rspec/rails"
-require "rspec/autorun"
 
 RSpec.configure do |config|
   config.use_transactional_fixtures = true
   config.infer_base_class_for_anonymous_controllers = false
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
 
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect
+  end
+
   config.after do
     Chanko::Config.reset
     Chanko::Config.units_directory_path = File.expand_path("../fixtures/units", __FILE__)
   end
+
+  # rspec-rails 3 will no longer automatically infer an example group's spec type
+  # from the file location. You can explicitly opt-in to the feature using this
+  # config option.
+  # To explicitly tag specs without using automatic inference, set the `:type`
+  # metadata manually:
+  #
+  #     describe ThingsController, :type => :controller do
+  #       # Equivalent to being in spec/controllers
+  #     end
+  config.infer_spec_type_from_file_location!
+
+  if Rails.respond_to?(:autoloaders) && Rails.autoloaders.zeitwerk_enabled?
+    config.filter_run_excluding classic: true
+  else
+    config.filter_run_excluding zeitwerk: true
+  end
 end
 
-Chanko::Config.units_directory_path = File.expand_path("../fixtures/units", __FILE__)