change-ruby 1.0.3 → 1.0.4

data/lib/change-ruby.rb

@@ -1,4 +1,5 @@
-# $LOAD_PATH << './lib' # Uncomment to load change-ruby in console without installing gem.
+# Uncomment to load change-ruby in console without installing gem. Then require './lib/change-ruby' in console
+# $LOAD_PATH << './lib'
 
 require 'digest/sha2'
 require 'httparty'

data/lib/requests/client.rb

@@ -38,12 +38,12 @@ module Change
       def deal_with_response(response)
         case response.code
         when 200, 202
-          response.parsed_response
+          ensure_parse(response.parsed_response)
         else
           messages = if response.code == 500
             ['A server error has occurred.']
           else
-            response.parsed_response['messages']
+            ensure_parse(response.parsed_response)['messages']
           end
 
           raise ChangeException.new(messages, response.code), messages.join(' '), caller
@@ -75,6 +75,16 @@ module Change
         HTTParty::HashConversions.to_params(params)
       end
 
+      # Change.org is currently not setting the content-type header
+      # as application/json when it's returning json, let's make sure strings
+      # are parsed as json...until Change.org fixes it.
+      def ensure_parse(supposedly_parsed_object)
+        if supposedly_parsed_object.is_a?(String)
+          HTTParty::Parser.call(supposedly_parsed_object, :json)
+        else
+          supposedly_parsed_object
+        end
+      end
     end
   end
 end

data/lib/resources/signature_collection.rb

@@ -9,6 +9,7 @@ module Change
       def add_signature(params = {}, auth_key_to_use = nil)
         auth_key_to_use ||= auth_key
         raise "No auth key specified." if auth_key_to_use.nil?
+        raise "Petition not loaded." if @parent_resource.id.nil?
         params[:auth_key_to_use] = auth_key_to_use
         params[:source] = auth_key_to_use['source']
         response = make_request(:collection, { :method => :post }, params)

data/test/signature_collection_resource_test.rb

@@ -35,7 +35,7 @@ describe 'SignatureCollection' do
 
       before do
         @test_key = 'my_test_key'
-        @parent_resource = Change::Resources::Petition.new(@client, { :auth_key => { 'auth_key' => @test_key } })
+        @parent_resource = Change::Resources::Petition.new(@client, { :id => 1, :auth_key => { 'auth_key' => @test_key } })
         @signature_collection = Change::Resources::SignatureCollection.new(@parent_resource)
       end
 
@@ -58,7 +58,7 @@ describe 'SignatureCollection' do
     describe "when there is no auth key on the parent resource" do
 
       before do
-        @parent_resource = Change::Resources::Petition.new(@client)
+        @parent_resource = Change::Resources::Petition.new(@client, { :id => 1 })
         @signature_collection = Change::Resources::SignatureCollection.new(@parent_resource)
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: change-ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,22 +9,27 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-05 00:00:00.000000000 Z
+date: 2013-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &2153892880 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - =
+    - - '='
       - !ruby/object:Gem::Version
         version: 0.10.2
   type: :runtime
   prerelease: false
-  version_requirements: *2153892880
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.10.2
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2153892400 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153892400
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &2153891840 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +53,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153891840
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Ruby library for the Change.org API.
 email: eric@ericlukoff.com
 executables: []
@@ -90,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Change.org API Ruby Library (unofficial)