challah 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0c5d55264692dddf543d5c67c2590a56ca95ba7e
-  data.tar.gz: f1c1b7db86c25987bc4ec369a9928a6ff6a2043a
+SHA256:
+  metadata.gz: 52c23a580c2dfe4d78653d75a44f1a1f5f0c54b3d62c7091ce0089621e35add4
+  data.tar.gz: 839e41cf3038d7e8319d476268abad5004a8adbbedcf5eba2fbb1119ddef9b23
 SHA512:
-  metadata.gz: 66d518430ab8db7e27eb0bfd6ef23681b7d49af39eb20baf77c88b1ae6d403db85e4a972e0b852e9408800e9dba5323a345d9fff85c3930d5025a87c730d53ae
-  data.tar.gz: 272d606557225f242aa605c09e4ac76a62d5e19e8672b0861abe71a2eee10c97c55a48958b7468f25d0876f6370ed864ad99379561238860188357816e2c7091
+  metadata.gz: f91ad595ae383d6775e533f1cc60053be1221d824ff351b6ea6f24a22eed1e9ea6ff3172f82f6930a7aa522e6e910d0bb3b0e3a86a457a5e5d79368196c86938
+  data.tar.gz: c5b43537d21543b4d9d3eb2aa3791b669c9d91c26050f4211a07c5bf7bea5f5b9f5081e0de239fb8519cef8c61fdba3e9a05bbf18ec2c5a2a3341b86011af93a

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## Challah 1.6.1
+
+* Prevent an email address that is blank from saving the `User#email_hash` attribute
+* Removes default column for `last_session_ip` that unnecessarily stores user IP addresses by default and could be considered a privacy concern. This column can be manually included in the migration to still track the user IP.
+
 ## Challah 1.6.0
 
 * For token technique, don't bother checking the database for an empty token query param

data/README.md

@@ -1,6 +1,6 @@
 # Challah
 
-[![Build Status](https://travis-ci.org/jdtornow/challah.svg?branch=master)](https://travis-ci.org/jdtornow/challah) [![Code Climate](https://codeclimate.com/github/jdtornow/challah/badges/gpa.svg)](https://codeclimate.com/github/jdtornow/challah) [![Dependency Status](https://gemnasium.com/jdtornow/challah.svg)](https://gemnasium.com/jdtornow/challah) [![Gem Version](https://badge.fury.io/rb/challah.svg)](https://badge.fury.io/rb/challah)
+[![Build Status](https://travis-ci.org/jdtornow/challah.svg?branch=master)](https://travis-ci.org/jdtornow/challah) [![Code Climate](https://codeclimate.com/github/jdtornow/challah/badges/gpa.svg)](https://codeclimate.com/github/jdtornow/challah) [![Gem Version](https://badge.fury.io/rb/challah.svg)](https://badge.fury.io/rb/challah)
 
 Challah (pronounced HAH-lah) is a simple Rails authentication gem that provides users a way to authenticate with your app. Most of the functionality within the gem lives within a Rails engine and tries to stay out of the way of your app.
 
@@ -10,7 +10,7 @@ Challah doesn't provide any fancy controllers or views that clutter your app or
 
 * Ruby 2.2.2+
 * Bundler
-* Rails 5.0+ (4.2 still supported, but not recommended)
+* Rails 5.0+
 
 ## Installation
 

data/VERSION

@@ -1 +1 @@
-1.6.0
+1.6.1

data/lib/challah/concerns/user/attributeable.rb

@@ -50,7 +50,7 @@ module Challah
     def ensure_email_hash_presence
       if respond_to?("email_hash=")
         if email_changed?
-          self.email_hash = Encrypter.md5(email.to_s.downcase.strip)
+          self.email_hash = generate_email_hash
         end
       end
     end
@@ -64,6 +64,12 @@ module Challah
       end
     end
 
+    def generate_email_hash
+      if self.email.present?
+        Encrypter.md5(email.to_s.downcase.strip)
+      end
+    end
+
     # Downcase email and strip if of whitespace
     # Ex: "   HELLO@example.com   " => "hello@example.com"
     def normalize_user_email

data/lib/challah/concerns/user/authenticateable.rb

@@ -35,9 +35,9 @@ module Challah
     # been authenticated.
     def successful_authentication!(ip_address = nil)
       self.last_session_at = Time.now
-      self.last_session_ip = ip_address
+      self.last_session_ip = ip_address if respond_to?(:last_session_ip=)
       self.save
       self.increment!(:session_count, 1)
     end
   end
-end
+end

data/lib/generators/templates/migration.rb

@@ -8,7 +8,6 @@ class ChallahCreateUsers < ActiveRecord::Migration<%= migration_version %>
       t.string      :persistence_token
       t.string      :api_key
       t.datetime    :last_session_at
-      t.string      :last_session_ip
       t.integer     :session_count, default: 0
       t.integer     :failed_auth_count, default: 0
       t.integer     :created_by, default: 0
@@ -31,7 +30,6 @@ class ChallahCreateUsers < ActiveRecord::Migration<%= migration_version %>
       t.string      :token, limit: 500
       t.datetime    :expires_at
       t.datetime    :last_session_at
-      t.string      :last_session_ip
       t.integer     :session_count, default: 0
       t.timestamps  null: true
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: challah
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - John Tornow
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-20 00:00:00.000000000 Z
+date: 2018-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -116,6 +116,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 description: A simple gem for authorization and session management in Rails.
 email:
 - john@johntornow.com
@@ -194,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.8.11
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Rails authentication and sessions