challah 0.7.0 → 0.7.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## Challah 0.7.1
+
+* Ensure users can be looked up by username as case insensitive value. Allows logins posted from iOS devices (with initial caps) to be valid usernames even when stored as caps.
+
 ## Challah 0.7.0
 
 * Removed roles and permissions functionality to keep the gem completely geared towards user authentication. In a future release this functionality will be added back into its own separate gem.

data/lib/challah/user.rb

@@ -69,7 +69,7 @@ module Challah
 
         result = nil
 
-        result = self.where(:username => username_or_email).first
+        result = self.where(:username => username_or_email.to_s.strip.downcase).first
 
         unless result
           if username_or_email.to_s.include?('@')
@@ -230,6 +230,9 @@ module Challah
           if self.username.to_s.blank? and !self.email.to_s.blank?
             self.username = self.email
           end
+
+          # Make sure username stored is always stripped of whitespace and downcased
+          self.username = self.username.to_s.strip.downcase
         end
 
         # validation call for new passwords, make sure the password is confirmed, and is >= 4 characters

data/lib/challah/version.rb

@@ -1,3 +1,3 @@
 module Challah
-  VERSION = "0.7.0" unless defined?(::Challah::VERSION)
+  VERSION = "0.7.1" unless defined?(::Challah::VERSION)
 end

data/test/user_test.rb

@@ -17,12 +17,15 @@ class UserTest < ActiveSupport::TestCase
 
   context "A User class" do
     should "find a user by username or email" do
-      user_one = create(:user, :username => 'test-user', :email => 'tester@example.com')
-      user_two = create(:user, :username => 'test-user-2', :email => 'tester2@example.com')
+      user_one = create(:user, :username => ' Test-user ', :email => 'tester@example.com')
+      user_two = create(:user, :username => 'test-user-2  ', :email => 'tester2@example.com')
 
       assert_equal user_one, ::User.find_for_session('test-user')
       assert_equal user_one, ::User.find_for_session('tester@example.com')
 
+      assert_equal user_one, ::User.find_for_session('Test-user')
+      assert_equal user_one, ::User.find_for_session('tester@example.com')
+
       assert_equal user_two, ::User.find_for_session('test-user-2')
       assert_equal user_two, ::User.find_for_session('tester2@example.com')
 
@@ -132,6 +135,13 @@ class UserTest < ActiveSupport::TestCase
       assert user.errors.full_messages.include?("Password does not match the confirmation password.")
     end
 
+    should "always lower case a username when setting" do
+      user = build(:user)
+      user.username = 'JimBob'
+      assert user.save
+      assert_equal 'jimbob', user.username
+    end
+
     should "authenticate through various means by default" do
       user = create(:user)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: challah
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-16 00:00:00.000000000Z
+date: 2012-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
-  requirement: &70126733377560 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70126733377560
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70126733376880 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70126733376880
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70126733376160 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: 0.9.2
   type: :runtime
   prerelease: false
-  version_requirements: *70126733376160
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.9.2
 - !ruby/object:Gem::Dependency
   name: bcrypt-ruby
-  requirement: &70126733375400 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +69,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70126733375400
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A simple Rails engine gem for authentication, authorization, users, roles
   and permissions.
 email:
@@ -5185,7 +5205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Simple authentication and authorization gem for Rails.