chake 0.21.1 → 0.82

data/README.shell.md

@@ -0,0 +1,30 @@
+chake-shell(7) -- configure chake nodes with shell
+==================================================
+
+## Description
+
+This configuration manager is a simpler wrapper for running a list of shell
+commands on the nodes.
+
+## Configuration
+
+The _shell_ configuration manager requires one key called `shell`, and the
+value must be a list of strings representing the list of commands to run on the
+node when converging.
+
+```yaml
+host1.mycompany.com:
+  shell:
+    - echo "HELLO WORLD"
+```
+
+## Bootstrapping
+
+Very little bootstrapping is required for this configuration manager, as we
+hope every node you could possibly want to manage with it already has a POSIX
+shell as `/bin/sh`. During bootstrapping, only the node hostname will be set
+according to your chake configuration.
+
+## See also
+
+* **chake(1)**

data/Rakefile

@@ -1,5 +1,5 @@
 namespace :bundler do
-  require "bundler/gem_tasks"
+  require 'bundler/gem_tasks'
 end
 
 task :test do
@@ -8,6 +8,8 @@ end
 
 pkg = Gem::Specification.load('chake.gemspec')
 
+task 'bundler:build' => :manifest
+
 task 'build:tarball' => 'bundler:build' do
   chdir 'pkg' do
     sh 'gem2tgz', "#{pkg.name}-#{pkg.version}.gem"
@@ -17,7 +19,7 @@ end
 desc 'Create Debian source package'
 task 'build:debsrc' => ['bundler:clobber', 'build:tarball'] do
   dirname = "#{pkg.name}-#{pkg.version}"
-  v = `git describe`.strip.gsub('-', '.').sub(/^v/, '')
+  v = `git describe`.strip.tr('-', '.').sub(/^v/, '')
   chdir 'pkg' do
     sh 'gem2deb', '--no-wnpp-check', '-s', '-p', pkg.name, "#{dirname}.tar.gz"
     sh "rename s/#{pkg.version}/#{v}/ *.orig.tar.gz"
@@ -31,7 +33,7 @@ task 'build:debsrc' => ['bundler:clobber', 'build:tarball'] do
 end
 
 desc 'Builds and installs Debian package'
-task 'deb:install' => 'build:debsrc'do
+task 'deb:install' => 'build:debsrc' do
   chdir "pkg/#{pkg.name}-#{pkg.version}" do
     sh 'dpkg-buildpackage --diff-ignore=version.rb -us -uc'
     sh 'debi'
@@ -48,7 +50,7 @@ end
 file 'pkg/chake.spec' => ['chake.spec.erb', 'lib/chake/version.rb'] do |t|
   require 'erb'
   pkg = Gem::Specification.load('chake.gemspec')
-  template =  ERB.new(File.read('chake.spec.erb'))
+  template = ERB.new(File.read('chake.spec.erb'))
   File.open(t.name, 'w') do |f|
     f.puts(template.result(binding))
   end
@@ -60,27 +62,51 @@ task 'build:all' => ['build:debsrc', 'build:rpmsrc']
 desc 'lists changes since last release'
 task :changelog do
   last_tag = `git tag | sort -V`.split.last
-  sh 'git', 'shortlog', last_tag + '..'
+  sh 'git', 'shortlog', "#{last_tag}.."
 end
 
 task :check_tag do
   last_tag = `git tag | sort -V`.split.last
   if last_tag == "v#{pkg.version}"
-    fail "Version #{pkg.version} was already released!"
+    raise "Version #{pkg.version} was already released!"
   end
 end
 
 desc 'checks if the latest release is properly documented in ChangeLog.md'
 task :check_changelog do
   begin
-    sh 'grep', '^#\s*' + pkg.version.to_s, 'ChangeLog.md'
-  rescue
+    sh 'grep', "^#\\s*#{pkg.version}", 'ChangeLog.md'
+  rescue StandardError
     puts "Version #{pkg.version} not documented in ChangeLog.md!"
     raise
   end
 end
 
+desc 'Updates manifest file'
+task :manifest do
+  manifest = File.read('.manifest')
+  git = `git ls-files`
+  if manifest != git
+    File.open('.manifest', 'w') { |f| f.write(git) }
+    sh 'git commit .manifest -m "Update manifest"'
+  end
+end
+
 desc 'Makes a release'
-task :release => [:check_tag, :check_changelog, :test, 'bundler:release']
+task release: [:check_tag, :check_changelog, :default, 'bundler:release']
+
+desc 'Check coding style'
+task :style do
+  sh 'rubocop'
+end
+
+desc 'Check spelling in the source code'
+task :codespell do
+  sh 'codespell', '--skip=.git', '--skip=coverage', '--skip=*.asc', '--skip=*.swp'
+end
+
+task default: [:test, :style, :codespell]
+
+task clean: 'bundler:clobber'
 
-task :default => :test
+load './man/Rakefile'

data/bin/chake

@@ -4,7 +4,7 @@ require 'rake'
 
 rakefiles = %w[rakefile Rakefile rakefile.rb Rakefile.rb]
 
-if (!rakefiles.any? { |f| File.exist?(f) }) && !ARGV.include?('-f') && !ARGV.include?('--rakefile')
+if rakefiles.none? { |f| File.exist?(f) } && !ARGV.include?('-f') && !ARGV.include?('--rakefile')
   require 'tmpdir'
   require 'fileutils'
 
@@ -24,7 +24,7 @@ end
 
 class Rake::Application
   alias orig_thread_pool thread_pool
-  def thread_pool             # :nodoc:
+  def thread_pool # :nodoc:
     if Chake.respond_to?(:nodes)
       @thread_pool ||= Rake::ThreadPool.new(Chake.nodes.size + 1)
     else

data/chake.gemspec

@@ -1,27 +1,27 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'chake/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "chake"
+  spec.name          = 'chake'
   spec.version       = Chake::VERSION
-  spec.authors       = ["Antonio Terceiro"]
-  spec.email         = ["terceiro@softwarelivre.org"]
-  spec.summary       = %q{serverless configuration management tool for chef}
-  spec.description   = %q{chake allows one to manage a number of hosts via SSH by combining chef (solo) and rake. It doesn't require a chef server; all you need is a workstation from where you can SSH into all your hosts. chake automates copying the configuration management repository to the target host (including managing encrypted files), running chef on them, and running arbitrary commands on the hosts.}
-  spec.homepage      = "https://gitlab.com/terceiro/chake"
-  spec.license       = "MIT"
+  spec.authors       = ['Antonio Terceiro']
+  spec.email         = ['terceiro@softwarelivre.org']
+  spec.summary       = 'serverless configuration management tool for chef'
+  spec.description   = "chake allows one to manage a number of hosts via SSH by combining chef (solo) and rake. It doesn't require a chef server; all you need is a workstation from where you can SSH into all your hosts. chake automates copying the configuration management repository to the target host (including managing encrypted files), running chef on them, and running arbitrary commands on the hosts."
+  spec.homepage      = 'https://gitlab.com/terceiro/chake'
+  spec.license       = 'MIT'
 
-  spec.files         = Dir['**/*'] - Dir['pkg/**/*']
+  spec.files         = File.read('.manifest').split("\n") + ['.manifest']
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "asciidoctor", '>= 1.5.5'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'ronn-ng'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'simplecov'
 
-  spec.add_dependency "rake"
+  spec.add_dependency 'rake'
 end

data/examples/test/.ssh_config

@@ -0,0 +1,4 @@
+Host test.local
+  IdentityFile .vagrant/machines/default/libvirt/private_key
+
+# vim: ft=sshconfig

data/examples/test/Rakefile

@@ -1,4 +1,4 @@
-$:.unshift '../../lib' # this shouldn't be needed when you have chake installed
+$LOAD_PATH.unshift '../../lib' # this shouldn't be needed when you have chake installed
 require 'chake'
 
 manifest = %w[

data/examples/test/Vagrantfile

@@ -1,70 +1,6 @@
 # -*- mode: ruby -*-
 # vi: set ft=ruby :
 
-# All Vagrant configuration is done below. The "2" in Vagrant.configure
-# configures the configuration version (we support older styles for
-# backwards compatibility). Please don't change it unless you know what
-# you're doing.
 Vagrant.configure('2') do |config|
-  # The most common configuration options are documented and commented below.
-  # For a complete reference, please see the online documentation at
-  # https://docs.vagrantup.com.
-
-  # Every Vagrant development environment requires a box. You can search for
-  # boxes at https://vagrantcloud.com/search.
   config.vm.box = 'debian/buster64'
-
-  # Disable automatic box update checking. If you disable this, then
-  # boxes will only be checked for updates when the user runs
-  # `vagrant box outdated`. This is not recommended.
-  # config.vm.box_check_update = false
-
-  # Create a forwarded port mapping which allows access to a specific port
-  # within the machine from a port on the host machine. In the example below,
-  # accessing "localhost:8080" will access port 80 on the guest machine.
-  # NOTE: This will enable public access to the opened port
-  # config.vm.network "forwarded_port", guest: 80, host: 8080
-
-  # Create a forwarded port mapping which allows access to a specific port
-  # within the machine from a port on the host machine and only allow access
-  # via 127.0.0.1 to disable public access
-  # config.vm.network "forwarded_port", guest: 80, host: 8080, host_ip: "127.0.0.1"
-
-  # Create a private network, which allows host-only access to the machine
-  # using a specific IP.
-  # config.vm.network "private_network", ip: "192.168.33.10"
-
-  # Create a public network, which generally matched to bridged network.
-  # Bridged networks make the machine appear as another physical device on
-  # your network.
-  # config.vm.network "public_network"
-
-  # Share an additional folder to the guest VM. The first argument is
-  # the path on the host to the actual folder. The second argument is
-  # the path on the guest to mount the folder. And the optional third
-  # argument is a set of non-required options.
-  # config.vm.synced_folder "../data", "/vagrant_data"
-
-  # Provider-specific configuration so you can fine-tune various
-  # backing providers for Vagrant. These expose provider-specific options.
-  # Example for VirtualBox:
-  #
-  # config.vm.provider "virtualbox" do |vb|
-  #   # Display the VirtualBox GUI when booting the machine
-  #   vb.gui = true
-  #
-  #   # Customize the amount of memory on the VM:
-  #   vb.memory = "1024"
-  # end
-  #
-  # View the documentation for the provider you are using for more
-  # information on available options.
-
-  # Enable provisioning with a shell script. Additional provisioners such as
-  # Ansible, Chef, Docker, Puppet and Salt are also available. Please see the
-  # documentation for more information about their specific syntax and use.
-  # config.vm.provision "shell", inline: <<-SHELL
-  #   apt-get update
-  #   apt-get install -y apache2
-  # SHELL
 end

data/examples/test/config.rb

@@ -1,4 +1,4 @@
-root = File.expand_path(File.dirname(__FILE__))
-file_cache_path   root + '/cache'
-cookbook_path     root + '/cookbooks'
-role_path         root + '/config/roles'
+root = __dir__
+file_cache_path   "#{root}/cache"
+cookbook_path     "#{root}/cookbooks"
+role_path         "#{root}/config/roles"

data/lib/chake.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'yaml'
 require 'json'
 require 'tmpdir'
@@ -7,159 +5,117 @@ require 'tmpdir'
 require 'chake/config'
 require 'chake/version'
 require 'chake/readline'
-require 'chake/tmpdir'
-
-
-desc "Initializes current directory with sample structure"
-task :init do
-  if File.exists?('nodes.yaml')
-    puts '[exists] nodes.yaml'
-  else
-    File.open('nodes.yaml', 'w') do |f|
-      sample_nodes = <<EOF
-host1.mycompany.com:
-  run_list:
-    - recipe[basics]
-EOF
-      f.write(sample_nodes)
-      puts "[create] nodes.yaml"
-    end
-  end
-
-  if File.exist?('nodes.d')
-    puts '[exists] nodes.d/'
-  else
-    FileUtils.mkdir_p 'nodes.d'
-    puts '[ mkdir] nodes.d/'
-  end
-
-
-  if File.exists?('config.rb')
-    puts '[exists] config.rb'
-  else
-    File.open('config.rb', 'w') do |f|
-      f.puts "root = File.expand_path(File.dirname(__FILE__))"
-      f.puts "file_cache_path   root + '/cache'"
-      f.puts "cookbook_path     root + '/cookbooks'"
-      f.puts "role_path         root + '/config/roles'"
-    end
-    puts "[create] config.rb"
-  end
-
-  if !File.exist?('config/roles')
-    FileUtils.mkdir_p 'config/roles'
-    puts  '[ mkdir] config/roles'
-  end
-  if !File.exist?('cookbooks/basics/recipes')
-    FileUtils.mkdir_p 'cookbooks/basics/recipes/'
-    puts  '[ mkdir] cookbooks/basics/recipes/'
-  end
-  recipe = 'cookbooks/basics/recipes/default.rb'
-  if File.exists?(recipe)
-    puts "[exists] #{recipe}"
-  else
-    File.open(recipe, 'w') do |f|
-      f.puts "package 'openssh-server'"
-    end
-    puts "[create] #{recipe}"
-  end
-  if File.exists?('Rakefile')
-    puts '[exists] Rakefile'
-  else
-    File.open('Rakefile', 'w') do |f|
-      f.puts 'require "chake"'
-      puts '[create] Rakefile'
-    end
+require 'chake/wipe'
+
+desc 'Initializes current directory with sample structure'
+task init: 'init:itamae'
+Chake::ConfigManager.all.map do |cfgmgr|
+  desc "Initializes current directory for #{cfgmgr.short_name}"
+  task "init:#{cfgmgr.short_name}" do
+    cfgmgr.init
   end
 end
 
 desc 'list nodes'
 task :nodes do
+  fields = %i[hostname connection config_manager]
+  lengths = fields.map do |f|
+    [f.length, Chake.nodes.map { |n| n.send(f).to_s.length }.max].max
+  end
+  columns = lengths.map { |l| "%-#{l}s" }.join(' ')
+  puts(columns % fields)
+  puts(columns % lengths.map { |l| '-' * l })
   Chake.nodes.each do |node|
-    puts "%-40s %-5s\n" % [node.hostname, node.backend]
+    puts(columns % fields.map { |f| node.send(f) })
   end
 end
 
 def encrypted_for(node)
-  encrypted_files = Dir.glob("**/files/{default,host-#{node}}/*.{asc,gpg}") + Dir.glob("**/files/*.{asc,gpg}")
-  encrypted_files.inject({}) do |hash, key|
+  encrypted_files = Dir.glob("**/files/{default,host-#{node}}/*.{asc,gpg}") + Dir.glob('**/files/*.{asc,gpg}')
+  encrypted_files.each_with_object({}) do |key, hash|
     hash[key] = key.sub(/\.(asc|gpg)$/, '')
-    hash
   end
 end
 
-def if_files_changed(node, group_name, files)
-  if files.empty?
-    return
+def maybe_decrypt(node)
+  if node.needs_upload?
+    return yield
+  end
+
+  files = encrypted_for(node.hostname)
+  files.each do |encrypted, target|
+    sh "gpg --use-agent --quiet --decrypt --output #{target} #{encrypted}"
+  end
+  begin
+    yield
+  ensure
+    files.each do |_, target|
+      Chake::Wipe.instance.wipe(target)
+    end
   end
-  hash_io = IO.popen(['xargs', 'sha1sum'], 'w+')
+end
+
+def if_files_changed(node, group_name, files)
+  return if files.empty?
+
+  hash_io = IO.popen(%w[xargs sha1sum], 'w+')
   files.sort.each { |f| hash_io.puts(f) }
   hash_io.close_write
   current_hash = hash_io.read
 
-  hash_file = File.join(Chake.tmpdir, node + '.' + group_name + '.sha1sum')
+  hash_file = File.join(Chake.tmpdir, "#{node}.#{group_name}.sha1sum")
   hash_on_disk = nil
-  if File.exists?(hash_file)
-    hash_on_disk = File.read(hash_file)
-  end
+  hash_on_disk = File.read(hash_file) if File.exist?(hash_file)
 
-  if current_hash != hash_on_disk
-    yield
-  end
+  yield if current_hash != hash_on_disk
   FileUtils.mkdir_p(File.dirname(hash_file))
   File.open(hash_file, 'w') do |f|
     f.write(current_hash)
   end
 end
 
-
 def write_json_file(file, data)
-  File.chmod(0600, file) if File.exists?(file)
-  File.open(file, 'w', 0600) do |f|
+  File.chmod(0o600, file) if File.exist?(file)
+  File.open(file, 'w', 0o600) do |f|
     f.write(JSON.pretty_generate(data))
     f.write("\n")
   end
 end
 
-bootstrap_steps = Dir.glob(File.expand_path('chake/bootstrap/*.sh', File.dirname(__FILE__))).sort
-
 desc 'Executed before bootstrapping'
-task :bootstrap_common => :connect_common
+task bootstrap_common: :connect_common
 
 desc 'Executed before uploading'
-task :upload_common => :connect_common
+task upload_common: :connect_common
 
 desc 'Executed before uploading'
-task :converge_common => :connect_common
+task converge_common: :connect_common
 
 desc 'Executed before connecting to any host'
 task :connect_common
 
 Chake.nodes.each do |node|
+  node.silent = Rake.application.options.silent
 
   hostname = node.hostname
-  bootstrap_script = File.join(Chake.tmpdir, 'bootstrap-' + hostname)
-
-  file bootstrap_script => bootstrap_steps do |t|
-    mkdir_p(File.dirname(bootstrap_script))
-    File.open(t.name, 'w') do |f|
-      f.puts '#!/bin/sh'
-      f.puts 'set -eu'
-      bootstrap_steps.each do |platform|
-        f.puts(File.read(platform))
-      end
-    end
-    chmod 0755, t.name
-  end
+
+  bootstrap_script = File.join(Chake.tmpdir, "#{hostname}.bootstrap")
+
+  bootstrap_steps = node.bootstrap_steps
+
+  bootstrap_code = (["#!/bin/sh\n", "set -eu\n"] + bootstrap_steps.map { |f| File.read(f) }).join
 
   desc "bootstrap #{hostname}"
-  task "bootstrap:#{hostname}" => [:bootstrap_common, bootstrap_script] do
-    config = File.join(Chake.tmpdir, hostname + '.json')
+  task "bootstrap:#{hostname}" => :bootstrap_common do
+    mkdir_p Chake.tmpdir unless File.directory?(Chake.tmpdir)
+    if !File.exist?(bootstrap_script) || File.read(bootstrap_script) != bootstrap_code
+
+      # create bootstrap script
+      File.open(bootstrap_script, 'w') do |f|
+        f.write(bootstrap_code)
+      end
+      chmod 0o755, bootstrap_script
 
-    if File.exists?(config)
-      # already bootstrapped, just overwrite
-      write_json_file(config, node.data)
-    else
       # copy bootstrap script over
       scp = node.scp
       target = "/tmp/.chake-bootstrap.#{Etc.getpwuid.name}"
@@ -167,28 +123,29 @@ Chake.nodes.each do |node|
 
       # run bootstrap script
       node.run_as_root("#{target} #{hostname}")
-
-      # overwrite config with current contents
-      mkdir_p File.dirname(config)
-      write_json_file(config, node.data)
     end
 
+    # overwrite config with current contents
+    config = File.join(Chake.tmpdir, "#{hostname}.json")
+    write_json_file(config, node.data)
   end
 
   desc "upload data to #{hostname}"
   task "upload:#{hostname}" => :upload_common do
+    next unless node.needs_upload?
+
     encrypted = encrypted_for(hostname)
-    rsync_excludes = (encrypted.values + encrypted.keys).map { |f| ["--exclude", f] }.flatten
-    rsync_excludes << "--exclude" << ".git/"
-    rsync_excludes << "--exclude" << "cache/"
-    rsync_excludes << "--exclude" << "nodes/"
-    rsync_excludes << "--exclude" << "local-mode-cache/"
+    rsync_excludes = (encrypted.values + encrypted.keys).map { |f| ['--exclude', f] }.flatten
+    rsync_excludes << '--exclude' << '.git/'
+    rsync_excludes << '--exclude' << 'cache/'
+    rsync_excludes << '--exclude' << 'nodes/'
+    rsync_excludes << '--exclude' << 'local-mode-cache/'
 
-    rsync = node.rsync + ["-avp"] + ENV.fetch('CHAKE_RSYNC_OPTIONS', '').split
+    rsync = node.rsync + ['-avp'] + ENV.fetch('CHAKE_RSYNC_OPTIONS', '').split
     rsync_logging = Rake.application.options.silent && '--quiet' || '--verbose'
 
     hash_files = Dir.glob(File.join(Chake.tmpdir, '*.sha1sum'))
-    files = Dir.glob("**/*").select { |f| !File.directory?(f) } - encrypted.keys - encrypted.values - hash_files
+    files = Dir.glob('**/*').reject { |f| File.directory?(f) } - encrypted.keys - encrypted.values - hash_files
     if_files_changed(hostname, 'plain', files) do
       sh *rsync, '--delete', rsync_logging, *rsync_excludes, './', node.rsync_dest
     end
@@ -199,14 +156,14 @@ Chake.nodes.each do |node|
           target = File.join(tmpdir, target_file)
           mkdir_p(File.dirname(target))
           rm_f target
-          File.open(target, 'w', 0400) do |output|
+          File.open(target, 'w', 0o400) do |output|
             IO.popen(['gpg', '--quiet', '--batch', '--use-agent', '--decrypt', encrypted_file]) do |data|
               output.write(data.read)
             end
           end
           puts "#{target} (decrypted)"
         end
-        sh *rsync, rsync_logging, tmpdir + '/', node.rsync_dest
+        sh *rsync, rsync_logging, "#{tmpdir}/", node.rsync_dest
       end
     end
   end
@@ -215,19 +172,21 @@ Chake.nodes.each do |node|
 
   desc "converge #{hostname}"
   task "converge:#{hostname}" => converge_dependencies do
-    chef_logging = Rake.application.options.silent && '-l fatal' || ''
-    node.run_as_root "sh -c 'rm -f #{node.path}/nodes/*.json && chef-solo -c #{node.path}/#{Chake.chef_config} #{chef_logging} -j #{node.path}/#{Chake.tmpdir}/#{hostname}.json'"
+    maybe_decrypt(node) do
+      node.converge
+    end
   end
 
   desc 'apply <recipe> on #{hostname}'
-  task "apply:#{hostname}", [:recipe] => [:recipe_input, :connect_common] do |task, args|
-    chef_logging = Rake.application.options.silent && '-l fatal' || ''
-    node.run_as_root "sh -c 'rm -f #{node.path}/nodes/*.json && chef-solo -c #{node.path}/#{Chake.chef_config} #{chef_logging} -j #{node.path}/#{Chake.tmpdir}/#{hostname}.json --override-runlist recipe[#{$recipe_to_apply}]'"
+  task "apply:#{hostname}", [:recipe] => %i[recipe_input connect_common] do |_task, _args|
+    maybe_decrypt(node) do
+      node.apply($recipe_to_apply)
+    end
   end
   task "apply:#{hostname}" => converge_dependencies
 
   desc "run a command on #{hostname}"
-  task "run:#{hostname}", [:command] => [:run_input, :connect_common] do
+  task "run:#{hostname}", [:command] => %i[run_input connect_common] do
     node.run($cmd_to_run)
   end
 
@@ -240,32 +199,31 @@ Chake.nodes.each do |node|
   task "check:#{hostname}" => :connect_common do
     node.run('sudo echo OK')
   end
-
 end
 
-task :run_input, :command do |task,args|
+task :run_input, :command do |_task, args|
   $cmd_to_run = args[:command]
-  if !$cmd_to_run
-    puts "# Enter command to run (use arrow keys for history):"
+  unless $cmd_to_run
+    puts '# Enter command to run (use arrow keys for history):'
     $cmd_to_run = Chake::Readline::Commands.readline
   end
   if !$cmd_to_run || $cmd_to_run.strip == ''
     puts
-    puts "I: no command provided, operation aborted."
+    puts 'I: no command provided, operation aborted.'
     exit(1)
   end
 end
 
-task :recipe_input, :recipe do |task,args|
+task :recipe_input, :recipe do |_task, args|
   $recipe_to_apply = args[:recipe]
 
-  if !$recipe_to_apply
+  unless $recipe_to_apply
     recipes = Dir['**/*/recipes/*.rb'].map do |f|
       f =~ %r{(.*/)?(.*)/recipes/(.*).rb$}
-      cookbook = $2
-      recipe = $3
+      cookbook = Regexp.last_match(2)
+      recipe = Regexp.last_match(3)
       recipe = nil if recipe == 'default'
-      [cookbook,recipe].compact.join('::')
+      [cookbook, recipe].compact.join('::')
     end.sort
     puts 'Available recipes:'
 
@@ -276,43 +234,43 @@ task :recipe_input, :recipe do |task,args|
     $recipe_to_apply = Chake::Readline::Recipes.readline
     if !$recipe_to_apply || $recipe_to_apply.empty?
       puts
-      puts "I: no recipe provided, operation aborted."
+      puts 'I: no recipe provided, operation aborted.'
       exit(1)
     end
-    if !recipes.include?($recipe_to_apply)
+    unless recipes.include?($recipe_to_apply)
       abort "E: no such recipe: #{$recipe_to_apply}"
     end
   end
 end
 
-desc "upload to all nodes"
-multitask :upload => Chake.nodes.map { |node| "upload:#{node.hostname}" }
+desc 'upload to all nodes'
+multitask upload: Chake.nodes.map { |node| "upload:#{node.hostname}" }
 
-desc "bootstrap all nodes"
-multitask :bootstrap => Chake.nodes.map { |node| "bootstrap:#{node.hostname}" }
+desc 'bootstrap all nodes'
+multitask bootstrap: Chake.nodes.map { |node| "bootstrap:#{node.hostname}" }
 
-desc "converge all nodes (default)"
-multitask "converge" => Chake.nodes.map { |node| "converge:#{node.hostname}" }
+desc 'converge all nodes (default)'
+multitask 'converge' => Chake.nodes.map { |node| "converge:#{node.hostname}" }
 
-desc "Apply <recipe> on all nodes"
-multitask "apply", [:recipe] => Chake.nodes.map { |node| "apply:#{node.hostname}" }
+desc 'Apply <recipe> on all nodes'
+multitask 'apply', [:recipe] => Chake.nodes.map { |node| "apply:#{node.hostname}" }
 
-desc "run <command> on all nodes"
+desc 'run <command> on all nodes'
 multitask :run, [:command] => Chake.nodes.map { |node| "run:#{node.hostname}" }
 
-task :default => :converge
+task default: :converge
 
 desc 'checks connectivity and setup on all nodes'
-multitask :check => (Chake.nodes.map { |node| "check:#{node.hostname}" }) do
-  puts "✓ all hosts OK"
-  puts "  - ssh connection works"
-  puts "  - password-less sudo works"
+multitask check: (Chake.nodes.map { |node| "check:#{node.hostname}" }) do
+  puts '✓ all hosts OK'
+  puts '  - ssh connection works'
+  puts '  - password-less sudo works'
 end
 
 desc 'runs a Ruby console in the chake environment'
 task :console do
   require 'irb'
-  IRB.setup(eval("__FILE__"), argv: [])
+  IRB.setup('__FILE__', argv: [])
   workspace = IRB::WorkSpace.new(self)
 
   puts 'chake - interactive console'