cfonb 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 057c580fc124d3731dc852832c8c6f601584bbd235604fd5c44605b4509429c0
-  data.tar.gz: 037c88124d45e136b909660a8ef7f840a03fa5a7bc06c9e19e592e2eb67080a5
+  metadata.gz: dc4cf0c8e232fa1e00ee5bce36bd4c08c794c10f11c0ebdc003656acd76b55a9
+  data.tar.gz: b0cb3d056013926111232aee3d88405b39f828aa91fa2d1376f9352a25d7dd87
 SHA512:
-  metadata.gz: b803bf7c0a2c0803e7ae54ea937d3ccb06eeeced3f7dcc033ce202a658137c41da085adf462c2ebcf9d76352cb3990467a45deeaf0a80ad6c86b713a9733248e
-  data.tar.gz: 02c6b90c2732f5da3b481ec2c9b811b17377d0a7e602780d2048baf86499c3115abe4fcff98cd1cf454a80967565167aa6475fd53cc8442e43c14ddad79d89a4
+  metadata.gz: 778ef5f41ef6e3bbee2b9559027846b40075dc1550d54730bfb1af6d1f6760b44cb2b5b434dbf3e91734972d92e3668f2937b973a2d76e40207bff91d512f385
+  data.tar.gz: 3f1d6d72236faf46f2ff7ac120f31d7e6892498b2109e6c0b1bc4f5ed49a5bdf0063dc43bfc7a4342e756fd14edb83594a609b6fe3277ce214a502fab6e9bd22

data/lib/cfonb/operation_details/base.rb

@@ -7,7 +7,7 @@ module CFONB
         base.singleton_class.prepend(
           Module.new do
             def apply(details, line)
-              code = :"@#{line.detail_code}"
+              code = :"@#{line.detail_code.gsub(' ', '_')}"
               details.instance_variable_set(code, instance_value(details, line, code))
 
               super

data/lib/cfonb/operation_details/unknown.rb

@@ -2,12 +2,15 @@
 
 module CFONB
   module OperationDetails
-    class Unknown < Base
-      ATTRIBUTES = %i[unknown].freeze
-
+    class Unknown
       def self.apply(details, line)
-        details.unknown ||= {}
-        code = line.detail_code
+        unless details.instance_variable_defined?(:@unknown)
+          details.instance_variable_set(:@unknown, {})
+
+          details.class.attr_accessor :unknown
+        end
+
+        code = line.detail_code.gsub(' ', '_')
 
         details.unknown[code] =
           if details.unknown[code] && line.detail.is_a?(String)

data/lib/cfonb/operation_details.rb

@@ -15,7 +15,7 @@ module CFONB
     end
 
     def self.for(line)
-      return unless line.respond_to?(:detail_code)
+      return unless line.respond_to?(:detail_code) && line.detail_code != ''
 
       @details[line.detail_code] || Unknown
     end

data/spec/cfonb/operation_spec.rb

@@ -276,8 +276,8 @@ describe CFONB::Operation do
     context 'with an unknown detail' do
       let(:detail) do
         OpenStruct.new(
-          body: '0530004411001871EUR2 0001016255614090823     AAAEUR200000000000740',
-          detail_code: 'AAA',
+          body: '0530004411001871EUR2 0001016255614090823     A AEUR200000000000740',
+          detail_code: 'A A',
           detail: 'EUR200000000000740',
         )
       end
@@ -285,14 +285,25 @@ describe CFONB::Operation do
       it 'adds the detail to the unknown details hash' do
         operation.merge_detail(detail)
 
-        expect(operation.details.unknown).to eq({ 'AAA' => 'EUR200000000000740' })
+        expect(operation.details.unknown).to eq({ 'A_A' => 'EUR200000000000740' })
       end
 
       it 'updates the current details in case of duplicated codes' do
         operation.merge_detail(detail)
         operation.merge_detail(detail)
 
-        expect(operation.details.unknown).to eq({ 'AAA' => "EUR200000000000740\nEUR200000000000740" })
+        expect(operation.details.unknown).to eq({ 'A_A' => "EUR200000000000740\nEUR200000000000740" })
+      end
+
+      it 'does not add any detail if they are empty' do
+        detail = OpenStruct.new(
+          body: '0530004411001871EUR2 0001016255614090823',
+          detail_code: '',
+          detail: 'EUR200000000000740',
+        )
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to be_nil
       end
     end
   end

data/spec/cfonb/parser_spec.rb

@@ -53,6 +53,8 @@ describe CFONB::Parser do
             'AAA' => "INTERNETA AAA\nINTERNETA ABB",
             'BBB' => 'INTERNETE BBB',
             'CCC' => 'INTERNETI CCC',
+            'N_Y' => 'EXAMPLE WITH EMPTY SPACE',
+            '2\'C' => 'EXAMPLE WITH OTHER COMBINATIONS',
           },
         )
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfonb
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Johan Le Bray
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-05 00:00:00.000000000 Z
+date: 2025-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: license_finder