cfonb 1.0.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f80902862080f864dd6e69edc2f15d1d07d863fef754f47eb70bf052d4628cc2
-  data.tar.gz: 3258fdf0214ee434a09643ce033cc4fbf56500ad5d3633b3e424ed36f0d0a93d
+  metadata.gz: '09ba2c778bfad0f2b60f224bd4e13a67b9cb15d3f02062036c0a9ae7ed407b9e'
+  data.tar.gz: 13430b0b63638d05fc0127780b767bc746cdd5caaa65a671d017c4339111e63d
 SHA512:
-  metadata.gz: f0b35b9c4d7aa76957195c087e26f9777dad59308fcdb12a02c77da031d86798c726b3dc90e9fb9756c995414d34ce92f7d35638bed80fe10f5ff5c64e332659
-  data.tar.gz: b55fa730f6659cd878fa46a965a832bc3eb3b26e0fca3182a43af4b04bb4827995d73bfee61c7c1cb39674f01074f31a255ab060caf3fd0b3c0dc05a9c563f46
+  metadata.gz: '097f4da9225e785f732dbedcd31e2465c2794a9533dbbaa4dd64d70f11cac80d2e57dbcc9f1346c72d055c351884649ded431b49114b4da4a9156155ac2d2eae'
+  data.tar.gz: eb270fd78d5cbbf9c1a05779f876859544687891099ecbf9236e42a7230da8f7b6b2c0ab4831495279e137919adcb8273d9a755b0b68e8d6440c02d5ab846c56

data/lib/cfonb/operation_details/base.rb

@@ -7,10 +7,23 @@ module CFONB
         base.singleton_class.prepend(
           Module.new do
             def apply(details, line)
-              details.instance_variable_set(:"@#{line.detail_code}", line.detail)
+              code = :"@#{line.detail_code.gsub(' ', '_')}"
+              details.instance_variable_set(code, instance_value(details, line, code))
 
               super
             end
+
+            private
+
+            def append_detail?(details, line, code)
+              details.instance_variable_defined?(code) && line.detail.is_a?(String)
+            end
+
+            def instance_value(details, line, code)
+              return line.detail unless append_detail?(details, line, code)
+
+              details.instance_variable_get(code) + "\n#{line.detail}"
+            end
           end,
         )
       end

data/lib/cfonb/operation_details/ibe.rb

@@ -7,7 +7,7 @@ module CFONB
 
       def self.apply(details, line)
         details.creditor_identifier = line.detail[0..34].strip
-        details.creditor_identifier_type = line.detail[35..-1].strip
+        details.creditor_identifier_type = line.detail[35..-1]&.strip
       end
 
       CFONB::OperationDetails.register('IBE', self)

data/lib/cfonb/operation_details/ipy.rb

@@ -7,7 +7,7 @@ module CFONB
 
       def self.apply(details, line)
         details.debtor_identifier = line.detail[0..34].strip
-        details.debtor_identifier_type = line.detail[35..-1].strip
+        details.debtor_identifier_type = line.detail[35..-1]&.strip
       end
 
       CFONB::OperationDetails.register('IPY', self)

data/lib/cfonb/operation_details/unknown.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class Unknown < Base
+      ATTRIBUTES = %i[unknown].freeze
+
+      def self.apply(details, line)
+        details.unknown ||= {}
+        code = line.detail_code.gsub(' ', '_')
+
+        details.unknown[code] =
+          if details.unknown[code] && line.detail.is_a?(String)
+            details.unknown[code] + "\n#{line.detail}"
+          else
+            line.detail
+          end
+      end
+
+      CFONB::OperationDetails.register('Unknown', self)
+    end
+  end
+end

data/lib/cfonb/operation_details.rb

@@ -15,7 +15,9 @@ module CFONB
     end
 
     def self.for(line)
-      @details[line.detail_code]
+      return unless line.respond_to?(:detail_code) && line.detail_code != ''
+
+      @details[line.detail_code] || Unknown
     end
   end
 end

data/lib/cfonb.rb

@@ -32,6 +32,7 @@ require_relative 'cfonb/operation_details/fee'
 require_relative 'cfonb/operation_details/ibe'
 require_relative 'cfonb/operation_details/npo'
 require_relative 'cfonb/operation_details/nbu'
+require_relative 'cfonb/operation_details/unknown'
 
 module CFONB
   def self.parse(input, optimistic: false)

data/spec/cfonb/operation_spec.rb

@@ -272,6 +272,40 @@ describe CFONB::Operation do
         expect(operation.details.ultimate_creditor).to eq('Patrick')
       end
     end
+
+    context 'with an unknown detail' do
+      let(:detail) do
+        OpenStruct.new(
+          body: '0530004411001871EUR2 0001016255614090823     A AEUR200000000000740',
+          detail_code: 'A A',
+          detail: 'EUR200000000000740',
+        )
+      end
+
+      it 'adds the detail to the unknown details hash' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to eq({ 'A_A' => 'EUR200000000000740' })
+      end
+
+      it 'updates the current details in case of duplicated codes' do
+        operation.merge_detail(detail)
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to eq({ 'A_A' => "EUR200000000000740\nEUR200000000000740" })
+      end
+
+      it 'does not add any detail if they are empty' do
+        detail = OpenStruct.new(
+          body: '0530004411001871EUR2 0001016255614090823',
+          detail_code: '',
+          detail: 'EUR200000000000740',
+        )
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to be_nil
+      end
+    end
   end
 
   describe '#type_code' do

data/spec/cfonb/parser_spec.rb

@@ -43,12 +43,18 @@ describe CFONB::Parser do
           reference: '',
         )
         expect(statements[0].operations[0].details).to have_attributes(
-          free_label: 'MENSUEAUHTR13133',
+          free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP",
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
           purpose: 'PURPOSE',
           debtor: 'INTERNET SFR',
+          unknown: {
+            'AAA' => "INTERNETA AAA\nINTERNETA ABB",
+            'BBB' => 'INTERNETE BBB',
+            'CCC' => 'INTERNETI CCC',
+            'N_Y' => 'EXAMPLE WITH EMPTY SPACE',
+          },
         )
 
         expect(statements[0].operations[1]).to have_attributes(
@@ -272,7 +278,7 @@ describe CFONB::Parser do
 
           expect(statements[0].operations[0].details).to have_attributes(
             operation_reference: 'REFERENCE',
-            free_label: 'MENSUEAUHTR13133',
+            free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP",
             debtor: 'INTERNET SFR',
             client_reference: 'OTHER REFERENCE',
             original_currency: nil,
@@ -705,7 +711,7 @@ describe CFONB::Parser do
           expect(operation.details).to have_attributes(
             operation_reference: 'REFERENCE',
             client_reference: 'OTHER REFERENCE',
-            free_label: "MENSUEAUHTR13133\nP051928612   22793301700040",
+            free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP\nP051928612   22793301700040",
             debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfonb
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Johan Le Bray
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-15 00:00:00.000000000 Z
+date: 2024-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: license_finder
@@ -112,6 +112,7 @@ files:
 - lib/cfonb/operation_details/npy.rb
 - lib/cfonb/operation_details/rcn.rb
 - lib/cfonb/operation_details/ref.rb
+- lib/cfonb/operation_details/unknown.rb
 - lib/cfonb/parser.rb
 - lib/cfonb/refinements/strings.rb
 - lib/cfonb/statement.rb