cfonb 0.0.7 → 1.1.0

data/spec/cfonb/operation_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'cfonb'
+require 'securerandom'
 require 'ostruct'
 
 describe CFONB::Operation do
@@ -36,6 +37,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.free_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -49,6 +53,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.unstructured_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -62,6 +69,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.unstructured_label_2).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -75,6 +85,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.structured_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -86,9 +99,9 @@ describe CFONB::Operation do
       it 'Adds the original currency information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(
+        expect(operation.details).to have_attributes(
           original_currency: 'USD',
-          original_amount: -12.34,
+          original_amount: 12.34,
           exchange_rate: nil,
         )
       end
@@ -99,9 +112,9 @@ describe CFONB::Operation do
         it 'Adds the original currency information' do
           operation.merge_detail(detail)
 
-          expect(operation).to have_attributes(
+          expect(operation.details).to have_attributes(
             original_currency: 'USD',
-            original_amount: -8358,
+            original_amount: 8358,
             exchange_rate: 1.077,
           )
         end
@@ -112,10 +125,9 @@ describe CFONB::Operation do
 
         it 'Adds the original currency information' do
           operation.merge_detail(detail)
-
-          expect(operation).to have_attributes(
+          expect(operation.details).to have_attributes(
             original_currency: 'EUR',
-            original_amount: -18_756.25,
+            original_amount: 18_756.25,
             exchange_rate: nil,
           )
         end
@@ -128,7 +140,7 @@ describe CFONB::Operation do
       it 'Adds the debtor information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(debtor: 'Patrick')
+        expect(operation.details).to have_attributes(debtor: 'Patrick')
       end
     end
 
@@ -138,7 +150,7 @@ describe CFONB::Operation do
       it 'Adds the creditor information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(creditor: 'Jean-Pierre')
+        expect(operation.details).to have_attributes(creditor: 'Jean-Pierre')
       end
     end
 
@@ -151,11 +163,11 @@ describe CFONB::Operation do
         )
       end
 
-      it 'adds the reference information' do
+      it 'adds the client reference information' do
         operation.merge_detail(detail)
 
-        expect(operation.reference).to eq('42 - SWILE-CMD-TR-YPDHMA')
-        expect(operation.purpose).to eq('TICKET RESTO')
+        expect(operation.details.client_reference).to eq('SWILE-CMD-TR-YPDHMA')
+        expect(operation.details.purpose).to eq('TICKET RESTO')
       end
     end
 
@@ -168,10 +180,10 @@ describe CFONB::Operation do
         )
       end
 
-      it 'adds the reference information' do
+      it 'adds the operation reference information' do
         operation.merge_detail(detail)
 
-        expect(operation.reference).to eq('42 - PENNYLANE B13A93908C36C82DF5C319/1')
+        expect(operation.details.operation_reference).to eq('PENNYLANE B13A93908C36C82DF5C319/1')
       end
     end
 
@@ -187,8 +199,100 @@ describe CFONB::Operation do
       it 'adds the fee information' do
         operation.merge_detail(detail)
 
-        expect(operation.fee_currency).to eq('EUR')
-        expect(operation.fee).to eq(7.4)
+        expect(operation.details.fee_currency).to eq('EUR')
+        expect(operation.details.fee).to eq(7.4)
+      end
+    end
+
+    context 'with a IPY detail' do
+      let(:debtor_identifier) { SecureRandom.alphanumeric(35) }
+      let(:debtor_identifier_type) { SecureRandom.alphanumeric(35) }
+
+      let(:detail) do
+        OpenStruct.new(
+          body: "0530004411001871EUR2 0001016255614090823     IPY#{debtor_identifier}#{debtor_identifier_type}",
+          detail_code: 'IPY',
+          detail: "#{debtor_identifier}#{debtor_identifier_type}",
+        )
+      end
+
+      it 'adds the debtor_identifier' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.debtor_identifier).to eq(debtor_identifier)
+        expect(operation.details.debtor_identifier_type).to eq(debtor_identifier_type)
+      end
+    end
+
+    context 'with a IBE detail' do
+      let(:creditor_identifier) { SecureRandom.alphanumeric(35) }
+      let(:creditor_identifier_type) { SecureRandom.alphanumeric(35) }
+
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'IBE',
+          detail: "#{creditor_identifier}#{creditor_identifier_type}",
+        )
+      end
+
+      it 'adds the IBE information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.creditor_identifier).to eq(creditor_identifier)
+        expect(operation.details.creditor_identifier_type).to eq(creditor_identifier_type)
+      end
+    end
+
+    context 'with a NPO detail' do
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'NPO',
+          detail: 'Patrick                                                               ',
+        )
+      end
+
+      it 'adds the NPO information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.ultimate_debtor).to eq('Patrick')
+      end
+    end
+
+    context 'with a NBU detail' do
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'NBU',
+          detail: 'Patrick                                                               ',
+        )
+      end
+
+      it 'adds the NBU information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.ultimate_creditor).to eq('Patrick')
+      end
+    end
+
+    context 'with an unknown detail' do
+      let(:detail) do
+        OpenStruct.new(
+          body: '0530004411001871EUR2 0001016255614090823     AAAEUR200000000000740',
+          detail_code: 'AAA',
+          detail: 'EUR200000000000740',
+        )
+      end
+
+      it 'adds the detail to the unknown details hash' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to eq({ 'AAA' => 'EUR200000000000740' })
+      end
+
+      it 'updates the current details in case of duplicated codes' do
+        operation.merge_detail(detail)
+        operation.merge_detail(detail)
+
+        expect(operation.details.unknown).to eq({ 'AAA' => "EUR200000000000740\nEUR200000000000740" })
       end
     end
   end

data/spec/cfonb/parser_spec.rb

@@ -35,17 +35,25 @@ describe CFONB::Parser do
           exoneration_code: '0',
           interbank_code: 'B1',
           internal_code: '9162',
-          label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+          label: 'PRLV SEPA TEST CABINET',
           number: 0,
-          reference: 'REFERENCE - OTHER REFERENCE',
-          purpose: 'PURPOSE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: '',
+        )
+        expect(statements[0].operations[0].details).to have_attributes(
+          free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP",
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: 'PURPOSE',
           debtor: 'INTERNET SFR',
+          unknown: {
+            'AAA' => "INTERNETA AAA\nINTERNETA ABB",
+            'BBB' => 'INTERNETE BBB',
+            'CCC' => 'INTERNETI CCC',
+          },
         )
 
         expect(statements[0].operations[1]).to have_attributes(
@@ -57,14 +65,19 @@ describe CFONB::Parser do
           internal_code: '9162',
           label: 'VIR  SEPA DEMONSTRATION',
           number: 0,
-          reference: 'REFERENCE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: 'REFERENCE',
+        )
+
+        expect(statements[0].operations[1].details).to have_attributes(
+          debtor: 'ELEC ERDF',
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
-          debtor: 'ELEC ERDF',
+          purpose: nil,
         )
 
         expect(statements[0].operations[2]).to have_attributes(
@@ -76,10 +89,15 @@ describe CFONB::Parser do
           internal_code: '0117',
           label: 'F COMMISSION D INTERVENTION',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[0].operations[2].details).to have_attributes(
+          free_label: nil,
+          purpose: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
@@ -105,15 +123,21 @@ describe CFONB::Parser do
           exoneration_code: '',
           interbank_code: 'A3',
           internal_code: '0158',
-          label: "PRLV SEPA GROUPAMA CEN\nP051928612   22793301700040",
+          label: 'PRLV SEPA GROUPAMA CEN',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[1].operations[0].details).to have_attributes(
+          free_label: 'P051928612   22793301700040',
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
 
         expect(statements[1].operations[1]).to have_attributes(
@@ -125,13 +149,19 @@ describe CFONB::Parser do
           internal_code: '0337',
           label: 'F FRAIS PRLV IMP 97 49EUR',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[1].operations[1].details).to have_attributes(
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
 
         expect(statements[1].operations[2]).to have_attributes(
@@ -143,13 +173,19 @@ describe CFONB::Parser do
           internal_code: '0117',
           label: 'F COMMISSION D INTERVENTION',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: '',
+        )
+
+        expect(statements[1].operations[2].details).to have_attributes(
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
       end
     end
@@ -232,18 +268,22 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+
+          expect(statements[0].operations[0].details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP",
+            debtor: 'INTERNET SFR',
+            client_reference: 'OTHER REFERENCE',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
-
           expect(statements[0].operations[1]).to have_attributes(
             amount: -10.7,
             currency: 'EUR',
@@ -253,10 +293,13 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: 'REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: 'REFERENCE',
+          )
+
+          expect(statements[0].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -272,10 +315,13 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[0].operations[2].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -301,12 +347,16 @@ describe CFONB::Parser do
             exoneration_code: '',
             interbank_code: 'A3',
             internal_code: '0158',
-            label: "PRLV SEPA GROUPAMA CEN\nP051928612   22793301700040",
+            label: 'PRLV SEPA GROUPAMA CEN',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[1].operations[0].details).to have_attributes(
+            free_label: 'P051928612   22793301700040',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -321,10 +371,13 @@ describe CFONB::Parser do
             internal_code: '0337',
             label: 'F FRAIS PRLV IMP 97 49EUR',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[1].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -339,10 +392,13 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+
+          expect(statements[1].operations[2].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -365,14 +421,17 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -392,14 +451,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -419,14 +480,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -446,14 +509,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
           expect(statements[0].operations[1]).to have_attributes(
             amount: -7.9,
@@ -464,10 +529,12 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -503,16 +570,20 @@ describe CFONB::Parser do
           exoneration_code: '0',
           interbank_code: 'B1',
           internal_code: '9162',
-          label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+          label: 'PRLV SEPA TEST CABINET',
           number: 0,
-          reference: 'REFERENCE - OTHER REFERENCE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+        )
+        expect(operation.details).to have_attributes(
+          operation_reference: 'REFERENCE',
+          client_reference: 'OTHER REFERENCE',
+          debtor: 'INTERNET SFR',
+          free_label: 'MENSUEAUHTR13133',
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
-          debtor: 'INTERNET SFR',
         )
       end
     end
@@ -563,16 +634,20 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+          expect(operation.details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            client_reference: 'OTHER REFERENCE',
+            free_label: 'MENSUEAUHTR13133',
+            debtor: 'INTERNET SFR',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -588,16 +663,20 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+          expect(operation.details).to have_attributes(
+            client_reference: 'OTHER REFERENCE',
+            operation_reference: 'REFERENCE',
+            free_label: 'MENSUEAUHTR13133',
+            debtor: 'INTERNET SFR',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -621,16 +700,21 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133\nP051928612   22793301700040",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+
+          expect(operation.details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            client_reference: 'OTHER REFERENCE',
+            free_label: "MENSUEAUHTR13133\nMENSUEAUHTR13DUP\nP051928612   22793301700040",
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end