cfonb 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85f6bbc0d3b93bd081c3bbb00ac463b6907937b9520b628abc078785f48efa70
-  data.tar.gz: e1e9c68239d2fd2b912561b521d64d97429d2f52af2a664351773cafeb35f546
+  metadata.gz: f80902862080f864dd6e69edc2f15d1d07d863fef754f47eb70bf052d4628cc2
+  data.tar.gz: 3258fdf0214ee434a09643ce033cc4fbf56500ad5d3633b3e424ed36f0d0a93d
 SHA512:
-  metadata.gz: 032a11a0ec0797c262e9dd19c9ddaec04ffd63223674273c9674c7de90d48fe48386700a2934b23e54423f79a7a530367802440237faa3f637457a9135151775
-  data.tar.gz: bedf78c43c86ecb9b9de4f9c4560158a1666d6c19e8b7e05b7f8dbb803ac59d00bc14d8b590ce82ebf21e0074bcbff4a45f47010ee17716ae2dd742a83f6f82f
+  metadata.gz: f0b35b9c4d7aa76957195c087e26f9777dad59308fcdb12a02c77da031d86798c726b3dc90e9fb9756c995414d34ce92f7d35638bed80fe10f5ff5c64e332659
+  data.tar.gz: b55fa730f6659cd878fa46a965a832bc3eb3b26e0fca3182a43af4b04bb4827995d73bfee61c7c1cb39674f01074f31a255ab060caf3fd0b3c0dc05a9c563f46

data/lib/cfonb/line_parser/base.rb

@@ -12,7 +12,7 @@ module CFONB
         ['bank', (2..6)],
         ['branch', (11..15)],
         ['currency', (16..18)],
-        ['scale', 19, proc { _1.to_i }],
+        ['scale', 19, proc { _1.to_i }], # rubocop:disable Style/SymbolProc
         ['account', (21..31)],
         ['date', (34..39), proc { |value, instance| instance.send(:parse_date, value) }],
       ].freeze

data/lib/cfonb/line_parser/operation.rb

@@ -9,7 +9,7 @@ module CFONB
         ['rejection_code', (40..41)],
         ['value_date', (42..47), proc { |value, instance| instance.send(:parse_date, value) }],
         ['label', (48..79)],
-        ['number', (81..87), proc { _1.to_i }],
+        ['number', (81..87), proc { _1.to_i }], # rubocop:disable Style/SymbolProc
         ['exoneration_code', 88],
         ['unavailability_code', 89],
         ['reference', (104..119)],

data/lib/cfonb/line_parser/{operation_detail.rb → operation_details.rb}

@@ -2,7 +2,7 @@
 
 module CFONB
   module LineParser
-    class OperationDetail < Base
+    class OperationDetails < Base
       DICTIONARY = [
         ['internal_operation_code', (7..10)],
         ['interbank_operation_code', (32..33)],

data/lib/cfonb/operation.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 module CFONB
+  Details = Class.new
+
   class Operation
     BASE_ATTRIBUTES = %i[
       raw
@@ -16,6 +18,7 @@ module CFONB
       rejection_code
       unavailability_code
       value_date
+      details
     ].freeze
 
     attr_accessor(*BASE_ATTRIBUTES)
@@ -34,11 +37,13 @@ module CFONB
       self.label = line.label.strip
       self.number = line.number
       self.reference = line.reference
+      self.details = Details.new
     end
 
     def merge_detail(line)
       self.raw += "\n#{line.body}"
-      OperationDetail.for(line)&.apply(self, line)
+
+      OperationDetails.for(line)&.apply(details, line)
     end
 
     def type_code

data/lib/cfonb/operation_details/base.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class Base
+      def self.inherited(base)
+        base.singleton_class.prepend(
+          Module.new do
+            def apply(details, line)
+              details.instance_variable_set(:"@#{line.detail_code}", line.detail)
+
+              super
+            end
+          end,
+        )
+      end
+    end
+  end
+end

data/lib/cfonb/operation_details/fee.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class FEE < Base
+      ATTRIBUTES = %i[fee fee_currency].freeze
+
+      def self.apply(details, line)
+        details.fee_currency = line.detail[0..2]
+        scale = line.detail[3].to_i
+
+        details.fee = BigDecimal(line.detail[4..17]) / (10**scale)
+      end
+
+      CFONB::OperationDetails.register('FEE', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/ibe.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class IBE < Base
+      ATTRIBUTES = %i[creditor_identifier creditor_identifier_type].freeze
+
+      def self.apply(details, line)
+        details.creditor_identifier = line.detail[0..34].strip
+        details.creditor_identifier_type = line.detail[35..-1].strip
+      end
+
+      CFONB::OperationDetails.register('IBE', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/ipy.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class IPY < Base
+      ATTRIBUTES = %i[debtor_identifier debtor_identifier_type].freeze
+
+      def self.apply(details, line)
+        details.debtor_identifier = line.detail[0..34].strip
+        details.debtor_identifier_type = line.detail[35..-1].strip
+      end
+
+      CFONB::OperationDetails.register('IPY', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/lc2.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class LC2 < Base
+      ATTRIBUTES = %i[unstructured_label_2].freeze
+
+      def self.apply(details, line)
+        details.unstructured_label_2 = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('LC2', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/lcc.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class LCC < Base
+      ATTRIBUTES = %i[unstructured_label].freeze
+
+      def self.apply(details, line)
+        details.unstructured_label = line.detail.strip.to_s
+      end
+
+      CFONB::OperationDetails.register('LCC', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/lcs.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class LCS < Base
+      ATTRIBUTES = %i[structured_label].freeze
+
+      def self.apply(details, line)
+        details.structured_label = line.detail[0..35].strip
+      end
+
+      CFONB::OperationDetails.register('LCS', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/lib.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class LIB < Base
+      ATTRIBUTES = %i[free_label].freeze
+
+      def self.apply(details, line)
+        details.free_label = [details.free_label, line.detail.strip].compact.join("\n")
+      end
+
+      CFONB::OperationDetails.register('LIB', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/mmo.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'bigdecimal'
+
+module CFONB
+  module OperationDetails
+    class MMO < Base
+      ATTRIBUTES = %i[original_currency original_amount exchange_rate].freeze
+
+      def self.apply(details, line)
+        details.original_currency = line.detail[0..2]
+        scale = line.detail[3].to_i
+
+        details.original_amount = BigDecimal(line.detail[4..17]) / (10**scale)
+        exchange_rate_value = line.detail[26..29]
+
+        return if exchange_rate_value.nil? || exchange_rate_value.strip.empty?
+
+        exchange_rate_scale = line.detail[18]
+        details.exchange_rate = BigDecimal(exchange_rate_value) / (10**BigDecimal(exchange_rate_scale))
+      end
+
+      CFONB::OperationDetails.register('MMO', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/nbe.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class NBE < Base
+      ATTRIBUTES = %i[creditor].freeze
+
+      def self.apply(details, line)
+        details.creditor = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('NBE', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/nbu.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class NBU < Base
+      ATTRIBUTES = %i[ultimate_creditor].freeze
+
+      def self.apply(details, line)
+        details.ultimate_creditor = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('NBU', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/npo.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class NPO < Base
+      ATTRIBUTES = %i[ultimate_debtor].freeze
+
+      def self.apply(details, line)
+        details.ultimate_debtor = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('NPO', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/npy.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class NPY < Base
+      ATTRIBUTES = %i[debtor].freeze
+
+      def self.apply(details, line)
+        details.debtor = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('NPY', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/rcn.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class RCN < Base
+      using CFONB::Refinements::Strings
+
+      ATTRIBUTES = %i[client_reference purpose].freeze
+
+      def self.apply(details, line)
+        details.client_reference = line.detail[0..34].strip
+        details.purpose = line.detail[35..-1]&.strip
+      end
+
+      CFONB::OperationDetails.register('RCN', self)
+    end
+  end
+end

data/lib/cfonb/operation_details/ref.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module CFONB
+  module OperationDetails
+    class REF < Base
+      using CFONB::Refinements::Strings
+
+      ATTRIBUTES = %i[operation_reference].freeze
+
+      def self.apply(details, line)
+        details.operation_reference = line.detail.strip
+      end
+
+      CFONB::OperationDetails.register('REF', self)
+    end
+  end
+end

data/lib/cfonb/{operation_detail.rb → operation_details.rb}

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
 module CFONB
-  module OperationDetail
+  module OperationDetails
     @details = {}
 
     def self.register(code, klass)
       if klass.const_defined?(:ATTRIBUTES)
-        Operation.class_eval do
+        CFONB::Details.class_eval do
           attr_accessor(*klass::ATTRIBUTES)
         end
       end

data/lib/cfonb.rb

@@ -8,25 +8,30 @@ require_relative 'cfonb/error'
 require_relative 'cfonb/parser'
 require_relative 'cfonb/statement'
 require_relative 'cfonb/operation'
-require_relative 'cfonb/operation_detail'
+require_relative 'cfonb/operation_details'
 
 require_relative 'cfonb/line_parser'
 require_relative 'cfonb/line_parser/base'
 require_relative 'cfonb/line_parser/previous_balance'
 require_relative 'cfonb/line_parser/operation'
-require_relative 'cfonb/line_parser/operation_detail'
+require_relative 'cfonb/line_parser/operation_details'
 require_relative 'cfonb/line_parser/new_balance'
 
-require_relative 'cfonb/operation_detail/lib'
-require_relative 'cfonb/operation_detail/lcc'
-require_relative 'cfonb/operation_detail/lc2'
-require_relative 'cfonb/operation_detail/lcs'
-require_relative 'cfonb/operation_detail/mmo'
-require_relative 'cfonb/operation_detail/nbe'
-require_relative 'cfonb/operation_detail/npy'
-require_relative 'cfonb/operation_detail/rcn'
-require_relative 'cfonb/operation_detail/ref'
-require_relative 'cfonb/operation_detail/fee'
+require_relative 'cfonb/operation_details/base'
+require_relative 'cfonb/operation_details/lib'
+require_relative 'cfonb/operation_details/lcc'
+require_relative 'cfonb/operation_details/lc2'
+require_relative 'cfonb/operation_details/lcs'
+require_relative 'cfonb/operation_details/mmo'
+require_relative 'cfonb/operation_details/nbe'
+require_relative 'cfonb/operation_details/npy'
+require_relative 'cfonb/operation_details/ipy'
+require_relative 'cfonb/operation_details/rcn'
+require_relative 'cfonb/operation_details/ref'
+require_relative 'cfonb/operation_details/fee'
+require_relative 'cfonb/operation_details/ibe'
+require_relative 'cfonb/operation_details/npo'
+require_relative 'cfonb/operation_details/nbu'
 
 module CFONB
   def self.parse(input, optimistic: false)

data/spec/cfonb/line_parser/{operation_detail_spec.rb → operation_details_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'cfonb'
 
-describe CFONB::LineParser::OperationDetail do
+describe CFONB::LineParser::OperationDetails do
   describe '.initialize' do
     subject(:line) { described_class.new(input) }
 

data/spec/cfonb/operation_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'cfonb'
+require 'securerandom'
 require 'ostruct'
 
 describe CFONB::Operation do
@@ -36,6 +37,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.free_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -49,6 +53,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.unstructured_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -62,6 +69,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.unstructured_label_2).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -75,6 +85,9 @@ describe CFONB::Operation do
 
         expect(operation.label).to eq(<<~TXT.strip)
           A random operation label
+        TXT
+
+        expect(operation.details.structured_label).to eq(<<~TXT.strip)
           Extra label
         TXT
       end
@@ -86,9 +99,9 @@ describe CFONB::Operation do
       it 'Adds the original currency information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(
+        expect(operation.details).to have_attributes(
           original_currency: 'USD',
-          original_amount: -12.34,
+          original_amount: 12.34,
           exchange_rate: nil,
         )
       end
@@ -99,13 +112,26 @@ describe CFONB::Operation do
         it 'Adds the original currency information' do
           operation.merge_detail(detail)
 
-          expect(operation).to have_attributes(
+          expect(operation.details).to have_attributes(
             original_currency: 'USD',
-            original_amount: -8358,
+            original_amount: 8358,
             exchange_rate: 1.077,
           )
         end
       end
+
+      context 'when exchange rate is missing' do
+        let(:detail) { OpenStruct.new(body: '', detail_code: 'MMO', detail: 'EUR200000001875625             04') }
+
+        it 'Adds the original currency information' do
+          operation.merge_detail(detail)
+          expect(operation.details).to have_attributes(
+            original_currency: 'EUR',
+            original_amount: 18_756.25,
+            exchange_rate: nil,
+          )
+        end
+      end
     end
 
     context 'with a NPY detail' do
@@ -114,7 +140,7 @@ describe CFONB::Operation do
       it 'Adds the debtor information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(debtor: 'Patrick')
+        expect(operation.details).to have_attributes(debtor: 'Patrick')
       end
     end
 
@@ -124,7 +150,7 @@ describe CFONB::Operation do
       it 'Adds the creditor information' do
         operation.merge_detail(detail)
 
-        expect(operation).to have_attributes(creditor: 'Jean-Pierre')
+        expect(operation.details).to have_attributes(creditor: 'Jean-Pierre')
       end
     end
 
@@ -137,11 +163,11 @@ describe CFONB::Operation do
         )
       end
 
-      it 'adds the reference information' do
+      it 'adds the client reference information' do
         operation.merge_detail(detail)
 
-        expect(operation.reference).to eq('42 - SWILE-CMD-TR-YPDHMA')
-        expect(operation.purpose).to eq('TICKET RESTO')
+        expect(operation.details.client_reference).to eq('SWILE-CMD-TR-YPDHMA')
+        expect(operation.details.purpose).to eq('TICKET RESTO')
       end
     end
 
@@ -154,10 +180,10 @@ describe CFONB::Operation do
         )
       end
 
-      it 'adds the reference information' do
+      it 'adds the operation reference information' do
         operation.merge_detail(detail)
 
-        expect(operation.reference).to eq('42 - PENNYLANE B13A93908C36C82DF5C319/1')
+        expect(operation.details.operation_reference).to eq('PENNYLANE B13A93908C36C82DF5C319/1')
       end
     end
 
@@ -173,8 +199,77 @@ describe CFONB::Operation do
       it 'adds the fee information' do
         operation.merge_detail(detail)
 
-        expect(operation.fee_currency).to eq('EUR')
-        expect(operation.fee).to eq(7.4)
+        expect(operation.details.fee_currency).to eq('EUR')
+        expect(operation.details.fee).to eq(7.4)
+      end
+    end
+
+    context 'with a IPY detail' do
+      let(:debtor_identifier) { SecureRandom.alphanumeric(35) }
+      let(:debtor_identifier_type) { SecureRandom.alphanumeric(35) }
+
+      let(:detail) do
+        OpenStruct.new(
+          body: "0530004411001871EUR2 0001016255614090823     IPY#{debtor_identifier}#{debtor_identifier_type}",
+          detail_code: 'IPY',
+          detail: "#{debtor_identifier}#{debtor_identifier_type}",
+        )
+      end
+
+      it 'adds the debtor_identifier' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.debtor_identifier).to eq(debtor_identifier)
+        expect(operation.details.debtor_identifier_type).to eq(debtor_identifier_type)
+      end
+    end
+
+    context 'with a IBE detail' do
+      let(:creditor_identifier) { SecureRandom.alphanumeric(35) }
+      let(:creditor_identifier_type) { SecureRandom.alphanumeric(35) }
+
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'IBE',
+          detail: "#{creditor_identifier}#{creditor_identifier_type}",
+        )
+      end
+
+      it 'adds the IBE information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.creditor_identifier).to eq(creditor_identifier)
+        expect(operation.details.creditor_identifier_type).to eq(creditor_identifier_type)
+      end
+    end
+
+    context 'with a NPO detail' do
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'NPO',
+          detail: 'Patrick                                                               ',
+        )
+      end
+
+      it 'adds the NPO information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.ultimate_debtor).to eq('Patrick')
+      end
+    end
+
+    context 'with a NBU detail' do
+      let(:detail) do
+        OpenStruct.new(
+          detail_code: 'NBU',
+          detail: 'Patrick                                                               ',
+        )
+      end
+
+      it 'adds the NBU information' do
+        operation.merge_detail(detail)
+
+        expect(operation.details.ultimate_creditor).to eq('Patrick')
       end
     end
   end

data/spec/cfonb/parser_spec.rb

@@ -35,16 +35,19 @@ describe CFONB::Parser do
           exoneration_code: '0',
           interbank_code: 'B1',
           internal_code: '9162',
-          label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+          label: 'PRLV SEPA TEST CABINET',
           number: 0,
-          reference: 'REFERENCE - OTHER REFERENCE',
-          purpose: 'PURPOSE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: '',
+        )
+        expect(statements[0].operations[0].details).to have_attributes(
+          free_label: 'MENSUEAUHTR13133',
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: 'PURPOSE',
           debtor: 'INTERNET SFR',
         )
 
@@ -57,14 +60,19 @@ describe CFONB::Parser do
           internal_code: '9162',
           label: 'VIR  SEPA DEMONSTRATION',
           number: 0,
-          reference: 'REFERENCE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: 'REFERENCE',
+        )
+
+        expect(statements[0].operations[1].details).to have_attributes(
+          debtor: 'ELEC ERDF',
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
-          debtor: 'ELEC ERDF',
+          purpose: nil,
         )
 
         expect(statements[0].operations[2]).to have_attributes(
@@ -76,10 +84,15 @@ describe CFONB::Parser do
           internal_code: '0117',
           label: 'F COMMISSION D INTERVENTION',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[0].operations[2].details).to have_attributes(
+          free_label: nil,
+          purpose: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
@@ -105,15 +118,21 @@ describe CFONB::Parser do
           exoneration_code: '',
           interbank_code: 'A3',
           internal_code: '0158',
-          label: "PRLV SEPA GROUPAMA CEN\nP051928612   22793301700040",
+          label: 'PRLV SEPA GROUPAMA CEN',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[1].operations[0].details).to have_attributes(
+          free_label: 'P051928612   22793301700040',
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
 
         expect(statements[1].operations[1]).to have_attributes(
@@ -125,13 +144,19 @@ describe CFONB::Parser do
           internal_code: '0337',
           label: 'F FRAIS PRLV IMP 97 49EUR',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
+          reference: '',
+        )
+
+        expect(statements[1].operations[1].details).to have_attributes(
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
 
         expect(statements[1].operations[2]).to have_attributes(
@@ -143,13 +168,19 @@ describe CFONB::Parser do
           internal_code: '0117',
           label: 'F COMMISSION D INTERVENTION',
           number: 0,
-          reference: '',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+          reference: '',
+        )
+
+        expect(statements[1].operations[2].details).to have_attributes(
+          free_label: nil,
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
+          purpose: nil,
+          debtor: nil,
         )
       end
     end
@@ -232,18 +263,22 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+
+          expect(statements[0].operations[0].details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            free_label: 'MENSUEAUHTR13133',
+            debtor: 'INTERNET SFR',
+            client_reference: 'OTHER REFERENCE',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
-
           expect(statements[0].operations[1]).to have_attributes(
             amount: -10.7,
             currency: 'EUR',
@@ -253,10 +288,13 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: 'REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: 'REFERENCE',
+          )
+
+          expect(statements[0].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -272,10 +310,13 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[0].operations[2].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -301,12 +342,16 @@ describe CFONB::Parser do
             exoneration_code: '',
             interbank_code: 'A3',
             internal_code: '0158',
-            label: "PRLV SEPA GROUPAMA CEN\nP051928612   22793301700040",
+            label: 'PRLV SEPA GROUPAMA CEN',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[1].operations[0].details).to have_attributes(
+            free_label: 'P051928612   22793301700040',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -321,10 +366,13 @@ describe CFONB::Parser do
             internal_code: '0337',
             label: 'F FRAIS PRLV IMP 97 49EUR',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
+            reference: '',
+          )
+
+          expect(statements[1].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -339,10 +387,13 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+
+          expect(statements[1].operations[2].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -365,14 +416,17 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -392,14 +446,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -419,14 +475,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -446,14 +504,16 @@ describe CFONB::Parser do
             internal_code: '9162',
             label: 'VIR  SEPA DEMONSTRATION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[0].details).to have_attributes(
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
           expect(statements[0].operations[1]).to have_attributes(
             amount: -7.9,
@@ -464,10 +524,12 @@ describe CFONB::Parser do
             internal_code: '0117',
             label: 'F COMMISSION D INTERVENTION',
             number: 0,
-            reference: '',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+            reference: '',
+          )
+          expect(statements[0].operations[1].details).to have_attributes(
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
@@ -503,16 +565,20 @@ describe CFONB::Parser do
           exoneration_code: '0',
           interbank_code: 'B1',
           internal_code: '9162',
-          label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+          label: 'PRLV SEPA TEST CABINET',
           number: 0,
-          reference: 'REFERENCE - OTHER REFERENCE',
           rejection_code: '',
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
+        )
+        expect(operation.details).to have_attributes(
+          operation_reference: 'REFERENCE',
+          client_reference: 'OTHER REFERENCE',
+          debtor: 'INTERNET SFR',
+          free_label: 'MENSUEAUHTR13133',
           original_currency: nil,
           original_amount: nil,
           exchange_rate: nil,
-          debtor: 'INTERNET SFR',
         )
       end
     end
@@ -563,16 +629,20 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+          expect(operation.details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            client_reference: 'OTHER REFERENCE',
+            free_label: 'MENSUEAUHTR13133',
+            debtor: 'INTERNET SFR',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -588,16 +658,20 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+          expect(operation.details).to have_attributes(
+            client_reference: 'OTHER REFERENCE',
+            operation_reference: 'REFERENCE',
+            free_label: 'MENSUEAUHTR13133',
+            debtor: 'INTERNET SFR',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -621,16 +695,21 @@ describe CFONB::Parser do
             exoneration_code: '0',
             interbank_code: 'B1',
             internal_code: '9162',
-            label: "PRLV SEPA TEST CABINET\nMENSUEAUHTR13133\nP051928612   22793301700040",
+            label: 'PRLV SEPA TEST CABINET',
             number: 0,
-            reference: 'REFERENCE - OTHER REFERENCE',
             rejection_code: '',
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
+          )
+
+          expect(operation.details).to have_attributes(
+            operation_reference: 'REFERENCE',
+            client_reference: 'OTHER REFERENCE',
+            free_label: "MENSUEAUHTR13133\nP051928612   22793301700040",
+            debtor: 'ELEC ERDF',
             original_currency: nil,
             original_amount: nil,
             exchange_rate: nil,
-            debtor: 'ELEC ERDF',
           )
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfonb
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Johan Le Bray
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-14 00:00:00.000000000 Z
+date: 2024-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: license_finder
@@ -93,25 +93,30 @@ files:
 - lib/cfonb/line_parser/base.rb
 - lib/cfonb/line_parser/new_balance.rb
 - lib/cfonb/line_parser/operation.rb
-- lib/cfonb/line_parser/operation_detail.rb
+- lib/cfonb/line_parser/operation_details.rb
 - lib/cfonb/line_parser/previous_balance.rb
 - lib/cfonb/operation.rb
-- lib/cfonb/operation_detail.rb
-- lib/cfonb/operation_detail/fee.rb
-- lib/cfonb/operation_detail/lc2.rb
-- lib/cfonb/operation_detail/lcc.rb
-- lib/cfonb/operation_detail/lcs.rb
-- lib/cfonb/operation_detail/lib.rb
-- lib/cfonb/operation_detail/mmo.rb
-- lib/cfonb/operation_detail/nbe.rb
-- lib/cfonb/operation_detail/npy.rb
-- lib/cfonb/operation_detail/rcn.rb
-- lib/cfonb/operation_detail/ref.rb
+- lib/cfonb/operation_details.rb
+- lib/cfonb/operation_details/base.rb
+- lib/cfonb/operation_details/fee.rb
+- lib/cfonb/operation_details/ibe.rb
+- lib/cfonb/operation_details/ipy.rb
+- lib/cfonb/operation_details/lc2.rb
+- lib/cfonb/operation_details/lcc.rb
+- lib/cfonb/operation_details/lcs.rb
+- lib/cfonb/operation_details/lib.rb
+- lib/cfonb/operation_details/mmo.rb
+- lib/cfonb/operation_details/nbe.rb
+- lib/cfonb/operation_details/nbu.rb
+- lib/cfonb/operation_details/npo.rb
+- lib/cfonb/operation_details/npy.rb
+- lib/cfonb/operation_details/rcn.rb
+- lib/cfonb/operation_details/ref.rb
 - lib/cfonb/parser.rb
 - lib/cfonb/refinements/strings.rb
 - lib/cfonb/statement.rb
 - spec/cfonb/line_parser/new_balance_spec.rb
-- spec/cfonb/line_parser/operation_detail_spec.rb
+- spec/cfonb/line_parser/operation_details_spec.rb
 - spec/cfonb/line_parser/operation_spec.rb
 - spec/cfonb/line_parser/previous_balance_spec.rb
 - spec/cfonb/operation_spec.rb
@@ -129,14 +134,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.2
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: CFONB parser

data/lib/cfonb/operation_detail/fee.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class FEE
-      ATTRIBUTES = %i[fee fee_currency].freeze
-
-      def self.apply(operation, line)
-        operation.fee_currency = line.detail[0..2]
-        scale = line.detail[3].to_i
-
-        operation.fee = BigDecimal(line.detail[4..17]) / (10**scale)
-      end
-
-      CFONB::OperationDetail.register('FEE', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/lc2.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class LC2
-      def self.apply(operation, line)
-        operation.label += "\n#{line.detail.strip}"
-      end
-
-      CFONB::OperationDetail.register('LC2', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/lcc.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class LCC
-      def self.apply(operation, line)
-        operation.label += "\n#{line.detail.strip}"
-      end
-
-      CFONB::OperationDetail.register('LCC', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/lcs.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class LCS
-      def self.apply(operation, line)
-        operation.label += "\n#{line.detail[0..35].strip}"
-      end
-
-      CFONB::OperationDetail.register('LCS', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/lib.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class LIB
-      def self.apply(operation, line)
-        operation.label += "\n#{line.detail.strip}"
-      end
-
-      CFONB::OperationDetail.register('LIB', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/mmo.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require 'bigdecimal'
-
-module CFONB
-  module OperationDetail
-    class MMO
-      ATTRIBUTES = %i[original_currency original_amount exchange_rate].freeze
-
-      def self.apply(operation, line)
-        operation.original_currency = line.detail[0..2]
-
-        scale = line.detail[3].to_i
-        sign = operation.amount <=> 0 # the detail amount is unsigned
-
-        operation.original_amount = sign * BigDecimal(line.detail[4..17]) / (10**scale)
-        exchange_rate_value = line.detail[26..29]
-        return unless exchange_rate_value
-
-        exchange_rate_scale = line.detail[18]
-        operation.exchange_rate = BigDecimal(exchange_rate_value) / (10**BigDecimal(exchange_rate_scale))
-      end
-
-      CFONB::OperationDetail.register('MMO', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/nbe.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class NBE
-      ATTRIBUTES = %i[creditor].freeze
-
-      def self.apply(operation, line)
-        operation.creditor = line.detail.strip
-      end
-
-      CFONB::OperationDetail.register('NBE', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/npy.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class NPY
-      ATTRIBUTES = %i[debtor].freeze
-
-      def self.apply(operation, line)
-        operation.debtor = line.detail.strip
-      end
-
-      CFONB::OperationDetail.register('NPY', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/rcn.rb

@@ -1,22 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class RCN
-      using CFONB::Refinements::Strings
-
-      ATTRIBUTES = %i[reference purpose].freeze
-
-      def self.apply(operation, line)
-        operation.reference = [
-          operation.reference,
-          line.detail[0..34].strip,
-        ].filter_map(&:presence).join(' - ')
-
-        operation.purpose = line.detail[35..-1]&.strip
-      end
-
-      CFONB::OperationDetail.register('RCN', self)
-    end
-  end
-end

data/lib/cfonb/operation_detail/ref.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-module CFONB
-  module OperationDetail
-    class REF
-      using CFONB::Refinements::Strings
-
-      ATTRIBUTES = %i[reference].freeze
-
-      def self.apply(operation, line)
-        operation.reference = [
-          operation.reference,
-          line.detail.strip,
-        ].filter_map(&:presence).join(' - ')
-      end
-
-      CFONB::OperationDetail.register('REF', self)
-    end
-  end
-end