cfonb 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 45c55ed710afa4873c8d7cbb73412d9255ad5992c619e4a00918429b691517ce
-  data.tar.gz: 82075981bcd15526501ebf5fd965b97a0e09fdc7ace490c48c3de4cbbd2c7662
+  metadata.gz: 894f7b20e6c030c8343e833f79f0a5a69c4701e4d262c66a5740c1872efd4603
+  data.tar.gz: 380cb8f1225d203fdf845456a2630d3ca13605c03c7bc0deb11f64da6f8e905c
 SHA512:
-  metadata.gz: a985ece7273a2f4a06c5915c30d65e873d624b0be138ea141fc18237316ce248740ee6b5c384e3a3da021bffc918273f19abe4b27e8b161974838b105f1587ae
-  data.tar.gz: '0185ec1ef15211cd9dafa449d968a67a43e736083de9648761e054959ddb0485a7cf14aa45e2e83f64edc9bff6b9732779cec059abb9dc560a47e22a866ed31e'
+  metadata.gz: f6ba5f905c66dc4a4c60916ca5548703484e5270893efc1785d94aa100d60ef4933784589c75964e7dab358c7843b12958348f2476e2d04cc364b3687c0bc604
+  data.tar.gz: 5cc5774eb790f41f28fb9b885a50fd4682719feb9d6083351600e50ac9045dc375202a382ef36cd748fd4991b35ce84d7fdd4ffb6ccaf96c586c56f7a510df3f

data/lib/cfonb/line_parser/base.rb

@@ -14,7 +14,7 @@ module CFONB
         ['currency', (16..18)],
         ['scale', 19, proc { _1.to_i }],
         ['account', (21..31)],
-        ['date', (34..39), proc { |value, instance| instance.send(:parse_date, value) }]
+        ['date', (34..39), proc { |value, instance| instance.send(:parse_date, value) }],
       ].freeze
 
       AMOUNT_SPECIFIERS = {
@@ -37,7 +37,7 @@ module CFONB
         'P' => { sign: -1, value: '7' },
         'Q' => { sign: -1, value: '8' },
         'R' => { sign: -1, value: '9' },
-        '}' => { sign: -1, value: '0' }
+        '}' => { sign: -1, value: '0' },
       }.transform_values(&:freeze).freeze
 
       attr_reader :body, *BASE_DICTIONARY.map(&:first)
@@ -58,7 +58,7 @@ module CFONB
 
       def parse_amount(input)
         specifier = AMOUNT_SPECIFIERS[input.last]
-        raise ParserError, "Invalid specifier '#{input.last}' for line #{input}" unless specifier
+        raise ParserError.new("Invalid specifier '#{input.last}' for line #{input}") unless specifier
 
         specifier[:sign] * BigDecimal(input[0..-2] + specifier[:value]) / (10**scale)
       end
@@ -68,14 +68,14 @@ module CFONB
         return if input.strip.empty?
 
         input_with_year = if input.last(2).to_i > 60
-                            "#{input[0..3]}19#{input[4..5]}"
-                          else
-                            "#{input[0..3]}20#{input[4..5]}"
-                          end
+          "#{input[0..3]}19#{input[4..5]}"
+        else
+          "#{input[0..3]}20#{input[4..5]}"
+        end
 
         Date.strptime(input_with_year, '%d%m%Y')
       rescue Date::Error
-        raise ParserError, "Invalid date '#{input}' for line #{input}"
+        raise ParserError.new("Invalid date '#{input}' for line #{input}")
       end
     end
   end

data/lib/cfonb/line_parser/new_balance.rb

@@ -4,7 +4,7 @@ module CFONB
   module LineParser
     class NewBalance < Base
       DICTIONARY = [
-        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }]
+        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }],
       ].freeze
 
       attr_reader(*DICTIONARY.map(&:first))

data/lib/cfonb/line_parser/operation.rb

@@ -13,7 +13,7 @@ module CFONB
         ['exoneration_code', 88],
         ['unavailability_code', 89],
         ['reference', (104..119)],
-        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }]
+        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }],
       ].freeze
 
       attr_reader(*DICTIONARY.map(&:first))

data/lib/cfonb/line_parser/operation_detail.rb

@@ -7,7 +7,7 @@ module CFONB
         ['internal_operation_code', (7..10)],
         ['interbank_operation_code', (32..33)],
         ['detail_code', (45..47)],
-        ['detail', (48..117)]
+        ['detail', (48..117)],
       ].freeze
 
       attr_reader(*DICTIONARY.map(&:first))

data/lib/cfonb/line_parser/previous_balance.rb

@@ -4,7 +4,7 @@ module CFONB
   module LineParser
     class PreviousBalance < Base
       DICTIONARY = [
-        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }]
+        ['amount', (90..103), proc { |value, instance| instance.send(:parse_amount, value) }],
       ].freeze
 
       attr_reader(*DICTIONARY.map(&:first))

data/lib/cfonb/operation_detail/fee.rb

@@ -8,9 +8,8 @@ module CFONB
       def self.apply(operation, line)
         operation.fee_currency = line.detail[0..2]
         scale = line.detail[3].to_i
-        sign = operation.amount <=> 0 # the detail amount is unsigned
 
-        operation.fee = sign * BigDecimal(line.detail[4..17]) / (10**scale)
+        operation.fee = BigDecimal(line.detail[4..17]) / (10**scale)
       end
 
       CFONB::OperationDetail.register('FEE', self)

data/lib/cfonb/operation_detail/ref.rb

@@ -10,7 +10,7 @@ module CFONB
       def self.apply(operation, line)
         operation.reference = [
           operation.reference,
-          line.detail.strip
+          line.detail.strip,
         ].filter_map(&:presence).join(' - ')
       end
 

data/lib/cfonb/parser.rb

@@ -8,7 +8,7 @@ module CFONB
       PREVIOUS_BALANCE_CODE = '01',
       OPERATION_CODE = '04',
       OPERATION_DETAIL_CODE = '05',
-      NEW_BALANCE_CODE = '07'
+      NEW_BALANCE_CODE = '07',
     ].freeze
 
     def initialize(input)
@@ -52,7 +52,7 @@ module CFONB
 
     def parse_line(line)
       return if line.strip.empty?
-      raise InvalidCodeError, "Invalid line code '#{line.first(2)}'" unless CODES.include?(line.first(2))
+      raise InvalidCodeError.new("Invalid line code '#{line.first(2)}'") unless CODES.include?(line.first(2))
 
       line = CFONB::LineParser.parse(line)
 
@@ -97,7 +97,7 @@ module CFONB
 
         current_operation.merge_detail(line)
       else
-        return handle_error(UnhandledLineCodeError)
+        handle_error(UnhandledLineCodeError)
       end
     end
 

data/lib/cfonb/statement.rb

@@ -9,7 +9,7 @@ module CFONB
         from from_balance
         to to_balance
         operations
-      ]
+      ],
     )
 
     def initialize(line)
@@ -33,7 +33,7 @@ module CFONB
       [
         begin_raw,
         operations.map(&:raw),
-        end_raw
+        end_raw,
       ].join("\n")
     end
 

data/lib/cfonb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'date'
 
 require_relative 'cfonb/refinements/strings'

data/spec/cfonb/line_parser/new_balance_spec.rb

@@ -19,7 +19,7 @@ describe CFONB::LineParser::NewBalance do
         'scale' => 2,
         'account' => '98765432100',
         'date' => Date.new(2019, 5, 15),
-        'amount' => -190.43
+        'amount' => -190.43,
       )
     end
   end

data/spec/cfonb/line_parser/operation_detail_spec.rb

@@ -22,7 +22,7 @@ describe CFONB::LineParser::OperationDetail do
         'internal_operation_code' => '9162',
         'interbank_operation_code' => 'B1',
         'detail_code' => 'LIB',
-        'detail' => 'MENSUEAUHTR13133'
+        'detail' => 'MENSUEAUHTR13133',
       )
     end
   end

data/spec/cfonb/line_parser/operation_spec.rb

@@ -28,7 +28,7 @@ describe CFONB::LineParser::Operation do
         'number' => 7_654_321,
         'exoneration_code' => 'U',
         'unavailability_code' => 'P',
-        'reference' => 'XYZ123'
+        'reference' => 'XYZ123',
       )
     end
   end

data/spec/cfonb/line_parser/previous_balance_spec.rb

@@ -19,7 +19,7 @@ describe CFONB::LineParser::PreviousBalance do
         'scale' => 2,
         'account' => '98765432100',
         'date' => Date.new(2019, 5, 15),
-        'amount' => -190.43
+        'amount' => -190.43,
       )
     end
   end

data/spec/cfonb/operation_spec.rb

@@ -13,7 +13,7 @@ describe CFONB::Operation do
       date: Date.new(2021, 3, 5),
       currency: 'EUR',
       amount: -15,
-      reference: '42'
+      reference: '42',
     )
   end
 
@@ -88,7 +88,7 @@ describe CFONB::Operation do
 
         expect(operation).to have_attributes(
           original_currency: 'USD',
-          original_amount: -12.34
+          original_amount: -12.34,
         )
       end
     end
@@ -118,7 +118,7 @@ describe CFONB::Operation do
         OpenStruct.new(
           body: '',
           detail_code: 'RCN',
-          detail: 'SWILE-CMD-TR-YPDHMA                TICKET RESTO                       '
+          detail: 'SWILE-CMD-TR-YPDHMA                TICKET RESTO                       ',
         )
       end
 
@@ -135,7 +135,7 @@ describe CFONB::Operation do
         OpenStruct.new(
           body: '0530002112701731EUR2E0000073337DA129082300   REFPENNYLANE B13A93908C36C82DF5C319/1                                      ',
           detail_code: 'REF',
-          detail: 'PENNYLANE B13A93908C36C82DF5C319/1                                      '
+          detail: 'PENNYLANE B13A93908C36C82DF5C319/1                                      ',
         )
       end
 
@@ -151,7 +151,7 @@ describe CFONB::Operation do
         OpenStruct.new(
           body: '0530004411001871EUR2 0001016255614090823     FEEEUR200000000000740',
           detail_code: 'FEE',
-          detail: 'EUR200000000000740'
+          detail: 'EUR200000000000740',
         )
       end
 
@@ -159,7 +159,7 @@ describe CFONB::Operation do
         operation.merge_detail(detail)
 
         expect(operation.fee_currency).to eq('EUR')
-        expect(operation.fee).to eq(-7.4)
+        expect(operation.fee).to eq(7.4)
       end
     end
   end

data/spec/cfonb/parser_spec.rb

@@ -12,7 +12,7 @@ describe CFONB::Parser do
       it 'parses correctly' do
         expect(statements).to contain_exactly(
           an_instance_of(CFONB::Statement),
-          an_instance_of(CFONB::Statement)
+          an_instance_of(CFONB::Statement),
         )
 
         expect(statements[0]).to have_attributes(
@@ -23,7 +23,7 @@ describe CFONB::Parser do
           from: Date.new(2019, 5, 15),
           from_balance: -190.4,
           to: Date.new(2019, 5, 16),
-          to_balance: -241.21
+          to_balance: -241.21,
         )
 
         expect(statements[0].operations.size).to eq(3)
@@ -44,7 +44,7 @@ describe CFONB::Parser do
           value_date: Date.new(2019, 5, 16),
           original_currency: nil,
           original_amount: nil,
-          debtor: 'INTERNET SFR'
+          debtor: 'INTERNET SFR',
         )
 
         expect(statements[0].operations[1]).to have_attributes(
@@ -62,7 +62,7 @@ describe CFONB::Parser do
           value_date: Date.new(2019, 5, 16),
           original_currency: nil,
           original_amount: nil,
-          debtor: 'ELEC ERDF'
+          debtor: 'ELEC ERDF',
         )
 
         expect(statements[0].operations[2]).to have_attributes(
@@ -79,7 +79,7 @@ describe CFONB::Parser do
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
           original_currency: nil,
-          original_amount: nil
+          original_amount: nil,
         )
 
         expect(statements[1]).to have_attributes(
@@ -90,7 +90,7 @@ describe CFONB::Parser do
           from: Date.new(2019, 5, 16),
           from_balance: -241.21,
           to: Date.new(2019, 5, 17),
-          to_balance: -163.72
+          to_balance: -163.72,
         )
 
         expect(statements[1].operations.size).to eq(3)
@@ -109,7 +109,7 @@ describe CFONB::Parser do
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
           original_currency: nil,
-          original_amount: nil
+          original_amount: nil,
         )
 
         expect(statements[1].operations[1]).to have_attributes(
@@ -126,7 +126,7 @@ describe CFONB::Parser do
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 15),
           original_currency: nil,
-          original_amount: nil
+          original_amount: nil,
         )
 
         expect(statements[1].operations[2]).to have_attributes(
@@ -143,7 +143,7 @@ describe CFONB::Parser do
           unavailability_code: '0',
           value_date: Date.new(2019, 5, 16),
           original_currency: nil,
-          original_amount: nil
+          original_amount: nil,
         )
       end
     end
@@ -203,7 +203,7 @@ describe CFONB::Parser do
         it 'parses correctly' do
           expect(statements).to contain_exactly(
             an_instance_of(CFONB::Statement),
-            an_instance_of(CFONB::Statement)
+            an_instance_of(CFONB::Statement),
           )
 
           expect(statements[0]).to have_attributes(
@@ -214,7 +214,7 @@ describe CFONB::Parser do
             from: Date.new(2019, 5, 15),
             from_balance: -190.4,
             to: Date.new(2019, 5, 16),
-            to_balance: -241.21
+            to_balance: -241.21,
           )
 
           expect(statements[0].operations.size).to eq(3)
@@ -234,7 +234,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'INTERNET SFR'
+            debtor: 'INTERNET SFR',
           )
 
           expect(statements[0].operations[1]).to have_attributes(
@@ -252,7 +252,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
 
           expect(statements[0].operations[2]).to have_attributes(
@@ -269,7 +269,7 @@ describe CFONB::Parser do
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
             original_currency: nil,
-            original_amount: nil
+            original_amount: nil,
           )
 
           expect(statements[1]).to have_attributes(
@@ -280,7 +280,7 @@ describe CFONB::Parser do
             from: Date.new(2019, 5, 16),
             from_balance: -241.21,
             to: Date.new(2019, 5, 17),
-            to_balance: -163.72
+            to_balance: -163.72,
           )
 
           expect(statements[1].operations.size).to eq(3)
@@ -299,7 +299,7 @@ describe CFONB::Parser do
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
             original_currency: nil,
-            original_amount: nil
+            original_amount: nil,
           )
 
           expect(statements[1].operations[1]).to have_attributes(
@@ -316,7 +316,7 @@ describe CFONB::Parser do
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 15),
             original_currency: nil,
-            original_amount: nil
+            original_amount: nil,
           )
 
           expect(statements[1].operations[2]).to have_attributes(
@@ -333,7 +333,7 @@ describe CFONB::Parser do
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
-            original_amount: nil
+            original_amount: nil,
           )
         end
       end
@@ -359,7 +359,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -385,7 +385,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -411,7 +411,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
         end
       end
@@ -437,7 +437,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
           expect(statements[0].operations[1]).to have_attributes(
             amount: -7.9,
@@ -453,7 +453,7 @@ describe CFONB::Parser do
             unavailability_code: '0',
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
-            original_amount: nil
+            original_amount: nil,
           )
         end
       end
@@ -494,7 +494,7 @@ describe CFONB::Parser do
           value_date: Date.new(2019, 5, 16),
           original_currency: nil,
           original_amount: nil,
-          debtor: 'INTERNET SFR'
+          debtor: 'INTERNET SFR',
         )
       end
     end
@@ -553,7 +553,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'INTERNET SFR'
+            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -577,7 +577,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'INTERNET SFR'
+            debtor: 'INTERNET SFR',
           )
         end
       end
@@ -609,7 +609,7 @@ describe CFONB::Parser do
             value_date: Date.new(2019, 5, 16),
             original_currency: nil,
             original_amount: nil,
-            debtor: 'ELEC ERDF'
+            debtor: 'ELEC ERDF',
           )
         end
       end

data/spec/cfonb/statement_spec.rb

@@ -5,8 +5,8 @@ require 'cfonb'
 describe CFONB::Statement do
   subject(:statement) do
     described_class.new(begin_line)
-                   .tap { _1.operations << operation }
-                   .tap { _1.merge_new_balance(end_line) }
+      .tap { _1.operations << operation }
+      .tap { _1.merge_new_balance(end_line) }
   end
 
   let(:operation) do
@@ -17,22 +17,22 @@ describe CFONB::Statement do
 
   let(:begin_line) do
     CFONB::LineParser.parse(
-      '0115589    00000EUR2 98765432100  150519                                                  0000000001904}150519160519    '
+      '0115589    00000EUR2 98765432100  150519                                                  0000000001904}150519160519    ',
     )
   end
   let(:operation_line) do
     CFONB::LineParser.parse(
-      '0415589916200000EUR2 98765432100B1160519  160519PRLV SEPA TEST CABINET           0000000000000000000322J                '
+      '0415589916200000EUR2 98765432100B1160519  160519PRLV SEPA TEST CABINET           0000000000000000000322J                ',
     )
   end
   let(:detail_line) do
     CFONB::LineParser.parse(
-      '0515589916200000EUR2 98765432100B1160519     LIBMENSUEAUHTR13133                                                        '
+      '0515589916200000EUR2 98765432100B1160519     LIBMENSUEAUHTR13133                                                        ',
     )
   end
   let(:end_line) do
     CFONB::LineParser.parse(
-      '0715489    00000EUR2 98765432100  160519                                                  0000000002412J                '
+      '0715489    00000EUR2 98765432100  160519                                                  0000000002412J                ',
     )
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfonb
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Johan Le Bray
@@ -9,8 +9,78 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-28 00:00:00.000000000 Z
-dependencies: []
+date: 2023-11-08 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: license_finder
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ruboclean
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: An easy to use CFONB format parser
 email: ''
 executables: []
@@ -59,14 +129,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: CFONB parser