cfndsl 0.16.5 → 0.16.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2df6ce4cd8345b6b98c522f4862fe29a3c725274e5032d9df0bb151f8094880
-  data.tar.gz: 50ec4a16897869a33322e936ed1ecd28b30399898669530d6718f5bb10f086bf
+  metadata.gz: 32406255a9011d3aed5a47d015a3b55e3d7f2f500cff17847aba34e29f02e03f
+  data.tar.gz: f340711869f18db7f011c2a9e4dadf928ca32efa12ab977590d54f72d0db37a3
 SHA512:
-  metadata.gz: 315f3fda2e9a1bf5c88ee7f9077640728b6a6172354bdc2e6e38776408990ab55b56b3f5c576f01300ef137b582fe37e45ddbdbc013eb784d1585f7fdbea1ace
-  data.tar.gz: ed0f7aedd0c7bcc64879a6ea0fa28d4682f6e137118572aed6a8a6fcf308953c9e0a1028211d12ef39ce89249b07b94f8e3df999898478019466d4c226a30ebc
+  metadata.gz: 7186f763335491c5777d1194cddce0b96687cfd335cc6d50dcff13ee7491ee25b37713f968d8579c980688bbfa399d3c5b8cd783bef2164416c15214a0ccd029
+  data.tar.gz: 8793e4e15dfad5a6d03ffaf7c43742ee9aedd24d649780366f197a5e9fa7c2f5b81a06cd30122155f8034b0d8011e1e8f7e96ef34d0e1e945945befa999228f1

data/.gitignore

@@ -5,3 +5,5 @@ tmp/
 coverage/
 *.swp
 *.swo
+vendor
+.bundle

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Change Log
 
+## [0.16.6](https://github.com/cfndsl/cfndsl/tree/0.16.6) (2018-05-31)
+[Full Changelog](https://github.com/cfndsl/cfndsl/compare/v0.16.5...0.16.6)
+
+**Fixed bugs:**
+
+- Array Issue for Nested Types [\#349](https://github.com/cfndsl/cfndsl/issues/349)
+
+**Merged pull requests:**
+
+- Array dupe [\#372](https://github.com/cfndsl/cfndsl/pull/372) ([johnf](https://github.com/johnf))
+
+## [v0.16.5](https://github.com/cfndsl/cfndsl/tree/v0.16.5) (2018-04-16)
+[Full Changelog](https://github.com/cfndsl/cfndsl/compare/v0.16.4...v0.16.5)
+
 ## [v0.16.4](https://github.com/cfndsl/cfndsl/tree/v0.16.4) (2018-04-16)
 [Full Changelog](https://github.com/cfndsl/cfndsl/compare/v0.16.3...v0.16.4)
 

data/lib/cfndsl/types.rb

@@ -123,8 +123,8 @@ module CfnDsl
                     # hope that the user knows what he is
                     # doing and stuff them into our existing
                     # array
-                    array_params.each do |_|
-                      existing.push value
+                    array_params.each do |v|
+                      existing.push v
                     end
                   end
                   return existing

data/lib/cfndsl/version.rb

@@ -1,3 +1,3 @@
 module CfnDsl
-  VERSION = '0.16.5'.freeze
+  VERSION = '0.16.6'.freeze
 end

data/spec/aws/nested_arrays_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe CfnDsl::CloudFormationTemplate do
+  subject(:template) { described_class.new }
+
+  describe '#Nested_Arrays' do
+    it 'ensure nested arrays are not duplicated' do
+      template.DirectoryService_SimpleAD(:Test) do
+        VpcSettings do
+          SubnetId ['subnet-a', 'subnet-b']
+        end
+      end
+
+      puts template.to_json
+      expect(template.to_json).to include('"SubnetIds":["subnet-a","subnet-b"]}')
+      expect(template.to_json).not_to include('"SubnetIds":[["subnet-a","subnet-b"],["subnet-a","subnet-b"]]')
+    end
+
+    it 'check multiple invocations work' do
+      template.DirectoryService_SimpleAD(:Test) do
+        VpcSettings do
+          SubnetId 'subnet-a'
+          SubnetId 'subnet-b'
+        end
+      end
+
+      expect(template.to_json).to include('"SubnetIds":["subnet-a","subnet-b"]}')
+    end
+
+    it 'check multiple invocation with arrays works' do
+      template.DirectoryService_SimpleAD(:Test) do
+        VpcSettings do
+          SubnetId ['subnet-a', 'subnet-b']
+          SubnetId ['subnet-c', 'subnet-d']
+        end
+      end
+
+      expect(template.to_json).to include('"SubnetIds":["subnet-a","subnet-b","subnet-c","subnet-d"]')
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cfndsl
 version: !ruby/object:Gem::Version
-  version: 0.16.5
+  version: 0.16.6
 platform: ruby
 authors:
 - Steven Jack
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-16 00:00:00.000000000 Z
+date: 2018-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,6 +106,7 @@ files:
 - spec/aws/iam_managed_policy_spec.rb
 - spec/aws/kms_alias_spec.rb
 - spec/aws/logs_log_group_spec.rb
+- spec/aws/nested_arrays_spec.rb
 - spec/aws/rds_db_instance_spec.rb
 - spec/aws/serverless_spec.rb
 - spec/cfndsl_spec.rb
@@ -150,7 +151,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: AWS Cloudformation DSL
@@ -160,6 +161,7 @@ test_files:
 - spec/aws/iam_managed_policy_spec.rb
 - spec/aws/kms_alias_spec.rb
 - spec/aws/logs_log_group_spec.rb
+- spec/aws/nested_arrays_spec.rb
 - spec/aws/rds_db_instance_spec.rb
 - spec/aws/serverless_spec.rb
 - spec/cfndsl_spec.rb