cfn-nag 0.5.16 → 0.5.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f54fefb56a9075ff84e6c296efce0af7e61af28c1a401994e3f9d231701b8cb9
-  data.tar.gz: 89e772cf489875f245bd7a26fe0b4fb7f2429c042fffe76e09f42f243c03076a
+  metadata.gz: a2aef8ca978e7bec7da91b72542b6ce2a71d5b892ea68742e8ec354a6378baf7
+  data.tar.gz: aac3bcd3d7655b5482df715cd596b2e92d466b121d64c2e427687e1bf816d72e
 SHA512:
-  metadata.gz: 81580a8f9ef1cd1c9f004d55ce7dc9ff6f0e8ccd5e6e3d0082bc40dc5e813e8fd125828a351000936cc5afd930a80da9266627bb9db6cb3cd9799aaef20abf88
-  data.tar.gz: ca919585b93bb22a75337fd0f56a1e0b7067e6d9822160c6b4c4c3d77790cc438db65bdbf84892a3173bd34f15808a96de335ae56f370c332bf85c339af483cf
+  metadata.gz: a32ace894c95bd5ff075a0de2cdb3ba62aa6e749d52ea3395985d0c71c86ba8deebd983ea5783dbe4994f9697da2e882f0361a222b0533ad61fb7e656d821b35
+  data.tar.gz: 4defeed8e3cef607919e4964dbc08a36c54b502ed19decaa5b95cc544c374d7aec6d897bc9f8b62f3fa67ec43705b31b2f3a3836000d12b1c75dcefed67d6287

data/lib/cfn-nag/custom_rules/EMRClusterSecurityConfigurationAttachedRule.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'base'
+
+class EMRClusterSecurityConfigurationAttachedRule < BaseRule
+  def rule_text
+    'EMR Cluster should specify SecurityConfiguration.'
+  end
+
+  def rule_type
+    Violation::WARNING
+  end
+
+  def rule_id
+    'W63'
+  end
+
+  def audit_impl(cfn_model)
+    violating_emr_clusters = cfn_model.resources_by_type('AWS::EMR::Cluster').select do |cluster|
+      # Warn if SecurityConfiguration property is not set or does not exist in this template
+      cluster.securityConfiguration.nil? || cfn_model.resource_by_ref(cluster.securityConfiguration, 'Arn').nil?
+    end
+
+    violating_emr_clusters.map(&:logical_resource_id)
+  end
+end

data/lib/cfn-nag/custom_rules/EMRSecurityConfigurationEncryptionsEnabledAndConfiguredRule.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require 'cfn-nag/violation'
+require_relative 'base'
+
+class EMRSecurityConfigurationEncryptionsEnabledAndConfiguredRule < BaseRule
+  def rule_text
+    'EMR SecurityConfiguration should enable and properly configure encryption at rest and in transit.'
+  end
+
+  def rule_type
+    Violation::WARNING
+  end
+
+  def rule_id
+    'W61'
+  end
+
+  def audit_impl(cfn_model)
+    violating_emr_sec_configs = cfn_model.resources_by_type('AWS::EMR::SecurityConfiguration').select do |sec_config|
+      bad_security_config?(sec_config)
+    end
+
+    violating_emr_sec_configs.map(&:logical_resource_id)
+  end
+
+  private
+
+  def bad_security_config?(security_config_object)
+    # Poorly formatted SecurityConfiguration
+    return true unless security_config_object.securityConfiguration['EncryptionConfiguration']
+
+    encryption_config = security_config_object.securityConfiguration['EncryptionConfiguration']
+
+    # Either encryption type disabled
+    return true unless encryption_config['EnableAtRestEncryption'] && encryption_config['EnableInTransitEncryption']
+
+    bad_at_rest_encryption?(encryption_config) || bad_in_transit_encryption?(encryption_config)
+  end
+
+  def bad_at_rest_encryption?(config)
+    # Missing AtRestEncryptionConfiguration
+    return true unless config.key?('AtRestEncryptionConfiguration')
+
+    # AtRest encryptions misconfigured
+    return true unless \
+      (config['AtRestEncryptionConfiguration'].key?('LocalDiskEncryptionConfiguration') &&
+       config['AtRestEncryptionConfiguration']['LocalDiskEncryptionConfiguration'].key?('EncryptionKeyProviderType')) ||
+      (config['AtRestEncryptionConfiguration'].key?('S3EncryptionConfiguration') &&
+       config['AtRestEncryptionConfiguration']['S3EncryptionConfiguration'].key?('EncryptionMode'))
+
+    false
+  end
+
+  def bad_in_transit_encryption?(config)
+    # Missing InTransitEncryptionConfiguration
+    return true unless config.key?('InTransitEncryptionConfiguration')
+
+    # InTransit encryptions misconfigured
+    return true unless \
+      config['InTransitEncryptionConfiguration'].key?('TLSCertificateConfiguration') &&
+      config['InTransitEncryptionConfiguration']['TLSCertificateConfiguration'].key?('CertificateProviderType')
+
+    false
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cfn-nag
 version: !ruby/object:Gem::Version
-  version: 0.5.16
+  version: 0.5.17
 platform: ruby
 authors:
 - Eric Kascic
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-02 00:00:00.000000000 Z
+date: 2020-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -202,6 +202,8 @@ files:
 - lib/cfn-nag/custom_rules/EMRClusterKerberosAttributesADDomainJoinPasswordRule.rb
 - lib/cfn-nag/custom_rules/EMRClusterKerberosAttributesCrossRealmTrustPrincipalPasswordRule.rb
 - lib/cfn-nag/custom_rules/EMRClusterKerberosAttributesKdcAdminPasswordRule.rb
+- lib/cfn-nag/custom_rules/EMRClusterSecurityConfigurationAttachedRule.rb
+- lib/cfn-nag/custom_rules/EMRSecurityConfigurationEncryptionsEnabledAndConfiguredRule.rb
 - lib/cfn-nag/custom_rules/EbsVolumeEncryptionKeyRule.rb
 - lib/cfn-nag/custom_rules/EbsVolumeHasSseRule.rb
 - lib/cfn-nag/custom_rules/ElastiCacheReplicationGroupAtRestEncryptionRule.rb