cf_script 0.0.1 → 0.0.2

data/test/lib/cf_script/command/cf/apps/app_test.rb

@@ -37,13 +37,13 @@ describe 'AppCommand' do
     fake_cf app: :empty do
       result = command.run(:worker)
 
-      assert_equal nil, result
+      assert_nil result
     end
   end
 
   it "returns nil when the app is not found" do
     fake_cf app: :not_found do
-      assert_equal nil, command.run(:api)
+      assert_nil command.run(:api)
     end
   end
 

data/test/lib/cf_script/command/cf/apps/delete_test.rb

@@ -21,7 +21,7 @@ describe 'DeleteCommand' do
     fake_cf delete: :not_exist do |stdout, stderr|
       command.run(:name)
 
-      assert_match /\{delete\} failed to delete app/, stderr.lines.first
+      assert_match(/\{delete\} failed to delete app/, stderr.lines.first)
     end
   end
 

data/test/lib/cf_script/command/cf/apps/push_test.rb

@@ -23,7 +23,7 @@ describe 'PushCommand' do
     fake_cf push: :empty do
       result = command.run(:api)
 
-      assert_equal nil, result
+      assert_nil result
     end
   end
 

data/test/lib/cf_script/command/cf/apps/rename_test.rb

@@ -21,7 +21,7 @@ describe 'RenameCommand' do
     fake_cf rename: :not_found do |stdout, stderr|
       command.run(:old, :new)
 
-      assert_match /\{rename\} failed to rename/, stderr.lines.first
+      assert_match(/\{rename\} failed to rename/, stderr.lines.first)
     end
   end
 
@@ -29,7 +29,7 @@ describe 'RenameCommand' do
     fake_cf rename: :not_found do |stdout, stderr|
       assert_equal false, command.run(:old, :new)
 
-      assert_match /\{rename\} failed to rename/, stderr.lines.first
+      assert_match(/\{rename\} failed to rename/, stderr.lines.first)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/restage_test.rb

@@ -43,13 +43,13 @@ describe 'RestageCommand' do
     fake_cf restage: :empty do
       result = command.run(:api)
 
-      assert_equal nil, result
+      assert_nil result
     end
   end
 
   it "returns nil on failure" do
     fake_cf restage: :not_found do
-      assert_equal nil, command.run(:some_app)
+      assert_nil command.run(:some_app)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/restart_app_instance_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'
+
+describe 'RestartAppInstanceCommand' do
+  include MockExecution
+
+  let(:command) { CfScript::Command::Apps::RestartAppInstanceCommand.instance }
+
+  it_behaves_like 'a command object that', {
+    has_type:  :apps,
+    has_name:  :restart_app_instance,
+    fails_with: false
+  }
+
+  it "returns true on success" do
+    fake_cf do
+      assert_equal true, command.run(:worker, 0)
+    end
+  end
+
+  it "prints an error on failure" do
+    fake_cf restart_app_instance: :not_found do |stdout, stderr|
+      command.run(:bogus, 0)
+
+      assert_match(
+        /\{restart_app_instance\} failed to restart app instance 0/,
+        stderr.lines.first
+      )
+    end
+  end
+
+  it "returns false when the app is not found" do
+    fake_cf restart_app_instance: :not_found do |stdout, stderr|
+      assert_equal false, command.run(:bogus, 0)
+
+      assert_match(
+        /\{restart_app_instance\} failed to restart app instance 0/,
+        stderr.lines.first
+      )
+    end
+  end
+end

data/test/lib/cf_script/command/cf/apps/restart_test.rb

@@ -43,13 +43,13 @@ describe 'RestartCommand' do
     fake_cf restart: :empty do
       result = command.run(:worker)
 
-      assert_equal nil, result
+      assert_nil result
     end
   end
 
   it "returns nil on failure" do
     fake_cf restart: :not_found do
-      assert_equal nil, command.run(:some_app)
+      assert_nil command.run(:some_app)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/scale_test.rb

@@ -0,0 +1,51 @@
+require 'test_helper'
+
+describe 'ScaleCommand' do
+  include MockExecution
+
+  let(:command) { CfScript::Command::Apps::ScaleCommand.instance }
+
+  it_behaves_like 'a command object that', {
+    has_type:   :apps,
+    has_name:   :scale,
+    fails_with: nil
+  }
+
+  it "returns true on success" do
+    fake_cf do
+      result = command.run(:worker)
+
+      assert_instance_of TrueClass, result
+    end
+  end
+
+  it "returns false if no attributes were found" do
+    fake_cf scale: :empty do
+      result = command.run(:api)
+
+      assert_equal false, result
+    end
+  end
+
+  it "translates long option names to cf's short ones" do
+    fake_cf do
+      assert_equal({ f: 'a' }, command.translate_options({ force_restart: 'a' }))
+      assert_equal({ i: 'a' }, command.translate_options({ instances: 'a' }))
+      assert_equal({ m: 'a' }, command.translate_options({ memory: 'a' }))
+      assert_equal({ k: 'a' }, command.translate_options({ disk: 'a' }))
+
+      assert_equal(
+        { i: 'a', m: 'b', k: 'c' },
+        command.translate_options(
+          { instances: 'a',  memory: 'b', disk: 'c' }
+        )
+      )
+    end
+  end
+
+  it "builds options and flag for run_cf" do
+    assert_command_args command,
+      [:worker, i: 2, memory: '123', disk: '345'],
+      [:worker, { i: 2, m: '123', k: '345' }]
+  end
+end

data/test/lib/cf_script/command/cf/apps/set_env_test.rb

@@ -32,7 +32,7 @@ describe 'SetEnvCommand' do
       result = command.run(:api, 'API_PASSWORD', 'password')
 
       assert_equal false, result
-      assert_match /\{set_env\} FAILED/, stderr.lines.first
+      assert_match(/\{set_env\} FAILED/, stderr.lines.first)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/start_test.rb

@@ -51,13 +51,13 @@ describe 'StartCommand' do
     fake_cf start: :empty do
       result = command.run(:worker)
 
-      assert_equal nil, result
+      assert_nil result
     end
   end
 
   it "returns nil on failure" do
     fake_cf start: :not_found do
-      assert_equal nil, command.run(:some_app)
+      assert_nil command.run(:some_app)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/stop_test.rb

@@ -21,7 +21,7 @@ describe 'StopCommand' do
     fake_cf stop: :not_found do |stdout, stderr|
       command.run(:bogus)
 
-      assert_match /\{stop\} failed to stop/, stderr.lines.first
+      assert_match(/\{stop\} failed to stop/, stderr.lines.first)
     end
   end
 
@@ -29,7 +29,7 @@ describe 'StopCommand' do
     fake_cf stop: :not_found do |stdout, stderr|
       assert_equal false, command.run(:bogus)
 
-      assert_match /\{stop\} failed to stop/, stderr.lines.first
+      assert_match(/\{stop\} failed to stop/, stderr.lines.first)
     end
   end
 end

data/test/lib/cf_script/command/cf/apps/unset_env_test.rb

@@ -32,7 +32,7 @@ describe 'UnsetEnvCommand' do
       result = command.run(:bogus, 'VAR_NAME')
 
       assert_equal false, result
-      assert_match /\{unset_env\} FAILED/, stderr.lines.first
+      assert_match(/\{unset_env\} FAILED/, stderr.lines.first)
     end
   end
 end

data/test/lib/cf_script/command/cf/general/api_test.rb

@@ -24,7 +24,7 @@ describe 'ApiCommand' do
 
     it "returns nil when the api endpoint is not set" do
       fake_cf api: :not_set do |stdout, stderr|
-        assert_equal nil, command.run
+        assert_nil command.run
       end
     end
   end
@@ -42,13 +42,13 @@ describe 'ApiCommand' do
 
     it "returns nil when the argument is invalid" do
       fake_cf api: :bad_argument do |stdout, stderr|
-        assert_equal nil, command.run('')
+        assert_nil command.run('')
       end
     end
 
     it "returns nil when the endpoint is invalid" do
       fake_cf api: :bad_endpoint do |stdout, stderr|
-        assert_equal nil, command.run('https://api.example.com')
+        assert_nil command.run('https://api.example.com')
       end
     end
   end

data/test/lib/cf_script/command/cf/general/target_test.rb

@@ -13,7 +13,7 @@ describe 'TargetCommand' do
 
   it "returns nil and prints an error on parsing failure" do
     fake_cf target: :empty do |stdout, stderr|
-      assert_equal nil, command.run
+      assert_nil command.run
 
       assert_includes stderr.lines, "{target} object is nil\n"
     end
@@ -75,7 +75,7 @@ describe 'TargetCommand' do
 
     it "returns nil and prints an error when the space is not found" do
       fake_cf do |stdout, stderr|
-        assert_equal nil, command.run(:not_found)
+        assert_nil command.run(:not_found)
 
         assert_includes stderr.lines, "{target} Space not_found not found\n"
       end

data/test/lib/cf_script/command/cf/routes/map_route_test.rb

@@ -34,9 +34,9 @@ describe 'MapRouteCommand' do
     fake_cf map_route: :invalid do |stdout, stderr|
       assert_equal false, command.run(:api, 'example.com')
 
-      assert_match /\{map_route\}/, stderr.lines.last
-      assert_match /Server error/, stderr.lines.last
-      assert_match /route is invalid/, stderr.lines.last
+      assert_match(/\{map_route\}/, stderr.lines.last)
+      assert_match(/Server error/, stderr.lines.last)
+      assert_match(/route is invalid/, stderr.lines.last)
     end
   end
 
@@ -60,9 +60,9 @@ describe 'MapRouteCommand' do
     fake_cf map_route: :host_taken do |stdout, stderr|
       assert_equal false, command.run(:api, 'example.com')
 
-      assert_match /\{map_route\}/, stderr.lines.last
-      assert_match /Server error/, stderr.lines.last
-      assert_match /The host is taken: api/, stderr.lines.last
+      assert_match(/\{map_route\}/, stderr.lines.last)
+      assert_match(/Server error/, stderr.lines.last)
+      assert_match(/The host is taken: api/, stderr.lines.last)
     end
   end
 end

data/test/lib/cf_script/command/cf/routes/routes_test.rb

@@ -26,7 +26,7 @@ describe 'RoutesCommand' do
     fake_cf routes: :empty do
       routes = command.run
 
-      assert_equal nil, routes
+      assert_nil routes
     end
   end
 end

data/test/lib/cf_script/command/cf/spaces/space_test.rb

@@ -34,7 +34,7 @@ describe 'SpaceCommand' do
     fake_cf space: :empty do
       space = command.run(:space)
 
-      assert_equal nil, space
+      assert_nil space
     end
   end
 

data/test/lib/cf_script/command/cf/spaces/spaces_test.rb

@@ -24,7 +24,7 @@ describe 'SpacesCommand' do
     fake_cf spaces: :empty do
       spaces = command.run
 
-      assert_equal nil, spaces
+      assert_nil spaces
     end
   end
 

data/test/lib/cf_script/command/line_test.rb

@@ -4,7 +4,9 @@ describe CfScript::Command::Line do
   subject { CfScript::Command::Line }
 
   it "initializes bin, name, args, options, and flags" do
-    line = subject.new({ foo: :bar}, 'bin', :test, :dummy, [:arg1, :arg2, { i: 1, o: 2, flags: [:s] }])
+    line = subject.new({ foo: :bar }, 'bin', :test, :dummy,
+      [:arg1, :arg2, { i: 1, o: 2, flags: [:s] }]
+    )
 
     assert_equal 'bin',          line.bin
     assert_equal :dummy,         line.name
@@ -15,19 +17,25 @@ describe CfScript::Command::Line do
 
   describe "line" do
     it "returns a formatted command line" do
-      line = subject.new({}, 'cf', :test, :dummy, [:arg1, :arg2, { i: 1, o: 2, flags: [:s] }])
+      line = subject.new({}, 'cf', :test, :dummy,
+        [:arg1, :arg2, { i: 1, o: 2, flags: [:s] }]
+      )
 
       assert_equal 'cf dummy arg1 arg2 -i 1 -o 2 -s', line.line
     end
 
     it "formats long flag names" do
-      line = subject.new({}, 'cf', :test, :dummy, [:arg1, { i: 1, flags: [:some_thing] }])
+      line = subject.new({}, 'cf', :test, :dummy,
+        [:arg1, { i: 1, flags: [:some_thing] }]
+      )
 
       assert_equal 'cf dummy arg1 -i 1 --some-thing', line.line
     end
 
     it "pass preformatted flags as is" do
-      line = subject.new({}, 'cf', :test, :dummy, [:arg1, { i: 1, flags: ['--one', '--foo-bar'] }])
+      line = subject.new({}, 'cf', :test, :dummy,
+        [:arg1, { i: 1, flags: ['--one', '--foo-bar'] }]
+      )
 
       assert_equal 'cf dummy arg1 -i 1 --one --foo-bar', line.line
     end
@@ -50,10 +58,10 @@ describe CfScript::Command::Line do
       line = subject.new({}, 'cf', :test, :login, [test])
       text = line.hide_sensitive
 
-      assert_match /cf login /, text
-      assert_match /-p \[PASSWORD HIDDEN\]/, text
-      assert_match /-u name/, text
-      assert_match /-a work/, text
+      assert_match(/cf login /, text)
+      assert_match(/-p \[PASSWORD HIDDEN\]/, text)
+      assert_match(/-u name/, text)
+      assert_match(/-a work/, text)
     end
   end
 end

data/test/lib/cf_script/command/registry_test.rb

@@ -0,0 +1,53 @@
+require 'test_helper'
+
+describe CfScript::Command::Registry do
+  subject { CfScript::Command::Registry.new }
+
+  class DummyCommand < CfScript::Command::Base
+    def initialize
+      super(:test, :dummy)
+    end
+  end
+
+  it "starts with zero commands" do
+    assert_equal({}, subject.commands)
+  end
+
+  describe "known?" do
+    it "returns false when given command is not registered" do
+      assert_equal false, subject.known?(:dummy)
+    end
+
+    it "returns true when given command is registered" do
+      subject.add! DummyCommand
+
+      assert_equal true, subject.known?(:dummy)
+    end
+  end
+
+  describe "check!" do
+    it "raises an exception for unknown commands" do
+      assert_raises(CfScript::Command::Registry::UnimplementedCommand) {
+        subject.check! :dummy
+      }
+    end
+  end
+
+  describe "add!" do
+    it "adds commands" do
+      assert_equal false, subject.known?(:dummy)
+
+      subject.add! DummyCommand
+
+      assert_equal true, subject.known?(:dummy)
+    end
+
+    it "raises an exception for duplicate commands" do
+      subject.add! DummyCommand
+
+      assert_raises(CfScript::Command::Registry::DuplicateCommand) {
+        subject.add! DummyCommand
+      }
+    end
+  end
+end

data/test/lib/cf_script/object/api_endpoint_test.rb

@@ -6,8 +6,8 @@ describe CfScript::ApiEndpoint do
   it "initializes all attributes to sensible defaults" do
     api_endpoint = subject.new
 
-    assert_equal nil, api_endpoint.url
-    assert_equal nil, api_endpoint.version
+    assert_nil api_endpoint.url
+    assert_nil api_endpoint.version
   end
 
   it "sets all given attributes" do