cf 0.6.1.rc2 → 0.6.1.rc3

data/lib/cf/cli/start/login.rb

@@ -60,6 +60,8 @@ module CF::Start
         end
       end
 
+      return if failed
+
       info.merge!(auth_token.to_hash)
       save_target_info(info)
       invalidate_client

data/lib/cf/version.rb

@@ -1,3 +1,3 @@
 module CF
-  VERSION = "0.6.1.rc2".freeze
+  VERSION = "0.6.1.rc3".freeze
 end

data/spec/cf/cli/start/login_spec.rb

@@ -61,6 +61,20 @@ command CF::Start::Login do
       expect(tokens_yaml["https://api.some-domain.com"][:refresh_token]).to eq("some-new-refresh-token")
     end
 
+    context "when the user logs in with invalid credentials" do
+      before do
+        stub_ask("Username", {}) { "my-username" }
+        stub_ask("8-digit PIN", {:echo => "*", :forget => true}) { "my-password" }
+
+        stub(client).login("my-username", "my-password") { raise CFoundry::Denied }
+      end
+
+      it "informs the user gracefully" do
+        subject
+        expect(output).to say("Authenticating... FAILED")
+      end
+    end
+
     context "with space and org in the token file" do
       before do
         write_token_file(:space => "space-id-1", :organization => "organization-id-1")
@@ -99,7 +113,7 @@ command CF::Start::Login do
 
         context "with one organization" do
           let(:organizations) {
-            [ organization ]
+            [organization]
           }
 
           it "does not prompt for an organization" do
@@ -112,7 +126,7 @@ command CF::Start::Login do
 
         context "with multiple organizations" do
           let(:organizations) {
-            [ organization, OpenStruct.new(:name => 'My Org 2', :guid => 'organization-id-2') ]
+            [organization, OpenStruct.new(:name => 'My Org 2', :guid => 'organization-id-2')]
           }
 
           before do

data/spec/features/account_lifecycle_spec.rb

@@ -90,6 +90,14 @@ if ENV['CF_V2_TEST_USER'] && ENV['CF_V2_TEST_PASSWORD'] && ENV['CF_V2_TEST_TARGE
 
       run("#{cf_bin} login #{email} --password p") do |runner|
         expect(runner).to say "Authenticating... FAILED"
+
+        expect(runner).to say "Password>"
+        runner.send_keys "another_password"
+        expect(runner).to say "Password>"
+        runner.send_keys "passwords_for_everyone"
+        expect(runner).to say "FAILED"
+        runner.output.should_not =~ /CFoundry::/
+        runner.output.should_not =~ %r{~/\.cf/crash}
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cf
 version: !ruby/object:Gem::Version
-  version: 0.6.1.rc2
+  version: 0.6.1.rc3
   prerelease: 6
 platform: ruby
 authors:
@@ -67,7 +67,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.6.1.rc2
+        version: 0.6.1.rc3
     - - <
       - !ruby/object:Gem::Version
         version: '0.7'
@@ -78,7 +78,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.6.1.rc2
+        version: 0.6.1.rc3
     - - <
       - !ruby/object:Gem::Version
         version: '0.7'
@@ -354,7 +354,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3541781099873169759
+      hash: 1521493965711051536
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -363,7 +363,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: cf
-rubygems_version: 1.8.25
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Friendly command-line interface for Cloud Foundry.