cetus 0.1.21 → 0.1.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e35fd2792cfb584909c6ddadfaeb6b30e92ff09b4f838585a85f8de977c333e
-  data.tar.gz: f2b2f7e300a593f9ba2973d8451f4148f9057c5bc4680ad3c9ac77075ae6f19e
+  metadata.gz: 040badb6cd9462f5d5a2fe5f5b5e320c03fbbd80984d71e526c500bdd0781822
+  data.tar.gz: c48f55c076c32815785341986791e680b990b3fbf3bf1d519835b70331790a52
 SHA512:
-  metadata.gz: 6ab765cb054741e0d6951040d7b655d7235d1c583646c96f8bd1b12d74778fd05a735b0a3864e3f87e4b1652316a3bef6b966745bba3d3efe113d46cde306826
-  data.tar.gz: 1d723a6b666671544a081e426ecf34df28a6fa02bd158fed08f9c89873dbef12a050f66caf286f3231847aa622783abcb41da1285ce0b75104a9fe999658ee1c
+  metadata.gz: a7a6655724e7b3e5e46d20d8bf0cc90a3032aacdca0dbbbb4d4348c87c845e8a974574f2530781ff44a7860ed1d3f9eb8e0c5caa952411963106ac3622fc39f9
+  data.tar.gz: c61c40989b45d3e4c2ecc04d6a04ceae2722fbf3d0d582e37fb86b4e00b5d78582c16edd18fef1c58ad86e3c20038d4ae3b5455270c7da25dba2bcdb19f27c75

data/bin/cetus

@@ -1,19 +1,20 @@
 #!/usr/bin/env ruby
-# ----------------------------------------------------------------------------- #
+# --------------------------------------------------------------------------- #
 #         File: cetus
 #  Description: Fast file navigation, a tiny version of zfm
 #               but with a different indexing mechanism
 #       Author: rkumar http://github.com/rkumar/cetus/
 #         Date: 2013-02-17 - 17:48
 #      License: GPL
-#  Last update: 2019-03-04 23:50
-# ----------------------------------------------------------------------------- #
-#  cetus.rb  Copyright (C) 2012-2013 rahul kumar
+#  Last update: 2019-03-10 15:07
+# --------------------------------------------------------------------------- #
+#  cetus.rb  Copyright (C) 2012-2019 rahul kumar
 # == CHANGELOG
 # 2019-02-20 - added smcup and rmcup so alt-screen is used. works a bit
 # 2019-03-04 - change clear to go to 0,0 and clear down to reduce pollution
 # 2019-03-04 - changed quit to q (earlier Q)
 # 2019-03-04 - first dirs then files
+# 2019-03-10 - changing selected_files to have fullpath
 #  == TODO
 #  To dirs add GEMHOME RUBYLIB PYTHONILB or PYTHONPATH,
 #  Make rubygem aware : gemspec or Gemfile the expand lib and bin
@@ -23,10 +24,9 @@ require 'readline'
 require 'io/wait'
 # http://www.ruby-doc.org/stdlib-1.9.3/libdoc/shellwords/rdoc/Shellwords.html
 require 'shellwords'
+# https://docs.ruby-lang.org/en/2.6.0/FileUtils.html
 require 'fileutils'
 # -- requires 1.9.3 for io/wait
-# -- cannot do with Highline since we need a timeout on wait,
-#   not sure if HL can do that
 
 ## INSTALLATION
 # copy into PATH
@@ -35,113 +35,119 @@ require 'fileutils'
 
 # 2019-02-20 - added so alt-screen is used
 system 'tput smcup'
-VERSION = '0.1.21.0'
+VERSION = '0.1.22.0'.freeze
 O_CONFIG = true
-CONFIG_FILE = '~/.lyrainfo'
+# CONFIG_FILE = '~/.lyrainfo'.freeze
+CONFIG_FILE = '~/.config/cetus/conf.yml'.freeze
 
 $bindings = {}
 $bindings = {
-  '`'   => 'main_menu',
-  '='   => 'toggle_menu',
-  '!'   => 'command_mode',
-  '@'   => 'selection_mode_toggle',
+  '`' => 'main_menu',
+  '=' => 'toggle_menu',
+  '!' => 'command_mode',
+  '@' => 'selection_mode_toggle',
   'M-a' => 'select_all',
   'M-A' => 'unselect_all',
-  ','   => 'goto_parent_dir',
-  '+'   => 'goto_dir',
-  '.'   => 'pop_dir',
-  ':'   => 'subcommand',
-  "'"   => 'goto_bookmark',
-  '/'   => 'enter_regex',
-  'M-p'   => 'prev_page',
-  'M-n'   => 'next_page',
-  'SPACE'   => 'next_page',
-  'M-f'   => 'select_visited_files',
-  'M-d'   => 'select_used_dirs',
-  'M-b'   => 'select_bookmarks',
-  'M-m'   => 'create_bookmark',
-  'M-M'   => 'show_marks',
-  'C-c'   => 'escape',
-  'ESCAPE'   => 'escape',
-  'TAB'   => 'views',
-  'C-i'   => 'views',
-  '?'   => 'dirtree',
-  'ENTER'   => 'select_current',
-  'D'   => 'delete_file',
-  'M'   => 'file_actions most',
-  'q'   => 'quit_command', # was Q now q 2019-03-04 -
-  #"RIGHT"   => "column_next",
-  'RIGHT'   => 'select_current', # changed 2018-03-12 - for faster navigation
-  'LEFT'   => 'goto_parent_dir', # changed on 2018-03-12 - earlier column_next 1
-  ']'   => 'column_next',
-  '['   => 'column_next 1',
-  'C-x'   => 'file_actions',
-  'M--'   => 'columns_incdec -1',
-  'M-+'   => 'columns_incdec 1',
-  'S'     =>  'command_file list y ls -lh',
-  'L'     =>  'command_file Page n less',
-  'C-d'   =>  'cursor_scroll_dn',
-  'C-b'   =>  'cursor_scroll_up',
-  'UP'   =>  'cursor_up',
-  'DOWN'   =>  'cursor_dn',
+  ',' => 'goto_parent_dir',
+  '~' => 'goto_home_dir',
+  '-' => 'goto_previous_dir', # 2019-03-07 - added. like 'cd ='
+  '+' => 'goto_dir',       # 2019-03-07 - TODO: change binding
+  '.' => 'pop_dir',
+  ':' => 'subcommand',
+  "'" => 'goto_bookmark',
+  '/' => 'enter_regex',
+  'M-p' => 'prev_page',
+  'M-n' => 'next_page',
+  'SPACE' => 'next_page',
+  'M-f' => 'select_visited_files',
+  'M-d' => 'select_used_dirs',
+  'M-b' => 'select_bookmarks',
+  'M-m' => 'create_bookmark',
+  'M-M' => 'show_marks',
+  'C-c' => 'escape',
+  'ESCAPE' => 'escape',
+  'TAB' => 'views',
+  'C-i' => 'views',
+  '?' => 'dirtree',
+  'ENTER' => 'select_current',
+  'C-p' => 'page_current',
+  'C-e' => 'edit_current',
+  'C-o' => 'edit_current',
+  'D' => 'delete_file',
+  'M' => 'file_actions most',
+  'q' => 'quit_command', # was Q now q 2019-03-04 -
+  # "RIGHT"   => "column_next",
+  'RIGHT' => 'select_current', # changed 2018-03-12 - for faster navigation
+  'LEFT' => 'goto_parent_dir', # changed on 2018-03-12 - earlier column_next 1
+  ']' => 'column_next',
+  '[' => 'column_next 1',
+  'C-x' => 'file_actions',
+  'M--' => 'columns_incdec -1',
+  'M-+' => 'columns_incdec 1',
+  'S' => 'command_file list y ls -lh',
+  'L' => 'command_file Page n less',
+  'C-d' => 'cursor_scroll_dn',
+  'C-b' => 'cursor_scroll_up',
+  'UP' => 'cursor_up',
+  'DOWN' => 'cursor_dn',
   'C-SPACE' => 'visual_mode_toggle',
 
-  'M-?'   => 'print_help',
-  'F1'   => 'print_help',
-  'F2'   => 'child_dirs',
-  'F3'   => 'dirtree',
-  'F4'   => 'tree',
-  'S-F1'   => 'dirtree',
-  'S-F2'   => 'tree'
+  'M-?' => 'print_help',
+  'F1' => 'print_help',
+  'F2' => 'child_dirs',
+  'F3' => 'dirtree',
+  'F4' => 'tree',
+  'S-F1' => 'dirtree',
+  'S-F2' => 'tree'
 
 }
 
 ## clean this up a bit, copied from shell program and macro'd
-$kh=Hash.new
-$kh["OP"]="F1"
-$kh[""]="UP"
-$kh["[5~"]="PGUP"
-$kh['']="ESCAPE"
-KEY_PGDN="[6~"
-KEY_PGUP="[5~"
+$kh = {}
+$kh["\eOP"] = 'F1'
+$kh["\e[A"] = 'UP'
+$kh["\e[5~"] = 'PGUP'
+$kh[''] = 'ESCAPE'
+KEY_PGDN = "\e[6~".freeze
+KEY_PGUP = "\e[5~".freeze
 ## I needed to replace the O with a [ for this to work
 #  in Vim Home comes as ^[OH whereas on the command line it is correct as ^[[H
-KEY_HOME=''
-KEY_END=""
-KEY_F1="OP"
-KEY_UP=""
-KEY_DOWN=""
-
-$kh[KEY_PGDN]="PgDn"
-$kh[KEY_PGUP]="PgUp"
-$kh[KEY_HOME]="Home"
-$kh[KEY_END]="End"
-$kh[KEY_F1]="F1"
-$kh[KEY_UP]="UP"
-$kh[KEY_DOWN]="DOWN"
-KEY_LEFT=''
-KEY_RIGHT=''
-$kh["OQ"]="F2"
-$kh["OR"]="F3"
-$kh["OS"]="F4"
-$kh[KEY_LEFT] = "LEFT"
-$kh[KEY_RIGHT]= "RIGHT"
-KEY_F5='[15~'
-KEY_F6='[17~'
-KEY_F7='[18~'
-KEY_F8='[19~'
-KEY_F9='[20~'
-KEY_F10='[21~'
-KEY_S_F1=''
-$kh[KEY_F5]="F5"
-$kh[KEY_F6]="F6"
-$kh[KEY_F7]="F7"
-$kh[KEY_F8]="F8"
-$kh[KEY_F9]="F9"
-$kh[KEY_F10]="F10"
+KEY_HOME = ''.freeze
+KEY_END = "\e[F".freeze
+KEY_F1 = "\eOP".freeze
+KEY_UP = "\e[A".freeze
+KEY_DOWN = "\e[B".freeze
+
+$kh[KEY_PGDN] = 'PgDn'
+$kh[KEY_PGUP] = 'PgUp'
+$kh[KEY_HOME] = 'Home'
+$kh[KEY_END] = 'End'
+$kh[KEY_F1] = 'F1'
+$kh[KEY_UP] = 'UP'
+$kh[KEY_DOWN] = 'DOWN'
+KEY_LEFT = ''.freeze
+KEY_RIGHT = ''.freeze
+$kh["\eOQ"] = 'F2'
+$kh["\eOR"] = 'F3'
+$kh["\eOS"] = 'F4'
+$kh[KEY_LEFT] = 'LEFT'
+$kh[KEY_RIGHT] = 'RIGHT'
+KEY_F5 = '[15~'.freeze
+KEY_F6 = '[17~'.freeze
+KEY_F7 = '[18~'.freeze
+KEY_F8 = '[19~'.freeze
+KEY_F9 = '[20~'.freeze
+KEY_F10 = '[21~'.freeze
+KEY_S_F1 = ''.freeze
+$kh[KEY_F5] = 'F5'
+$kh[KEY_F6] = 'F6'
+$kh[KEY_F7] = 'F7'
+$kh[KEY_F8] = 'F8'
+$kh[KEY_F9] = 'F9'
+$kh[KEY_F10] = 'F10'
 # testing out shift+Function. these are the codes my kb generates
-$kh[KEY_S_F1]="S-F1"
-$kh['']="S-F2"
+$kh[KEY_S_F1] = 'S-F1'
+$kh[''] = 'S-F2'
 
 def old_clear_screen
   system 'clear'
@@ -169,16 +175,16 @@ end
 # copied from fff
 # Call before shelling to editor pager and when exiting
 def reset_terminal
-    # Reset the terminal to a useable state (undo all changes).
-    # '\e[?7h':  Re-enable line wrapping.
-    # '\e[?25h': Unhide the cursor.
-    # '\e[2J':   Clear the terminal.
-    # '\e[;r':   Set the scroll region to its default value.
-    #            Also sets cursor to (0,0).
-    print "\e[?7h\e[?25h\e[2J\e[;r"
+  # Reset the terminal to a useable state (undo all changes).
+  # '\e[?7h':  Re-enable line wrapping.
+  # '\e[?25h': Unhide the cursor.
+  # '\e[2J':   Clear the terminal.
+  # '\e[;r':   Set the scroll region to its default value.
+  #            Also sets cursor to (0,0).
+  print "\e[?7h\e[?25h\e[2J\e[;r"
 
-    # Show user input.
-    system 'stty echo'
+  # Show user input.
+  system 'stty echo'
 end
 
 # copied from fff
@@ -197,107 +203,115 @@ def setup_terminal
   system 'stty -echo'
 end
 
+# wrap readline so C-c can be ignored, but blank is taken as default
+def readline
+  begin
+    target = Readline.readline('>', true)
+  rescue Interrupt
+    return nil
+  end
+  target
+end
+
 ## get a character from user and return as a string
 # Adapted from:
-#http://stackoverflow.com/questions/174933/how-to-get-a-single-character-without-pressing-enter/8274275#8274275
+# http://stackoverflow.com/questions/174933/how-to-get-a-single-character-without-pressing-enter/8274275#8274275
 # Need to take complex keys and matc against a hash.
 def get_char
-  begin
-    system('stty raw -echo 2>/dev/null') # turn raw input on
-    c = nil
-    #if $stdin.ready?
-    c = $stdin.getc
-    cn = c.ord
-    return 'ENTER' if cn == 10 || cn == 13
-    return 'BACKSPACE' if cn == 127
-    return 'C-SPACE' if cn == 0
-    return 'SPACE' if cn == 32
-    # next does not seem to work, you need to bind C-i
-    return 'TAB' if cn == 8
-
-    if cn >= 0 && cn < 27
-      x = cn + 96
-      return "C-#{x.chr}"
-    end
-    if c == ''
-      buff=c.chr
-      while true
-        k = nil
-        if $stdin.ready?
-          k = $stdin.getc
-          #puts "got #{k}"
-          buff += k.chr
-        else
-          x = $kh[buff]
-          return x if x
-
-          # puts "returning with  #{buff}"
-          if buff.size == 2
-            ## possibly a meta/alt char
-            k = buff[-1]
-            return "M-#{k.chr}"
-          end
-          return buff
+  system('stty raw -echo 2>/dev/null') # turn raw input on
+  c = nil
+  # if $stdin.ready?
+  c = $stdin.getc
+  cn = c.ord
+  return 'ENTER' if cn == 10 || cn == 13
+  return 'BACKSPACE' if cn == 127
+  return 'C-SPACE' if cn == 0
+  return 'SPACE' if cn == 32
+  # next does not seem to work, you need to bind C-i
+  return 'TAB' if cn == 8
+
+  if cn >= 0 && cn < 27
+    x = cn + 96
+    return "C-#{x.chr}"
+  end
+  if c == ''
+    buff = c.chr
+    loop do
+      k = nil
+      if $stdin.ready?
+        k = $stdin.getc
+        # puts "got #{k}"
+        buff += k.chr
+      else
+        x = $kh[buff]
+        return x if x
+
+        # puts "returning with  #{buff}"
+        if buff.size == 2
+          ## possibly a meta/alt char
+          k = buff[-1]
+          return "M-#{k.chr}"
         end
+        return buff
       end
     end
-    #end
-    return c.chr if c
-  ensure
-    #system "stty -raw echo" # turn raw input off
-    system('stty -raw echo 2>/dev/null') # turn raw input on
   end
+  # end
+  return c.chr if c
+ensure
+  # system "stty -raw echo" # turn raw input off
+  system('stty -raw echo 2>/dev/null') # turn raw input on
 end
 
 ## GLOBALS
-#$IDX="123456789abcdefghijklmnoprstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
-#$IDX="abcdefghijklmnopqrstuvwxy"
-$IDX=('a'..'y').to_a
+# $IDX="123456789abcdefghijklmnoprstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
+# $IDX="abcdefghijklmnopqrstuvwxy"
+$IDX = ('a'..'y').to_a
 $IDX.delete 'q'
 $IDX.concat ('za'..'zz').to_a
 $IDX.concat ('Za'..'Zz').to_a
 $IDX.concat ('ZA'..'ZZ').to_a
 
-$selected_files = Array.new
+$selected_files = []
 $bookmarks = {}
 $mode = nil
-$glines=%x(tput lines).to_i
-$gcols=%x(tput cols).to_i
+$glines = `tput lines`.to_i
+$gcols = `tput cols`.to_i
 $grows = $glines - 3
 $pagesize = 60
 $gviscols = 3
 $pagesize = $grows * $gviscols
 $stact = 0
-#$editor_mode = true
+# $editor_mode = true
 $editor_mode = false # changed 2018-03-12 - so we start in pager mode
 $enhanced_mode = true
 $visual_block_start = nil
 $pager_command = {
-  :text => 'most',
-  :image => 'open',
-  :zip => 'tar ztvf %% | most',
-  :unknown => 'open'
+  text: 'most',
+  image: 'open',
+  zip: 'tar ztvf %% | most',
+  unknown: 'open'
 }
 $dir_position = {}
 ## CONSTANTS
-GMARK='*'
-CURMARK='>'
+GMARK = '*'.freeze
+CURMARK = '>'.freeze
 MSCROLL = 10
-SPACE=" "
-CLEAR      = "\e[0m"
-BOLD       = "\e[1m"
-BOLD_OFF       = "\e[22m"
-RED        = "\e[31m"
-ON_RED        = "\e[41m"
-GREEN      = "\e[32m"
-YELLOW     = "\e[33m"
-BLUE       = "\e[1;34m"
-
-ON_BLUE    = "\e[44m"
-REVERSE    = "\e[7m"
-UNDERLINE    = "\e[4m"
+SPACE = ' '.freeze
+CLEAR      = "\e[0m".freeze
+BOLD       = "\e[1m".freeze
+BOLD_OFF = "\e[22m".freeze
+RED = "\e[31m".freeze
+ON_RED = "\e[41m".freeze
+GREEN      = "\e[32m".freeze
+YELLOW     = "\e[33m".freeze
+BLUE       = "\e[1;34m".freeze
+
+ON_BLUE    = "\e[44m".freeze
+REVERSE    = "\e[7m".freeze
+UNDERLINE    = "\e[4m".freeze
 CURSOR_COLOR = ON_BLUE
-$patt=nil
+$patt = nil
 $ignorecase = true
 $quitting = false
 $modified = $writing = false
@@ -306,20 +320,20 @@ $visited_files = []
 $visited_dirs = []
 ## dirs where some work has been done, for saving and restoring
 $used_dirs = []
-$default_sort_order = "om"
+$default_sort_order = 'om'
 $sorto = $default_sort_order
 $viewctr = 0
 $history = []
 $sta = $cursor = 0
 $visual_mode = false
-#$help = "#{BOLD}1-9a-zA-Z#{BOLD_OFF} Select #{BOLD}/#{BOLD_OFF} Grep #{BOLD}'#{BOLD_OFF} First char  #{BOLD}M-n/p#{BOLD_OFF} Paging  #{BOLD}!#{BOLD_OFF} Command Mode  #{BOLD}@#{BOLD_OFF} Selection Mode  #{BOLD}q#{BOLD_OFF} Quit"
+# $help = "#{BOLD}1-9a-zA-Z#{BOLD_OFF} Select #{BOLD}/#{BOLD_OFF} Grep #{BOLD}'#{BOLD_OFF} First char  #{BOLD}M-n/p#{BOLD_OFF} Paging  #{BOLD}!#{BOLD_OFF} Command Mode  #{BOLD}@#{BOLD_OFF} Selection Mode  #{BOLD}q#{BOLD_OFF} Quit"
 
 $help = "#{BOLD}M-?#{BOLD_OFF} Help   #{BOLD}`#{BOLD_OFF} Menu   #{BOLD}!#{BOLD_OFF} Command   #{BOLD}=#{BOLD_OFF} Toggle   #{BOLD}@#{BOLD_OFF} Selection Mode  #{BOLD}q#{BOLD_OFF} Quit "
 
-  ## main loop which calls all other programs
+## main loop which calls all other programs
 def run
-  home=ENV['HOME']
-  ctr=0
+  home = ENV['HOME']
+  ctr = 0
   config_read
   $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}M)'`.split("\n")
   $files = sort_file_list $files
@@ -327,27 +341,27 @@ def run
   ## added by RK 2014-03-31 - 00:29 since too many duplicates
   $files = $files.uniq if $enhanced_mode
 
-  fl=$files.size
+  fl = $files.size
 
   selectedix = nil
-  $patt=""
-  $sta=0
-  while true
+  $patt = ''
+  $sta = 0
+  loop do
     i = 0
-    if $patt
-      if $ignorecase
-        $view = $files.grep(/#{$patt}/i)
-      else
-        $view = $files.grep(/#{$patt}/)
-      end
-    else
-      $view = $files
-    end
-    fl=$view.size
+    $view = if $patt
+              if $ignorecase
+                $files.grep(/#{$patt}/i)
+              else
+                $files.grep(/#{$patt}/)
+                      end
+            else
+              $files
+            end
+    fl = $view.size
     $sta = 0 if $sta >= fl || $sta < 0
     $viewport = $view[$sta, $pagesize]
     fin = $sta + $viewport.size
-    $title ||= Dir.pwd.sub(home, "~")
+    $title ||= Dir.pwd.sub(home, '~')
     clear_screen
     # title
     print "#{GREEN}#{$help}  #{BLUE}cetus #{VERSION}#{CLEAR}\n"
@@ -355,36 +369,34 @@ def run
     t = t[t.size - $gcols..-1] if t.size >= $gcols
     print "#{BOLD}#{t}#{CLEAR}\n"
     ## nilling the title means a superimposed one gets cleared.
-    #$title = nil
+    # $title = nil
     # split into 2 procedures so columnate can e clean and reused.
-    buff = format $viewport
+    buff = _format $viewport
     buff = columnate buff, $grows
     # needed the next line to see how much extra we were going in padding
-    #buff.each {|line| print "#{REVERSE}#{line}#{CLEAR}\n" }
-    buff.each {|line| print line, "\n"  }
+    # buff.each {|line| print "#{REVERSE}#{line}#{CLEAR}\n" }
+    buff.each { |line| print line, "\n" }
     print
     # prompt
-    #print "#{$files.size}, #{view.size} sta=#{sta} (#{patt}): "
-    _mm = ""
+    # print "#{$files.size}, #{view.size} sta=#{sta} (#{patt}): "
+    _mm = ''
     _mm = "[#{$mode}] " if $mode
     print "\r#{_mm}#{$patt} >"
     ch = get_char
-    #puts
-    #break if ch == "q"
-    #elsif  ch =~ /^[1-9a-zA-Z]$/
+    # puts
+    # break if ch == "q"
+    # elsif  ch =~ /^[1-9a-zA-Z]$/
     # 2019-03-04 - ignore q since that is quit key now
-    #if  ch =~ /^[a-zZ]$/
+    # if  ch =~ /^[a-zZ]$/
     if ch =~ /^[a-pr-zZ]$/
       # hint mode
       select_hint $viewport, ch
       ctr = 0
-    elsif ch == "BACKSPACE"
-      if $patt && $patt.size > 0
-        $patt = $patt[0..-2]
-      end
+    elsif ch == 'BACKSPACE'
+      $patt = $patt[0..-2] if $patt && !$patt.empty?
       ctr = 0
     else
-      #binding = $bindings[ch]
+      # binding = $bindings[ch]
       x = $bindings[ch]
       x = x.split if x
       if x
@@ -392,57 +404,56 @@ def run
         args = x
         send(binding, *args) if binding
       else
-        #perror "No binding for #{ch}"
+        perror "No binding for #{ch}"
       end
-      #p ch
+      # p ch
     end
     break if $quitting
   end
   write_curdir
-  puts "bye"
+  puts 'bye'
   config_write if $writing
 end
 
 ## write current dir to a file so we can ccd to it when exiting
 def write_curdir
-
-  f =  File.expand_path("~/.fff_d")
+  f = File.expand_path('~/.fff_d')
   s = Dir.pwd
-  File.open(f, "w") do |f2|
+  File.open(f, 'w') do |f2|
     f2.puts s
   end
-  #puts "Written #{s} to #{f}"
+  # puts "Written #{s} to #{f}"
 end
 
-
 ## code related to long listing of files
-GIGA_SIZE = 1073741824.0
-MEGA_SIZE = 1048576.0
+GIGA_SIZE = 1_073_741_824.0
+MEGA_SIZE = 1_048_576.0
 KILO_SIZE = 1024.0
 
 # Return the file size with a readable style.
+# NOTE format is a kernel method.
 def readable_file_size(size, precision)
-  case
-    #when size == 1 : "1 B"
-  when size < KILO_SIZE then "%d B" % size
-  when size < MEGA_SIZE then "%.#{precision}f K" % (size / KILO_SIZE)
-  when size < GIGA_SIZE then "%.#{precision}f M" % (size / MEGA_SIZE)
-  else "%.#{precision}f G" % (size / GIGA_SIZE)
+  if size < KILO_SIZE then format('%d B', size)
+  elsif size < MEGA_SIZE then format("%.#{precision}f K", (size / KILO_SIZE))
+  elsif size < GIGA_SIZE then format("%.#{precision}f M", (size / MEGA_SIZE))
+  else format("%.#{precision}f G", (size / GIGA_SIZE))
   end
 end
+
 ## format date for file given stat
-def date_format t
-  t.strftime "%Y/%m/%d"
+def date_format(t)
+  t.strftime '%Y/%m/%d'
 end
+
 ##
 #
 # print in columns
 # ary - array of data
 # sz  - lines in one column
 #
-def columnate ary, sz
-  buff=Array.new
-  return buff if ary.nil? || ary.size == 0
+def columnate(ary, sz)
+  buff = []
+  return buff if ary.nil? || ary.empty?
 
   # determine width based on number of files to show
   # if less than sz then 1 col and full width
@@ -454,39 +465,35 @@ def columnate ary, sz
   if ars <= sz
     wid = $gcols - d
   else
-    tmp = (ars * 1.000/ sz).ceil
+    tmp = (ars * 1.000 / sz).ceil
     wid = $gcols / tmp - d
   end
-  #elsif ars < sz * 2
-    #wid = $gcols/2 - d
-  #elsif ars < sz * 3
-    #wid = $gcols/3 - d
-  #else
-    #wid = $gcols/$gviscols - d
-  #end
+  # elsif ars < sz * 2
+  # wid = $gcols/2 - d
+  # elsif ars < sz * 3
+  # wid = $gcols/3 - d
+  # else
+  # wid = $gcols/$gviscols - d
+  # end
 
   # ix refers to the index in the complete file list, wherease we only show 60 at a time
-  ix=0
-  while true
+  ix = 0
+  loop do
     ## ctr refers to the index in the column
-    ctr=0
+    ctr = 0
     while ctr < sz
 
       f = ary[ix]
       fsz = f.size
       if fsz > wid
-        f = f[0, wid-2]+"$ "
+        f = f[0, wid - 2] + '$ '
         ## we do the coloring after trunc so ANSI escpe seq does not get get
-        if ix + $sta == $cursor
-          f = "#{CURSOR_COLOR}#{f}#{CLEAR}"
-        end
+        f = "#{CURSOR_COLOR}#{f}#{CLEAR}" if ix + $sta == $cursor
       else
         ## we do the coloring before padding so the entire line does not get padded, only file name
-        if ix + $sta == $cursor
-          f = "#{CURSOR_COLOR}#{f}#{CLEAR}"
-        end
-        #f = f.ljust(wid)
-        f << " " * (wid-fsz)
+        f = "#{CURSOR_COLOR}#{f}#{CLEAR}" if ix + $sta == $cursor
+        # f = f.ljust(wid)
+        f << ' ' * (wid - fsz)
       end
 
       if buff[ctr]
@@ -495,156 +502,188 @@ def columnate ary, sz
         buff[ctr] = f
       end
 
-      ctr+=1
-      ix+=1
+      ctr += 1
+      ix += 1
       break if ix >= ary.size
     end
     break if ix >= ary.size
   end
-  return buff
+  buff
 end
+
 ## formats the data with number, mark and details
-def format ary
-  #buff = Array.new
+# 2019-03-09 - at some time this got renamed to `format` which is a kernel
+#  method and this overshadowed that method.
+def _format(ary)
+  # buff = Array.new
   buff = Array.new(ary.size)
-  return buff if ary.nil? || ary.size == 0
+  return buff if ary.nil? || ary.empty?
 
   # determine width based on number of files to show
   # if less than sz then 1 col and full width
   #
   # ix refers to the index in the complete file list, wherease we only show 60 at a time
-  ix=0
-  ctr=0
+  ix = 0
+  ctr = 0
   ary.each do |f|
     ## ctr refers to the index in the column
     ind = get_shortcut(ix)
-    mark=SPACE
-    cur=SPACE
+    mark = SPACE
+    cur = SPACE
     cur = CURMARK if ix + $sta == $cursor
-    mark=GMARK if $selected_files.index(ary[ix])
+    # TODO: add full path TESTME
+    # mark = GMARK if $selected_files.index(ary[ix])
+    mark = GMARK if selected?(ary[ix])
 
     if $long_listing
       begin
-        unless File.exist? f
-          last = f[-1]
-          if last == " " || last == "@" || last == '*'
-            stat = File.stat(f.chop)
-          end
-        else
+        if File.exist? f
           stat = File.stat(f)
+        else
+          last = f[-1]
+          stat = File.stat(f.chop) if last == ' ' || last == '@' || last == '*'
         end
-        f = "%10s  %s  %s" % [readable_file_size(stat.size,1), date_format(stat.mtime), f]
+        f = format('%10s  %s  %s', readable_file_size(stat.size, 1),
+                   date_format(stat.mtime), f)
       rescue Exception => e
-        f = "%10s  %s  %s" % ["?", "??????????", f]
+        f = format('%10s  %s  %s', '?', '??????????', f)
       end
     end
 
     s = "#{ind}#{mark}#{cur}#{f}"
     # I cannot color the current line since format does the chopping
-    # so not only does the next lines alignment get skeweed, but also if the line is truncated
+    # so not only does the next lines alignment get skewed,
+    # but also if the line is truncated
     # then the color overflows.
-    #if ix + $sta == $cursor
-      #s = "#{RED}#{s}#{CLEAR}"
-    #end
+    # if ix + $sta == $cursor
+    # s = "#{RED}#{s}#{CLEAR}"
+    # end
 
     buff[ctr] = s
 
-    ctr+=1
-    ix+=1
+    ctr += 1
+    ix += 1
   end
-  return buff
+  buff
 end
+
 ## select file based on key pressed
-def select_hint view, ch
+def select_hint(view, ch)
   # a to y is direct
   # if x or z take a key IF there are those many
   #
   ix = get_index(ch, view.size)
-  if ix
-    f = view[ix]
-    return unless f
-    $cursor = $sta + ix
-
-    if $mode == 'SEL'
-      toggle_select f
-    elsif $mode == 'COM'
-      run_command f
-    else
-      open_file f
-    end
-    #selectedix=ix
+  return unless ix
+
+  f = view[ix]
+  return unless f
+
+  $cursor = $sta + ix
+
+  if $mode == 'SEL'
+    toggle_select f
+  elsif $mode == 'COM'
+    run_command f
+  else
+    open_file f
   end
+  # selectedix=ix
 end
+
 ## toggle selection state of file
-def toggle_select f
-  if $selected_files.index f
-    $selected_files.delete f
+def toggle_select(f)
+  # dir = Dir.pwd
+  # file = File.join(dir, f)
+  if selected? f
+    remove_from_selection f
   else
-    $selected_files.push f
+    add_to_selection f
   end
 end
 
 ## open file or directory
-def open_file f
+def open_file(f)
   return unless f
-  if f[0] == "~"
-    f = File.expand_path(f)
-  end
+
+  f = File.expand_path(f) if f[0] == '~'
   unless File.exist? f
     # this happens if we use (T) in place of (M)
     # it places a space after normal files and @ and * which borks commands
     last = f[-1]
-    if last == " " || last == "@" || last == '*'
-      f = f.chop
-    end
+    f = f.chop if last == ' ' || last == '@' || last == '*'
   end
   nextpos = nil
 
   # could be a bookmark with position attached to it
-  if f.index(":")
-    f, nextpos = f.split(":")
-  end
+  f, nextpos = f.split(':') if f.index(':')
   if File.directory? f
     save_dir_pos
     change_dir f, nextpos
   elsif File.readable? f
-    $default_command ||= "$EDITOR"
+    $default_command ||= '$PAGER'
     if !$editor_mode
       ft = filetype f
       if ft
         comm = $pager_command[ft]
       else
         comm = $pager_command[File.extname(f)]
-        comm = $pager_command["unknown"] unless comm
+        comm ||= $pager_command['unknown']
       end
     else
       comm = $default_command
     end
     comm ||= $default_command
-    if comm.index("%%")
-      comm = comm.gsub("%%", Shellwords.escape(f))
-    else
-      comm = comm + " #{Shellwords.escape(f)}"
-    end
+    comm = if comm.index('%%')
+             comm.gsub('%%', Shellwords.escape(f))
+           else
+             comm + " #{Shellwords.escape(f)}"
+           end
     clear_screen
     reset_terminal
-    system("#{comm}")
+    system(comm.to_s)
     setup_terminal
-    f = Dir.pwd + "/" + f if f[0] != '/'
+    f = Dir.pwd + '/' + f if f[0] != '/'
     $visited_files.insert(0, f)
     push_used_dirs Dir.pwd
   else
     perror "open_file: (#{f}) not found"
-      # could check home dir or CDPATH env variable DO
+    # could check home dir or CDPATH env variable DO
   end
 end
 
+# regardless of mode, view the current file using pager
+def page_current
+  command = ENV['MANPAGER'] || ENV['PAGER'] || 'less'
+  run_on_current command
+end
+
+# regardless of mode, edit the current file using editor
+def edit_current
+  command = ENV['EDITOR'] || ENV['VISUAL'] || 'vim'
+  run_on_current command
+  $visited_files.insert(0, current_file)
+end
+
+# run given command on current file
+def run_on_current(command)
+  f = $view[$cursor]
+  return unless f
+  f = File.expand_path(f)
+  return unless File.readable?(f)
+
+  clear_screen
+  reset_terminal
+  comm = "#{command} #{f}"
+  system(comm.to_s)
+  setup_terminal
+end
+
 ## run command on given file/s
 #   Accepts command from user
 #   After putting readline in place of gets, pressing a C-c has a delayed effect. It goes intot
 #   exception bloack after executing other commands and still does not do the return !
-def run_command f
-  files=nil
+def run_command(f)
+  files = nil
   case f
   when Array
     # escape the contents and create a string
@@ -654,13 +693,14 @@ def run_command f
   end
   print "Run a command on #{files}: "
   begin
-    #Readline::HISTORY.push(*values)
-    command = Readline::readline('>', true)
-    #command = gets().chomp
-    return if command.size == 0
-    print "Second part of command: "
-    #command2 = gets().chomp
-    command2 = Readline::readline('>', true)
+    # Readline::HISTORY.push(*values)
+    command = Readline.readline('>', true)
+    # command = gets().chomp
+    return if command.empty?
+
+    print 'Second part of command: '
+    # command2 = gets().chomp
+    command2 = Readline.readline('>', true)
     puts "#{command} #{files} #{command2}"
     system "#{command} #{files} #{command2}"
   rescue Exception => ex
@@ -672,27 +712,33 @@ def run_command f
   end
 
   refresh
-  puts "Press a key ..."
+  puts 'Press a key ...'
   push_used_dirs Dir.pwd
   get_char
 end
 
 ## cd to a dir
-def change_dir f, pos = nil
+def change_dir(f, pos = nil)
   $visited_dirs.insert(0, Dir.pwd)
   f = File.expand_path(f)
   Dir.chdir f
-  $filterstr ||= "M"
+  $filterstr ||= 'M'
   $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
   $files = sort_file_list $files
   post_cd
   if pos
     # convert curpos to sta also
-    #$cursor = pos.to_i
+    # $cursor = pos.to_i
     goto_line pos.to_i
   end
 end
 
+def goto_previous_dir
+  prev_dir = $visited_dirs.first
+  return unless prev_dir
+  change_dir prev_dir
+end
+
 ## clear sort order and refresh listing, used typically if you are in some view
 #  such as visited dirs or files
 def escape
@@ -700,25 +746,25 @@ def escape
   $sorto = $default_sort_order
   $viewctr = 0
   $title = nil
-  $filterstr = "M"
+  $filterstr = 'M'
   visual_block_clear
   refresh
 end
 
 ## refresh listing after some change like option change, or toggle
 def refresh
-    $filterstr ||= "M"
-    $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
-    # first put dirs then files
-    $files = sort_file_list $files
-    $patt = nil
-    $title = nil
+  $filterstr ||= 'M'
+  $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
+  # first put dirs then files
+  $files = sort_file_list $files
+  $patt = nil
+  $title = nil
 end
 
-def sort_file_list files
-    _dirs  = $files.select { |f| File.directory?(f) }
-    _files = $files.select { |f| File.file?(f) }
-    return _dirs + _files
+def sort_file_list(_files)
+  _dirs = $files.select { |f| File.directory?(f) }
+  _files = $files.select { |f| File.file?(f) }
+  _dirs + _files
 end
 
 ## unselect all files
@@ -729,31 +775,31 @@ end
 
 ## select all files
 def select_all
-  $selected_files = $view.dup
+  # TODO: add path TESTME
+  dir = Dir.pwd
+  $selected_files = $view.map { |file| File.join(dir, file) }
 end
 
 ## accept dir to goto and change to that ( can be a file too)
 def goto_dir
-  print "Enter path: "
+  print 'Enter path: '
   begin
-    #path = gets.chomp
-    path = Readline::readline('>', true)
-    return if path == ""
-    #rescue => ex
+    # path = gets.chomp
+    path = Readline.readline('>', true)
+    return if path == ''
+    # rescue => ex
   rescue Exception => ex
-    perror "Cancelled cd, press a key"
+    perror 'Cancelled cd, press a key'
     return
   end
   f = File.expand_path(path)
   unless File.directory? f
     ## check for env variable
     tmp = ENV[path]
-    if tmp.nil? || !File.directory?( tmp )
+    if tmp.nil? || !File.directory?(tmp)
       ## check for dir in home
       tmp = File.expand_path("~/#{path}")
-      if File.directory? tmp
-        f = tmp
-      end
+      f = tmp if File.directory? tmp
     else
       f = tmp
     end
@@ -769,15 +815,14 @@ end
 def selection_mode_toggle
   if $mode == 'SEL'
     # we seem to be coming out of select mode with some files
-    if $selected_files.size > 0
-      run_command $selected_files
-    end
+    run_command $selected_files unless $selected_files.empty?
     $mode = nil
   else
-    #$selection_mode = !$selection_mode
+    # $selection_mode = !$selection_mode
     $mode = 'SEL'
   end
 end
+
 ## toggle command mode
 def command_mode
   if $mode == 'COM'
@@ -786,24 +831,32 @@ def command_mode
   end
   $mode = 'COM'
 end
+
 def goto_parent_dir
   change_dir '..'
 end
+
+def goto_home_dir
+  change_dir '~'
+end
+
 ## This actually filters, in zfm it goes to that entry since we have a cursor there
 #
-def goto_entry_starting_with fc=nil
+def goto_entry_starting_with(fc = nil)
   unless fc
-    print "Entries starting with: "
+    print 'Entries starting with: '
     fc = get_char
   end
   return if fc.size != 1
+
   ## this is wrong and duplicates the functionality of /
   #  It shoud go to cursor of item starting with fc
   $patt = "^#{fc}"
 end
-def goto_bookmark ch=nil
+
+def goto_bookmark(ch = nil)
   unless ch
-    print "Enter bookmark char: "
+    print 'Enter bookmark char: '
     ch = get_char
   end
   if ch =~ /^[0-9A-Z]$/
@@ -812,122 +865,173 @@ def goto_bookmark ch=nil
     # this way we leave the position as is, so it gets written back
     nextpos = nil
     if d
-      if d.index(":")
-        ix = d.index(":")
-        nextpos = d[ix+1..-1]
-        d = d[0,ix]
+      if d.index(':')
+        ix = d.index(':')
+        nextpos = d[ix + 1..-1]
+        d = d[0, ix]
       end
       change_dir d, nextpos
     else
       perror "#{ch} not a bookmark"
     end
   else
-    #goto_entry_starting_with ch
+    # goto_entry_starting_with ch
     file_starting_with ch
   end
 end
 
-
 ## take regex from user, to run on files on screen, user can filter file names
 def enter_regex
-  print "Enter (regex) pattern: "
-  #$patt = gets().chomp
-  $patt = Readline::readline('>', true)
+  print 'Enter (regex) pattern: '
+  # $patt = gets().chomp
+  $patt = Readline.readline('>', true)
   ctr = 0
 end
+
 def next_page
   $sta += $pagesize
 end
+
 def prev_page
   $sta -= $pagesize
 end
 
+# print help on key-bindings
+# 2019-03-08 - write to temp file and user PAGER
 def print_help
-  clear_screen
-  puts "HELP"
-  puts
-  puts "To open a file or dir press 1-9 a-z A-Z "
-  puts "Command Mode: Will prompt for a command to run on a file, after selecting using hotkey"
-  puts "Selection Mode: Each selection adds to selection list (toggles)"
-  puts "                Upon exiting mode, user is prompted for a command to run on selected files"
-  puts
-  ary = []
-  $bindings.each_pair { |k, v| ary.push "#{k.ljust(7)}  =>  #{v}" }
-  ary = columnate ary, $grows - 7
-  ary.each {|line| print line, "\n"  }
-  get_char
+  require 'tempfile'
+  file = Tempfile.new('help')
+  begin
+    file.puts '    HELP'
+
+    file.puts
+    file.puts 'To open a file or dir press 1-9 a-z A-Z '
+    file.puts 'Command Mode: Will prompt for a command to run on a file, after selecting using hotkey'
+    file.puts 'Selection Mode: Each selection adds to selection list (toggles)'
+    file.puts '   Execute commands on selected files. e.g D    '
+    file.puts '   Upon exiting mode, user is prompted for a command to run on selected files'
+    file.puts
+    ary = []
+    $bindings.each_pair { |k, v| ary.push "#{k.ljust(7)}  =>  #{v}" }
+    ary = columnate ary, (ary.size/2)+1
+    ary.each { |line| file.puts line }
+    file.flush
+    system "$PAGER #{file.path}"
+  rescue
+    file.close
+    file.unlink
+  end
+end #
 
-end
 def show_marks
   puts
-  puts "Bookmarks: "
+  puts 'Bookmarks: '
   $bookmarks.each_pair { |k, v| puts "#{k.ljust(7)}  =>  #{v}" }
   puts
-  print "Enter bookmark to goto: "
+  print 'Enter bookmark to goto: '
   ch = get_char
   goto_bookmark(ch) if ch =~ /^[0-9A-Z]$/
 end
+
 # MENU MAIN -- keep consistent with zfm
 def main_menu
   h = {
-    :a => :ack,
-    "/" => :ffind,
+    :a => :ag,
+    '/' => :ffind,
     :l => :locate,
-    :v => :viminfo,
+    :V => :viminfo,
+    :v => :vidir,
     :z => :z_interface,
     :d => :child_dirs,
     :r => :recent_files,
+    '1' => :select_visited_files,
+    '2' => :select_used_dirs,
     :t => :dirtree,
-    "4" => :tree,
+    '4' => :tree,
     :s => :sort_menu,
     :F => :filter_menu,
-    :c => :command_menu ,
+    :c => :command_menu,
     :B => :bindkey_ext_command,
     :M => :newdir,
-    "%" => :newfile,
+    '%' => :newfile,
+    'S' => :scripts,
     :x => :extras
   }
-  menu "Main Menu", h
+  menu 'Main Menu', h
+end
+
+# trying out fzf instead
+# 2019-03-08 - 23:46
+# FIXME returns a String not symbol, so some callers can fail
+def fzfmenu(title, h)
+  return unless h
+
+  pbold title.to_s
+  values = h.values.join("\n")
+  binding = `echo "#{values}" | fzf --prompt="#{title.to_s} :"`
+  # h.each_pair { |k, v| puts " #{k}: #{v}" }
+  # ch = get_char
+  # binding = h[ch]
+  # binding ||= h[ch.to_sym]
+  # FIXME we have converted symbol to string
+  ch = nil
+  if binding
+    binding = binding.chomp
+    send(binding) if respond_to?(binding, true)
+    ch = h.key(binding)
+  end
+  [ch, binding]
 end
-def menu title, h
+
+# this style used hotkeys which I remember. But it can get long.
+#  and I have to fix a hotkey for each new entry
+def menu(title, h)
   return unless h
 
-  pbold "#{title}"
-  h.each_pair { |k, v| puts " #{k}: #{v}" }
+  pbold title.to_s
+  # h.each_pair { |k, v| puts " #{k}: #{v}" }
+  # 2019-03-09 - trying out using `column` to print in cols
+  ary = []
+  h.each_pair { |k, v| ary << " #{k}: #{v}" }
+  x = ary.join("\n")
+  puts %x{echo "#{x}" | column}
+
   ch = get_char
   binding = h[ch]
-  binding = h[ch.to_sym] unless binding
+  binding ||= h[ch.to_sym]
   if binding
-    if respond_to?(binding, true)
-      send(binding)
-    end
+    send(binding) if respond_to?(binding, true)
   end
-  return ch, binding
+  [ch, binding]
 end
+
 def toggle_menu
-  h = { :h => :toggle_hidden, :c => :toggle_case, :l => :toggle_long_list , "1" => :toggle_columns,
-  :p => :toggle_pager_mode, :e => :toggle_enhanced_list}
-  ch, menu_text = menu "Toggle Menu", h
+  h = { :h => :toggle_hidden, :c => :toggle_case, :l => :toggle_long_list, '1' => :toggle_columns,
+        :p => :toggle_pager_mode, :e => :toggle_enhanced_list }
+  ch, menu_text = menu 'Toggle Menu', h
+  # NOTE fzfmenu returns string not symbol
+  return unless menu_text
+
   case menu_text
   when :toggle_hidden
-    $hidden = $hidden ? nil : "D"
+    $hidden = $hidden ? nil : 'D'
     refresh
   when :toggle_case
-    #$ignorecase = $ignorecase ? "" : "i"
+    # $ignorecase = $ignorecase ? "" : "i"
     $ignorecase = !$ignorecase
     refresh
   when :toggle_columns
     $gviscols = 3 if $gviscols == 1
-    #$long_listing = false if $gviscols > 1
+    # $long_listing = false if $gviscols > 1
     x = $grows * $gviscols
-    $pagesize = $pagesize==x ? $grows : x
+    $pagesize = $pagesize == x ? $grows : x
   when :toggle_pager_mode
     $editor_mode = !$editor_mode
-    if $editor_mode
-      $default_command = nil
-    else
-      $default_command = ENV['MANPAGER'] || ENV['PAGER']
-    end
+    $default_command = if $editor_mode
+                         ENV['EDITOR'] # earlier nil # 2019-03-10 -
+                       else
+                         ENV['MANPAGER'] || ENV['PAGER']
+                       end
   when :toggle_enhanced_list
     $enhanced_mode = !$enhanced_mode
 
@@ -938,7 +1042,7 @@ def toggle_menu
       $pagesize = $grows
     else
       x = $grows * $gviscols
-      $pagesize = $pagesize==x ? $grows : x
+      $pagesize = $pagesize == x ? $grows : x
     end
     refresh
   end
@@ -946,34 +1050,34 @@ end
 
 def sort_menu
   lo = nil
-  h = { :n => :newest, :a => :accessed, :o => :oldest,
-    :l => :largest, :s => :smallest , :m => :name , :r => :rname, :d => :dirs, :c => :clear }
-  ch, menu_text = menu "Sort Menu", h
+  h = { n: :newest, a: :accessed, o: :oldest,
+        l: :largest, s: :smallest, m: :name, r: :rname, d: :dirs, c: :clear }
+  ch, menu_text = menu 'Sort Menu', h
   case menu_text
   when :newest
-    lo="om"
+    lo = 'om'
   when :accessed
-    lo="oa"
+    lo = 'oa'
   when :oldest
-    lo="Om"
+    lo = 'Om'
   when :largest
-    lo="OL"
+    lo = 'OL'
   when :smallest
-    lo="oL"
+    lo = 'oL'
   when :name
-    lo="on"
+    lo = 'on'
   when :rname
-    lo="On"
+    lo = 'On'
   when :dirs
-    lo="/"
+    lo = '/'
   when :clear
-    lo=""
+    lo = ''
   end
   ## This needs to persist and be a part of all listings, put in change_dir.
   $sorto = lo
   $files = `zsh -c 'print -rl -- *(#{lo}#{$hidden}M)'`.split("\n") if lo
   $title = nil
-  #$files =$(eval "print -rl -- ${pattern}(${MFM_LISTORDER}$filterstr)")
+  # $files =$(eval "print -rl -- ${pattern}(${MFM_LISTORDER}$filterstr)")
 end
 
 def command_menu
@@ -986,13 +1090,14 @@ def command_menu
   # should be able to sort THIS listing and not rerun command. But for that I'd need to use
   # xargs ls -t etc rather than the zsh sort order. But we can run a filter using |.
   #
-  h = { :t => :today, :D => :default_command , :R => :remove_from_list}
-  if $editor_mode
-    h[:e] = :pager_mode
-  else
-    h[:e] = :editor_mode
-  end
-  ch, menu_text = menu "Command Menu", h
+  h = { t: :today, D: :default_command, R: :remove_from_list,
+        v: :page_selection }
+  h[:e] = if $editor_mode
+            :pager_mode
+          else
+            :editor_mode
+          end
+  _, menu_text = menu 'Command Menu', h
   case menu_text
   when :pager_mode
     $editor_mode = false
@@ -1008,26 +1113,27 @@ def command_menu
     $files = `zsh -c 'print -rl -- *(#{$hidden}Mm0)'`.split("\n")
     $title = "Today's files"
   when :default_command
-    print "Selecting a file usually invokes $EDITOR, what command do you want to use repeatedly on selected files: "
-    $default_command = gets().chomp
-    if $default_command != ""
-      print "Second part of command (maybe blank): "
-      $default_command2 = gets().chomp
+    print 'Selecting a file usually invokes $EDITOR, what command do you want to use repeatedly on selected files: '
+    $default_command = gets.chomp
+    if $default_command != ''
+      print 'Second part of command (maybe blank): '
+      $default_command2 = gets.chomp
     else
-      print "Cleared default command, will default to $EDITOR"
+      print 'Cleared default command, will default to $EDITOR'
       $default_command2 = nil
       $default_command = nil
     end
   end
 end
+
 def extras
-  h = { "1" => :one_column, "2" => :multi_column, :c => :columns, :r => :config_read , :w => :config_write}
-  ch, menu_text = menu "Extras Menu", h
+  h = { '1' => :one_column, '2' => :multi_column, :c => :columns, :r => :config_read, :w => :config_write }
+  ch, menu_text = menu 'Extras Menu', h
   case menu_text
   when :one_column
     $pagesize = $grows
   when :multi_column
-    #$pagesize = 60
+    # $pagesize = 60
     $pagesize = $grows * $gviscols
   when :columns
     print "How many columns to show: 1-6 [current #{$gviscols}]? "
@@ -1039,44 +1145,50 @@ def extras
     end
   end
 end
+
 def filter_menu
-  h = { :d => :dirs, :f => :files, :e => :emptydirs , "0" => :emptyfiles}
-  ch, menu_text = menu "Filter Menu", h
+  h = { :d => :dirs, :f => :files, :e => :emptydirs, '0' => :emptyfiles }
+  ch, menu_text = menu 'Filter Menu', h
   files = nil
   case menu_text
   when :dirs
-    $filterstr = "/M"
+    $filterstr = '/M'
     files = `zsh -c 'print -rl -- *(#{$sorto}/M)'`.split("\n")
-    $title = "Filter: directories only"
+    $title = 'Filter: directories only'
   when :files
-    $filterstr = "."
+    $filterstr = '.'
     files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}.)'`.split("\n")
-    $title = "Filter: files only"
+    $title = 'Filter: files only'
   when :emptydirs
-    $filterstr = "/D^F"
+    $filterstr = '/D^F'
     files = `zsh -c 'print -rl -- *(#{$sorto}/D^F)'`.split("\n")
-    $title = "Filter: empty directories"
+    $title = 'Filter: empty directories'
   when :emptyfiles
-    $filterstr = ".L0"
+    $filterstr = '.L0'
     files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}.L0)'`.split("\n")
-    $title = "Filter: empty files"
+    $title = 'Filter: empty files'
   end
   if files
     $files = files
     $stact = 0
   end
 end
+
 def select_used_dirs
-  $title = "Used Directories"
-  $files = $used_dirs.uniq
+  $title = 'Used Directories'
+  home = File.expand_path '~'
+  $files = $used_dirs.uniq.map { |path| path.sub("#{home}", '~') }
 end
+
 def select_visited_files
   # not yet a unique list, needs to be unique and have latest pushed to top
-  $title = "Visited Files"
-  $files = $visited_files.uniq
+  $title = 'Visited Files'
+  home = File.expand_path '~'
+  $files = $visited_files.uniq.map { |path| path.sub("#{home}", '~') }
 end
+
 def select_bookmarks
-  $title = "Bookmarks"
+  $title = 'Bookmarks'
   $files = $bookmarks.values
 end
 
@@ -1084,15 +1196,13 @@ end
 #  or we'll be stuck in a cycle
 def pop_dir
   # the first time we pop, we need to put the current on stack
-  if !$visited_dirs.index(Dir.pwd)
-    $visited_dirs.push Dir.pwd
-  end
+  $visited_dirs.push Dir.pwd unless $visited_dirs.index(Dir.pwd)
   ## XXX make sure thre is something to pop
   d = $visited_dirs.delete_at 0
   ## XXX make sure the dir exists, cuold have been deleted. can be an error or crash otherwise
   $visited_dirs.push d
   Dir.chdir d
-  $filterstr ||= "M"
+  $filterstr ||= 'M'
   $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}#{$filterstr})'`.split("\n")
   $files = sort_file_list $files
   post_cd
@@ -1100,14 +1210,14 @@ end
 
 # after changing directory
 def post_cd
-  $patt=nil
+  $patt = nil
   $sta = $cursor = 0
   $title = nil
-  if $selected_files.size > 0
-    $selected_files = []
-  end
+  # 2019-03-10 - why am I clearing selected when dir changed !!! FIXME
+  # $selected_files = [] unless $selected_files.empty?
   $visual_block_start = nil
   $stact = 0
+  $current_dir = Dir.pwd # 2019-03-10 - so i don't keep doing in functions
   screen_settings
   # i think this will screw with the dir_pos since it is not filename based.
   enhance_file_list
@@ -1118,103 +1228,108 @@ end
 
 ## read dirs and files and bookmarks from file
 def config_read
-  #f =  File.expand_path("~/.zfminfo")
-  f =  File.expand_path(CONFIG_FILE)
-  if File.readable? f
-    load f
-    # maybe we should check for these existing else crash will happen.
-    $used_dirs.push(*(DIRS.split ":"))
-    $used_dirs.concat get_env_paths
-    $visited_files.push(*(FILES.split ":"))
-    #$bookmarks.push(*bookmarks) if bookmarks
-    chars = ('A'..'Z').to_a
-    chars.concat( ('0'..'9').to_a )
-    chars.each do |ch|
-      if Kernel.const_defined? "BM_#{ch}"
-        $bookmarks[ch] = Kernel.const_get "BM_#{ch}"
-      end
-    end
-  end
+  # f =  File.expand_path("~/.zfminfo")
+  f = File.expand_path(CONFIG_FILE)
+  return unless File.readable? f
+
+  hash = loadYML(f)
+  $used_dirs = hash['DIRS']
+  $visited_files = hash['FILES']
+  $bookmarks = hash['BOOKMARKS']
+  $used_dirs.concat get_env_paths
 end
+
 def get_env_paths
   files = []
-  %w{ GEM_HOME PYTHONHOME}.each do |p|
+  %w[GEM_HOME PYTHONHOME].each do |p|
     d = ENV[p]
     files.push d if d
   end
-  %w{ RUBYLIB RUBYPATH GEM_PATH PYTHONPATH }.each do |p|
+  %w[RUBYLIB RUBYPATH GEM_PATH PYTHONPATH].each do |p|
     d = ENV[p]
-    files.concat d.split(":") if d
+    files.concat d.split(':') if d
   end
-  return files
+  files
 end
 
 ## save dirs and files and bookmarks to a file
+# - moved to yml 2019-03-09
 def config_write
   # Putting it in a format that zfm can also read and write
-  #f1 =  File.expand_path("~/.zfminfo")
-  f1 =  File.expand_path(CONFIG_FILE)
-  d = $used_dirs.join ":"
-  f = $visited_files.join ":"
-  File.open(f1, 'w+') do |f2|
-    # use "\n" for two lines of text
-    f2.puts "DIRS=\"#{d}\""
-    f2.puts "FILES=\"#{f}\""
-    $bookmarks.each_pair { |k, val|
-      f2.puts "BM_#{k}=\"#{val}\""
-      #f2.puts "BOOKMARKS[\"#{k}\"]=\"#{val}\""
-    }
-  end
+  f1 = File.expand_path(CONFIG_FILE)
+  hash = {}
+  hash['DIRS'] = $used_dirs.select {|dir| File.exist? dir}
+  hash['FILES'] = $visited_files.select {|file| File.exist? file}
+  hash['BOOKMARKS'] = $bookmarks
+  writeYML hash, f1
   $writing = $modified = false
 end
 
+# {{{ YML
+require 'yaml'
+def loadYML( filename)
+  hash = YAML::load( File.open( filename ) )
+  if $opt_debug
+    $stderr.puts hash.keys.size
+  end
+  return hash
+end
+def writeYML obj, filename
+  File.open(filename, 'w') {|f| f.write obj.to_yaml }
+  if $opt_debug
+    $stderr.puts "Written to file #{filename}"
+  end
+end
+# }}}
 ## accept a character to save this dir as a bookmark
 def create_bookmark
-  print "Enter A to Z or 0-9 for bookmark: "
+  print 'Enter A to Z or 0-9 for bookmark: '
   ch = get_char
   if ch =~ /^[0-9A-Z]$/
     $bookmarks[ch] = "#{Dir.pwd}:#{$cursor}"
     $modified = true
   else
-    perror "Bookmark must be upper-case character or number."
+    perror 'Bookmark must be upper-case character or number.'
   end
 end
+
 def subcommand
-  print "Enter command: "
+  print 'Enter command: '
   begin
-    #command = gets().chomp
-    command = Readline::readline('>', true)
-    return if command == ""
+    # command = gets().chomp
+    command = Readline.readline('>', true)
+    return if command == ''
   rescue Exception => ex
     return
   end
-  if command == "q"
+  if command == 'q'
     if $modified
-      print "Do you want to save bookmarks? (y/n): "
+      print 'Do you want to save bookmarks? (y/n): '
       ch = get_char
-      if ch == "y"
+      if ch == 'y'
         $writing = true
         $quitting = true
-      elsif ch == "n"
+      elsif ch == 'n'
         $quitting = true
-        print "Quitting without saving bookmarks"
+        print 'Quitting without saving bookmarks'
       else
-        perror "No action taken."
+        perror 'No action taken.'
       end
     else
       $quitting = true
     end
-  elsif command == "wq"
+  elsif command == 'wq'
     $quitting = true
     $writing = true
-  elsif command == "x"
+  elsif command == 'x'
     $quitting = true
     $writing = true if $modified
-  elsif command == "p"
+  elsif command == 'p'
     system 'echo $PWD | pbcopy'
     puts 'Stored PWD in clipboard (using pbcopy)'
   end
 end
+
 def quit_command
   if $modified
     puts 'Press w to save bookmarks before quitting ' if $modified
@@ -1228,91 +1343,102 @@ def quit_command
 end
 
 def views
-  views=%w[/ om oa Om OL oL On on]
-  viewlabels=%w[Dirs Newest Accessed Oldest Largest Smallest Reverse Name]
+  views = %w[/ om oa Om OL oL On on]
+  viewlabels = %w[Dirs Newest Accessed Oldest Largest Smallest Reverse Name]
   $sorto = views[$viewctr]
   $title = viewlabels[$viewctr]
   $viewctr += 1
   $viewctr = 0 if $viewctr > views.size
 
   $files = `zsh -c 'print -rl -- *(#{$sorto}#{$hidden}M)'`.split("\n")
-
 end
+
 def child_dirs
-  $title = "Child directories"
+  $title = 'Child directories'
   $files = `zsh -c 'print -rl -- *(/#{$sorto}#{$hidden}M)'`.split("\n")
 end
+
 def dirtree
-  $title = "Child directories"
+  $title = 'Child directories'
   $files = `zsh -c 'print -rl -- **/*(/#{$sorto}#{$hidden}M)'`.split("\n")
 end
+
 #
 # Get a full recursive listing of what's in this dir - useful for small projects with more
 # structure than files.
 def tree
   # Caution: use only for small projects, don't use in root.
-  $title = "Full Tree"
+  $title = 'Full Tree'
   $files = `zsh -c 'print -rl -- **/*(#{$sorto}#{$hidden}M)'`.split("\n")
 end
+
 # lists recent files in current dir
-# TODO in some cases it shows mostly .git files, we need to prune those
+# In some cases it shows mostly .git files, we need to prune those
 def recent_files
   # print -rl -- **/*(Dom[1,10])
-  $title = "Recent files"
-  $files = `zsh -c 'print -rl -- **/*(Dom[1,15])'`.split("\n")
+  $title = 'Recent files'
+  $files = `zsh -c 'print -rl -- **/*(Dom[1,15])'`.split("\n").reject {|f| f[0] == '.'}
 end
 
 def select_current
   ## vp is local there, so i can do $vp[0]
-  #open_file $view[$sta] if $view[$sta]
+  # open_file $view[$sta] if $view[$sta]
   open_file $view[$cursor] if $view[$cursor]
 end
 
 ## create a list of dirs in which some action has happened, for saving
-def push_used_dirs d=Dir.pwd
+def push_used_dirs(d = Dir.pwd)
   $used_dirs.index(d) || $used_dirs.push(d)
 end
-def pbold text
+
+def pbold(text)
   puts "#{BOLD}#{text}#{BOLD_OFF}"
 end
-def perror text
+
+def perror(text)
   puts "#{RED}#{text}#{CLEAR}"
   get_char
 end
-def pause text=" Press a key ..."
+
+def pause(text = ' Press a key ...')
   print text
   get_char
 end
+
 ## return shortcut for an index (offset in file array)
 # use 2 more arrays to make this faster
 #  if z or Z take another key if there are those many in view
 #  Also, display ROWS * COLS so now we are not limited to 60.
-def get_shortcut ix
-  return "<" if ix < $stact
+def get_shortcut(ix)
+  return '<' if ix < $stact
+
   ix -= $stact
   i = $IDX[ix]
   return i if i
-  return "->"
+
+  '->'
 end
+
 ## returns the integer offset in view (file array based on a-y za-zz and Za - Zz
 # Called when user types a key
 #  should we even ask for a second key if there are not enough rows
 #  What if we want to also trap z with numbers for other purposes
-def get_index key, vsz=999
+def get_index(key, vsz = 999)
   i = $IDX.index(key)
-  return i+$stact if i
-  #sz = $IDX.size
+  return i + $stact if i
+
+  # sz = $IDX.size
   zch = nil
   if vsz > 25
-    if key == "z" || key == "Z"
+    if key == 'z' || key == 'Z'
       print key
       zch = get_char
       print zch
       i = $IDX.index("#{key}#{zch}")
-      return i+$stact if i
+      return i + $stact if i
     end
   end
-  return nil
+  nil
 end
 
 def delete_file
@@ -1323,21 +1449,22 @@ end
 #  prompt is the user friendly text of command such as list for ls, or extract for dtrx, page for less
 #  pauseyn is whether to pause after command as in file or ls
 #
-def command_file prompt, *command
+def command_file(prompt, *command)
   pauseyn = command.shift
-  command = command.join " "
-    print "[#{prompt}] Choose a file [#{$view[$cursor]}]: "
-    file = ask_hint $view[$cursor]
-  #print "#{prompt} :: Enter file shortcut: "
-  #file = ask_hint
-  perror "Command Cancelled" unless file
+  command = command.join ' '
+  print "[#{prompt}] Choose a file [#{$view[$cursor]}]: "
+  file = ask_hint $view[$cursor]
+  # print "#{prompt} :: Enter file shortcut: "
+  # file = ask_hint
+  perror 'Command Cancelled' unless file
   return unless file
+
   file = File.expand_path(file)
-  if File.exists? file
+  if File.exist? file
     file = Shellwords.escape(file)
     pbold "#{command} #{file} (#{pauseyn})"
     system "#{command} #{file}"
-    pause if pauseyn == "y"
+    pause if pauseyn == 'y'
     refresh
   else
     perror "File #{file} not found"
@@ -1346,31 +1473,30 @@ end
 
 ## prompt user for file shortcut and return file or nil
 #
-def ask_hint deflt=nil
+def ask_hint(deflt = nil)
   f = nil
   ch = get_char
-  if ch == "ENTER"
-    return deflt
-  end
+  return deflt if ch == 'ENTER'
+
   ix = get_index(ch, $viewport.size)
   f = $viewport[ix] if ix
-  return f
+  f
 end
 
 ## check screen size and accordingly adjust some variables
 #
 def screen_settings
-  $glines = %x(tput lines).to_i
-  $gcols = %x(tput cols).to_i
+  $glines = `tput lines`.to_i
+  $gcols = `tput cols`.to_i
   $grows = $glines - 3
   $pagesize = 60
-  #$gviscols = 3
+  # $gviscols = 3
   $pagesize = $grows * $gviscols
 end
 
 ## moves column offset so we can reach unindexed columns or entries
 # 0 forward and any other back/prev
-def column_next dir = 0
+def column_next(dir = 0)
   if dir == 0
     $stact += $grows
     $stact = 0 if $stact >= $viewport.size
@@ -1382,12 +1508,14 @@ end
 
 # currently i am only passing the action in from the list there as a key
 # I should be able to pass in new actions that are external commands
-def file_actions(action=nil)
-  h = { :d => :delete, :m => :move, :r => :rename, :v => ENV["EDITOR"] || :vim,
-    :c => :copy, :C => :chdir,
-    :l => :less, :s => :most , :f => :file , :o => :open, :x => :dtrx, :z => :zip }
-  #acttext = h[action.to_sym] || action
-  acttext = action || ""
+# 2019-03-08 - TODO when a file name changes or moves it must be removed
+#  from selection
+def file_actions(action = nil)
+  h = { d: :delete, m: :move, r: :rename, v: ENV['EDITOR'] || :vim,
+        c: :copy, C: :chdir, W: :remspace,
+        l: :less, s: :most, f: :file, o: :open, x: :dtrx, z: :zip }
+  # acttext = h[action.to_sym] || action
+  acttext = action || ''
   file = nil
 
   sct = $selected_files.size
@@ -1395,11 +1523,20 @@ def file_actions(action=nil)
     text = "#{sct} files"
     file = $selected_files
   else
-    print "[#{acttext}] Choose a file [#{$view[$cursor]}]: "
-    file = ask_hint $view[$cursor]
+    # 2019-03-07 - trying out direct deletes
+    # why were we aksing to select a file when user is on a file
+    # print "[#{acttext}] Choose a file [#{$view[$cursor]}]: "
+    # file = ask_hint $view[$cursor]
+    file = $view[$cursor]
+    unless file
+      file = ask_hint $view[$cursor]
+    end
     return unless file
+
     text = file
   end
+  # 2019-03-07 - NOTE at this point file can be one or more files.
+  # 2019-03-07 - text can be a file or count of files, so unreliable !!! FIXME
 
   case file
   when Array
@@ -1409,67 +1546,138 @@ def file_actions(action=nil)
     files = Shellwords.escape(file)
   end
 
-
   ch = nil
   if action
-      menu_text = action
+    menu_text = action
   else
     ch, menu_text = menu "File Menu for #{text}", h
     menu_text = :quit if ch == 'q'
   end
+  return unless menu_text # pressed some wrong key
+
   case menu_text.to_sym
+
   when :quit
+
   when :delete
-    print "rmtrash #{files} ?[yn]: "
+    delcommand = 'rmtrash'
+    print "#{delcommand} #{files} ?[yn]: "
     ch = get_char
-    return if ch != "y"
-    system "rmtrash #{files}"
+    return if ch != 'y'
+
+    system "#{delcommand} #{files}"
     refresh
+
   when :move
+    # 2019-03-07 - NOTE this will only work with single file selection
     print "move #{text} to : "
-    #target = gets().chomp
-    target = Readline::readline('>', true)
-    text=File.expand_path(text)
-    return if target == ""
+    # target = gets().chomp
+    # target = Readline.readline('>', true)
+    target = readline
+    return unless target
+
+    target = '.' if target == ''
+    # 2019-03-07 - NOTE cannot use text if multiple files
+    # text = File.expand_path(text)
+    target = File.expand_path(target)
+    return if target == ''
+
     if File.directory? target
-      FileUtils.mv text, target
+      begin
+        FileUtils.mv file, target
+      rescue StandardError => exc
+        perror exc.to_s
+      end
+      # 2019-03-08 - TODO if success remove from selection
       refresh
     else
-      perror "Target not a dir"
+      perror 'Target not a dir'
     end
+
   when :copy
+    # Target must be directory
     print "copy #{text} to : "
-    target = Readline::readline('>', true)
-    return if target == ""
-    text=File.expand_path(text)
-    target = File.basename(text) if target == "."
-    if File.exists? target
-      perror "Target (#{target}) exists"
-    else
-      FileUtils.cp text, target
+    target = readline
+    return unless target # C-c
+
+    target = '.' if target == ''
+    target = File.expand_path(target)
+    return if target == ''
+
+    if File.directory? target
+      begin
+        FileUtils.cp file, target
+      rescue StandardError => exc
+        perror exc.to_s
+      end
       refresh
+    else
+      perror 'Copy target must be a dir'
     end
+
   when :chdir
     change_dir File.dirname(text)
+
   when :zip
-    print "Archive name: "
-    #target = gets().chomp
-    target = Readline::readline('>', true)
-    return if target == ""
+    print 'Archive name: '
+    # target = gets().chomp
+    target = Readline.readline('>', true)
+    return if target == ''
+
     # don't want a blank space or something screwing up
     if target && target.size > 3
-      if File.exists? target
+      if File.exist? target
         perror "Target (#{target}) exists"
       else
         system "tar zcvf #{target} #{files}"
         refresh
       end
     end
+
   when :rename
+    # 2019-03-07 NOTE works for single file FIXME
+    # 2019-03-07 - TODO for n files replace pattern with string
+    print "rename #{text} to : "
+    target = Readline.readline('>', true)
+    return if target == ''
+
+    text = File.expand_path(text)
+    target = File.basename(text) if target == '.'
+    if File.exist? target
+      perror "Target (#{target}) exists"
+    else
+      FileUtils.mv text, target
+      refresh
+    end
   when :most, :less, :vim
     system "#{menu_text} #{files}"
+    # should we remove from selection ?
+
+  when :remspace
+    # 2019-03-08 - 00:07 added replace space with underscore in filename
+    print "Remove spaces from #{file}"
+    pause
+    farray = nil
+
+    # stupidly using one variable for scalar and array DUH !
+    case file
+    when String
+      farray = [file]
+    when Array
+      farray = file
+    end
+
+    farray.each do |f|
+      if f.index ' '
+        nname = f.tr(' ', '_')
+        FileUtils.mv f, nname unless File.exist? nname
+        # if success then remove from selection
+      end
+    end
+    refresh
   else
     return unless menu_text
+
     print "#{menu_text} #{files}"
     pause
     print
@@ -1477,13 +1685,16 @@ def file_actions(action=nil)
     refresh
     pause
   end
-  # remove non-existent files from select list due to move or delete or rename or whatever
+
+  # remove non-existent files from select list due to move or delete
+  #  or rename or whatever
   if sct > 0
-    $selected_files.reject! {|x| x = File.expand_path(x); !File.exists?(x) }
+    $selected_files.select! { |x| x = File.expand_path(x); File.exist?(x) }
   end
 end
 
-def columns_incdec howmany
+# increase or decrease column
+def columns_incdec(howmany)
   $gviscols += howmany.to_i
   $gviscols = 1 if $gviscols < 1
   $gviscols = 6 if $gviscols > 6
@@ -1493,59 +1704,65 @@ end
 # bind a key to an external command wich can be then be used for files
 def bindkey_ext_command
   print
-  pbold "Bind a capital letter to an external command"
-  print "Enter a capital letter to bind: "
+  pbold 'Bind a capital letter to an external command'
+  print 'Enter a capital letter to bind: '
   ch = get_char
-  return if ch == "Q"
+  return if ch == 'Q'
+
   if ch =~ /^[A-Z]$/
     print "Enter an external command to bind to #{ch}: "
-    com = gets().chomp
-    if com != ""
-      print "Enter prompt for command (blank if same as command): "
-      pro = gets().chomp
-      pro = com if pro == ""
+    com = gets.chomp
+    if com != ''
+      print 'Enter prompt for command (blank if same as command): '
+      pro = gets.chomp
+      pro = com if pro == ''
     end
-    print "Pause after output [y/n]: "
+    print 'Pause after output [y/n]: '
     yn = get_char
     $bindings[ch] = "command_file #{pro} #{yn} #{com}"
   end
 end
-def ack
-  print "Enter a pattern to search (ack): "
-  #pattern = gets.chomp
-  pattern = Readline::readline('>', true)
-  return if pattern == ""
-  $title = "Files found using 'ack' #{pattern}"
-  system("ack #{pattern}")
+
+def ag
+  print 'Enter a pattern to search (ag): '
+  pattern = Readline.readline('>', true)
+  return if pattern == ''
+
+  $title = "Files found using 'ag' #{pattern}"
+  system("ag #{pattern}")
   pause
-  files = `ack -l #{pattern}`.split("\n")
-  if files.size == 0
-    perror "No files found."
+  files = `ag -l #{pattern}`.split("\n")
+  if files.empty?
+    perror 'No files found.'
   else
     $files = files
   end
 end
+
 def ffind
-  print "Enter a file name pattern to find: "
-  pattern = Readline::readline('>', true)
-  return if pattern == ""
+  print 'Enter a file name pattern to find: '
+  pattern = Readline.readline('>', true)
+  return if pattern == ''
+
   $title = "Files found using 'find' #{pattern}"
   files = `find . -name '#{pattern}'`.split("\n")
-  if files.size == 0
-    perror "No files found."
+  if files.empty?
+    perror 'No files found.'
   else
     $files = files
   end
 end
+
 def locate
-  print "Enter a file name pattern to locate: "
-  pattern = Readline::readline('>', true)
-  return if pattern == ""
+  print 'Enter a file name pattern to locate: '
+  pattern = Readline.readline('>', true)
+  return if pattern == ''
+
   $title = "Files found using 'locate' #{pattern}"
   files = `locate #{pattern}`.split("\n")
-  files.reject! {|x| x = File.expand_path(x); !File.exists?(x) }
-  if files.size == 0
-    perror "No files found."
+  files.select! { |x| x = File.expand_path(x); File.exist?(x) }
+  if files.empty?
+    perror 'No files found.'
   else
     $files = files
   end
@@ -1555,12 +1772,12 @@ end
 #  then you can modify this accordingly.
 #
 def viminfo
-  file = File.expand_path("~/.viminfo")
-  if File.exists? file
-    $title = "Files from ~/.viminfo"
-    #$files = `grep '^>' ~/.viminfo | cut -d ' ' -f 2- | sed "s#~#$HOME#g"`.split("\n")
+  file = File.expand_path('~/.viminfo')
+  if File.exist? file
+    $title = 'Files from ~/.viminfo'
+    # $files = `grep '^>' ~/.viminfo | cut -d ' ' -f 2- | sed "s#~#$HOME#g"`.split("\n")
     $files = `grep '^>' ~/.viminfo | cut -d ' ' -f 2- `.split("\n")
-    $files.reject! {|x| x = File.expand_path(x); !File.exists?(x) }
+    $files.select! { |x| x = File.expand_path(x); File.exist?(x) }
   end
 end
 
@@ -1568,43 +1785,49 @@ end
 #   modify this accordingly
 #
 def z_interface
-  file = File.expand_path("~/.z")
-  if File.exists? file
-    $title = "Directories from ~/.z"
+  file = File.expand_path('~/.z')
+  if File.exist? file
+    $title = 'Directories from ~/.z'
     $files = `sort -rn -k2 -t '|' ~/.z | cut -f1 -d '|'`.split("\n")
     home = ENV['HOME']
     $files.collect! do |f|
-      f.sub(/#{home}/,"~")
+      f.sub(/#{home}/, '~')
     end
   end
 end
 
+def vidir
+  system "vidir"
+end
 ## there is no one consisten way i am getting.
 #  i need to do a shell join if I am to pipe ffiles to say: xargs ls -t
 #  but if i want to pipe names to grep xxx then i need to join with newlines
-def pipe
-end
+def pipe; end
 
 ## some cursor movement functions
 ##
 #
 def cursor_scroll_dn
-  moveto(pos() + MSCROLL)
+  moveto(pos + MSCROLL)
 end
+
 def cursor_scroll_up
-  moveto(pos() - MSCROLL)
+  moveto(pos - MSCROLL)
 end
+
 def cursor_dn
-  moveto(pos() + 1)
+  moveto(pos + 1)
 end
+
 def cursor_up
-  moveto(pos() - 1)
+  moveto(pos - 1)
 end
+
 def pos
   $cursor
 end
 
-def moveto pos
+def moveto(pos)
   orig = $cursor
   $cursor = pos
   $cursor = [$cursor, $view.size - 1].min
@@ -1613,21 +1836,62 @@ def moveto pos
   fin = [orig, $cursor].max
   if $visual_mode
     # PWD has to be there in selction
-    if $selected_files.index $view[$cursor]
+    # TODO: add full path TESTME
+    if selected? current_file
       # this depends on the direction
-      $selected_files = $selected_files - $view[star..fin]
+      # $selected_files = $selected_files - $view[star..fin]
+      remove_from_selection $view[star..fin]
       ## current row remains in selection always.
-      $selected_files.push $view[$cursor]
+      add_to_selection current_file
     else
-      $selected_files.concat $view[star..fin]
+      # $selected_files.concat $view[star..fin]
+      add_to_selection $view[star..fin]
     end
   end
 end
+
+# is given file in selected array
+def selected?(file)
+  $current_dir ||= Dir.pwd
+  file = File.join($current_dir, file)
+  return $selected_files.index file
+end
+
+# TODO: can be array
+def add_to_selection(file)
+  ff = file
+  case file
+  when String
+    ff = [file]
+  end
+  $current_dir ||= Dir.pwd
+  ff.each do |f|
+    full = File.join($current_dir, f)
+    $selected_files.push full
+  end
+end
+
+# TODO: can be array
+def remove_from_selection(file)
+  ff = file
+  case file
+  when String
+    ff = [file]
+  end
+  $current_dir ||= Dir.pwd
+  ff.each do |f|
+    full = File.join($current_dir, f)
+    $selected_files.delete full
+  end
+end
+
 def visual_mode_toggle
   $visual_mode = !$visual_mode
   if $visual_mode
     $visual_block_start = $cursor
-    $selected_files.push $view[$cursor]
+    # TODO: add full path TESTME
+    # $selected_files.push $view[$cursor]
+    add_to_selection current_file
   end
 end
 
@@ -1635,69 +1899,77 @@ def visual_block_clear
   if $visual_block_start
     star = [$visual_block_start, $cursor].min
     fin = [$visual_block_start, $cursor].max
-    $selected_files = $selected_files - $view[star..fin]
+    # TODO: add full path TESTME
+    # $selected_files = $selected_files - $view[star..fin]
+    remove_from_selection $view[star..fin]
   end
   $visual_block_start = nil
   $visual_mode = nil
 end
 
-def file_starting_with fc
-  ix = return_next_match(method(:file_matching?), "^#{fc}")
-  if ix
-    goto_line ix
-  end
+def file_starting_with(first_char)
+  ix = return_next_match(method(:file_matching?), "^#{first_char}")
+  goto_line ix if ix
 end
-def file_matching? file, patt
+
+def file_matching?(file, patt)
   file =~ /#{patt}/
 end
 
 ## generic method to take cursor to next position for a given condition
-def return_next_match binding, *args
+def return_next_match(binding, *args)
   first = nil
   ix = 0
-  $view.each_with_index do |elem,ii|
-    if binding.call(elem, *args)
-      first ||= ii
-      if ii > $cursor
-        ix = ii
-        break
-      end
+  $view.each_with_index do |elem, ii|
+    next unless binding.call(elem, *args)
+
+    first ||= ii
+    if ii > $cursor
+      ix = ii
+      break
     end
   end
   return first if ix == 0
-  return ix
+
+  ix
 end
+
 ##
 # position cursor on a specific line which could be on a nother page
 # therefore calculate the correct start offset of the display also.
-def goto_line pos
-  pages = ((pos * 1.00)/$pagesize).ceil
+def goto_line(pos)
+  pages = ((pos * 1.00) / $pagesize).ceil
   pages -= 1
   $sta = pages * $pagesize + 1
   $cursor = pos
 end
-def filetype f
+
+def filetype(f)
   return nil unless f
+
   f = Shellwords.escape(f)
   s = `file #{f}`
-  if s.index "text"
+  if s.index 'text'
     return :text
   elsif s.index(/[Zz]ip/)
     return :zip
-  elsif s.index("archive")
+  elsif s.index('archive')
     return :zip
-  elsif s.index "image"
+  elsif s.index 'image'
     return :image
-  elsif s.index "data"
+  elsif s.index 'data'
     return :text
   end
+
   nil
 end
 
 def save_dir_pos
   return if $sta == 0 && $cursor == 0
+
   $dir_position[Dir.pwd] = [$sta, $cursor]
 end
+
 def revert_dir_pos
   $sta = 0
   $cursor = 0
@@ -1706,50 +1978,108 @@ def revert_dir_pos
     $sta = a.first
     $cursor = a[1]
     raise "sta is nil for #{Dir.pwd} : #{$dir_position[Dir.pwd]}" unless $sta
-    raise "cursor is nil" unless $cursor
+    raise 'cursor is nil' unless $cursor
   end
 end
+
 def newdir
   print
-  print "Enter directory name: "
-  str = Readline::readline('>', true)
-  return if str == ""
-  if File.exists? str
+  print 'Enter directory name: '
+  str = Readline.readline('>', true)
+  return if str == ''
+
+  if File.exist? str
     perror "#{str} exists."
     return
   end
   begin
     FileUtils.mkdir str
-    $used_dirs.insert(0, str) if File.exists?(str)
+    $used_dirs.insert(0, str) if File.exist?(str)
     refresh
   rescue Exception => ex
     perror "Error in newdir: #{ex}"
   end
 end
+
 def newfile
   print
-  print "Enter file name: "
-  str = Readline::readline('>', true)
-  return if str == ""
-  system "$EDITOR #{str}"
-  $visited_files.insert(0, str) if File.exists?(str)
+  print 'Enter file name: '
+  str = Readline.readline('>', true)
+  return if str == ''
+
+  # FIXME a file with space will not create single file
+  # 2019-03-10 - maybe touch a file
+
+  system %($EDITOR "#{str}")
+  $visited_files.insert(0, str) if File.exist?(str)
   refresh
 end
 
+
+
+def current_file
+  $view[$cursor]
+end
+
+def current_or_selected_files
+  return $selected_files if $selected_files.size > 0
+
+  return [current_file]
+end
+
+# ------------------- scripts ------------------ #
+# prompt for scripts to execute, giving selected file names
+def scripts
+  title = 'Select a script'
+  script_path = '~/.config/cetus/scripts'
+  binding = `find #{script_path} -type f | fzf --prompt="#{title.to_s} :"`
+  return unless binding
+
+  binding = binding.chomp if binding
+  # TODO: check if binding is a file and executable
+  # xargs only seems to take the first file
+  # cf = current_or_selected_files.join('\0')
+  # cf = Shellwords.join(current_or_selected_files)
+  current_or_selected_files.each do |file|
+    system %( #{binding} "#{file}" )
+  end
+  # system %(echo "#{cf}" | xargs #{binding})
+  pause
+end
+# ------------- end of scripts --------------------------------#
+
+# ------------------- page_selection ------------------ #
+def page_selection
+  require 'tempfile'
+  file = Tempfile.new('selected_files')
+  begin
+    $selected_files.each { |row| file.puts row }
+    file.flush
+    system "$PAGER #{file.path}"
+  rescue
+    file.close
+    file.unlink
+  end
+end
+# ------------- end of page_selection --------------------------------#
 ##
 # Editing of the User Dir List.
 # remove current entry from used dirs list, since we may not want some entries being there
 #
 def remove_from_list
-  if $selected_files.size > 0
+  unless $selected_files.empty?
     sz = $selected_files.size
     print "Remove #{sz} files from used list (y)?: "
     ch = get_char
-    return if ch != "y"
-    $used_dirs = $used_dirs - $selected_files
-    $visited_files = $visited_files - $selected_files
+    return if ch != 'y'
+
+    arr = $selected_files.map { |path| File.expand_path(path) }
+
+    $used_dirs = $used_dirs - arr
+    $visited_files = $visited_files - arr
     unselect_all
     $modified = true
+    refresh
     return
   end
   print
@@ -1757,7 +2087,8 @@ def remove_from_list
   file = $view[$cursor]
   print "Remove #{file} from used list (y)?: "
   ch = get_char
-  return if ch != "y"
+  return if ch != 'y'
+
   file = File.expand_path(file)
   if File.directory? file
     $used_dirs.delete(file)
@@ -1767,6 +2098,7 @@ def remove_from_list
   refresh
   $modified = true
 end
+
 #
 # If there's a short file list, take recently mod and accessed folders and put latest
 # files from there and insert it here. I take both since recent mod can be binaries / object
@@ -1775,15 +2107,16 @@ end
 # include files.
 def enhance_file_list
   return unless $enhanced_mode
+
   # if only one entry and its a dir
   # get its children and maybe the recent mod files a few
 
   if $files.size == 1
     # its a dir, let give the next level at least
-    if $files.first[-1] == "/"
+    if $files.first[-1] == '/'
       d = $files.first
       f = `zsh -c 'print -rl -- #{d}*(omM)'`.split("\n")
-      if f && f.size > 0
+      if f && !f.empty?
         $files.concat f
         $files.concat get_important_files(d)
         return
@@ -1797,28 +2130,28 @@ def enhance_file_list
   # check if a ruby project dir, although it could be a backup file too,
   # if so , expand lib and maby bin, put a couple recent files
   #
-  if $files.index("Gemfile") || $files.grep(/\.gemspec/).size > 0
+  if $files.index('Gemfile') || !$files.grep(/\.gemspec/).empty?
     # usually the lib dir has only one file and one dir
     flg = false
     $files.concat get_important_files(Dir.pwd)
-    if $files.index("lib/")
+    if $files.index('lib/')
       f = `zsh -c 'print -rl -- lib/*(om[1,5]M)'`.split("\n")
-      if f && f.size() > 0
-        insert_into_list("lib/", f)
+      if f && !f.empty?
+        insert_into_list('lib/', f)
         flg = true
       end
       dd = File.basename(Dir.pwd)
       if f.index("lib/#{dd}/")
         f = `zsh -c 'print -rl -- lib/#{dd}/*(om[1,5]M)'`.split("\n")
-        if f && f.size() > 0
+        if f && !f.empty?
           insert_into_list("lib/#{dd}/", f)
           flg = true
         end
       end
     end
-    if $files.index("bin/")
+    if $files.index('bin/')
       f = `zsh -c 'print -rl -- bin/*(om[1,5]M)'`.split("\n")
-      insert_into_list("bin/", f) if f && f.size() > 0
+      insert_into_list('bin/', f) if f && !f.empty?
       flg = true
     end
     return if flg
@@ -1830,15 +2163,11 @@ def enhance_file_list
 
   ## first check accessed else modified will change accessed
   moda = `zsh -c 'print -rn -- *(/oa[1]M)'`
-  if moda && moda != ""
+  if moda && moda != ''
     modf = `zsh -c 'print -rn -- #{moda}*(oa[1]M)'`
-    if modf && modf != ""
-      insert_into_list moda, modf
-    end
+    insert_into_list moda, modf if modf && modf != ''
     modm = `zsh -c 'print -rn -- #{moda}*(om[1]M)'`
-    if modm && modm != "" && modm != modf
-      insert_into_list moda, modm
-    end
+    insert_into_list moda, modm if modm && modm != '' && modm != modf
   end
   ## get last modified dir
   modm = `zsh -c 'print -rn -- *(/om[1]M)'`
@@ -1853,38 +2182,38 @@ def enhance_file_list
     # are the same dir, so we need to find the second modified dir
   end
 end
-def insert_into_list dir, file
-  #ix = $files.index(dir)
-  #raise "something wrong can find #{dir}." unless ix
-  #$files.insert ix, *file
+
+def insert_into_list(_dir, file)
+  # ix = $files.index(dir)
+  # raise "something wrong can find #{dir}." unless ix
+  # $files.insert ix, *file
   # 2013-03-19 - 19:42 adding at end to avoid confusion
-  #$files.concat file
+  # $files.concat file
   $files.push *file
 end
-def get_important_files dir
+
+def get_important_files(dir)
   # checks various lists like visited_files and bookmarks
   # to see if files from this dir or below are in it.
   # More to be used in a dir with few files.
   list = []
   l = dir.size + 1
   $visited_files.each do |e|
-    if e.index(dir) == 0
-      list << e[l..-1]
-    end
+    list << e[l..-1] if e.index(dir) == 0
   end
   # bookmarks have : which needs to be removed
-  #list1 = $bookmarks.values.select do |e|
-    #e.index(dir) == 0
-  #end
-  #list.concat list1
-  return list
+  # list1 = $bookmarks.values.select do |e|
+  # e.index(dir) == 0
+  # end
+  # list.concat list1
+  list
 end
 
-Signal.trap('EXIT') {
+Signal.trap('EXIT') do
   reset_terminal
   # system 'tput rmcup'
   exit
-}
+end
 run
 # 2019-02-20 - added so alt-screen is used
 system 'tput rmcup'