certmeister 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41a8e46ac96ea1df82ccd6bc6d1e7ac813c45b39
-  data.tar.gz: 7d3deab06f303c7725b316db513e1951d7ce2429
+  metadata.gz: 4a27d8981207e04f484c463efee5eb192b1ac040
+  data.tar.gz: d3d089cf572cd18dd08997483539fe56b1257f88
 SHA512:
-  metadata.gz: 476a2abd15ebd45ac60facf0c6b3837ae08b3bc11d9785e230ecd94b58acad5aa3abf3a5b5db246be204a9400e1bf2aacc19173ff42f4d3cc721f1edb1f34ef4
-  data.tar.gz: e7385adbdb0288a486897979c64b459b1efb672bbc334502300ac35764bff158a7759060f748e68b5750d013f01b40e8281deb277786d13e06b0c6e16d9c7a7d
+  metadata.gz: 0699466fc8b0eee2e5f68a001138c8a4fa30b64c9fc16830e6e5b5bd64b3d08796e6f348e7c3d2430366890505991173d8857a7e00b252c2923dbf023b0af5c2
+  data.tar.gz: 76df1686defaeb078155b070dd5b4325bf29a5d565c49bd4d4dacfc5f4754b7607952da5e516651e75edd740fded0e02def5ac2ce3c20032fb725e988629d8c6

data/Gemfile.lock

@@ -1,12 +1,12 @@
 PATH
   remote: .
   specs:
-    certmeister (0.4.0)
-    certmeister-rack (0.4.0)
-      certmeister (= 0.4.0)
+    certmeister (0.4.1)
+    certmeister-rack (0.4.1)
+      certmeister (= 0.4.1)
       rack (~> 1.5)
-    certmeister-redis (0.4.0)
-      certmeister (= 0.4.0)
+    certmeister-redis (0.4.1)
+      certmeister (= 0.4.1)
       redis-sentinel (~> 1.4)
 
 GEM

data/README.md

@@ -58,6 +58,8 @@ changes):
 ```
 # edit lib/certmeister/version.rb
 bundle
-git commit -m "Bump to version x.y.z" Gemfile.lock lib/certmeister/version.rb
+git commit \
+  -m "Bump version to v$(bundle exec ruby -Ilib -rcertmeister -e 'puts Certmeister::VERSION')" \
+  Gemfile.lock lib/certmeister/version.rb
 bundle exec release
 ```

data/lib/certmeister/policy/chain_any.rb

@@ -12,11 +12,10 @@ module Certmeister
       end
 
       def authenticate(request)
-        failure = Certmeister::Policy::Response.new(false, "no conditions satisifed")
-        @policies.inject(failure) do |continue, policy|
+        @policies.inject(nil) do |continue, policy|
           response = policy.authenticate(request)
           break response if response.authenticated?
-          continue
+          continue or response
         end
       end
 

data/lib/certmeister/version.rb

@@ -1,5 +1,5 @@
 module Certmeister
 
-  VERSION = '0.4.0' unless defined?(VERSION)
+  VERSION = '0.4.1' unless defined?(VERSION)
 
 end

data/spec/certmeister/policy/chain_all_spec.rb

@@ -32,9 +32,17 @@ describe Certmeister::Policy::ChainAll do
     policies.each do |policy|
       response = policy.authenticate({anything: 'something'})
       expect(response).to_not be_authenticated
-      expect(response.error).to eql "blackholed"
     end
   end
 
+  it "uses the error message of the first encountered refusal in the chain" do
+    policy = Certmeister::Policy::ChainAll.new([
+      Certmeister::Policy::Domain.new(['unmatched.com']),
+      Certmeister::Policy::Blackhole.new,
+    ])
+    response = policy.authenticate({cn: 'wrongdomain.com'})
+    expect(response.error).to eql 'cn in unknown domain'
+  end
+
 end
 

data/spec/certmeister/policy/chain_any_spec.rb

@@ -25,13 +25,19 @@ describe Certmeister::Policy::ChainAny do
   end
 
   it "refuses a request that none of its chained policies refuses" do
-    policy = Certmeister::Policy::ChainAll.new([ Certmeister::Policy::Blackhole.new, Certmeister::Policy::Blackhole.new])
+    policy = Certmeister::Policy::ChainAny.new([ Certmeister::Policy::Blackhole.new, Certmeister::Policy::Blackhole.new])
     response = policy.authenticate({anything: 'something'})
     expect(response).to_not be_authenticated
-    expect(response.error).to eql "blackholed"
   end
 
-  it "uses the error message of the last encountered refusal in the chain"
+  it "uses the error message of the first encountered refusal in the chain" do
+    policy = Certmeister::Policy::ChainAny.new([
+      Certmeister::Policy::Domain.new(['unmatched.com']),
+      Certmeister::Policy::Blackhole.new,
+    ])
+    response = policy.authenticate({cn: 'wrongdomain.com'})
+    expect(response.error).to eql 'cn in unknown domain'
+  end
 
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: certmeister
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Sheldon Hearn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-05 00:00:00.000000000 Z
+date: 2014-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler