central_logger 0.1.0 → 0.1.1

data/README.md

@@ -4,7 +4,11 @@ Log to a central MongoDB from Rails apps.
 
 ## Usage
 
-1. Install the gem:
+1. If using Bundler, add the following to your Gemfile then refresh your dependencies by executing "bundle install":
+
+        gem "central_logger"
+
+1. If you're just using gem:
 
         gem install central_logger
 
@@ -12,13 +16,12 @@ Log to a central MongoDB from Rails apps.
 
         include CentralLogger::Filter
 
-1. If using Rails < 3, configure environment.rb as shown below (in config/environment.rb).  Otherwise, the logger is
-automatically initialized for all environments.
+1. If using Rails 3, SKIP this step.  Otherwise, add the following to config/environment.rb:
 
        require 'central_logger'
        CentralLogger::Initializer.initialize_deprecated_logger(config)
 
-1. Add mongo settings to database.yml for each environment in which you want to use MongoDB for logging. The values below are defaults:
+1. Add mongo settings to database.yml for each environment in which you want to use the Central Logger for logging. The values below are defaults:
 
         development:
           adapter: mysql

data/Rakefile

@@ -24,10 +24,6 @@ Jeweler::Tasks.new do |gem|
   gem.email = "astupka@customink.com"
   gem.homepage = "http://github.com/customink/central_logger"
   gem.authors = ["Phil Burrows", "Alex Stupka"]
-  gem.rubyforge_project = "central_logger"
-end
-Jeweler::RubyforgeTasks.new do |rubyforge|
-  rubyforge.doc_task = "rdoc"
 end
 # dependencies defined in Gemfile
 

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/central_logger.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{central_logger}
-  s.version = "0.1.0"
+  s.version = "0.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Phil Burrows", "Alex Stupka"]
-  s.date = %q{2010-11-01}
+  s.date = %q{2010-11-03}
   s.description = %q{Centralized logging for rails apps using MongoDB. The idea and the core code is from http://github.com/peburrows/central_logger}
   s.email = %q{astupka@customink.com}
   s.extra_rdoc_files = [
@@ -39,7 +39,6 @@ Gem::Specification.new do |s|
   ]
   s.homepage = %q{http://github.com/customink/central_logger}
   s.require_paths = ["lib"]
-  s.rubyforge_project = %q{central_logger}
   s.rubygems_version = %q{1.3.7}
   s.summary = %q{Central Logger for Rails}
   s.test_files = [

data/lib/central_logger/mongo_logger.rb

@@ -52,16 +52,15 @@ module CentralLogger
         :request_time => Time.now.getutc,
         :application_name => @application_name
       })
-      # In case of exception, make sure it's set
-      runtime = 0
-      runtime = Benchmark.measure do
-        yield
-      end
+
+      runtime = Benchmark.measure{ yield }.real
     rescue Exception => e
       add(3, e.message + "\n" + e.backtrace.join("\n"))
       # Reraise the exception for anyone else who cares
       raise e
     ensure
+      # In case of exception, make sure runtime is set
+      runtime ||= 0
       insert_log_record(runtime)
     end
 
@@ -105,7 +104,7 @@ module CentralLogger
       end
 
       def insert_log_record(runtime)
-        @mongo_record[:runtime] = (runtime.real * 1000).ceil
+        @mongo_record[:runtime] = (runtime * 1000).ceil
         @mongo_connection[@mongo_collection_name].insert(@mongo_record) rescue nil
       end
 

data/test/test_helper.rb

@@ -17,6 +17,12 @@ class Test::Unit::TestCase
     end
   end
 
+  def log_exception(msg)
+    @central_logger.mongoize({"id" => 1}) do
+      raise msg
+    end
+  end
+
   def log_metadata(options)
     @central_logger.mongoize({"id" => 1}) do
       @central_logger.add_metadata(options)

data/test/unit/central_logger_test.rb

@@ -5,6 +5,8 @@ require 'central_logger/mongo_logger'
 class CentralLogger::MongoLoggerTest < Test::Unit::TestCase
   extend LogMacros
 
+  EXCEPTION_MSG = "Foo"
+
   context "A CentralLogger::MongoLogger" do
     context "during configuration in instantiation" do
       setup do
@@ -47,6 +49,7 @@ class CentralLogger::MongoLoggerTest < Test::Unit::TestCase
       setup do
         @central_logger = CentralLogger::MongoLogger.new
         common_setup
+        @central_logger.reset_collection
       end
 
       context "upon insertion of a log record when active record is not used" do
@@ -67,7 +70,6 @@ class CentralLogger::MongoLoggerTest < Test::Unit::TestCase
         setup do
           @log_message = "TESTING"
           require_bogus_active_record
-          @central_logger.reset_collection
           log("\e[31m #{@log_message} \e[0m")
         end
 
@@ -87,13 +89,20 @@ class CentralLogger::MongoLoggerTest < Test::Unit::TestCase
         log_metadata(options)
         assert_equal 1, @collection.find({"application" => self.class.name}).count
       end
+
+      context "when an exception is raised" do
+        should "log the exception" do
+          assert_raise(RuntimeError, EXCEPTION_MSG) {log_exception(EXCEPTION_MSG)}
+          assert_equal 1, @collection.find_one({"messages.error" => /^#{EXCEPTION_MSG}/})["messages"]["error"].count
+        end
+      end
     end
 
     context "logging at INFO level" do
       setup do
         @central_logger = CentralLogger::MongoLogger.new(:level => CentralLogger::MongoLogger::INFO)
-        @central_logger.reset_collection
         common_setup
+        @central_logger.reset_collection
         log("INFO")
       end
 
@@ -103,5 +112,6 @@ class CentralLogger::MongoLoggerTest < Test::Unit::TestCase
         assert_equal 0, @collection.find_one({}, :fields => ["messages"])["messages"].count
       end
     end
+
   end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Phil Burrows
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-01 00:00:00 -04:00
+date: 2010-11-03 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: "0"
 requirements: []
 
-rubyforge_project: central_logger
+rubyforge_project: 
 rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3