cemeng-paperclip 2.3.6

data/test/command_line_test.rb

@@ -0,0 +1,133 @@
+require './test/helper'
+
+class CommandLineTest < Test::Unit::TestCase
+  def setup
+    Paperclip::CommandLine.path = nil
+    File.stubs(:exist?).with("/dev/null").returns(true)
+  end
+
+  should "take a command and parameters and produce a shell command for bash" do
+    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
+    assert_equal "convert a.jpg b.png", cmd.command
+  end
+
+  should "be able to set a path and produce commands with that path" do
+    Paperclip::CommandLine.path = "/opt/bin"
+    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
+    assert_equal "/opt/bin/convert a.jpg b.png", cmd.command
+  end
+
+  should "be able to interpolate quoted variables into the parameters" do
+    cmd = Paperclip::CommandLine.new("convert",
+                                     ":one :{two}",
+                                     :one => "a.jpg",
+                                     :two => "b.png",
+                                     :swallow_stderr => false)
+    assert_equal "convert 'a.jpg' 'b.png'", cmd.command
+  end
+
+  should "quote command line options differently if we're on windows" do
+    File.stubs(:exist?).with("/dev/null").returns(false)
+    cmd = Paperclip::CommandLine.new("convert",
+                                     ":one :{two}",
+                                     :one => "a.jpg",
+                                     :two => "b.png",
+                                     :swallow_stderr => false)
+    assert_equal 'convert "a.jpg" "b.png"', cmd.command
+  end
+
+  should "be able to quote and interpolate dangerous variables" do
+    cmd = Paperclip::CommandLine.new("convert",
+                                     ":one :two",
+                                     :one => "`rm -rf`.jpg",
+                                     :two => "ha'ha.png",
+                                     :swallow_stderr => false)
+    assert_equal "convert '`rm -rf`.jpg' 'ha'\\''ha.png'", cmd.command
+  end
+
+  should "be able to quote and interpolate dangerous variables even on windows" do
+    File.stubs(:exist?).with("/dev/null").returns(false)
+    cmd = Paperclip::CommandLine.new("convert",
+                                     ":one :two",
+                                     :one => "`rm -rf`.jpg",
+                                     :two => "ha'ha.png",
+                                     :swallow_stderr => false)
+    assert_equal %{convert "`rm -rf`.jpg" "ha'ha.png"}, cmd.command
+  end
+
+  should "add redirection to get rid of stderr in bash" do
+    File.stubs(:exist?).with("/dev/null").returns(true)
+    cmd = Paperclip::CommandLine.new("convert",
+                                     "a.jpg b.png",
+                                     :swallow_stderr => true)
+
+    assert_equal "convert a.jpg b.png 2>/dev/null", cmd.command
+  end
+
+  should "add redirection to get rid of stderr in cmd.exe" do
+    File.stubs(:exist?).with("/dev/null").returns(false)
+    cmd = Paperclip::CommandLine.new("convert",
+                                     "a.jpg b.png",
+                                     :swallow_stderr => true)
+
+    assert_equal "convert a.jpg b.png 2>NUL", cmd.command
+  end
+
+  should "raise if trying to interpolate :swallow_stderr or :expected_outcodes" do
+    cmd = Paperclip::CommandLine.new("convert",
+                                     ":swallow_stderr :expected_outcodes",
+                                     :swallow_stderr => false,
+                                     :expected_outcodes => [0, 1])
+    assert_raise(Paperclip::PaperclipCommandLineError) do
+      cmd.command
+    end
+  end
+
+  should "run the #command it's given and return the output" do
+    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
+    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
+    with_exitstatus_returning(0) do
+      assert_equal :correct_value, cmd.run
+    end
+  end
+
+  should "raise a PaperclipCommandLineError if the result code isn't expected" do
+    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
+    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
+    with_exitstatus_returning(1) do
+      assert_raises(Paperclip::PaperclipCommandLineError) do
+        cmd.run
+      end
+    end
+  end
+
+  should "not raise a PaperclipCommandLineError if the result code is expected" do
+    cmd = Paperclip::CommandLine.new("convert",
+                                     "a.jpg b.png",
+                                     :expected_outcodes => [0, 1],
+                                     :swallow_stderr => false)
+    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
+    with_exitstatus_returning(1) do
+      assert_nothing_raised do
+        cmd.run
+      end
+    end
+  end
+
+  should "log the command" do
+    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
+    cmd.class.stubs(:'`')
+    Paperclip.expects(:log).with("convert a.jpg b.png")
+    cmd.run
+  end
+
+  should "detect that the system is unix or windows based on presence of /dev/null" do
+    File.stubs(:exist?).returns(true)
+    assert Paperclip::CommandLine.unix?
+  end
+
+  should "detect that the system is not unix or windows based on absence of /dev/null" do
+    File.stubs(:exist?).returns(false)
+    assert ! Paperclip::CommandLine.unix?
+  end
+end

data/test/database.yml

@@ -0,0 +1,4 @@
+test:
+  adapter: sqlite3
+  database: ":memory:"
+

data/test/database_storage_test.rb

@@ -0,0 +1,267 @@
+require './test/helper'
+
+module ActionController
+  class Base
+    def self.relative_url_root
+      '/base'
+    end
+  end
+end
+
+def rebuild_database_table_1_blob_column options = {}
+  ActiveRecord::Base.connection.create_table :dummies, :force => true do |table|
+    table.column :other, :string
+    table.column :avatar_file_name, :string
+    table.column :avatar_content_type, :string
+    table.column :avatar_file_size, :integer
+    table.column :avatar_updated_at, :datetime
+    table.column :avatar_file, :binary
+  end
+end
+
+def rebuild_database_table_3_default_blob_columns options = {}
+  ActiveRecord::Base.connection.create_table :dummies, :force => true do |table|
+    table.column :other, :string
+    table.column :avatar_file_name, :string
+    table.column :avatar_content_type, :string
+    table.column :avatar_file_size, :integer
+    table.column :avatar_updated_at, :datetime
+    table.column :avatar_file, :binary
+    table.column :avatar_thumb_file, :binary
+    table.column :avatar_medium_file, :binary
+  end
+end
+
+def rebuild_database_table_3_custom_blob_columns options = {}
+  ActiveRecord::Base.connection.create_table :dummies, :force => true do |table|
+    table.column :other, :string
+    table.column :avatar_file_name, :string
+    table.column :avatar_content_type, :string
+    table.column :avatar_file_size, :integer
+    table.column :avatar_updated_at, :datetime
+    table.column :avatar_file_data, :binary
+    table.column :thumb_file_data, :binary
+    table.column :medium_file_data, :binary
+  end
+end
+
+class DatabaseStorageTest < Test::Unit::TestCase
+
+  context "An attachment with database storage and default options" do
+    setup do
+      rebuild_database_table_1_blob_column
+      rebuild_class :storage => :database
+    end
+    
+    should "be extended by the database storage module" do
+      assert Dummy.new.avatar.is_a?(Paperclip::Storage::Database)
+    end
+    
+    should "return the meta data columns from select_without_file_columns_for" do
+      assert_equal Dummy.select_without_file_columns_for(:avatar),
+                   { :select=>"id,other,avatar_file_name,avatar_content_type,avatar_file_size,avatar_updated_at" }
+    end    
+  end
+
+  context "An attachment with database storage and array style options" do
+    setup do
+      rebuild_database_table_1_blob_column
+      rebuild_class :storage => :database, :styles => {:original => ["200x200", :jpg ]}
+    end
+
+    should "be extended by the database storage module" do
+      assert Dummy.new.avatar.is_a?(Paperclip::Storage::Database)
+    end
+
+    should "return the meta data columns from select_without_file_columns_for" do
+      assert_equal Dummy.select_without_file_columns_for(:avatar),
+                   { :select=>"id,other,avatar_file_name,avatar_content_type,avatar_file_size,avatar_updated_at" }
+    end
+  end
+
+  context "An attachment with database storage, default options plus two styles" do
+    setup do
+      rebuild_database_table_3_default_blob_columns
+      rebuild_class :storage => :database,
+        :styles => { 
+          :medium => {:geometry => "300x300>"},
+          :thumb => {:geometry => "100x100>"}
+        }
+    end
+    
+    should "return the meta data columns from select_without_file_columns_for" do
+      assert_equal Dummy.select_without_file_columns_for(:avatar),
+                   { :select=>"id,other,avatar_file_name,avatar_content_type,avatar_file_size,avatar_updated_at" }
+    end
+  end
+
+  context "An attachment with database storage and incorrect original style column name" do
+    setup do
+      rebuild_database_table_1_blob_column
+    end
+    
+    should "raise an exception" do
+      assert_raises(Paperclip::PaperclipError) do
+        rebuild_class :storage => :database, :column => 'missing'
+      end
+    end
+  end
+
+  context "An attachment with database storage and incorrect other style column name" do
+    setup do
+      rebuild_database_table_3_default_blob_columns
+    end
+    
+    should "raise an exception" do
+      assert_raises(Paperclip::PaperclipError) do
+        rebuild_class :storage => :database,
+          :styles => { 
+            :medium => {:geometry => "300x300>", :column => 'missing'},
+            :thumb => {:geometry => "100x100>"}
+          }
+      end
+    end
+  end
+
+  context "An attachment with database storage and original style column name set to attachment name" do
+    setup do
+      rebuild_database_table_3_default_blob_columns
+    end
+    
+    should "raise an exception" do
+      assert_raises(Paperclip::PaperclipError) do
+        rebuild_class :storage => :database, :column => 'avatar',
+          :styles => { 
+            :medium => {:geometry => "300x300>"},
+            :thumb => {:geometry => "100x100>"}
+          }
+      end
+    end
+  end
+
+
+  context "An attachment with database storage and other style column name set to attachment name" do
+    setup do
+      rebuild_database_table_3_default_blob_columns
+    end
+    
+    should "raise an exception" do
+      assert_raises(Paperclip::PaperclipError) do
+        rebuild_class :storage => :database,
+          :styles => { 
+            :medium => {:geometry => "300x300>", :column => 'avatar'},
+            :thumb => {:geometry => "100x100>"}
+          }
+      end
+    end
+  end
+
+
+  context "An attachment with database storage" do
+    setup do
+      rebuild_database_table_3_custom_blob_columns
+      rebuild_class :storage => :database, :column => 'avatar_file_data',
+        :styles => { 
+          :medium => {:geometry => "300x300>", :column => 'medium_file_data'},
+          :thumb => {:geometry => "100x100>", :column => 'thumb_file_data'}
+        }
+      @dummy = Dummy.new
+    end
+    
+    context "before assigned a file" do
+      should "return false when asked exists?" do
+        assert !@dummy.avatar.exists?
+      end
+
+      should "return its default_url" do
+        assert @dummy.avatar.to_file.nil?
+        assert_equal "/avatars/original/missing.png", @dummy.avatar.url
+        assert_equal "/avatars/blah/missing.png", @dummy.avatar.url(:blah)
+      end
+
+      should "return nil as path" do
+        assert @dummy.avatar.to_file.nil?
+        assert_equal nil, @dummy.avatar.path
+        assert_equal nil, @dummy.avatar.path(:blah)
+      end
+    end
+
+    context "and assigned a file" do
+      setup do
+        @file = File.new(File.join(File.dirname(__FILE__),
+                                   "fixtures",
+                                   "5k.png"), 'rb')
+        @contents = @file.read
+        @file.rewind
+
+        @dummy.avatar = @file
+      end
+
+      teardown { @file.close if @file }
+
+      should "be dirty" do
+        assert @dummy.avatar.dirty?
+      end
+
+      should "exist" do
+        assert @dummy.avatar.exists?
+      end
+
+      should "save the actual file contents to the original style column" do
+        assert_equal @contents, @dummy.avatar_file_data
+        assert !(file = @dummy.avatar.to_file).nil?
+        assert_equal Paperclip::Tempfile, file.class
+        file.close
+      end
+
+      should "save some value to the other style columns" do
+        assert !@dummy.medium_file_data.nil?
+        assert !@dummy.thumb_file_data.nil?
+      end
+
+      should "return the proper default url" do
+        assert_match %r{^/dummies/avatars/#{@dummy.id}\?style=original}, @dummy.avatar.url
+        assert_match %r{^/dummies/avatars/#{@dummy.id}\?style=medium}, @dummy.avatar.url(:medium)
+        assert_match %r{^/dummies/avatars/#{@dummy.id}\?style=thumb}, @dummy.avatar.url(:thumb)
+      end
+
+      should "return the column name as path" do
+        assert_equal "avatar_file_data", @dummy.avatar.path
+        assert_equal "avatar_file_data", @dummy.avatar.path(:original)
+        assert_equal "medium_file_data", @dummy.avatar.path(:medium)
+        assert_equal "thumb_file_data", @dummy.avatar.path(:thumb)
+      end
+
+      context "and assigned to another attachment" do
+        setup do
+          @dummy2 = Dummy.new
+          @dummy2.avatar = @dummy.avatar
+        end
+
+        should "have the proper attributes assigned to the other attachment" do
+          assert_equal @dummy.avatar_file_name, @dummy2.avatar_file_name
+          assert_equal @dummy.avatar_content_type, @dummy2.avatar_content_type
+          assert_equal @dummy.avatar_file_size, @dummy2.avatar_file_size
+          assert_equal @dummy.avatar_file_data, @dummy2.avatar.file_contents
+        end
+      end
+
+      context "and saved and assigned to another attachment" do
+        setup do
+          @dummy.save
+
+          @dummy2 = Dummy.new
+          @dummy2.avatar = @dummy.avatar
+        end
+
+        should "have the proper attributes assigned to the other attachment" do
+          assert_equal @dummy.avatar_file_name, @dummy2.avatar_file_name
+          assert_equal @dummy.avatar_content_type, @dummy2.avatar_content_type
+          assert_equal @dummy.avatar_file_size, @dummy2.avatar_file_size
+          assert_equal @dummy.avatar_file_data, @dummy2.avatar.file_contents
+        end
+      end
+
+    end
+  end
+end

data/test/fixtures/bad.png

@@ -0,0 +1 @@
+This is not an image.

data/test/fixtures/s3.yml

@@ -0,0 +1,8 @@
+development:
+  key: 54321
+production:
+  key: 12345
+test:
+  bucket: <%= ENV['S3_BUCKET'] %>
+  access_key_id: <%= ENV['S3_KEY'] %>
+  secret_access_key: <%= ENV['S3_SECRET'] %>

data/test/geometry_test.rb

@@ -0,0 +1,177 @@
+require './test/helper'
+
+class GeometryTest < Test::Unit::TestCase
+  context "Paperclip::Geometry" do
+    should "correctly report its given dimensions" do
+      assert @geo = Paperclip::Geometry.new(1024, 768)
+      assert_equal 1024, @geo.width
+      assert_equal 768, @geo.height
+    end
+
+    should "set height to 0 if height dimension is missing" do
+      assert @geo = Paperclip::Geometry.new(1024)
+      assert_equal 1024, @geo.width
+      assert_equal 0, @geo.height
+    end
+
+    should "set width to 0 if width dimension is missing" do
+      assert @geo = Paperclip::Geometry.new(nil, 768)
+      assert_equal 0, @geo.width
+      assert_equal 768, @geo.height
+    end
+
+    should "be generated from a WxH-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800x600")
+      assert_equal 800, @geo.width
+      assert_equal 600, @geo.height
+    end
+
+    should "be generated from a xH-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("x600")
+      assert_equal 0, @geo.width
+      assert_equal 600, @geo.height
+    end
+
+    should "be generated from a Wx-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800x")
+      assert_equal 800, @geo.width
+      assert_equal 0, @geo.height
+    end
+
+    should "be generated from a W-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800")
+      assert_equal 800, @geo.width
+      assert_equal 0, @geo.height
+    end
+
+    should "ensure the modifier is nil if not present" do
+      assert @geo = Paperclip::Geometry.parse("123x456")
+      assert_nil @geo.modifier
+    end
+
+    should "treat x and X the same in geometries" do
+      @lower = Paperclip::Geometry.parse("123x456")
+      @upper = Paperclip::Geometry.parse("123X456")
+      assert_equal 123, @lower.width
+      assert_equal 123, @upper.width
+      assert_equal 456, @lower.height
+      assert_equal 456, @upper.height
+    end
+
+    ['>', '<', '#', '@', '%', '^', '!', nil].each do |mod|
+      should "ensure the modifier #{mod.inspect} is preserved" do
+        assert @geo = Paperclip::Geometry.parse("123x456#{mod}")
+        assert_equal mod, @geo.modifier
+        assert_equal "123x456#{mod}", @geo.to_s
+      end
+    end
+
+    ['>', '<', '#', '@', '%', '^', '!', nil].each do |mod|
+      should "ensure the modifier #{mod.inspect} is preserved with no height" do
+        assert @geo = Paperclip::Geometry.parse("123x#{mod}")
+        assert_equal mod, @geo.modifier
+        assert_equal "123#{mod}", @geo.to_s
+      end
+    end
+
+    should "make sure the modifier gets passed during transformation_to" do
+      assert @src = Paperclip::Geometry.parse("123x456")
+      assert @dst = Paperclip::Geometry.parse("123x456>")
+      assert_equal ["123x456>", nil], @src.transformation_to(@dst)
+    end
+
+    should "generate correct ImageMagick formatting string for W-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800")
+      assert_equal "800", @geo.to_s
+    end
+
+    should "generate correct ImageMagick formatting string for Wx-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800x")
+      assert_equal "800", @geo.to_s
+    end
+
+    should "generate correct ImageMagick formatting string for xH-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("x600")
+      assert_equal "x600", @geo.to_s
+    end
+
+    should "generate correct ImageMagick formatting string for WxH-formatted string" do
+      assert @geo = Paperclip::Geometry.parse("800x600")
+      assert_equal "800x600", @geo.to_s
+    end
+
+    should "be generated from a file" do
+      file = File.join(File.dirname(__FILE__), "fixtures", "5k.png")
+      file = File.new(file, 'rb')
+      assert_nothing_raised{ @geo = Paperclip::Geometry.from_file(file) }
+      assert @geo.height > 0
+      assert @geo.width > 0
+    end
+
+    should "be generated from a file path" do
+      file = File.join(File.dirname(__FILE__), "fixtures", "5k.png")
+      assert_nothing_raised{ @geo = Paperclip::Geometry.from_file(file) }
+      assert @geo.height > 0
+      assert @geo.width > 0
+    end
+
+    should "not generate from a bad file" do
+      file = "/home/This File Does Not Exist.omg"
+      assert_raise(Paperclip::NotIdentifiedByImageMagickError){ @geo = Paperclip::Geometry.from_file(file) }
+    end
+
+    [['vertical',   900,  1440, true,  false, false, 1440, 900, 0.625],
+     ['horizontal', 1024, 768,  false, true,  false, 1024, 768, 1.3333],
+     ['square',     100,  100,  false, false, true,  100,  100, 1]].each do |args|
+      context "performing calculations on a #{args[0]} viewport" do
+        setup do
+          @geo = Paperclip::Geometry.new(args[1], args[2])
+        end
+
+        should "#{args[3] ? "" : "not"} be vertical" do
+          assert_equal args[3], @geo.vertical?
+        end
+
+        should "#{args[4] ? "" : "not"} be horizontal" do
+          assert_equal args[4], @geo.horizontal?
+        end
+
+        should "#{args[5] ? "" : "not"} be square" do
+          assert_equal args[5], @geo.square?
+        end
+
+        should "report that #{args[6]} is the larger dimension" do
+          assert_equal args[6], @geo.larger
+        end
+
+        should "report that #{args[7]} is the smaller dimension" do
+          assert_equal args[7], @geo.smaller
+        end
+
+        should "have an aspect ratio of #{args[8]}" do
+          assert_in_delta args[8], @geo.aspect, 0.0001
+        end
+      end
+    end
+
+    [[ [1000, 100], [64, 64],  "x64", "64x64+288+0" ],
+     [ [100, 1000], [50, 950], "x950", "50x950+22+0" ],
+     [ [100, 1000], [50, 25],  "50x", "50x25+0+237" ]]. each do |args|
+      context "of #{args[0].inspect} and given a Geometry #{args[1].inspect} and sent transform_to" do
+        setup do
+          @geo = Paperclip::Geometry.new(*args[0])
+          @dst = Paperclip::Geometry.new(*args[1])
+          @scale, @crop = @geo.transformation_to @dst, true
+        end
+
+        should "be able to return the correct scaling transformation geometry #{args[2]}" do
+          assert_equal args[2], @scale
+        end
+
+        should "be able to return the correct crop transformation geometry #{args[3]}" do
+          assert_equal args[3], @crop
+        end
+      end
+    end
+  end
+end