cem_acpt 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7329475f3aa0a02e2b6f65017ed0c24b35769f31eddcff07f306297d99b6558
-  data.tar.gz: 346c753606378a5b022f2c0cd5e2f3db37dbc473468828075c1c6b9d1f2bf8d6
+  metadata.gz: '049c0d34c878395e52956c95a55dd0b1e2fafa9f8ec2e708982b1574865e0c71'
+  data.tar.gz: 5a69317f0b2da6e09d60f41cde8b45df6bb475167ec84328917f3ec9dcf0fe9c
 SHA512:
-  metadata.gz: d3eeb3af0f675509e0e02f658656a21d66e682c2d127196155a44adedade3513f4361dd78bb818070d0bd4bb2e349782d4a475a3d1a7a51b9ab800bcc0d9b1e6
-  data.tar.gz: 2ac9dc43f0bd592b22053599060ffce68cccb995b32755686c0c4128cf69c2d125b155738be38a0ad91cbca7e7017109ab0721bfda4adaae4da46ab72e30a00d
+  metadata.gz: 023d83eeceb14f629ef811781a51d28b4620c45ebd69fd8417f949d3952a1a2e89f94b42392efc93ee408399717dae0906bc820ee5d870b6052500a4f0a78879
+  data.tar.gz: a372082235f0aaf4a533262545f9cb1df04e4ed98f0428e90425d097b1d5e28f2ac8fc40a2b6bf9999707705e88918f6a3398c185eb58680777c95bea16357c6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cem_acpt (0.8.1)
+    cem_acpt (0.8.3)
       async-http (>= 0.60, < 0.70)
       bcrypt_pbkdf (>= 1.0, < 2.0)
       deep_merge (>= 1.2, < 2.0)

data/lib/cem_acpt/provision/terraform.rb

@@ -25,6 +25,7 @@ module CemAcpt
         @module_package_path = nil
         @private_key = nil
         @public_key = nil
+        @applied = false
       end
 
       # @return [Hash] A hash of instance names and IPs
@@ -36,13 +37,18 @@ module CemAcpt
         terraform_init
         terraform_plan(formatted_vars, DEFAULT_PLAN_NAME)
         terraform_apply(DEFAULT_PLAN_NAME)
-        begin
-          output = terraform_output('instance_name_ip', json: true)
-          JSON.parse(output)
-        rescue JSON::ParserError => e
-          logger.error('CemAcpt::Provision::Terraform') { "Error parsing Terraform output: #{output}" }
-          raise e
-        end
+        @applied = true
+      end
+
+      def output
+        raise 'Terraform has not been applied yet' unless @applied
+
+        output = terraform_output('instance_name_ip', json: true)
+        logger.debug('CemAcpt::Provision::Terraform') { "Terraform output:\n#{output}" }
+        JSON.parse(output)
+      rescue JSON::ParserError => e
+        logger.error('CemAcpt::Provision::Terraform') { "Error parsing Terraform output: #{output}" }
+        raise e
       end
 
       def destroy

data/lib/cem_acpt/test_runner.rb

@@ -59,7 +59,8 @@ module CemAcpt
         @run_data[:nodes] = new_node_data
         logger.info('CemAcpt::TestRunner') { 'Created node data...' }
         logger.verbose('CemAcpt::TestRunner') { "Node data: #{@run_data[:nodes]}" }
-        @instance_names_ips = provision_test_nodes
+        provision_test_nodes
+        @instance_names_ips = provisioner_output
         logger.info('CemAcpt::TestRunner') { "Instance names and IPs class: #{@instance_names_ips.class}" }
         @provisioned = true
         logger.info('CemAcpt::TestRunner') { 'Provisioned test nodes...' }
@@ -156,6 +157,24 @@ module CemAcpt
         @provisioner.provision
       end
 
+      def provisioner_output
+        logger.info('CemAcpt::TestRunner') { 'Getting provisioner output...' }
+        @attempts = 0
+        @max_attempts = 3
+        output = nil
+        while @attempts < @max_attempts
+          @attempts += 1
+          output = @provisioner.output
+          break unless (output.nil? || output.empty?) && @attempts < @max_attempts # Don't sleep if this is last attempt
+
+          logger.info('CemAcpt::TestRunner') { "Provisioner output is nil or empty, retrying (#{@attempts}/#{@max_attempts})" }
+          sleep 3
+        end
+        raise 'Provisioner output is nil or empty' if output.nil? || output.empty?
+
+        output
+      end
+
       def destroy_test_nodes
         logger.info('CemAcpt::TestRunner') { 'Destroying test nodes if necessary...' }
         if !@provisioned

data/lib/cem_acpt/utils/shell.rb

@@ -30,19 +30,10 @@ module CemAcpt
           stdin.close
           outerr.sync = true
           output_thread = Thread.new do
-            while (line = outerr.readline_nonblock)
+            while (line = outerr.gets("\n"))
               output << line if output
               io_outerr.write(line) unless line.chomp.empty?
             end
-          rescue IO::WaitReadable
-            begin
-              IO.select([outerr])
-              retry
-            rescue IOError
-              # outerr closed, won't retry
-            end
-          rescue EOFError
-            # outerr closed, won't retry
           end
           wait_thr.join
           output_thread.exit
@@ -70,21 +61,6 @@ module CemAcpt
         end
         nil
       end
-
-      # IO monkey patch for non-blocking readline
-      class ::IO
-        def readline_nonblock
-          rlnb = []
-          rnlb << read_nonblock(1) while rlnb[-1] != "\n"
-          rlnb.join
-        rescue IO::WaitReadable => blocking
-          raise blocking if rlnb.empty?
-
-          rlnb.join
-        rescue EOFError
-          rlnb.join
-        end
-      end
     end
   end
 end

data/lib/cem_acpt/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CemAcpt
-  VERSION = '0.8.1'
+  VERSION = '0.8.3'
 end

data/lib/terraform/gcp/linux/goss/puppet_idempotent.yaml

@@ -1,6 +1,6 @@
 command:
   puppet_idempotent:
-    exec: 'sudo /opt/puppetlabs/puppet/bin/puppet apply --logdest console,/opt/cem_acpt/idempotent_apply.log --debug --verbose --detailed-exitcodes /opt/cem_acpt/manifest.pp'
+    exec: '/opt/puppetlabs/puppet/bin/puppet apply --logdest console,/opt/cem_acpt/idempotent_apply.log --debug --verbose --detailed-exitcodes /opt/cem_acpt/manifest.pp'
     timeout: 300000 # 5 mins in miliseconds
     stdout:
       - "/Applied catalog in.*/"

data/lib/terraform/gcp/linux/goss/puppet_noop.yaml

@@ -1,6 +1,6 @@
 command:
   puppet_noop:
-    exec: 'sudo /opt/puppetlabs/puppet/bin/puppet apply --logdest console,/opt/cem_acpt/noop_apply.log --debug --verbose --detailed-exitcodes --noop /opt/cem_acpt/manifest.pp'
+    exec: '/opt/puppetlabs/puppet/bin/puppet apply --logdest console,/opt/cem_acpt/noop_apply.log --debug --verbose --detailed-exitcodes --noop /opt/cem_acpt/manifest.pp'
     timeout: 300000 # 5 mins in miliseconds
     stdout:
       - "Applied catalog in"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cem_acpt
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.3
 platform: ruby
 authors:
 - puppetlabs
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-09-05 00:00:00.000000000 Z
+date: 2023-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async-http