cem_acpt 0.11.0 → 0.11.2

data/docs/rfcs/0006-configurable-windows-bucket.md

@@ -0,0 +1,96 @@
+# RFC 0006: Make the Windows GCS bucket configurable
+
+- **Status:** Proposed
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** High
+- **Category:** Bug
+- **Affected components:** `lib/cem_acpt/test_runner.rb`, `lib/cem_acpt/config/cem_acpt.rb`
+
+## Summary
+
+The Windows test path uploads the Puppet module tarball to a
+hard-coded `gs://win_cem_acpt` bucket. Anyone who is not a Puppet
+employee (or who has a different bucket name in their own GCP project)
+must fork the gem to use the Windows path. Make the bucket name
+configurable.
+
+## Background
+
+`lib/cem_acpt/test_runner.rb:386`:
+
+```ruby
+@run_data[:win_remote_module_path] =
+  File.join('gs://win_cem_acpt', @run_data[:win_remote_module_name])
+```
+
+The same string appears in `cleanup_bucket` (line 397+).
+[`docs/ARCHITECTURE.md` §13](../ARCHITECTURE.md#13-windows-path) calls
+this out as not configurable.
+
+## Problem
+
+- External users cannot run the Windows acceptance suite at all.
+- There is no way to point at a per-project bucket without editing
+  vendored gem source.
+- A typo or bucket-name change requires a new gem release.
+
+## Proposal
+
+Add a config key `platform.gcp.windows_bucket` (under the existing
+`platform` namespace), defaulting to `win_cem_acpt` to preserve
+current behavior for Puppet contributors:
+
+```ruby
+# lib/cem_acpt/config/cem_acpt.rb defaults
+platform: {
+  name: 'gcp',
+  gcp: {
+    windows_bucket: 'win_cem_acpt',
+  },
+},
+```
+
+In `test_runner.rb`, replace literals with config lookups:
+
+```ruby
+def windows_bucket_uri
+  bucket = config.get('platform.gcp.windows_bucket')
+  raise 'platform.gcp.windows_bucket is not configured' if bucket.nil? || bucket.empty?
+  "gs://#{bucket}"
+end
+```
+
+Use `windows_bucket_uri` in both `upload_module_to_bucket` and
+`cleanup_bucket`.
+
+Also surface a `--windows-bucket BUCKET` CLI flag for ad-hoc overrides
+that mirror existing flag-based knobs.
+
+## Alternatives Considered
+
+- **Derive the bucket name from `platform.project`.** Avoids a new
+  config key but requires every project to follow the same naming
+  convention, which is its own coupling.
+- **Drop the bucket-upload step entirely** in favor of a WinRM file
+  push. Larger change; would also remove a useful "the module
+  artifact is reachable from any node" property.
+
+## Risks & Migration
+
+- Defaulting to `win_cem_acpt` means existing internal users see no
+  change.
+- External users gain a new required override (or use the default
+  if their bucket happens to share the name).
+- Config-explanation output (`-X`) will start listing the new key.
+
+## Acceptance Criteria
+
+- [ ] Config schema (`VALID_KEYS` and `defaults`) extended.
+- [ ] CLI flag `--windows-bucket` parsed in `Cli`.
+- [ ] All references to `'gs://win_cem_acpt'` removed from
+      `test_runner.rb`.
+- [ ] RSpec coverage for both upload and cleanup paths.
+- [ ] [`docs/ARCHITECTURE.md` §13](../ARCHITECTURE.md#13-windows-path)
+      updated to describe the new key.
+- [ ] README updated.

data/docs/rfcs/0007-logging-quiet-and-typos.md

@@ -0,0 +1,121 @@
+# RFC 0007: Tighten `--quiet` semantics and fix logging typos
+
+- **Status:** Proposed
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** High
+- **Category:** Bug
+- **Affected components:** `lib/cem_acpt.rb`, `lib/cem_acpt/test_runner.rb`
+
+## Summary
+
+`--quiet` is silently a no-op when used without `--log-file`, and a
+log line in `upload_module_to_bucket` references a non-existent
+`@run_data[:module_pakage_path]` key (typo for `module_package_path`).
+Fix both. Document the CI-mode override.
+
+## Background
+
+`lib/cem_acpt.rb#initialize_logger!` (lines 59-80):
+
+```ruby
+logdevs = [$stdout]
+if config.get('log_file') && config.get('quiet')
+  logdevs = [config.get('log_file')]
+elsif config.get('log_file') && !config.get('quiet')
+  logdevs << config.get('log_file')
+end
+if config.ci_mode? && !logdevs.include?($stdout)
+  logdevs << $stdout
+end
+```
+
+[`docs/ARCHITECTURE.md` §15 / §19 (item 6)](../ARCHITECTURE.md#15-logging)
+describes the current behavior and flags the surprising "quiet alone
+does nothing" case.
+
+`test_runner.rb:388`:
+
+```ruby
+logger.info('CemAcpt') {
+  "Uploading #{@run_data[:module_pakage_path]} to #{@run_data[:win_remote_module_path]}..."
+}
+```
+
+`@run_data[:module_pakage_path]` is never assigned. The interpolation
+quietly produces an empty string in the log. The other call on the
+following line correctly reads `module_package_path`.
+
+## Problem
+
+1. `--quiet` without `--log-file` reads as "be quiet" but does
+   nothing — confusing for anyone scripting around it.
+2. `--quiet --log-file X` *with* CI mode also adds `$stdout` back in;
+   undocumented in `--help`.
+3. Misspelled run-data key produces a broken log line — no functional
+   damage today, but the log message is one of the few breadcrumbs
+   for diagnosing the Windows upload step.
+
+## Proposal
+
+### Quiet semantics
+
+Treat `--quiet` as "drop `$stdout`" everywhere except CI mode, with
+clear messaging:
+
+```ruby
+def initialize_logger!
+  raise 'Config must be loaded ...' if config.nil? || config.empty?
+
+  logdevs = []
+  logdevs << $stdout unless config.get('quiet')
+  logdevs << config.get('log_file') if config.get('log_file')
+  if config.ci_mode? && !logdevs.include?($stdout)
+    logger_warn_once('--quiet is overridden in CI mode; logging to stdout for ::group:: support')
+    logdevs << $stdout
+  end
+  raise '--quiet without --log-file would silence all output; pass --log-file or drop --quiet' if logdevs.empty?
+  ...
+end
+```
+
+Refusing the all-silenced combination outside CI is preferred to
+silently dropping logs.
+
+### Typo
+
+In `test_runner.rb:388`, change `:module_pakage_path` to
+`:module_package_path`. Add a smoke test that exercises
+`upload_module_to_bucket` with a stub shell to assert the log line
+contains the correct path.
+
+### Documentation
+
+Update `docs/ARCHITECTURE.md` §15 to reflect the new behavior, and
+add a one-line note in `Cli` help next to `--quiet`.
+
+## Alternatives Considered
+
+- **Leave `--quiet` alone.** Documented as "no effect alone" — but
+  that's exactly the surprise we want to remove.
+- **Promote `--quiet` to fully silence logs even in CI.** Breaks
+  `::group::` annotations on Actions; not desirable.
+
+## Risks & Migration
+
+- Users today who passed `--quiet` and expected stdout to remain will
+  now see stdout disappear (correctly). This is a deliberate
+  behavioral fix.
+- Users today who passed `--quiet` with no `--log-file` get an
+  immediate, clear error rather than running normally with stdout
+  intact.
+
+## Acceptance Criteria
+
+- [ ] `lib/cem_acpt.rb#initialize_logger!` updated; comment cites
+      this RFC.
+- [ ] `:module_pakage_path` typo fixed.
+- [ ] RSpec covers the four logging combinations (`-q`, `-q --log-file`,
+      `--log-file` alone, `-q` in CI mode).
+- [ ] `docs/ARCHITECTURE.md` §15 updated.
+- [ ] `--help` output mentions the CI override.

data/docs/rfcs/0008-namespace-platform-classes.md

@@ -0,0 +1,110 @@
+# RFC 0008: Namespace dynamically-created platform classes
+
+- **Status:** Implemented (CEM-6717)
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** Medium
+- **Category:** Refactor
+- **Affected components:** `lib/cem_acpt/platform.rb`, `lib/cem_acpt/platform/gcp.rb`
+
+## Summary
+
+`Platform.platform_class` registers each generated class as a
+**top-level** constant (e.g. `::Gcp`). This pollutes `Object`'s
+constant table and risks silent collisions with any same-named class
+introduced elsewhere — including by transitive dependencies. Move the
+generated class into the `CemAcpt::Platform` namespace.
+
+## Background
+
+`lib/cem_acpt/platform.rb:79-115`:
+
+```ruby
+def platform_class(base_type, platform)
+  class_name = platform.capitalize
+  ...
+  if Object.const_defined?(class_name)
+    klass = Object.const_get(class_name)
+  else
+    ...
+    klass = Object.const_set(class_name, Class.new(baseklass) do
+      require_relative "platform/#{platform}"
+      include Platform
+    end)
+  end
+  klass
+end
+```
+
+[`docs/ARCHITECTURE.md` §6 / §19 (item 5)](../ARCHITECTURE.md#6-platform-abstraction)
+flags this as a defensive-namespace concern.
+
+## Problem
+
+- A future contributor (or a gem we depend on) defining
+  `class ::Gcp` would silently win the cache check
+  `Object.const_defined?('Gcp')`, so `platform_class` would return
+  the wrong class.
+- The constant lookup is also case-sensitive and the cache key
+  `platform.capitalize` fails for multi-word platforms like
+  `aws_govcloud` (would become `Aws_govcloud`).
+- Top-level constants make the runtime class graph noisier than it
+  needs to be.
+
+## Proposal
+
+Register and look up the class under `CemAcpt::Platform`:
+
+```ruby
+def platform_class(base_type, platform)
+  const_name = platform.split(/[_-]/).map(&:capitalize).join
+
+  if CemAcpt::Platform.const_defined?(const_name, false)
+    return CemAcpt::Platform.const_get(const_name, false)
+  end
+
+  baseklass = case base_type.to_sym
+              when :base then CemAcpt::Platform::Base
+              when :test then CemAcpt::Platform::TestBase
+              else raise Error, "Base type #{base_type} is not supported"
+              end
+
+  CemAcpt::Platform.const_set(const_name, Class.new(baseklass) do
+    require_relative "platform/#{platform}"
+    include CemAcpt::Platform.const_get(:Platform, false) # documented hook
+  end)
+end
+```
+
+Notes:
+
+- `const_defined?(name, false)` skips ancestor lookup, eliminating the
+  collision.
+- The `split(...).map(&:capitalize).join` form camel-cases multi-word
+  platform names safely.
+- `include Platform` references the module from the loaded file; we
+  preserve that contract but resolve it relative to the new namespace.
+
+## Alternatives Considered
+
+- **Switch to a registration DSL** (`Platform.register :gcp do ... end`).
+  Cleaner long term but a wider refactor. Defer.
+- **Keep top-level but assert uniqueness.** Solves the collision
+  problem but doesn't address the namespace pollution.
+
+## Risks & Migration
+
+- Any code that referenced the top-level `::Gcp` (none in this repo
+  per grep) would need to change. There are no such references in
+  `lib/`, `exe/`, or `spec/`.
+- The base class `CemAcpt::Platform::Base` remains untouched.
+
+## Acceptance Criteria
+
+- [ ] `Platform.platform_class` registers under `CemAcpt::Platform`.
+- [ ] No top-level `::Gcp` constant is created at runtime
+      (verified via spec).
+- [ ] Multi-word platform names (e.g. `azure_arm`) round-trip
+      correctly.
+- [ ] [`docs/ARCHITECTURE.md` §6](../ARCHITECTURE.md#6-platform-abstraction)
+      and §19 updated.

data/docs/rfcs/0009-bolt-log-formatter-cleanup.md

@@ -0,0 +1,111 @@
+# RFC 0009: Wire up or remove the orphaned Bolt log formatters
+
+- **Status:** Proposed
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** Medium
+- **Category:** Cleanup
+- **Affected components:** `lib/cem_acpt/test_runner/log_formatter.rb`, `lib/cem_acpt/test_runner/log_formatter/`
+
+## Summary
+
+Two formatter files exist under `lib/cem_acpt/test_runner/log_formatter/`
+but are never matched by `LogFormatter.new_formatter`'s `case`.
+`bolt_output_formatter.rb` is `require_relative`'d but unused;
+`bolt_error_formatter.rb` is neither required nor referenced. Either
+they should be hooked into the dispatcher or deleted.
+
+## Background
+
+`lib/cem_acpt/test_runner/log_formatter.rb`:
+
+```ruby
+require_relative 'log_formatter/bolt_summary_results_formatter'
+require_relative 'log_formatter/bolt_output_formatter'      # required, not matched
+require_relative 'log_formatter/goss_action_response'
+require_relative 'log_formatter/goss_error_formatter'
+require_relative 'log_formatter/standard_error_formatter'
+# bolt_error_formatter.rb is NOT required
+
+module ...
+  def self.new_formatter(result, *args, **_kwargs)
+    case result
+    when CemAcpt::Goss::Api::ActionResponse        then ...
+    when CemAcpt::Bolt::SummaryResults             then BoltSummaryResultsFormatter.new(...)
+    when StandardError                              then StandardErrorFormatter.new(result)
+    else raise ArgumentError, ...
+    end
+  end
+end
+```
+
+[`docs/ARCHITECTURE.md` §11 / §19 (item 8)](../ARCHITECTURE.md#11-result-aggregation--log-formatting)
+flags both files.
+
+## Problem
+
+- Future contributors waste time deciding whether the formatters are
+  load-bearing. The `require_relative` for `bolt_output_formatter`
+  creates the false impression that they are.
+- If `BoltOutputFormatter` was meant to render
+  `Bolt::Cmd::Output` instances, the dispatcher silently falls through
+  to `StandardErrorFormatter` (or raises) for any caller that pushes
+  one onto the results queue.
+
+## Proposal
+
+Pick one of two paths after a 5-minute decision:
+
+### Option A — wire them up
+
+If `BoltOutputFormatter` / `BoltErrorFormatter` are intended to render
+`Bolt::Cmd::Output` and `Bolt::Cmd::OutputError`:
+
+```ruby
+require_relative 'log_formatter/bolt_error_formatter'
+
+case result
+...
+when CemAcpt::Bolt::Cmd::OutputError
+  BoltErrorFormatter.new(result)
+when CemAcpt::Bolt::Cmd::Output
+  BoltOutputFormatter.new(*args, subject: result)
+when CemAcpt::Bolt::SummaryResults
+  BoltSummaryResultsFormatter.new(*args, subject: result)
+...
+end
+```
+
+Add coverage in
+`spec/cem_acpt/test_runner/log_formatter/` mirroring the existing
+`goss_action_response_spec.rb`.
+
+### Option B — delete them
+
+If, as the current code suggests, only the summary formatter is
+needed, delete both files and the dangling `require_relative`. Add
+a one-line comment on `BoltSummaryResultsFormatter` documenting that
+it is the canonical Bolt formatter.
+
+## Recommendation
+
+Option B. The dispatcher has been shipping in this state for at least
+several releases without anyone noticing the absent cases — the
+formatters are aspirational dead code. Deleting them now removes the
+ambiguity; if the need re-emerges, reintroducing them is a small
+patch.
+
+## Risks & Migration
+
+- Public API: none. The formatter classes are not part of the gem's
+  documented API.
+- Tests: none of the existing specs reference either file.
+
+## Acceptance Criteria
+
+- [ ] Decision recorded (Option A or B).
+- [ ] If A: dispatcher updated, both files required, RSpec coverage
+      added.
+- [ ] If B: both files deleted, dangling `require_relative` removed.
+- [ ] [`docs/ARCHITECTURE.md` §11](../ARCHITECTURE.md#11-result-aggregation--log-formatting)
+      and §19 updated.

data/docs/rfcs/0010-dead-code-cleanup.md

@@ -0,0 +1,83 @@
+# RFC 0010: Remove unreferenced top-level helpers and Windows placeholder
+
+- **Status:** Proposed
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** Medium
+- **Category:** Cleanup
+- **Affected components:** `lib/cem_acpt/puppet_helpers.rb`, `lib/cem_acpt/action_result.rb`, `lib/cem_acpt/provision/terraform/windows.rb`, `lib/cem_acpt/utils.rb`
+
+## Summary
+
+Several files / methods are dead — defined, but never called from
+`lib/`, `exe/`, or `spec/`. They confuse the codebase map and
+contradict the actual architecture. Remove them.
+
+## Background
+
+[`docs/ARCHITECTURE.md` §19 (items 1, 2, 3)](../ARCHITECTURE.md#19-open-questions--observed-dead-code)
+identifies the following:
+
+| File / Symbol                                               | Status                                       |
+|-------------------------------------------------------------|----------------------------------------------|
+| `lib/cem_acpt/puppet_helpers.rb` (`PuppetHelpers::Module.build_module_package`) | Superseded by `Utils::Puppet::ModulePackageBuilder`. No callers. |
+| `lib/cem_acpt/action_result.rb` (`CemAcpt::ActionResult`, `CemAcpt::ErrorActionResult`) | Superseded by `TestRunner::TestResults::TestActionResult` / `TestErrorActionResult`. No callers. |
+| `Provision::Windows#provision_commands` returning `['placeholder']` | Inert; the Windows path runs PowerShell from Ruby, not from a `remote-exec`. |
+| `Utils.package_win_module`                                   | Referenced by ARCHITECTURE.md as unused; re-confirm before removing. |
+
+## Problem
+
+- Each of these reads as "load-bearing" to a contributor wandering
+  the tree.
+- The placeholder return value in `Provision::Windows` is the kind of
+  code that gets "fixed" by a future contributor who doesn't realize
+  the Windows path skips the `remote-exec` block entirely.
+- `action_result.rb` defines two top-level constants
+  (`CemAcpt::ActionResult`, `CemAcpt::ErrorActionResult`) that shadow
+  intuitive names a future contributor might want.
+
+## Proposal
+
+1. **Delete** `lib/cem_acpt/puppet_helpers.rb`. Audit specs/fixtures
+   first; remove any orphan requires.
+2. **Delete** `lib/cem_acpt/action_result.rb`. Same audit.
+3. **In `Provision::Windows`**, replace the placeholder method with
+   a comment documenting that the Windows path intentionally has no
+   `remote-exec` provisioner, and have `provision_commands` raise
+   `NotImplementedError` if called by accident:
+
+   ```ruby
+   def provision_commands
+     raise NotImplementedError,
+       'Windows provisioning is performed via Utils::WinRMRunner, ' \
+       'not via Terraform remote-exec. See ARCHITECTURE.md §13.'
+   end
+   ```
+
+4. **`Utils.package_win_module`**: confirm with `git grep` and remove
+   if there are no callers. (One pass at the start of this RFC's
+   implementation should suffice.)
+
+## Alternatives Considered
+
+- **Mark as deprecated and keep around for one release.** Overkill —
+  these are internal helpers, not public API.
+- **Move to a `legacy/` directory.** Just delays the cleanup.
+
+## Risks & Migration
+
+- These symbols are not part of the public API of the gem; removing
+  them does not require a major version bump.
+- A `git grep` for each symbol must come back empty before deletion.
+
+## Acceptance Criteria
+
+- [ ] `git grep PuppetHelpers` returns no matches under `lib/`,
+      `exe/`, or `spec/`; file deleted.
+- [ ] `git grep CemAcpt::ActionResult` returns no matches; file
+      deleted.
+- [ ] `Provision::Windows#provision_commands` no longer returns
+      `['placeholder']`.
+- [ ] `Utils.package_win_module` removed if confirmed unused.
+- [ ] [`docs/ARCHITECTURE.md` §19](../ARCHITECTURE.md#19-open-questions--observed-dead-code)
+      items 1, 2, 3 deleted.

data/docs/rfcs/0011-provisioner-factory-consistency.md

@@ -0,0 +1,89 @@
+# RFC 0011: Make the provisioner factory honor configuration
+
+- **Status:** Proposed
+- **Author:** TBD
+- **Created:** 2026-04-30
+- **Priority:** Low
+- **Category:** Refactor
+- **Affected components:** `lib/cem_acpt/config/base.rb`, `lib/cem_acpt/provision.rb`
+
+## Summary
+
+`Config::Base#add_static_options!` force-sets `provisioner =
+'terraform'` after every other config source has been merged. The
+`Provision.new_provisioner` factory still branches on
+`config.get('provisioner')` and raises for unknown values — so the
+factory looks pluggable but is not. Either honor the config or remove
+the factory.
+
+## Background
+
+[`docs/ARCHITECTURE.md` §7 / §19 (item 4)](../ARCHITECTURE.md#7-provisioner-terraform):
+
+> `provisioner` is currently force-set to `'terraform'` in
+> `Config::Base#add_static_options!`, so this dispatch is effectively
+> fixed today.
+
+`lib/cem_acpt/provision.rb` (factory) reads the key but never sees
+anything other than `'terraform'` because of the static override.
+
+## Problem
+
+- The factory pattern signals an extensibility surface that does not
+  exist.
+- A user who sets `provisioner: foo` in config gets silently
+  overridden — `-X` will show the override but the runtime behavior
+  is unchanged.
+- This blocks experimentation with a Pulumi/Packer/local-only
+  provisioner without first untangling the static set.
+
+## Proposal
+
+Make the static layer set a *default* if absent, instead of
+clobbering:
+
+```ruby
+# Config::Base#add_static_options!
+@config[:provisioner] ||= 'terraform'
+```
+
+…and surface the relevant CLI flag in `Cli` (`--provisioner NAME`) so
+users can opt into alternates. The `Provision.new_provisioner` factory
+already raises a clear error for unknown values, which is the desired
+behavior.
+
+A complementary, even smaller change: if we don't actually intend to
+support alternate provisioners, **remove the factory** and have
+`TestRunner` instantiate `Provision::Terraform` directly. That is more
+honest given today's code.
+
+## Recommendation
+
+Do the smaller change (remove the factory and the dispatch) for now.
+Re-introduce the factory when there is a concrete second
+implementation in flight. Premature extensibility cost us little here,
+but it adds a layer of indirection that contributors have to chase.
+
+## Alternatives Considered
+
+- **Leave as-is.** Documentation drift continues; future contributors
+  keep mistaking the factory for an extension point.
+- **Implement a second provisioner now.** Out of scope.
+
+## Risks & Migration
+
+- No user-visible change if the factory is removed; the only code path
+  through it today is `'terraform'`.
+- Any out-of-tree consumer that referenced `Provision.new_provisioner`
+  directly (none in this repo) would need to update.
+
+## Acceptance Criteria
+
+- [ ] Decision recorded (factory kept-and-honored vs. factory
+      removed).
+- [ ] Static-set in `Config::Base#add_static_options!` updated
+      accordingly.
+- [ ] [`docs/ARCHITECTURE.md` §7](../ARCHITECTURE.md#7-provisioner-terraform)
+      and §19 updated.
+- [ ] Spec coverage adjusted (the existing `terraform_cmd_spec.rb` is
+      unaffected).

data/docs/rfcs/README.md

@@ -0,0 +1,34 @@
+# cem_acpt RFCs
+
+Design proposals and bug-fix plans for `cem_acpt`. Each RFC is a
+self-contained Markdown file using the layout in
+[`0000-template.md`](0000-template.md).
+
+## Index
+
+| #    | Title                                                                              | Priority | Category  |
+|------|------------------------------------------------------------------------------------|----------|-----------|
+| 0001 | [Fix the bolt-missing skip path](0001-fix-bolt-missing-skip-path.md)                | Critical | Bug       |
+| 0002 | [Fix malformed default `character_substitutions`](0002-fix-default-character-substitutions.md) | Critical | Bug       |
+| 0003 | [Ship a Windows image-builder Terraform template](0003-windows-image-builder-template.md) | Critical | Bug       |
+| 0004 | [Fix image-name truncation off-by-one](0004-image-name-truncation-off-by-one.md)    | High     | Bug       |
+| 0005 | [Replace `tests.first.include?('windows')` heuristic](0005-os-dispatch-replace-windows-heuristic.md) | High     | Refactor  |
+| 0006 | [Make the Windows GCS bucket configurable](0006-configurable-windows-bucket.md)     | High     | Bug       |
+| 0007 | [Tighten `--quiet` semantics and fix logging typos](0007-logging-quiet-and-typos.md) | High     | Bug       |
+| 0008 | [Namespace dynamically-created platform classes](0008-namespace-platform-classes.md) | Medium   | Refactor  |
+| 0009 | [Wire up or remove orphaned Bolt log formatters](0009-bolt-log-formatter-cleanup.md) | Medium   | Cleanup   |
+| 0010 | [Remove unreferenced top-level helpers and Windows placeholder](0010-dead-code-cleanup.md) | Medium   | Cleanup   |
+| 0011 | [Make the provisioner factory honor configuration](0011-provisioner-factory-consistency.md) | Low      | Refactor  |
+
+## Status
+
+All RFCs above are **Proposed** unless otherwise marked in the
+individual files. Authorship and review notes belong inside each RFC.
+
+## Adding a new RFC
+
+1. Copy [`0000-template.md`](0000-template.md) to the next available
+   number.
+2. Fill in every section. Keep cross-references to
+   [`docs/ARCHITECTURE.md`](../ARCHITECTURE.md) accurate.
+3. Append a row to the index above.

data/lib/cem_acpt/cli.rb

@@ -59,6 +59,12 @@ module CemAcpt
             options[:bolt] ||= {}
             options[:bolt][:keep_project] = true
           end
+
+          opts.on('--windows-bucket BUCKET', 'GCS bucket name for the Windows test path. Example: --windows-bucket "my-win-bucket"') do |b|
+            options[:platform] ||= {}
+            options[:platform][:gcp] ||= {}
+            options[:platform][:gcp][:windows_bucket] = b
+          end
         when :cem_acpt_image
           opts.on('--dry-run', 'Logs the information for the images that would be created. Does not create images.') do
             options[:dry_run] = true
@@ -126,7 +132,10 @@ module CemAcpt
           options[:no_destroy_nodes] = true
         end
 
-        opts.on('-q', '--quiet', 'Do not log to stdout') do
+        opts.on(
+          '-q', '--quiet',
+          'Drop stdout (requires --log-file outside CI; CI mode keeps stdout for ::group:: support)',
+        ) do
           options[:quiet] = true
         end
 

data/lib/cem_acpt/config/cem_acpt.rb

@@ -28,7 +28,7 @@ module CemAcpt
           ci_mode: false,
           config_file: nil,
           image_name_builder: {
-            character_substitutions: ['_', '-'],
+            character_substitutions: [['_', '-']],
             parts: ['cem-acpt', '$image_fam', '$collection', '$firewall'],
             join_with: '-',
           },
@@ -40,6 +40,9 @@ module CemAcpt
           no_ephemeral_ssh_key: false,
           platform: {
             name: 'gcp',
+            gcp: {
+              windows_bucket: 'win_cem_acpt',
+            },
           },
           quiet: false,
           test_data: {