celluloid_pubsub 0.9.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c703a33e176ab7877a83eb259536afa905b9aab2
-  data.tar.gz: d60ef25c80a4ebfffd92b9b289b9d1fdd0206a96
+  metadata.gz: bdde06fb1422bf75d45e6f83706c695288d9c42e
+  data.tar.gz: f98a1a07331fbc7fcb67ee168191c0e4510b5181
 SHA512:
-  metadata.gz: 32e7cf4839a394666c6cc6c508781d6e2271f4faee03e4b10dc547984ea241f9fcd4e4320ee17481216f12bdaa5c4269caceac61320c770598471e5d8a28055f
-  data.tar.gz: 086654a510e94c6a1f4ab74ff34258e95e750e54a485d3d16577643b80249833a7ee58a4db5c37e2c175a46db09025a140423b00be45fd348b307f7ca2251259
+  metadata.gz: 02f4c5e864fa97fa3cffbb2cdf30f0f5dddf7f6341c2b042b247cbc75209118feb79cb9570ebae48f7e7ac6928a3ebdf1df7247523001f84a0d4bf04873d25c9
+  data.tar.gz: b8e905df5512a160194ea0ea13e0034c62ffbaa6b05031fa63df6f7c3d2af8384b49eba3e12a2092ffefd343e28061a5823319094c754576fe086e4ccafe1ba2

data/.gitignore

@@ -17,3 +17,4 @@ tags
 .yardoc/
 doc/
 bin/
+gemfiles/*.lock

data/.reek

@@ -7,5 +7,12 @@ TooManyMethods:
   enabled: false
 UtilityFunction:
   enabled: false
+ManualDispatch:
+  enabled: false
+InstanceVariableAssumption:
+  enabled: false
+ClassVariable:
+  enabled: false
 exclude_paths:
-  - examples
+ - examples/**/**
+ - spec/**/**

data/.rubocop.yml

@@ -1,11 +1,16 @@
 AllCops:
   Exclude:
-    - washout_builder.gemspec
+    - celluloid_pubsub.gemspec
     - bin/**/*
     - Guardfile
     - vendor/**/**
     - examples/**/**
+    - spec/**/*
+    - Gemfile
+    - Rakefile
 
+  TargetRubyVersion: 2.3
+  
 ClassLength:
   Max: 500
 

data/celluloid_pubsub.gemspec

@@ -13,9 +13,10 @@ Gem::Specification.new do |s|
 
   s.licenses = ['MIT']
   s.files = `git ls-files`.split("\n")
-  s.test_files = s.files.grep(/^(spec)/)
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.executables   = `git ls-files -- bin/*`.split('\n').map{ |f| File.basename(f) }
   s.require_paths = ['lib']
-
+  
   s.add_runtime_dependency 'celluloid', '>= 0.16', '>= 0.16.0'
   s.add_runtime_dependency 'celluloid-io', '>= 0.16', '>= 0.16.2'
   s.add_runtime_dependency 'reel', '~> 0.6', '>= 0.6.0'

data/examples/simple_test.rb

@@ -15,10 +15,10 @@ class FirstActor
 
   def on_message(message)
     if @client.succesfull_subscription?(message)
-      puts "subscriber got successful subscription #{message.inspect}"
+      puts "subscriber got successful subscription #{message}"
       @client.publish('test_channel2', 'data' => ' subscriber got successfull subscription') # the message needs to be a Hash
     else
-      puts "subscriber got message #{message.inspect}"
+      puts "subscriber got message #{message}"
     end
   end
 
@@ -40,10 +40,10 @@ class SecondActor
 
   def on_message(message)
     if @client.succesfull_subscription?(message)
-      puts "publisher got successful subscription #{message.inspect}"
+      puts "publisher got successful subscription #{message}"
       @client.publish('test_channel', 'data' => ' my_message') # the message needs to be a Hash
     else
-      puts "publisher got message #{message.inspect}"
+      puts "publisher got message #{message}"
     end
   end
 

data/gemfiles/celluloid_0.16.0.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "activesupport", ">= 4.0", ">= 4.0"
+gem "celluloid", "0.16.0"
+
+gemspec :path => "../"

data/gemfiles/celluloid_0.17.3.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "activesupport", ">= 4.0", ">= 4.0"
+gem "celluloid", "0.17.3"
+
+gemspec :path => "../"

data/init.rb

@@ -1 +1,3 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require 'celluloid_pubsub'

data/lib/celluloid_pubsub.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require 'rubygems'
 require 'bundler'
 require 'bundler/setup'

data/lib/celluloid_pubsub/base_actor.rb

@@ -1,25 +1,44 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require_relative './helper'
 module CelluloidPubsub
   # base actor used for compatibility between celluloid versions
+  # @!attribute [r] config
+  #   @return [Hash] The configuration classes and their aliases
   module BaseActor
-
     class << self
       include Helper
-      attr_reader :config
 
+      # includes all the required modules in the class that includes this module
+      # @param [Class] base the class that will be used to include the required modules into it
+      # @return [void]
+      #
+      # @api public
       def included(base)
-        base.send(:include, Celluloid)
-        base.send(:include, Celluloid::IO)
-        base.send(:include, CelluloidPubsub::Helper)
-        base.send(:include, config['logger_class'])
+        [
+          Celluloid,
+          Celluloid::IO,
+          CelluloidPubsub::Helper,
+          config['logger_class']
+        ].each do |module_name|
+          base.send(:include, module_name)
+        end
       end
 
+      # returns the configuration classes and their aliases for celluloid
+      # @return [Hash] returns the configuration classes and their aliases for celluloid
+      #
+      # @api public
       def config
         {
           'logger_class' => celluloid_logger_class
         }
       end
 
+      # returns the logger class from celluloid depending on version
+      # @return [Class] returns the logger class from celluloid depending on version
+      #
+      # @api public
       def celluloid_logger_class
         if version_less_than_seventeen?
           Celluloid::Logger
@@ -28,22 +47,36 @@ module CelluloidPubsub
         end
       end
 
+      # returns the celluloid version loaded
+      # @return [String] returns the celluloid version loaded
+      #
+      # @api public
       def celluloid_version
         find_loaded_gem_property('celluloid', 'version')
       end
 
+      # returns true if celluloid version less than 0.17, otherwise false
+      # @return [Boolean] returns true if celluloid version less than 0.17, otherwise false
+      #
+      # @api public
       def version_less_than_seventeen?
         verify_gem_version(celluloid_version, '0.17', operator: '<')
       end
 
+      # sets up the actor supervision based on celluloid version
+      # @param [Class] class_name The class that will be used to supervise the actor
+      # @param [Hash] options Additional options needed for supervision
+      # @return [void]
+      #
+      # @api public
       def setup_actor_supervision(class_name, options)
+        actor_name, args = options.slice(:actor_name, :args).values
         if version_less_than_seventeen?
-          class_name.supervise_as(options[:actor_name], options[:args])
+          class_name.supervise_as(actor_name, args)
         else
-          class_name.supervise(as: options[:actor_name], args: [options[:args]].compact)
+          class_name.supervise(as: actor_name, args: [args].compact)
         end
       end
-
     end
   end
 end

data/lib/celluloid_pubsub/client.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require_relative './helper'
 module CelluloidPubsub
   # worker that subscribes to a channel or publishes to a channel
@@ -15,8 +17,18 @@ module CelluloidPubsub
   class Client
     include CelluloidPubsub::BaseActor
 
+    # The actor that made the connection
+    # @return [Celluloid::Actor] actor to which callbacks will be delegated to
+    attr_accessor :actor
+
+    #  options that can be used to connect to webser and send additional data
+    # @return [Hash] the options that can be used to connect to webser and send additional data
+    attr_accessor :options
+
+    # The channel to which the client will subscribe to once the connection is open
+    # @return [String] The channel to which the client will subscribe to
+    attr_accessor :channel
 
-    attr_accessor :actor, :options, :channel
     finalizer :shutdown
     #  receives a list of options that are used to connect to the webserver and an actor to which the callbacks are delegated to
     #  when receiving messages from a channel
@@ -88,7 +100,7 @@ module CelluloidPubsub
     #
     # @api public
     def port
-      @port ||= @options.fetch('port', nil) ||  CelluloidPubsub::WebServer.find_unused_port
+      @port ||= @options.fetch('port', nil) || CelluloidPubsub::WebServer.find_unused_port
     end
 
     # the method will return the path of the URL on which the servers acccepts the connection
@@ -253,12 +265,7 @@ module CelluloidPubsub
     #
     # @api private
     def chat(message)
-      final_message = nil
-      if message.is_a?(Hash)
-        final_message = message.to_json
-      else
-        final_message = JSON.dump(action: 'message', message: message)
-      end
+      final_message = message.is_a?(Hash) ? message.to_json : JSON.dump(action: 'message', message: message)
       log_debug("#{@actor.class} sends JSON #{final_message}")
       connection.text final_message
     end

data/lib/celluloid_pubsub/gem_version_parser.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+module CelluloidPubsub
+  # class used for parsing gem versions
+  # @!attribute [r] version
+  #   @return [String, Integer] version that needs parsing
+  #
+  # @!attribute [r] options
+  #   @return [Hash] The additional options for parsing the version
+  class GemVersionParser
+    attr_reader :version
+    attr_reader :options
+
+    #  receives the version and the additional options
+    #
+    # @param  [String, Integer] version  the version that needs parsing
+    # @param [Hash] options The additional options for parsing the version
+    #
+    # @return [void]
+    #
+    # @api public
+    #
+    # :nocov:
+    def initialize(version, options = {})
+      @version = version
+      @options = options.is_a?(Hash) ? options : {}
+    end
+
+    #  parses the version and returns the version with a single decimal point by default
+    # @return [Float]
+    #
+    # @api public
+    def parsed_number
+      return 0 if @version.blank?
+      @version_array = @version.to_s.split('.')
+      number_with_single_decimal_point if @version_array.size > 2
+      @version_array.join('.').to_f
+    end
+
+    # pops from the version array elements until its size is 2
+    # @return [void]
+    #
+    # @api public
+    def number_with_single_decimal_point
+      @version_array.pop until @version_array.size == 2
+    end
+  end
+end

data/lib/celluloid_pubsub/helper.rb

@@ -1,3 +1,6 @@
+# encoding: utf-8
+# frozen_string_literal: true
+require_relative './gem_version_parser'
 module CelluloidPubsub
   # class that holds the options that are configurable for this gem
   module Helper
@@ -12,31 +15,61 @@ module CelluloidPubsub
       message.is_a?(Hash) && message['client_action'] == 'successful_subscription'
     end
 
-    module_function
+  module_function
 
+    # returns the gem's property from its speification or nil
+    # @param [String] name the name of the gem
+    # @param [String] property name of the property we want
+    #
+    # @return [String, nil] returns the version of the gem
+    #
+    # @api public
     def find_loaded_gem(name, property = nil)
       gem_spec = Gem.loaded_specs.values.find { |repo| repo.name == name }
       gem_spec.present? && property.present? ? gem_spec.send(property) : gem_spec
     end
 
+    # returns the gem's property from its speification or nil
+    # @param [String] gem_name name of the gem
+    # @param [String] property name of the property we want
+    #
+    # @return [String, nil] returns the version of the gem
+    #
+    # @api public
     def find_loaded_gem_property(gem_name, property = 'version')
       find_loaded_gem(gem_name, property)
     end
 
+    # returns the parsed version of the gem
+    # @param [String] gem_name name of the gem
+    #
+    # @return [Float, nil] returns the version of the gem
+    #
+    # @api public
     def fetch_gem_version(gem_name)
       version = find_loaded_gem_property(gem_name)
       version.blank? ? nil : get_parsed_version(version)
     end
 
+    # returns the parsed version as a float or nil
+    # @param [String] version the version that needs to be parsed
+    #
+    # @return [Float, nil] returns the version of the gem
+    #
+    # @api public
     def get_parsed_version(version)
-      return 0 if version.blank?
-      version = version.to_s.split('.')
-      if version.size > 2
-        version.pop until version.size == 2
-      end
-      version.join('.').to_f
+      version_parser = CelluloidPubsub::GemVersionParser.new(version)
+      version_parser.parsed_number
     end
 
+    # returns true if gem_version is less or equal to the specified version, otherwise false
+    # @param [String] gem_version the version of the gem
+    # @param [String] version the version that will be checked against
+    # @param [Hash] options additional options
+    #
+    # @return [Boolean] returns true if gem_version is less or equal to the specified version, otherwise false
+    #
+    # @api public
     def verify_gem_version(gem_version, version, options = {})
       options.stringify_keys!
       version = get_parsed_version(version)

data/lib/celluloid_pubsub/initializers/reel_colors.rb

@@ -1,8 +1,10 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require 'reel/spy'
 Reel::Spy::Colors.class_eval do
   alias_method :original_colorize, :colorize
 
-  def colorize(n, str)
+  def colorize(_n, str)
     force_utf8_encoding(str)
   end
 

data/lib/celluloid_pubsub/reactor.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require_relative './registry'
 require_relative './helper'
 module CelluloidPubsub
@@ -15,7 +17,21 @@ module CelluloidPubsub
   class Reactor
     include CelluloidPubsub::BaseActor
 
-    attr_accessor :websocket, :server, :channels
+    # available actions that can be delegated
+    AVAILABLE_ACTIONS = %w(unsubscribe_clients unsubscribe subscribe publish unsubscribe_all).freeze
+
+    # The websocket connection received from the server
+    # @return [Reel::WebSocket] websocket connection
+    attr_accessor :websocket
+
+    # The server instance to which this reactor is linked to
+    # @return [CelluloidPubsub::Webserver] the server actor to which the reactor is connected to
+    attr_accessor :server
+
+    # The channels to which this reactor has subscribed to
+    # @return [Array] array of channels to which the current reactor has subscribed to
+    attr_accessor :channels
+
     finalizer :shutdown
     #  rececives a new socket connection from the server
     #  and listens for messages
@@ -163,21 +179,9 @@ module CelluloidPubsub
     #
     # @api public
     def delegate_action(json_data)
-      channel = json_data.fetch('channel', nil)
-      case json_data['client_action']
-      when 'unsubscribe_all'
-        unsubscribe_all
-      when 'unsubscribe_clients'
-        async.unsubscribe_clients(channel)
-      when 'unsubscribe'
-        async.unsubscribe(channel)
-      when 'subscribe'
-        async.start_subscriber(channel, json_data)
-      when 'publish'
-        async.publish_event(channel, json_data['data'].to_json)
-      else
-        handle_unknown_action(json_data)
-      end
+      channel, client_action = json_data.slice('channel', 'client_action').values
+      return unless CelluloidPubsub::Reactor::AVAILABLE_ACTIONS.include?(client_action)
+      async.send(client_action, channel, json_data)
     end
 
     # the method will delegate the message to the server in an asyncronous way by sending the current actor and the message
@@ -188,8 +192,8 @@ module CelluloidPubsub
     # @return [void]
     #
     # @api public
-    def handle_unknown_action(json_data)
-      log_debug "Trying to dispatch   to server  #{json_data}"
+    def handle_unknown_action(channel, json_data)
+      log_debug "Trying to dispatch   to server  #{json_data} on channel #{channel}"
       @server.async.handle_dispatched_message(Actor.current, json_data)
     end
 
@@ -217,10 +221,21 @@ module CelluloidPubsub
     # @return [void]
     #
     # @api public
-    def unsubscribe(channel)
+    def unsubscribe(channel, _json_data)
       log_debug "#{self.class} runs 'unsubscribe' method with  #{channel}"
       return unless channel.present?
       forget_channel(channel)
+      delete_server_subscribers(channel)
+    end
+
+    # the method will delete the reactor from the channel list on the server
+    #
+    # @param [String] channel
+    #
+    # @return [void]
+    #
+    # @api public
+    def delete_server_subscribers(channel)
       @server.mutex.synchronize do
         (@server.subscribers[channel] || []).delete_if do |hash|
           hash[:reactor] == Actor.current
@@ -235,7 +250,7 @@ module CelluloidPubsub
     # @return [void]
     #
     # @api public
-    def unsubscribe_clients(channel)
+    def unsubscribe_clients(channel, _json_data)
       log_debug "#{self.class} runs 'unsubscribe_clients' method with  #{channel}"
       return if channel.blank?
       unsubscribe_from_channel(channel)
@@ -265,7 +280,7 @@ module CelluloidPubsub
     # @return [void]
     #
     # @api public
-    def start_subscriber(channel, message)
+    def subscribe(channel, message)
       return unless channel.present?
       add_subscriber_to_channel(channel, message)
       log_debug "#{self.class} subscribed to #{channel} with #{message}"
@@ -305,28 +320,44 @@ module CelluloidPubsub
     #  method for publishing data to a channel
     #
     # @param [String] current_topic The Channel to which the reactor instance {CelluloidPubsub::Reactor} will publish the message to
-    # @param [Object] message
+    # @param [Object] json_data The additional data that contains the message that needs to be sent
     #
     # @return [void]
     #
     # @api public
-    def publish_event(current_topic, message)
+    def publish(current_topic, json_data)
+      message = json_data['data'].to_json
       return if current_topic.blank? || message.blank?
+      server_pusblish_event(current_topic, message)
+    rescue => exception
+      log_debug("could not publish message #{message} into topic #{current_topic} because of #{exception.inspect}")
+    end
+
+    # the method will publish to all subsribers of a channel a message
+    #
+    # @param [String] current_topic
+    # @param [#to_s] message
+    #
+    # @return [void]
+    #
+    # @api public
+    def server_pusblish_event(current_topic, message)
       @server.mutex.synchronize do
         (@server.subscribers[current_topic].dup || []).pmap do |hash|
           hash[:reactor].websocket << message
         end
       end
-    rescue => exception
-      log_debug("could not publish message #{message} into topic #{current_topic} because of #{exception.inspect}")
     end
 
     # unsubscribes all actors from all channels and terminates the curent actor
     #
+    # @param [String] _channel NOT USED - needed to maintain compatibility with the other methods
+    # @param [Object] _json_data NOT USED - needed to maintain compatibility with the other methods
+    #
     # @return [void]
     #
     # @api public
-    def unsubscribe_all
+    def unsubscribe_all(_channel, _json_data)
       log_debug "#{self.class} runs 'unsubscribe_all' method"
       CelluloidPubsub::Registry.channels.dup.pmap do |channel|
         unsubscribe_clients(channel)
@@ -343,6 +374,16 @@ module CelluloidPubsub
     # @api public
     def unsubscribe_from_channel(channel)
       log_debug "#{self.class} runs 'unsubscribe_from_channel' method with #{channel}"
+      server_kill_reactors(channel)
+    end
+
+    # kills all reactors registered on a channel and closes their websocket connection
+    #
+    # @param [String] channel
+    # @return [void]
+    #
+    # @api public
+    def server_kill_reactors(channel)
       @server.mutex.synchronize do
         (@server.subscribers[channel].dup || []).pmap do |hash|
           reactor = hash[:reactor]

data/lib/celluloid_pubsub/registry.rb

@@ -1,9 +1,13 @@
+# encoding: utf-8
+# frozen_string_literal: true
 module CelluloidPubsub
   # class used to register new channels and save them in memory
+  # @attr  channels
+  #   @return [Array] array of channels to which actors have subscribed to
   class Registry
     class << self
-      # @!attribute channels
-      #   @return [Array] array of channels to which actors have subscribed to
+      # The channels that the server can handle
+      # @return [Array] array of channels to which actors have subscribed to
       attr_accessor :channels
     end
     @channels = []

data/lib/celluloid_pubsub/version.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+# frozen_string_literal: true
 # Returns the version of the gem  as a <tt>Gem::Version</tt>
 module CelluloidPubsub
   #  it prints the gem version as a string
@@ -13,14 +15,14 @@ module CelluloidPubsub
   # provides a easy way of getting the major, minor and tiny
   module VERSION
     # major release version
-    MAJOR = 0
+    MAJOR = 1
     # minor release version
-    MINOR = 9
+    MINOR = 0
     # tiny release version
     TINY = 0
     # prelease version ( set this only if it is a prelease)
     PRE = nil
-
+    
     # generates the version string
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
   end

data/lib/celluloid_pubsub/web_server.rb

@@ -1,18 +1,22 @@
+# encoding: utf-8
+# frozen_string_literal: true
 require_relative './reactor'
 require_relative './helper'
 module CelluloidPubsub
   # webserver to which socket connects should connect to .
   # the server will dispatch each request into a new Reactor
   # which will handle the action based on the message
-  # @!attribute options
+  # @attr  server_options
   #   @return [Hash] options used to configure the webserver
-  #   @option options [String]:hostname The hostname on which the webserver runs on
-  #   @option options [Integer] :port The port on which the webserver runs on
-  #   @option options [String] :path The request path that the webserver accepts
-  #   @option options [Boolean] :spy Enable this only if you want to enable debugging for the webserver
+  #   @option server_options [String]:hostname The hostname on which the webserver runs on
+  #   @option server_options [Integer] :port The port on which the webserver runs on
+  #   @option server_options [String] :path The request path that the webserver accepts
+  #   @option server_options [Boolean] :spy Enable this only if you want to enable debugging for the webserver
   #
-  # @!attribute subscribers
+  # @attr  subscribers
   #   @return [Hash] The hostname on which the webserver runs on
+  # @attr  mutex
+  #   @return [Mutex] The mutex that will synchronize actions on subscribers
   class WebServer < Reel::Server::HTTP
     include CelluloidPubsub::BaseActor
 
@@ -20,7 +24,7 @@ module CelluloidPubsub
     HOST = '0.0.0.0'
     # The request path that the webserver accepts by default
     PATH = '/ws'
-      # The name of the default adapter
+    # The name of the default adapter
     CLASSIC_ADAPTER = 'classic'
 
     attr_accessor :server_options, :subscribers, :mutex
@@ -55,12 +59,30 @@ module CelluloidPubsub
     #
     # @api public
     def self.open_socket_on_unused_port
-      infos = ::Socket::getaddrinfo("localhost", nil, Socket::AF_UNSPEC, Socket::SOCK_STREAM, 0, Socket::AI_PASSIVE)
-      families = Hash[*infos.collect { |af, *_| af }.uniq.zip([]).flatten]
+      return ::TCPServer.open('0.0.0.0', 0) if socket_families.key?('AF_INET')
+      return ::TCPServer.open('::', 0) if socket_families.key?('AF_INET6')
+      ::TCPServer.open(0)
+    end
 
-      return ::TCPServer.open('0.0.0.0', 0) if families.has_key?('AF_INET')
-      return ::TCPServer.open('::', 0) if families.has_key?('AF_INET6')
-      return ::TCPServer.open(0)
+    # the method will  return the socket information available as an array
+    #
+    #
+    # @return [Array]  return the socket information available as an array
+    #
+    # @api public
+    def self.socket_infos
+      ::Socket::getaddrinfo('localhost', nil, Socket::AF_UNSPEC, Socket::SOCK_STREAM, 0, Socket::AI_PASSIVE)
+    end
+
+    # the method will  return the socket families avaiable
+    #
+    #
+    # @return [Hash]  return the socket families available as keys in the hash
+    #
+    # @api public
+    # rubocop:disable ClassVars
+    def self.socket_families
+      @@socket_families ||= Hash[*socket_infos.map { |af, *_| af }.uniq.zip([]).flatten]
     end
 
     # the method get from the socket connection that is already opened the port used.
@@ -77,6 +99,7 @@ module CelluloidPubsub
         port
       end
     end
+    # rubocop:enable ClassVars
 
     # this method is overriden from the Reel::Server::HTTP in order to set the spy to the celluloid logger
     # before the connection is accepted.
@@ -105,7 +128,7 @@ module CelluloidPubsub
     #
     # @api public
     def debug_enabled?
-      @debug_enabled = @server_options.fetch('enable_debug', false)
+      @debug_enabled = @server_options.fetch('enable_debug', true)
       @debug_enabled == true
     end
 
@@ -180,7 +203,6 @@ module CelluloidPubsub
       @backlog = @server_options.fetch('backlog', 1024)
     end
 
-
     #  callback that will execute when receiving new conections
     # If the connections is a websocket will call method {#route_websocket}
     # and if the connection is HTTP will call method {#route_request}
@@ -263,13 +285,13 @@ module CelluloidPubsub
     #
     # @api public
     def route_websocket(reactor, socket)
-       url = socket.url
-       if url == path || url == "/?"
+      url = socket.url
+      if url == path || url == '/?'
         reactor.async.work(socket, Actor.current)
-       else
-         log_debug "Received invalid WebSocket request for: #{url}"
-         socket.close
-       end
+      else
+        log_debug "Received invalid WebSocket request for: #{url}"
+        socket.close
+      end
     end
 
     # If the message can be parsed into a Hash it will respond to the reactor's websocket connection with the same message in JSON format
@@ -284,11 +306,7 @@ module CelluloidPubsub
     def handle_dispatched_message(reactor, data)
       log_debug "#{self.class} trying to dispatch message  #{data.inspect}"
       message = reactor.parse_json_data(data)
-      if message.present? && message.is_a?(Hash)
-        final_data = message.to_json
-      else
-        final_data = data.to_json
-      end
+      final_data = message.present? && message.is_a?(Hash) ? message.to_json : data.to_json
       reactor.websocket << final_data
     end
   end

data/spec/spec_helper.rb

@@ -50,7 +50,7 @@ end
 class TestActor
   include CelluloidPubsub::BaseActor
 
-  def initialize(*args)
+  def initialize(*_args)
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: celluloid_pubsub
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
 platform: ruby
 authors:
 - bogdanRada
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2016-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: celluloid
@@ -361,10 +361,13 @@ files:
 - Rakefile
 - celluloid_pubsub.gemspec
 - examples/simple_test.rb
+- gemfiles/celluloid_0.16.0.gemfile
+- gemfiles/celluloid_0.17.3.gemfile
 - init.rb
 - lib/celluloid_pubsub.rb
 - lib/celluloid_pubsub/base_actor.rb
 - lib/celluloid_pubsub/client.rb
+- lib/celluloid_pubsub/gem_version_parser.rb
 - lib/celluloid_pubsub/helper.rb
 - lib/celluloid_pubsub/initializers/reel_colors.rb
 - lib/celluloid_pubsub/reactor.rb
@@ -401,10 +404,5 @@ signing_key:
 specification_version: 4
 summary: CelluloidPubsub is a simple ruby implementation of publish subscribe design
   patterns using celluloid actors and websockets, using Celluloid::Reel server
-test_files:
-- spec/lib/celluloid_pubsub/client_pubsub_spec.rb
-- spec/lib/celluloid_pubsub/reactor_spec.rb
-- spec/lib/celluloid_pubsub/registry_spec.rb
-- spec/lib/celluloid_pubsub/web_server_spec.rb
-- spec/spec_helper.rb
+test_files: []
 has_rdoc: