cellular 2.1.0 → 2.2.0

data/spec/cellular/backends/link_mobility_spec.rb

@@ -0,0 +1,118 @@
+require 'spec_helper'
+
+describe Cellular::Backends::LinkMobility do
+  let(:recipient) { '+15005550004' }
+  let(:sender)    { '+15005550006' }
+  let(:message)   { 'This is an SMS message' }
+  let(:partner_id)   { 1234 }
+
+  let(:options) do
+    {
+      recipient: recipient,
+      sender: sender,
+      message: message,
+    }
+  end
+
+  let(:payload) do
+    {
+      source: sender,
+      destination: recipient,
+      userData: message,
+      platformId: 'COMMON_API',
+      platformPartnerId: partner_id
+    }.to_json
+  end
+
+  before do
+    Cellular.config.username = 'username'
+    Cellular.config.password = 'password'
+    Cellular.config.backend = Cellular::Backends::LinkMobility
+    Cellular.config.partner_id = 1234
+  end
+
+  describe '::deliver' do
+    before do
+      stub_request(:post, 'https://username:password@wsx.sp247.net/sms/send')
+        .to_return(
+          status: [200, 'OK'],
+          body: fixture('backends/link_mobility/success.json'),
+          headers: { 'Content-Type' => 'application/json' }
+        )
+    end
+
+    it 'uses HTTParty to deliver an SMS' do
+      expect(HTTParty).to receive(:post).with(
+        described_class.sms_url,
+        body: payload,
+        headers: described_class::HTTP_HEADERS,
+        basic_auth: described_class.link_mobility_config
+      ).and_call_original
+
+      described_class.deliver(options)
+    end
+
+    context 'when successful' do
+      it 'returns a status code and message' do
+        expect(described_class.deliver(options)).to eq [
+          'Queued'
+        ]
+      end
+    end
+
+    context 'when not successful' do
+      before do
+        stub_request(:post, 'https://username:password@wsx.sp247.net/sms/send')
+          .to_return(
+            status: [403, 'FORBIDDEN'],
+            body: fixture('backends/link_mobility/failure.json'),
+            headers: { 'Content-Type' => 'application/json' }
+          )
+      end
+
+      it 'returns a status code and message' do
+        expect(described_class.deliver(options)).to eq [
+          'Unable to access SMSC credentials'
+        ]
+      end
+    end
+  end
+
+  describe '::link_mobility_config' do
+    it 'returns the config for twilio' do
+      expect(described_class.link_mobility_config).to eq(
+        username: 'username',
+        password: 'password'
+      )
+    end
+  end
+
+  describe '::sms_url' do
+    it 'returns the full sms gateway url' do
+      expect(described_class.sms_url).to eq(
+        'https://wsx.sp247.net/sms/send'
+      )
+    end
+  end
+
+  describe '::payload' do
+    it 'returns the request payload' do
+      options[:batch] = recipient
+      expect(described_class.payload(options)).to eq(payload)
+    end
+  end
+
+  describe '::recipients_batch' do
+    it 'wraps recipient option into an array' do
+      result = described_class.recipients_batch(recipient: recipient)
+      expect(result).to eq [recipient]
+    end
+
+    it 'return recipients option as-is' do
+      result = described_class.recipients_batch(
+        recipients: [recipient, recipient]
+      )
+      expect(result).to eq [recipient, recipient]
+    end
+  end
+end

data/spec/cellular/backends/log_spec.rb

@@ -1,21 +1,20 @@
 require 'spec_helper'
 
 describe Cellular::Backends::Log do
-
   let(:recipient) { '47xxxxxxxx' }
   let(:sender)    { 'Custom sender' }
   let(:message)   { 'This is an SMS message' }
   let(:price)     { 100 }
-  let(:country)   { 'NO '}
+  let(:country)   { 'NO ' }
 
-  let(:options) {
+  let(:options) do
     {
       recipient: recipient,
       sender: sender,
       message: message,
       price: price
     }
-  }
+  end
 
   before do
     Cellular.config.username = 'username'
@@ -39,5 +38,4 @@ describe Cellular::Backends::Log do
       end.to raise_error NotImplementedError
     end
   end
-
 end

data/spec/cellular/backends/log_with_rails_spec.rb

@@ -1,21 +1,20 @@
 require 'spec_helper'
 
 describe Cellular::Backends::Log do
-
   let(:recipient) { '47xxxxxxxx' }
   let(:sender)    { 'Custom sender' }
   let(:message)   { 'This is an SMS message' }
   let(:price)     { 100 }
-  let(:country)   { 'NO '}
+  let(:country)   { 'NO ' }
 
-  let(:options) {
+  let(:options) do
     {
       recipient: recipient,
       sender: sender,
       message: message,
       price: price
     }
-  }
+  end
 
   before do
     # mock rails, we're pretending we're in a rails env
@@ -24,13 +23,13 @@ describe Cellular::Backends::Log do
       @logger ||= Cellular::Logger.new
     end
     Object.const_set(:Rails, rails)
-    
+
     Cellular.config.username = 'username'
     Cellular.config.password = 'password'
     Cellular.config.delivery_url = nil
     Cellular.config.logger = nil # so it will autowire
   end
-  
+
   after do
     Object.send :remove_const, :Rails
   end
@@ -43,5 +42,4 @@ describe Cellular::Backends::Log do
       described_class.deliver(options)
     end
   end
-
 end

data/spec/cellular/backends/sendega_spec.rb

@@ -1,28 +1,29 @@
 require 'spec_helper'
 
 describe Cellular::Backends::Sendega do
-
   let(:recipient)  { '47xxxxxxxx' }
   let(:sender)     { 'Custom sender' }
   let(:message)    { 'This is an SMS message' }
   let(:price)      { 100 }
-  let(:country)    { 'NO '}
-  let(:recipients) { (1..300).to_a.map!{|n| "47xxxxxxx#{n}"} }
-  let(:options)    {
+  let(:country)    { 'NO ' }
+  let(:recipients) { (1..300).to_a.map! { |n| "47xxxxxxx#{n}" } }
+
+  let(:options) do
     {
       recipient: recipient,
       sender: sender,
       message: message,
       price: price
     }
-  }
-  let(:savon_options) {
+  end
+
+  let(:savon_options) do
     {
       log: false
     }
-  }
+  end
 
-  let(:payload) {
+  let(:payload) do
     {
       username: Cellular.config.username,
       password: Cellular.config.password,
@@ -42,11 +43,11 @@ describe Cellular::Backends::Sendega do
       pid: 0,
       dcs: 0
     }
-  }
+  end
 
   before do
-    stub_request(:get, described_class::GATEWAY_URL).
-      to_return body: fixture('backends/sendega/service.wsdl')
+    stub_request(:get, described_class::GATEWAY_URL)
+      .to_return body: fixture('backends/sendega/service.wsdl')
 
     Cellular.config.username = 'username'
     Cellular.config.password = 'password'
@@ -55,10 +56,10 @@ describe Cellular::Backends::Sendega do
 
   describe '::deliver' do
     it 'uses Savon to deliver an SMS' do
-      client = double()
+      client = double
       Savon.stub(:client).and_return client
 
-      result = double(body: {send_response: {send_result: {}}})
+      result = double(body: { send_response: { send_result: {} } })
 
       expect(client).to receive(:call).with(:send, message:
       payload).and_return result
@@ -68,8 +69,8 @@ describe Cellular::Backends::Sendega do
 
     context 'when successful' do
       before do
-        stub_request(:post, 'https://smsc.sendega.com/Content.asmx').
-          to_return body: fixture('backends/sendega/success.xml')
+        stub_request(:post, 'https://smsc.sendega.com/Content.asmx')
+          .to_return body: fixture('backends/sendega/success.xml')
       end
 
       it 'returns a success code and a message' do
@@ -82,8 +83,8 @@ describe Cellular::Backends::Sendega do
 
     context 'when not successful' do
       before do
-        stub_request(:post, 'https://smsc.sendega.com/Content.asmx').
-          to_return body: fixture('backends/sendega/failure.xml')
+        stub_request(:post, 'https://smsc.sendega.com/Content.asmx')
+          .to_return body: fixture('backends/sendega/failure.xml')
       end
 
       it 'returns an error code and a message' do
@@ -104,41 +105,38 @@ describe Cellular::Backends::Sendega do
   end
 
   describe '::success_message' do
-    it 'should return this message' do
-      expect(
-        described_class.success_message)
-      .to eq 'Message is received and is being processed.'
+    it 'returns this message' do
+      expect(described_class.success_message)
+        .to eq 'Message is received and is being processed.'
     end
   end
 
-
   describe '::defaults_with' do
-    it 'should return the whole payload' do
+    it 'returns the whole payload' do
       options[:batch] = recipient
       expect(described_class.defaults_with(options)).to eq(payload)
-   end
+    end
   end
 
   describe '::savon_config' do
-    it 'should return a hash with config' do
-      expect(described_class.savon_config)
-      .to eq({
-           username: Cellular.config.username,
-           password: Cellular.config.password,
-           dlrUrl: Cellular.config.delivery_url
-        })
+    it 'returns a configuration hash' do
+      expect(described_class.savon_config).to eq(
+        username: Cellular.config.username,
+        password: Cellular.config.password,
+        dlrUrl: Cellular.config.delivery_url
+      )
     end
   end
 
   describe '::recipients_batch' do
-    it 'should split recipients into arrays of 100 then join them with ,' do
-      check = described_class.recipients_batch({recipients:recipients}).length
-      expect(check).to eq 3
+    it 'splits recipients into arrays of 100 joined with commas' do
+      result = described_class.recipients_batch(recipients: recipients)
+      expect(result.length).to eq 3
     end
 
-    it 'should put recipient into one array' do
-      check = described_class.recipients_batch({receipient:recipient}).length
-      expect(check).to eq 1
+    it 'puts recipient into one array' do
+      result = described_class.recipients_batch(receipient: recipient)
+      expect(result.length).to eq 1
     end
   end
 end

data/spec/cellular/backends/test_spec.rb

@@ -1,21 +1,11 @@
 require 'spec_helper'
 
 describe Cellular::Backends::Test do
-
   let(:recipient) { '47xxxxxxxx' }
   let(:sender)    { 'Custom sender' }
   let(:message)   { 'This is an SMS message' }
   let(:price)     { 100 }
-  let(:country)   { 'NO '}
-
-  let(:options) {
-    {
-      recipient: recipient,
-      sender: sender,
-      message: message,
-      price: price
-    }
-  }
+  let(:country)   { 'NO ' }
 
   before do
     Cellular.config.username = 'username'
@@ -49,5 +39,4 @@ describe Cellular::Backends::Test do
       end.to raise_error NotImplementedError
     end
   end
-
 end

data/spec/cellular/backends/twilio_spec.rb

@@ -1,36 +1,28 @@
 require 'spec_helper'
 
 describe Cellular::Backends::Twilio do
-
   let(:recipient) { '+15005550004' }
   let(:sender)    { '+15005550006' }
   let(:message)   { 'This is an SMS message' }
   let(:price)   { 0.001 }
 
-  let(:options) {
+  let(:options) do
     {
       recipient: recipient,
       sender: sender,
       message: message,
       price: price
     }
-  }
-
-  let(:auth) {
-    {
-      username: 'account_sid',
-      password: 'auth_token'
-    }
-  }
+  end
 
-  let(:payload) {
+  let(:payload) do
     {
       From: sender,
       To: recipient,
       Body: message,
       MaxPrice: price
     }
-  }
+  end
 
   before do
     Cellular.config.username = 'account_sid'
@@ -40,62 +32,72 @@ describe Cellular::Backends::Twilio do
 
   describe '::deliver' do
     before do
-      stub_request(:post, "https://account_sid:auth_token@api.twilio.com/2010-04-01/Accounts/account_sid/Messages").
-       to_return(:status => [201, "CREATED"], :body => fixture('backends/twilio/success.json'), :headers => {'Content-Type' => 'application/json'})
+      stub_request(:post, 'https://account_sid:auth_token@api.twilio.com/2010-04-01/Accounts/account_sid/Messages')
+        .to_return(
+          status: [201, 'CREATED'],
+          body: fixture('backends/twilio/success.json'),
+          headers: { 'Content-Type' => 'application/json' }
+        )
     end
 
-    it 'does uses HTTParty to deliver an SMS' do
-      expect(HTTParty).to receive(:post).with(described_class::sms_url, body:
-        payload, headers: described_class::HTTP_HEADERS, basic_auth: described_class::twilio_config).and_call_original
+    it 'uses HTTParty to deliver an SMS' do
+      expect(HTTParty).to receive(:post).with(
+        described_class.sms_url,
+        body: payload,
+        headers: described_class::HTTP_HEADERS,
+        basic_auth: described_class.twilio_config
+      ).and_call_original
 
       described_class.deliver(options)
     end
 
     context 'when successful' do
-      it 'does return a status code and message' do
-        expect(described_class.deliver(options)).to eq([
+      it 'returns a status code and message' do
+        expect(described_class.deliver(options)).to eq [
           201,
           'CREATED'
-        ])
+        ]
       end
     end
 
     context 'when not successful' do
       before do
-        stub_request(:post, "https://account_sid:auth_token@api.twilio.com/2010-04-01/Accounts/account_sid/Messages").
-          to_return(:status => [400, "BAD REQUEST"], :body => fixture('backends/twilio/failure.json'), :headers => {'Content-Type' => 'application/json'})
+        stub_request(:post, 'https://account_sid:auth_token@api.twilio.com/2010-04-01/Accounts/account_sid/Messages')
+          .to_return(
+            status: [400, 'BAD REQUEST'],
+            body: fixture('backends/twilio/failure.json'),
+            headers: { 'Content-Type' => 'application/json' }
+          )
       end
 
-      it 'does return a status code and message' do
-        expect(described_class.deliver(options)).to eq([
+      it 'returns a status code and message' do
+        expect(described_class.deliver(options)).to eq [
           400,
           'BAD REQUEST'
-        ])
+        ]
       end
     end
-
   end
 
   describe '::twilio_config' do
-    it 'does return the config for twilio' do
+    it 'returns the config for twilio' do
       expect(described_class.twilio_config).to eq(
-        {
-          username: 'account_sid',
-          password: 'auth_token'
-        })
+        username: 'account_sid',
+        password: 'auth_token'
+      )
     end
   end
 
   describe '::sms_url' do
-    it 'does return the full sms gateway url' do
+    it 'returns the full sms gateway url' do
       expect(described_class.sms_url).to eq(
-        "https://api.twilio.com/2010-04-01/Accounts/account_sid/Messages"
+        'https://api.twilio.com/2010-04-01/Accounts/account_sid/Messages'
       )
     end
   end
 
   describe '::payload' do
-    it 'does return the request payload' do
+    it 'returns the request payload' do
       options[:batch] = recipient
       expect(described_class.payload(options)).to eq(payload)
     end
@@ -107,7 +109,7 @@ describe Cellular::Backends::Twilio do
     end
 
     context 'when not successful' do
-      it 'does return the formatted success response' do
+      it 'returns the formatted success response' do
         subject.stub(:code).and_return(201)
         subject.stub(:message).and_return('CREATED')
 
@@ -121,7 +123,7 @@ describe Cellular::Backends::Twilio do
     end
 
     context 'when not successful' do
-      it 'does return the formatted failed response' do
+      it 'returns the formatted failed response' do
         subject.stub(:code).and_return(400)
         subject.stub(:message).and_return('BAD REQUEST')
 
@@ -136,13 +138,16 @@ describe Cellular::Backends::Twilio do
   end
 
   describe '::recipients_batch' do
-    it 'does wrap recipient option into a array' do
-      expect(described_class.recipients_batch({recipient: recipient}))
-        .to eq([recipient])
+    it 'wraps recipient option into an array' do
+      result = described_class.recipients_batch(recipient: recipient)
+      expect(result).to eq [recipient]
     end
-    it 'does return recipients option as it is' do
-      expect(described_class.recipients_batch({recipients: [recipient,recipient]}))
-        .to eq([recipient,recipient])
+
+    it 'return recipients option as-is' do
+      result = described_class.recipients_batch(
+        recipients: [recipient, recipient]
+      )
+      expect(result).to eq [recipient, recipient]
     end
   end
 end