cellular 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d69945358dbd5a90eda81aee664adfffe7a971a
-  data.tar.gz: d0cccde1eb19cc6d1eb8b54d2414ee21815f02f0
+  metadata.gz: b2b557a411a9a042061ab2725cc29921a353cf55
+  data.tar.gz: b3c248d7b158b41ce1015f68431b395e1c278db8
 SHA512:
-  metadata.gz: 1e752bde39f9752f58f4e5c09aa2eb73a431c19066324aeb69a45930b83393aa59e042e5afe8549c5c23c749bdf5d390880273b977cee25a8f0c959080cb255f
-  data.tar.gz: 87d001976dbefd1fc8b7bc76f6e01007ebe23e17f28ec74f0a2ac37c6d8b9fdab0de2cd5b7c623935bfb7487c11e928b4b17fe6e4c35a6d506e1f254201821b2
+  metadata.gz: d4cf9e5c7b6b22d90ed3cc99d60fbb9d44051d6e789b33463136bfceeaf0202ce012a248a946e07a3ef4892d1fa699dab57b8d557027a3b921cbc252aa360ca7
+  data.tar.gz: 0850f3123d23661353059947a672e2a56ba5774d2e90b2e0d856fd5658a3dd55f5be341092bf2bf4259d31230b13b183fcb9eff460aeedc98d4eb6bfd9589680

data/README.md

@@ -37,6 +37,7 @@ Cellular.configure do |config|
   config.username = 'username'
   config.password = 'password'
   config.backend  = Cellular::Backends::Sendega
+  config.sender = 'Default custom sender'
 end
 ```
 
@@ -55,7 +56,6 @@ The options supported may differ between backends.
 sms = Cellular::SMS.new(
   recipient: '47xxxxxxxx',
   sender: 'Custom sender',
-  country: 'NO',
   message: 'This is an SMS message'
 )
 
@@ -70,3 +70,9 @@ sms.deliver
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create pull request
+
+
+## Credits
+
+Hyper made this. We're a digital communications agency with a passion for good code,
+and if you're using this library we probably want to hire you.

data/lib/cellular/configuration.rb

@@ -3,5 +3,7 @@ module Cellular
 
     attr_accessor :username, :password, :delivery_url, :backend
 
+    attr_accessor :country_code, :price, :sender
+
   end
 end

data/lib/cellular/models/sms.rb

@@ -7,10 +7,10 @@ module Cellular
       @backend = Cellular.config.backend
 
       @recipient = options[:recipient]
-      @sender = options[:sender]
+      @sender = options[:sender] || Cellular.config.sender
       @message = options[:message]
-      @price = options[:price]
-      @country = options[:country]
+      @price = options[:price] || Cellular.config.price
+      @country = options[:country] || Cellular.config.country_code
 
       @delivered = false
     end

data/lib/cellular/version.rb

@@ -1,3 +1,3 @@
 module Cellular
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/spec/cellular/configuration_spec.rb

@@ -11,4 +11,11 @@ describe Cellular::Configuration do
   it { should respond_to :backend= }
   it { should respond_to :backend }
 
+  it { should respond_to :price= }
+  it { should respond_to :price }
+  it { should respond_to :country_code= }
+  it { should respond_to :country_code }
+  it { should respond_to :sender= }
+  it { should respond_to :sender }
+
 end

data/spec/cellular/models/sms_spec.rb

@@ -6,7 +6,7 @@ describe Cellular::SMS do
   let(:sender)    { 'Custom sender' }
   let(:message)   { 'This is an SMS message' }
   let(:price)     { 100 }
-  let(:country)   { 'NO '}
+  let(:country)   { 'NO'}
 
   subject do
     described_class.new(
@@ -30,6 +30,36 @@ describe Cellular::SMS do
     its(:country)   { should eq country }
 
     it { should_not be_delivered }
+
+    context 'when sender omitted' do
+      before do
+        Cellular.config.sender = 'Hyper'
+      end
+
+      subject { described_class.new }
+
+      its(:sender) { should eq 'Hyper' }
+    end
+
+    context 'when price omitted' do
+      before do
+        Cellular.config.price = 5
+      end
+
+      subject { described_class.new }
+
+      its(:price) { should eq 5 }
+    end
+
+    context 'when country omitted' do
+      before do
+        Cellular.config.country_code = 'NL'
+      end
+
+      subject { described_class.new }
+
+      its(:country) { should eq 'NL' }
+    end
   end
 
   describe '#deliver' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cellular
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Sindre Moen
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-28 00:00:00.000000000 Z
+date: 2014-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty