cdnetworks-client 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50e8eeb665f8b3e41ffd0b0bedde921461054f21
-  data.tar.gz: 8f98b1be2e0c9c31ea851a7e6766c4640ea4c213
+  metadata.gz: 93586b13b1c72ba395781dd8c56667276e23bc43
+  data.tar.gz: a07c0c362ac81150bc0a96faae072048fbcf6e50
 SHA512:
-  metadata.gz: cc818105a242ade3027b56d928ba3ae2bd6bd2468aa291792358ca1235bf6861e49ada1cf273fbfca66aae26fcc37cb86a5feb8fd33fe458162bcca76b21c515
-  data.tar.gz: e06898e2bc26113e18f5a101bb8e237b787eaff77785bab245e47e68384f68a747daca1f759f8b1de99ab5e1d986caa8509668446341dc1f955ff10d75331a8b
+  metadata.gz: 160c5e5c6aefa8b47d5506def0cb209c9938a534dfaffbd126720b8a3c647059dd9ad4ceaa6ae6db2688b085d0f11242741f00784615882793c03ef98b3c09f1
+  data.tar.gz: d746d1004e561a2e4e9e96c9ccae1e863518d0bdb41518d5c666729dfc70f2e60cd465517968d25bed1e03c42cf45a81fc26b520a96ce178bf7a26170ec103ea

data/lib/cdnetworks-client/open_api_error.rb

@@ -11,21 +11,30 @@ module OpenApiError
     "999" => "Temporary error"
   }
 
-  class ApiError < StandardError
+  class BaseError < StandardError
+    attr_accessor :code, :body
 
+    def initialize(error, code = nil, body = nil)
+      @code = code
+      @body = body
+      super(error)
+    end
   end
 
-  class CriticalApiError < StandardError
+  class ApiError < BaseError
+  end
 
+  class CriticalApiError < BaseError
   end
 
   class ErrorHandler
     def self.handle_error_response(code, body)
-      if desc = ERROR_CODES[code.to_s]
-        raise ApiError.new("Open API Error #{code}: #{desc}")
+      if ERROR_CODES[code.to_s]
+        message = "Open API Error #{code}: #{ERROR_CODES[code.to_s]}"
       else
-        raise ApiError.new("Unknown Open API Response Code #{code} (body: #{body})")
+        message = "Unknown Open API Response Code #{code} (body: #{body})"
       end
+      raise ApiError.new(message, code, body)
     end
   end
 end

data/lib/cdnetworks-client/version.rb

@@ -1,5 +1,5 @@
 module Cdnetworks
   module Client
-    VERSION = "1.1.1"
+    VERSION = "1.1.2"
   end
 end

data/spec/lib/cdnetworks-client/cdnetworks_client_spec.rb

@@ -373,7 +373,9 @@ describe CdnetworksClient do
 
       before do
         @good_token, _ = stub_auth_calls
-        stub_request(:post, "#{@url}/api/rest/getApiKeyList").with(body: {"output"=>"json", "sessionToken"=>bad_token}).to_return(body: expired_session_resp)
+        stub_request(:post, "#{@url}/api/rest/getApiKeyList")
+          .with(body: {"output"=>"json", "sessionToken"=>bad_token})
+          .to_return(body: expired_session_resp)
       end
 
       it "re-establishes session if it expires" do
@@ -384,17 +386,33 @@ describe CdnetworksClient do
       end
 
       it "doesn't infinite loop if session can't be re-established" do
-        stub_request(:post, "#{@url}/api/rest/login").to_return(body: JSON.pretty_unparse(loginResponse: {resultCode: 101}))
+        stub_request(:post, "#{@url}/api/rest/login")
+          .to_return(body: JSON.pretty_unparse(loginResponse: {resultCode: 101}))
         expect { @cdn_api.get_api_key_list(bad_token) }.to raise_error(OpenApiError::ApiError)
       end
 
       it "gives up if session is not re-established after MAX_SESSION_RETRIES tries" do
-        stub_request(:post, "#{@url}/api/rest/getApiKeyList").with(body: {"output"=>"json", "sessionToken"=>@good_token}).to_return(body: expired_session_resp)
+        stub_request(:post, "#{@url}/api/rest/getApiKeyList")
+          .with(body: {"output"=>"json", "sessionToken"=>@good_token})
+          .to_return(body: expired_session_resp)
 
         expect { @cdn_api.get_api_key_list(bad_token) }.to raise_error(OpenApiError::CriticalApiError)
 
         expect(a_request(:post, "#{@url}/api/rest/login")).to have_been_made.times(3)
       end
+
+      it "keeps code andy body around on the exception" do
+        response = JSON.pretty_unparse(loginResponse: { resultCode: 101 })
+        stub_request(:post, "#{@url}/api/rest/login")
+          .to_return(body: response)
+
+        begin
+          @cdn_api.get_api_key_list(bad_token)
+        rescue OpenApiError::ApiError => e
+          expect(e.code).to eq(101)
+          expect(e.body).to eq(response)
+        end
+      end
     end
 
     describe ConfigOpenApi do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cdnetworks-client
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Nell Shamrell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-04 00:00:00.000000000 Z
+date: 2015-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec