cdd-metric_fu 1.3.1

data/spec/base/graph_spec.rb

@@ -0,0 +1,32 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe MetricFu do
+  
+  describe "responding to #graph" do
+    it "should return an instance of Graph" do
+      MetricFu.graph.should be_a(Graph)
+    end
+  end
+end
+
+describe MetricFu::Graph do
+  
+  before(:each) do
+    @graph = MetricFu::Graph.new
+  end
+  
+  describe "responding to #add with gchart enabled" do
+    it 'should instantiate a grapher and push it to clazz' do
+      @graph.clazz.should_receive(:push).with(an_instance_of(RcovGchartGrapher))
+      @graph.add("rcov", 'gchart')
+    end
+  end
+  
+  describe "#date_for(report)" do
+    it "should return the right month/day date for the given report file name" do
+      @graph.send(:date_for, "tmp/metric_fu/_data/20100502.yml").should == "5/2"
+      @graph.send(:date_for, "tmp/metric_fu/_data/20081101.yml").should == "11/1"
+      @graph.send(:date_for, "tmp/metric_fu/_data/20081231.yml").should == "12/31"
+    end
+  end
+end

data/spec/base/md5_tracker_spec.rb

@@ -0,0 +1,57 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe MetricFu::MD5Tracker do
+  before do
+    @tmp_dir = File.join(File.dirname(__FILE__), 'tmp')
+    FileUtils.mkdir_p(@tmp_dir, :verbose => false) unless File.directory?(@tmp_dir)
+    @file1 = File.new(File.join(@tmp_dir, 'file1.txt'), 'w')
+    @file2 = File.new(File.join(@tmp_dir, 'file2.txt'), 'w')
+  end
+
+  after do
+    FileUtils.rm_rf(@tmp_dir, :verbose => false)
+  end
+
+  it "identical files should match" do
+    @file1.puts("Hello World")
+    @file1.close
+    file1_md5 = MD5Tracker.track(@file1.path, @tmp_dir)
+
+    @file2.puts("Hello World")
+    @file2.close
+    file2_md5 = MD5Tracker.track(@file2.path, @tmp_dir)
+
+    file2_md5.should == file1_md5
+  end
+
+  it "different files should not match" do
+    @file1.puts("Hello World")
+    @file1.close
+    file1_md5 = MD5Tracker.track(@file1.path, @tmp_dir)
+
+    @file2.puts("Goodbye World")
+    @file2.close
+    file2_md5 = MD5Tracker.track(@file2.path, @tmp_dir)
+
+    file2_md5.should_not == file1_md5
+  end
+
+  it "file_changed? should detect a change" do
+      @file2.close
+
+      @file1.puts("Hello World")
+      @file1.close
+      file1_md5 = MD5Tracker.track(@file1.path, @tmp_dir)
+
+      @file1 = File.new(File.join(@tmp_dir, 'file1.txt'), 'w')
+      @file1.puts("Goodbye World")
+      @file1.close
+      MD5Tracker.file_changed?(@file1.path, @tmp_dir).should be_true
+  end
+
+  it "should detect a new file" do
+    @file2.close
+    MD5Tracker.file_changed?(@file1.path, @tmp_dir).should be_true
+    File.exist?(MD5Tracker.md5_file(@file1.path, @tmp_dir)).should be_true
+  end
+end

data/spec/base/report_spec.rb

@@ -0,0 +1,139 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe MetricFu do
+  
+  describe "#report" do
+    it 'should return an instance of Report' do
+      MetricFu.report.instance_of?(Report).should be(true)
+    end
+  end
+end
+
+describe MetricFu::Report do
+
+  before(:each) do
+    @report = MetricFu::Report.new
+  end
+
+  describe "#to_yaml" do
+    it 'should call #report_hash' do
+      report_hash = mock('report_hash')
+      report_hash.should_receive(:to_yaml)
+      @report.should_receive(:report_hash).and_return(report_hash)
+      @report.to_yaml
+    end
+  end
+
+  describe "#report_hash" do
+  end
+
+  describe "#save_templatized_report" do
+    it 'should create a new template class assign a report_hash '\
+       'to the template class, and ask it to write itself out' do
+      template_class = mock('template_class')
+      template_class.should_receive(:new).and_return(template_class)
+      MetricFu.should_receive(:template_class).and_return(template_class)
+      template_class.should_receive(:report=)
+      template_class.should_receive(:write)
+      @report.save_templatized_report
+    end
+  end
+
+  describe "#add" do
+    it 'should add a passed hash to the report_hash instance variable' do
+      report_type = mock('report_type')
+      report_type.should_receive(:to_s).and_return('type')
+      report_type.should_receive(:generate_report).and_return({:a => 'b'})
+      MetricFu.should_receive(:const_get).
+               with('Type').and_return(report_type)
+      report_hash = mock('report_hash')
+      report_hash.should_receive(:merge!).with({:a => 'b'})
+      @report.should_receive(:report_hash).and_return(report_hash)
+      @report.add(report_type)
+    end
+  end
+
+  describe "#save_output" do
+    it 'should write the passed content to dir/index.html' do
+      f = mock('file')
+      content = 'content'
+      @report.should_receive(:open).with('dir/file', 'w').and_yield(f)
+      f.should_receive(:puts).with(content)
+      @report.save_output(content, 'dir', 'file')
+    end
+  end
+
+  describe '#open_in_browser? ' do
+
+    before(:each) do
+      @config = mock('configuration')
+    end
+    
+    describe 'when the platform is os x ' do
+      
+      before(:each) do
+        @config.should_receive(:platform).and_return('darwin')
+      end
+
+      describe 'and we are in cruise control ' do
+
+        before(:each) do
+          @config.should_receive(:is_cruise_control_rb?).and_return(true)
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+        
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+
+      describe 'and we are not in cruise control' do
+
+        before(:each) do
+          @config.should_receive(:is_cruise_control_rb?).and_return(false)
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return true' do
+          @report.open_in_browser?.should be_true
+        end
+      end
+    end
+    
+    describe 'when the platform is not os x ' do
+      before(:each) do
+        @config.should_receive(:platform).and_return('other')
+      end
+      
+      describe 'and we are in cruise control' do
+        before(:each) do
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+
+      describe 'and we are not in cruise control' do
+        before(:each) do
+          MetricFu.stub!(:configuration).and_return(@config)
+        end
+        
+        it 'should return false' do
+          @report.open_in_browser?.should be_false
+        end
+      end
+    end
+  end
+  
+
+  describe '#show_in_browser' do
+    it 'should call open with the passed directory' do
+      @report.should_receive(:open_in_browser?).and_return(true)
+      @report.should_receive(:system).with("open my_dir/index.html")
+      @report.show_in_browser('my_dir')
+    end
+    
+  end
+end

data/spec/generators/churn_spec.rb

@@ -0,0 +1,43 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Churn do
+  
+  describe "analyze method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      MetricFu::Churn.should_receive(:verify_dependencies!).and_return(true)
+      @changes = {"lib/generators/flog.rb"=>2, "lib/metric_fu.rb"=>3}
+    end
+    
+    it "should be empty on error" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, "fatal: Not a git repository")
+      result = churn.analyze
+      result.should == [:churn => {}]
+    end
+
+    it "should return yaml results" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@output, "--- \n:churn: \n  :changed_files: \n  - spec/graphs/flog_grapher_spec.rb\n  - spec/base/graph_spec.rb\n  - lib/templates/awesome/layout.html.erb\n  - lib/graphs/rcov_grapher.rb\n  - lib/base/base_template.rb\n  - spec/graphs/grapher_spec.rb\n  - lib/templates/awesome/flog.html.erb\n  - lib/templates/awesome/flay.html.erb\n  - lib/graphs/roodi_grapher.rb\n  - lib/graphs/reek_grapher.rb\n  - HISTORY\n  - spec/graphs/roodi_grapher_spec.rb\n  - lib/generators/rcov.rb\n  - spec/graphs/engines/gchart_spec.rb\n  - spec/graphs/rcov_grapher_spec.rb\n  - lib/templates/javascripts/excanvas.js\n  - lib/templates/javascripts/bluff-min.js\n  - spec/graphs/reek_grapher_spec.rb\n")
+      result = churn.analyze
+      result.should == {:churn=>{:changed_files=>["spec/graphs/flog_grapher_spec.rb", "spec/base/graph_spec.rb", "lib/templates/awesome/layout.html.erb", "lib/graphs/rcov_grapher.rb", "lib/base/base_template.rb", "spec/graphs/grapher_spec.rb", "lib/templates/awesome/flog.html.erb", "lib/templates/awesome/flay.html.erb", "lib/graphs/roodi_grapher.rb", "lib/graphs/reek_grapher.rb", "HISTORY", "spec/graphs/roodi_grapher_spec.rb", "lib/generators/rcov.rb", "spec/graphs/engines/gchart_spec.rb", "spec/graphs/rcov_grapher_spec.rb", "lib/templates/javascripts/excanvas.js", "lib/templates/javascripts/bluff-min.js", "spec/graphs/reek_grapher_spec.rb"]}}
+    end
+
+  end
+  
+  describe "to_h method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      MetricFu::Churn.should_receive(:verify_dependencies!).and_return(true)
+    end
+    
+    it "should put the changes into a hash" do
+      churn = MetricFu::Churn.new
+      churn.instance_variable_set(:@churn, {:churn => 'results'})
+      churn.to_h[:churn].should == "results"
+    end
+  end
+end
+

data/spec/generators/flay_spec.rb

@@ -0,0 +1,110 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe Flay do 
+  before :each do
+    MetricFu::Flay.stub!(:verify_dependencies!).and_return(true)
+  end
+  describe "emit method" do
+    it "should look at the dirs" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => ['app', 'lib']  } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')    
+    
+      Dir.should_receive(:[]).with(File.join("app", "**/*.rb")).and_return("path/to/app")
+      Dir.should_receive(:[]).with(File.join("lib", "**/*.rb")).and_return("path/to/lib")
+      @flay.should_receive(:`).with("flay path/to/app path/to/lib")
+      output = @flay.emit
+    end
+    
+    it "should limit flay scores by the minimum_score" do
+      MetricFu::Configuration.run {|config| config.flay = { :dirs_to_flay => [], :minimum_score => 99 } }
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+
+      @flay.should_receive(:`).with("flay --mass 99 ")
+      output = @flay.emit
+    end
+  end
+  
+  describe "analyze method" do
+    before :each do
+      lines = <<-HERE
+Total score (lower is better) = 246
+
+
+1) IDENTICAL code found in :or (mass*2 = 68)
+  app/controllers/link_targets_controller.rb:57
+  app/controllers/primary_sites_controller.rb:138
+
+2) Similar code found in :if (mass = 64)
+  app/controllers/primary_sites_controller.rb:75
+  app/controllers/primary_sites_controller.rb:76
+  app/controllers/primary_sites_controller.rb:88
+  app/controllers/primary_sites_controller.rb:89
+      HERE
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      @flay = MetricFu::Flay.new('base_dir')
+      @flay.instance_variable_set(:@output, lines)
+    end
+    
+    it "should analyze and return matches" do
+      @flay.analyze.should == [ ["Total score (lower is better) = 246"],
+                                ["\n1) IDENTICAL code found in :or (mass*2 = 68)",
+                                  "app/controllers/link_targets_controller.rb:57",
+                                  "app/controllers/primary_sites_controller.rb:138"],
+                                ["2) Similar code found in :if (mass = 64)",
+                                  "app/controllers/primary_sites_controller.rb:75",
+                                  "app/controllers/primary_sites_controller.rb:76",
+                                  "app/controllers/primary_sites_controller.rb:88",
+                                  "app/controllers/primary_sites_controller.rb:89"] ]
+    end
+  end
+  
+  describe "to_h method" do
+            
+    before :each do
+      lines = [ ["Total score (lower is better) = 284"], 
+                  ["\n1) IDENTICAL code found in :or (mass*2 = 68)", 
+                    "app/controllers/link_targets_controller.rb:57", 
+                    "app/controllers/primary_sites_controller.rb:138"], 
+                  ["2) Similar code found in :if (mass = 64)", 
+                    "app/controllers/primary_sites_controller.rb:75", 
+                    "app/controllers/primary_sites_controller.rb:76", 
+                    "app/controllers/primary_sites_controller.rb:88", 
+                    "app/controllers/primary_sites_controller.rb:89"], 
+                  ["3) Similar code found in :defn (mass = 40)", 
+                    "app/controllers/link_targets_controller.rb:40", 
+                    "app/controllers/primary_sites_controller.rb:98"], 
+                  ["4) Similar code found in :defn (mass = 38)", 
+                    "app/controllers/link_targets_controller.rb:13", 
+                    "app/controllers/primary_sites_controller.rb:50"], 
+                  ["5) Similar code found in :defn (mass = 38)", 
+                    "app/models/primary_site.rb:104", 
+                    "app/models/primary_site.rb:109"], 
+                  ["6) Similar code found in :call (mass = 36)", 
+                    "app/controllers/bookmarklet_integration_controller.rb:6", 
+                    "app/controllers/bookmarklet_integration_controller.rb:17"]]
+                    
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flay = MetricFu::Flay.new('base_dir')
+      flay.instance_variable_set(:@matches, lines)
+      @results = flay.to_h
+    end
+  
+    it "should find the total_score" do
+      @results[:flay][:total_score].should == '284'
+    end
+  
+    it "should have 6 matches" do
+      @results[:flay][:matches].size.should == 6
+    end
+    
+    it "should capture info for match" do
+      @results[:flay][:matches].first[:reason].should =~ /IDENTICAL/
+      @results[:flay][:matches].first[:matches].first[:name].should =~ /link_targets_controller/
+      @results[:flay][:matches].first[:matches].first[:line].should == "57"
+    end
+  end
+end

data/spec/generators/flog_spec.rb

@@ -0,0 +1,262 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+describe Flog do
+  before :each do
+    @text = <<-HERE
+    157.9: flog total
+     11.3: flog/method average
+
+     34.8: UsersController#create
+      9.2: branch
+      6.8: current_user
+      5.2: assignment
+      3.4: role
+      3.0: render
+      3.0: ==
+      2.8: flash
+      1.6: after_create_page
+      1.6: params
+      1.5: activate!
+      1.5: errors
+      1.4: login
+      1.4: redirect_to
+      1.4: []
+      1.3: empty?
+      1.3: save
+      1.2: new
+     24.2: UsersController#authorize_user
+      4.8: branch
+      4.7: current_user
+      3.6: params
+      3.2: []
+      2.6: ==
+      1.5: role
+      1.5: to_i
+      1.5: id
+      1.4: new_session_path
+      1.3: include?
+      1.2: assignment
+      1.2: flash
+      1.2: redirect_to
+     16.4: UsersController#thank_you
+      4.0: assignment
+      3.3: params
+      2.9: []
+      2.7: redirect_to
+      2.4: branch
+      1.5: new_session_path
+      1.4: flash
+      1.4: activate!
+      1.3: can_activate?
+      1.2: find_by_id
+     14.2: UsersController#update
+      3.2: params
+      2.8: []
+      2.6: assignment
+      1.4: login
+      1.4: flash
+      1.4: redirect_to
+      1.3: render
+      1.2: branch
+      1.2: update_attributes
+      1.2: find_by_id
+     12.5: UsersController#sanitize_params
+      3.9: assignment
+      3.6: branch
+      3.0: current_user
+      1.6: params
+      1.5: role
+      1.4: []
+      1.3: include?
+      1.3: ==
+      1.2: reject!
+     10.6: UsersController#users_have_changed
+      3.9: assignment
+      2.6: branch
+      1.6: params
+      1.5: refresh_from_external
+      1.4: find_by_id
+      1.4: []
+      1.2: split
+      1.2: each
+      1.2: head
+     10.0: UsersController#after_create_page
+      3.0: current_user
+      2.6: id
+      2.4: branch
+      1.5: role
+      1.3: login
+      1.3: ==
+      8.4: UsersController#add_primary_site
+      2.4: assignment
+      1.6: params
+      1.4: []
+      1.4: new
+      1.2: find_by_id
+      1.2: all
+      1.2: render
+      7.7: UsersController#none
+      3.3: before_filter
+      1.1: private
+      1.1: caches_page
+      1.1: after_filter
+      1.1: skip_before_filter
+      7.2: UsersController#destroy
+      1.8: params
+      1.6: []
+      1.4: find_by_id
+      1.2: destroy
+      1.2: redirect_to
+      5.9: UsersController#edit
+      2.4: assignment
+      1.6: params
+      1.4: []
+      1.2: all
+      1.2: find_by_id
+      2.7: UsersController#signup
+      1.2: render
+      1.2: assignment
+      1.2: new
+      1.7: UsersController#new
+      1.2: assignment
+      1.2: new
+      1.7: UsersController#index
+      1.2: assignment
+      1.2: all
+    HERE
+    MetricFu::Flog.stub!(:verify_dependencies!).and_return(true)
+  end
+  
+  describe "parse method" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      @flog_page = flog.parse(@text)
+    end
+    
+    it "should find the total score" do
+      @flog_page.score.should == 157.9
+    end
+    
+    it "should find the average score" do
+      @flog_page.average_score.should == 11.3
+    end
+    
+    it "should find the scanned method score" do
+      @flog_page.scanned_methods.first.score.should == 34.8
+    end
+    
+    it "should find the scanned method name" do
+      @flog_page.scanned_methods.first.name.should == "UsersController#create"
+    end
+    
+    it "should find the scanned method opperators names" do
+      @flog_page.scanned_methods.first.operators.first.operator.should == "branch"
+    end
+    
+    it "should find the scanned method opperators scores" do
+      @flog_page.scanned_methods.first.operators.first.score.should == 9.2
+    end
+    
+    it "should find the name of the method even if namespaced" do
+      text = <<-HERE
+      157.9: flog total
+       11.3: flog/method average
+
+       34.8: SomeNamespace::UsersController#create
+      HERE
+        flog = MetricFu::Flog.new('base_dir')
+        flog_page = flog.parse(text)
+        flog_page.scanned_methods.first.name.should == "SomeNamespace::UsersController#create"
+    end
+
+    it "should find the line number for the method" do
+      text = <<-HERE
+      157.9: flog total
+       11.3: flog/method average
+
+       34.8: SomeNamespace::UsersController#create lib/blah/file.rb:37
+      HERE
+      flog = MetricFu::Flog.new('base_dir')
+      flog_page = flog.parse(text)
+      flog_page.scanned_methods.first.line.should == "37"
+    end
+
+    it "should not add a line number, when none is found" do
+      text = <<-HERE
+      157.9: flog total
+       11.3: flog/method average
+
+       34.8: UsersController#none lib/blah/file.rb
+      HERE
+      flog = MetricFu::Flog.new('base_dir')
+      flog_page = flog.parse(text)
+      flog_page.scanned_methods.first.line.should == nil
+    end
+
+    it "should parse empty flog files" do
+      text = ""
+      flog = MetricFu::Flog.new('base_dir')
+      flog_page = flog.parse(text)
+      flog_page.should be_nil
+    end
+  end
+  
+  describe "to_h function with results" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      flog.should_receive(:open).and_return(@text)
+      flog.stub!(:is_file_current?).and_return(true)
+      Dir.should_receive(:glob).and_return(["tmp/metric_fu/scratch/flog/app/controllers/user_controller.txt"])
+      flog.analyze
+      @flog_hash = flog.to_h
+    end
+    
+    it "should put the total in the hash" do
+      @flog_hash[:flog][:total].should == 157.9
+    end
+    
+    it "should put the average in the hash" do
+      @flog_hash[:flog][:average].should == 11.3
+    end
+    
+    it "should put pages into the hash" do
+      @flog_hash[:flog][:pages].first[:scanned_methods].first[:score].should == 34.8
+    end
+    
+    it "should put the filename into the hash" do
+      @flog_hash[:flog][:pages].first[:path].should == "/app/controllers/user_controller.rb"
+    end
+  end
+  
+  describe "to_h function ignore files not current" do
+    before :each do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      flog.should_receive(:open).and_return(@text)
+      flog.stub!(:is_file_current?).and_return(false)
+      Dir.should_receive(:glob).and_return(["tmp/metric_fu/scratch/flog/app/controllers/user_controller.txt"])
+      flog.analyze
+      @flog_hash = flog.to_h
+    end
+    
+    it "should put the total in the hash" do
+      @flog_hash.should == {:flog=>{:total=>0, :pages=>[], :average=>0}}
+    end
+  
+  end
+  
+  describe "to_h function with zero total" do
+    it "should not blow up" do
+      MetricFu::Configuration.run {}
+      File.stub!(:directory?).and_return(true)
+      flog = MetricFu::Flog.new('base_dir')
+      flog.should_receive(:open).and_return("") # some sort of empty or unparsable file
+      Dir.should_receive(:glob).and_return(["empty_file.txt"])
+      flog.analyze
+    end
+  end
+end