ccru 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e43cfbd5053be67406cc1fbedb4cef6a265474324575d4daf9b7f24f8b13816e
-  data.tar.gz: b1063d288f39e04a66cea77a7c96986ddba5852e69e28b34015c9cee25e4f2a3
+  metadata.gz: 20d17debc362218e7bd68e57cff217704df4ac263885c7f467fa4a682b318517
+  data.tar.gz: f356b6682d584a9af3a55274674fe5c65d6ddeab7d39faee12fb6f5073cf1f13
 SHA512:
-  metadata.gz: 4e5ce7a4fe3bd9de1c9d184850110e011af442773d971a0f8499cdbd0e7ae5cbf20d151ebd5baa68d55d4731557ebddfdd83686305377d1ab578aebd5a7ddb0a
-  data.tar.gz: ef9ef311a41efec35a0a674f691f61190b24dba9bf4cc8a080ea1539559fd5ce1b262f90fdd254e9709d5e9bf7bbd1c7afb7234f2dbdb847bee2adcaf5f9702d
+  metadata.gz: eb00a13f5188ad77e6565f9ce3cb28ce431595043a244f4e42d00a67caf581988332696c29f08315a6abd96e60e7c19517e7d498f2bf6f2d77ca6b4e8bc75f90
+  data.tar.gz: ea3a1c071a6c0563c1ba469a75cc294143843ea2692df4833d7715af42231c10011deb3be8e4fda63e56da4cba7f45f9d756b7efd8d3e82c6188e8c263412611

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ccru (0.1.4)
+    ccru (0.1.7)
       rubocop (>= 0.5, < 2.0)
 
 GEM

data/lib/ccru/javascript_linter.rb

@@ -173,6 +173,20 @@ module Ccru
       @offenses
     end
 
+    def lint_filtered(content, changed_lines)
+      @current_code = content.lines
+
+      changed_lines.each do |line_number|
+        line_content = content.lines[line_number - 1]
+        next unless line_content
+
+        check_js_conventions_for_line(line_content, line_number)
+        check_line_trailing_whitespace(line_content, line_number)
+      end
+
+      @offenses
+    end
+
     def check_js_conventions(content)
       @current_code = content.lines
 
@@ -187,13 +201,21 @@ module Ccru
       end
     end
 
+    def check_js_conventions_for_line(line_content, line_number)
+      return if line_content.strip.empty?
+      return if commment?(line_content, line_number)
+
+      check_line_conventions(line_content, line_number)
+    end
+
     # rubocop:disable Metrics
     def check_line_conventions(line_content, line_number)
       ES6_VIOLATIONS.merge(CODE_QUALITY_RULES).each do |rule_name, rule|
         next if line_content.match(rule[:pattern]).nil?
         next if rule_name == :missing_semicolon && no_need_semicolon?(line_content)
         next if rule_name == :unused_variables && used_variable?(line_content, line_number)
-        next if rule_name == :loose_equality && line_content.include?("!==")
+        next if rule_name == :loose_equality && (line_content.include?("===") || line_content.include?("!=="))
+        next if rule_name == :loose_inequality && line_content.include?("!==")
 
         add_offense(rule_name, rule, line_content, line_number)
         break
@@ -253,8 +275,48 @@ module Ccru
       # but JS ASI will handle it, I consider it unnecessary
       return true if line.match(/^(return|break|continue|throw)\b/)
 
+      # Object/array literal properties and elements don't need semicolons
+      return true if in_object_or_array_literal?(line_content)
+
       false
     end
+
+    def in_object_or_array_literal?(line_content)
+      return false unless @current_code
+
+      line_number = @current_code.index(line_content) + 1
+      return false unless line_number
+
+      # Check if we're inside an object or array literal
+      brace_count = 0
+      bracket_count = 0
+      in_object = false
+      in_array = false
+
+      @current_code.each_with_index do |code_line, index|
+        break if index >= line_number
+
+        # Check for braces and brackets
+        code_line.each_char do |char|
+          case char
+          when "{"
+            brace_count += 1
+            in_object = true if brace_count == 1
+          when "}"
+            brace_count -= 1
+            in_object = false if brace_count.zero?
+          when "["
+            bracket_count += 1
+            in_array = true if bracket_count == 1
+          when "]"
+            bracket_count -= 1
+            in_array = false if bracket_count.zero?
+          end
+        end
+      end
+
+      in_object || in_array
+    end
     # rubocop:enable Metrics
 
     def commment?(line_content, line_number)

data/lib/ccru/javascript_linter_runner.rb

@@ -25,8 +25,11 @@ module Ccru
       return 0 unless content && meta[:lines].any?
 
       linter = JavaScriptLinter.new
-      result = linter.lint_code(content, path, meta[:lines])
-      result[:status]
+      offenses = linter.lint_filtered(content, meta[:lines])
+      return 0 if offenses.empty?
+
+      print_offenses(path, offenses)
+      1
     end
   end
 end

data/lib/ccru/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ccru
-  VERSION = "0.1.5"
+  VERSION = "0.1.7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ccru
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - thucpt