cb_nitride 0.1.19 → 0.1.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93f4436426d9597cff0264f811ffc7788baf4491
-  data.tar.gz: 843a14c73cd07f3061ce7b8ddd079c1d61bfac84
+  metadata.gz: 0aa1250b7f2deacfbf3f1bec44e3b163fb5e2819
+  data.tar.gz: 015c504fe928d9227eddb02be3f7a778b2e0569b
 SHA512:
-  metadata.gz: cfe2451f13775b4709376feb073787a70bf44d158d76727b523d5df7c57115ad413e456bc11c5589f73d06e103f19cce5a18f3bf6e98cab5b0e2e8456026ad1c
-  data.tar.gz: cad7ce264a8247fe788ac9950f8204933e39c1ffeeebb0481e5ea8e9fff9389c4c21778e279bd938ca19f876d54b2ffd18aa891749e53f95198e97311907bdb4
+  metadata.gz: 6f037679b84db72da768d7cbecde8c8967f3666a4e6ee40fcb6eeb7774b46bc5b5e742be9020813c6f6070709eb1d1ab924b3208a574f2ec090dde37bb56237c
+  data.tar.gz: 24d38999380fd572cebd2fdf8352daa5a7685d99e3ef95db4e543c0c9adaacfbf08c0d637df66fc80f22069d58910c8dc1cfd100591884d52ea03a33a0fc976a

data/lib/cb_nitride/category_sorter.rb

@@ -19,14 +19,14 @@ module CbNitride
       return ISSUE_CODE if is_issue?
     end
 
-    private
-
     def is_variant?
       return @is_variant unless @is_variant.nil?
       @is_variant = true if hash[:title].include? "VAR ED"
       @is_variant = true if hash[:title].include? "COMBO PACK"
+      @is_variant = true if hash[:title].include? "STANDARD ED"
       @is_variant = true if hash[:title].match(/(CVR)\s[B-Z]/)
       @is_variant = false if @is_variant.nil?
+      @is_variant = false if specific_issue_patterns(hash[:title])
       return @is_variant
     end
 
@@ -67,12 +67,14 @@ module CbNitride
       return @is_merch
     end
 
+    private
+
     def strict_issue_title_matcher(title)
       /^(#{title})\s[#]/
     end
 
     def specific_issue_patterns(title)
-      title.match(/(CVR)\s[A]/) |
+      title.match(/(CVR)\s[A]/) ||
         title.match(strict_issue_title_matcher("RED SONJA")) ||
         title.match(strict_issue_title_matcher("VAMPIRELLA")) ||
         title.match(strict_issue_title_matcher("ARMY OF DARKNESS VS HACK SLASH")) ||

data/lib/cb_nitride/diamond_item.rb

@@ -117,19 +117,15 @@ module CbNitride
 
     def is_issue?
       @_is_issue ||=
-        category_code == CategorySorter::ISSUE_CODE && is_variant? == false
+        category_code == CategorySorter::ISSUE_CODE && category_sorter.is_issue?
+    end
+
+    def category_sorter
+      @_category_sorter ||= CategorySorter.new({title: title, category_code: category_code  })
     end
 
     def is_variant?
-      @_is_variant ||=
-        value = false
-        if category_code == CategorySorter::ISSUE_CODE
-          value = true if title.include?("VAR ED")
-          value = true if title.include?("COMBO PACK")
-          value = true if title.include?("STANDARD ED")
-          value = true if title.include?(" CVR") unless title.include?("REG CVR") || title.include?("CVR A")
-        end
-        value
+      @_is_variant ||= category_code == CategorySorter::ISSUE_CODE && category_sorter.is_variant?
     end
   end
 end

data/lib/cb_nitride/private_hasher.rb

@@ -71,6 +71,9 @@ module CbNitride
       MechanizeClip.get(get_image_url(BASE_URL, IMAGE_CLASS), agent)
     end
 
+    def fine_sort
+    end
+
     def item_page
       @item_page ||= Nokogiri::HTML(agent.get(SEARCH_URL + diamond_number).content)
     end

data/lib/cb_nitride/version.rb

@@ -1,3 +1,3 @@
 module CbNitride
-  VERSION = "0.1.19"
+  VERSION = "0.1.20"
 end

data/test/unit/diamond_item_test.rb

@@ -1,6 +1,22 @@
 require_relative '../test_helper'
 
 class DiamondItemTest < MiniTest::Unit::TestCase
+  def specific_issue
+    @_type ||= CbNitride::DiamondItem.new(
+      {
+        category_code: "1",
+        title: "RED SONJA #12 SECOND CVR"
+      }).product_type?
+  end
+
+  def main_cvrs_check
+    @_type ||= CbNitride::DiamondItem.new(
+      {
+        category_code: "1",
+        title: "SOMETHING SOMETHING #20 MAIN CVRS"
+      }).product_type?
+  end
+
   def ideal_collection
     @_ideal_collection ||= CbNitride::DiamondItem.new(
       {
@@ -8,6 +24,7 @@ class DiamondItemTest < MiniTest::Unit::TestCase
         title: "BATTLING BOY HC GN"
       }).product_type?
   end
+
   def ideal_merchandise
     @_ideal_merchandise ||= CbNitride::DiamondItem.new(
       {
@@ -15,6 +32,7 @@ class DiamondItemTest < MiniTest::Unit::TestCase
         title: "ADV TIME MARCELINE NAME ONLY PX JRS RAGLAN LG (C: 0-1-0)"
       }).product_type?
   end
+
   def ideal_variant
     @_ideal_variant ||= CbNitride::DiamondItem.new(
       {
@@ -22,6 +40,7 @@ class DiamondItemTest < MiniTest::Unit::TestCase
         title: "SANDMAN OVERTURE #1 (OF 6) CVR B (MR)"
       }).product_type?
   end
+
   def ideal_issue
     @_ideal_issue ||= CbNitride::DiamondItem.new(
       {
@@ -31,6 +50,8 @@ class DiamondItemTest < MiniTest::Unit::TestCase
   end
 
   def test_that_they_are_the_right_items
+    assert_equal :issue, specific_issue
+    assert_equal :issue, main_cvrs_check
     assert_equal :issue, ideal_issue
     assert_equal :variant, ideal_variant
     assert_equal :collection, ideal_collection

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cb_nitride
 version: !ruby/object:Gem::Version
-  version: 0.1.19
+  version: 0.1.20
 platform: ruby
 authors:
 - Alex Jarvis