cattri 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba04c1c408b5ffe93591ba80633bc3b7d7950d0e651e4adf738e30fe4ba795ea
-  data.tar.gz: a4d5f788238eee82419df14b8977b018ed8b7d91169f7719171186c26e9dde7d
+  metadata.gz: a81d60325f6f78ae5c66943a89b7dd77f6577a0d0aa4626edf28c0fbdf83cd0c
+  data.tar.gz: b3b458634e08b6c58ed3204de7c1b261082b50655e9430d7509e6cf4206b2f45
 SHA512:
-  metadata.gz: 1a923822a64d948f87bc16c14511ab2b9a6d278f3b3a9264ee4ab57515644f3f42dedaee7db4bd3b6d5a7d294daf866a00dd99b0d4d72b29faade58f6facc0e2
-  data.tar.gz: 26cc1589b802f4916b55b43312d567e7e68138a83e16780c6c5a49405b16e45a6325bfd5d5e39b7b80bbe5bdf53bbadd84b606765c156cf53183be6a49e251f9
+  metadata.gz: 6563f60e3f86a0509a03367be7c40a4d2f9820fd6e44bfd77f1111b89426ac526c33653c040cd51027a82e49c9dc5a77b6f7d1f56347bad9623b98d8d702f3b7
+  data.tar.gz: 11b6c7d02e22a206c70661d7d8ee93d03ba9a129b502911ed30c316c1477b1b065ef897e465dd3ab57532d21debf4c9fef15b835a12b48dc6edcc401db9046be

data/.github/workflows/main.yml

@@ -16,6 +16,9 @@ jobs:
         ruby:
           - '2.7.0'
           - '3.1.4'
+          - '3.2.9'
+          - '3.3.10'
+          - '3.4.7'
 
     steps:
       - uses: actions/checkout@v4

data/lib/cattri/attribute.rb

@@ -94,11 +94,11 @@ module Cattri
       %i[read read_write].include?(@options.expose)
     end
 
-    # @return [Boolean] whether the attribute allows writing
+    # @return [Boolean] whether the attribute should define a writer (public or internal)
     def writable?
       return false if @options.expose == :none
 
-      !readonly?
+      !readonly? || internal_writer?
     end
 
     # @return [Boolean] whether the attribute is marked readonly

data/lib/cattri/version.rb

@@ -2,6 +2,6 @@
 
 module Cattri
   # :nocov:
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
   # :nocov:
 end

data/sig/lib/cattri/dsl.rbs

@@ -35,7 +35,7 @@ module Cattri
         ?default: ::Proc | untyped | nil,
         ?expose: expose_types,
         ?visibility: visibility_types
-      ) { (?) -> untyped } -> ::Array[::Symbol]
+      ) ?{ (?) -> untyped } -> ::Array[::Symbol]
 
     # Defines a write-once (final) attribute.
     #
@@ -61,6 +61,6 @@ module Cattri
         ?default: ::Proc | untyped | nil,
         ?expose: expose_types,
         ?visibility: visibility_types
-      ) { (?) -> untyped } -> ::Array[::Symbol]
+      ) ?{ (?) -> untyped } -> ::Array[::Symbol]
   end
 end

data/spec/cattri/attribute_compiler_spec.rb

@@ -78,13 +78,37 @@ RSpec.describe Cattri::AttributeCompiler do
         )
       end
 
-      it "does not define a writer" do
+      it "keeps the writer private" do
         described_class.define_accessor(attribute, context)
         instance = dummy_class.new
 
         expect(instance.visible).to eq("shown")
         expect(instance.respond_to?(:visible=)).to be(false)
-        expect(instance.respond_to?(:visible=, true)).to be(false)
+        expect(instance.respond_to?(:visible=, true)).to be(true)
+
+        instance.send(:visible=, "hidden")
+        expect(instance.visible).to eq("hidden")
+      end
+    end
+
+    context "when writable? returns false" do
+      let(:attribute) do
+        Cattri::Attribute.new(
+          :disabled_writer,
+          defined_in: dummy_class,
+          default: -> { "initial" },
+          expose: :read_write
+        )
+      end
+
+      it "skips writer definition" do
+        allow(attribute).to receive(:writable?).and_return(false)
+
+        described_class.define_accessor(attribute, context)
+        instance = dummy_class.new
+
+        expect(instance).not_to respond_to(:disabled_writer=)
+        expect(instance.disabled_writer).to eq("initial")
       end
     end
   end

data/spec/cattri/attribute_spec.rb

@@ -111,11 +111,11 @@ RSpec.describe Cattri::Attribute do
 
   describe "#writable?" do
     [
-      [true, :read, false],
+      [true, :read, true],
       [true, :write, true],
       [true, :read_write, true],
       [true, :none, false],
-      [false, :read, false],
+      [false, :read, true],
       [false, :write, true],
       [false, :read_write, true],
       [false, :none, false]
@@ -190,20 +190,26 @@ RSpec.describe Cattri::Attribute do
   end
 
   describe "#allowed_methods" do
-    shared_examples_for "allowed method set" do |writable, predicate, expected|
-      let(:expose) { writable ? :read_write : :read }
-      let(:predicate) { predicate }
-      let(:final) { false }
-
-      it "returns #{expected.inspect} for writable: #{writable}, predicate: #{predicate}" do
-        expect(attribute.allowed_methods).to eq(expected)
+    [
+      [:read_write, true,  %i[attr attr= attr?]],
+      [:read_write, false, %i[attr attr=]],
+      [:read, true,        %i[attr attr= attr?]],
+      [:read, false,       %i[attr attr=]],
+      [:write, true,       %i[attr attr= attr?]],
+      [:write, false,      %i[attr attr=]],
+      [:none, true,        %i[attr attr?]],
+      [:none, false,       [:attr]]
+    ].each do |(exposure, predicate_value, expected)|
+      context "when expose is #{exposure} and predicate: #{predicate_value}" do
+        let(:expose) { exposure }
+        let(:predicate) { predicate_value }
+        let(:final) { false }
+
+        it "returns #{expected.inspect}" do
+          expect(attribute.allowed_methods).to eq(expected)
+        end
       end
     end
-
-    it_behaves_like "allowed method set", true,  true,  %i[attr attr= attr?]
-    it_behaves_like "allowed method set", true,  false, %i[attr attr=]
-    it_behaves_like "allowed method set", false, true,  %i[attr attr?]
-    it_behaves_like "allowed method set", false, false, [:attr]
   end
 
   describe "#validate_assignment!" do

data/spec/cattri_spec.rb

@@ -206,6 +206,23 @@ RSpec.describe Cattri do
       expect(obj.token).to eq("abc123")
       expect { obj.token = "fail" }.to raise_error(Cattri::AttributeError)
     end
+
+    it "allows internal assignment for read-exposed attributes" do
+      klass = Class.new do
+        include Cattri
+
+        cattri :token, expose: :read
+
+        def initialize(token)
+          send(:token=, token)
+        end
+      end
+
+      instance = klass.new("abc123")
+
+      expect(instance.token).to eq("abc123")
+      expect { instance.token = "fail" }.to raise_error(NoMethodError)
+    end
   end
 
   describe "visibility with write-only exposure" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cattri
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Nathan Lucas
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-12-14 00:00:00.000000000 Z
+date: 2025-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: debride